GitLab

Re-landing r71485 (which was reverted in r71500).

BUG=23581
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6278007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71814 0039d316-1c4b-4281-b951-d872f2087c98

This mirrors the behaviour on other platforms, and allows the optimized Pepper
plugin painting path to be used (see RenderWidget::DoDeferredUpdate()).

BUG=none
TEST=MacFlapper paints correctly in the "windowed" case

Review URL: http://codereview.chromium.org/6359005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71813 0039d316-1c4b-4281-b951-d872f2087c98

Pass correct dummy filename ("name.html" instead of "name./html") to GTK MIME lookup, to fix the file-filter drop-down in GTK file dialogs.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6379001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71812 0039d316-1c4b-4281-b951-d872f2087c98

Add TextRange and GetSelectedRange, SelectRange and GetCursorPosition, which are necessary to implement ominibox.

I'm adding them as Views only and left win/gtk blank because we don't use win/gtk impl for omnibox.

 I also didn't add TextRange variable to Textfield as its state is kept in Model. Let me know if you want to add it in Textfield class as well.

BUG=none
TEST=added new tests RangeTest, SelectRangeTest

Review URL: http://codereview.chromium.org/6318004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71811 0039d316-1c4b-4281-b951-d872f2087c98

Filed http://code.google.com/p/drmemory/issues/detail?id=273 to find out why a
separate suppression type is needed
BUG=57910,68307
TBR=glider
TEST=DrM/FYI bot should become greener
Review URL: http://codereview.chromium.org/6314009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71810 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6289005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=python:PolicyJsonUnittest.*

Review URL: http://codereview.chromium.org/6312006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69883
TEST=Display Task Manager while one or more tabs are open, and start typing into the Omnibox of one of them.

Review URL: http://codereview.chromium.org/6240006
Patch from Wez Weatherall <wez@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71807 0039d316-1c4b-4281-b951-d872f2087c98

The password manager was incorrectly down-casting from WebNode to WebInputElement and then upon method invocation, was crashing.  This change adds extra checks to |FindFormInputElements| before down-casting.  Also, when "name" attributes are ambiguous, the code now rejects filling.  This fixes the case where password text can erroneously get filled in the username field.

BUG=29352
TEST=PasswordAutocompleteManagerTest.*, and manual according to bugs.

Review URL: http://codereview.chromium.org/6271007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71806 0039d316-1c4b-4281-b951-d872f2087c98

The first is inside GCF where we get a tab message after the target tab has been torn down.
Before, we set handled to 'false' which would cause the message to end up in AutomationProxy which doesn't know how to handle it.  The fix is to drop the message and treat it as handled.

The second is when we attempt to send a download request to the host browser but the request has already been terminated.
We treated this as a fatal error, but now only log an error.

TEST=See repro steps in bug.
BUG=69595

Review URL: http://codereview.chromium.org/6260009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71805 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pastarmovj@chromium.org
BUG=70115
TEST=None

Review URL: http://codereview.chromium.org/6348008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71804 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70115
TEST=None

Review URL: http://codereview.chromium.org/6318006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71802 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68910
TEST=playing a compressed wave should fail gracefully

Review URL: http://codereview.chromium.org/6288008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71801 0039d316-1c4b-4281-b951-d872f2087c98

situation where the opener ends up the same as the tab being
closed. The only way I could see this happening is a new tab getting
the same address as a tab that was deleted. This seems unlikely, but
I've added the code to make sure we clean up properly when a tab is
deleted. I'm also adding a couple more checks.

BUG=34135
TEST=none

Review URL: http://codereview.chromium.org/6346008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71800 0039d316-1c4b-4281-b951-d872f2087c98

ResourceHandler's expect to be deleted on the IO thread after their ref count goes to 0. Change the unit test to explicitly drop ref count and run the IO thread's message loop.

BUG=69414
TEST=valgrind trybots

Review URL: http://codereview.chromium.org/6136006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6361002


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98

Weak symbols are either broken or they don't work the way that we need.
Either way, the current weak symbol based scheme is causing
runtime-linker aborts on systems without NSS 3.12.6.

This change switches to using dlsym to lookup the symbol at runtime.

BUG=69345
TEST=Run chrome on systems with libnss.so < 3.12.6

http://codereview.chromium.org/6250008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71796 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=still works

Review URL: http://codereview.chromium.org/6307006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71795 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6296014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71794 0039d316-1c4b-4281-b951-d872f2087c98

the new code location under Source/.

Review URL: http://codereview.chromium.org/6264004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71793 0039d316-1c4b-4281-b951-d872f2087c98

This change will enable a fix for issue 57289, which requires a different base directory for extensions.

BUG=70111
TEST=ExtensionServiceTest.ExternalPrefProvider

Review URL: http://codereview.chromium.org/6293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71792 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6241008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64877
TEST=Existing unittests; manual testing.

Review URL: http://codereview.chromium.org/6310012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71790 0039d316-1c4b-4281-b951-d872f2087c98

Revert http://src.chromium.org/viewvc/chrome?view=rev&revision=70896 to move speech input back behind a flag.
We have more work to do and the feature isn't ready for M10 so moving it back behind a flag.

BUG=61677
TEST=browser_tests --gtest_filter="SpeechInputBrowserTest.*"

Review URL: http://codereview.chromium.org/6353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60634, 67627
TEST=Manually interfere with Temp directory creation, see that expected failures happen.

Review URL: http://codereview.chromium.org/6297003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71788 0039d316-1c4b-4281-b951-d872f2087c98

This should address the wtc review in http://codereview.chromium.org/6338002/

BUG=64263
TEST=trybots

Review URL: http://codereview.chromium.org/6322003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71787 0039d316-1c4b-4281-b951-d872f2087c98

Also fix the following error when we try to get the width of column that does not exist anymore.

(views_examples:3921): Gtk-CRITICAL **: gtk_tree_view_column_get_width: assertion `GTK_IS_TREE_VIEW_COLUMN (tree_column)' failed

BUG=None
TEST=export GYP_DEFINES="toolkit_views" && gclient runhooks && make -j4 -k views_examples
     out/Debug/views_examples, go to the table tab. Now clicking in one of the checkboxes,
     the corresponded column should be removed.

Review URL: http://codereview.chromium.org/6256004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9344, chromium-os:10605
TEST=manual

Review URL: http://codereview.chromium.org/6320007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71785 0039d316-1c4b-4281-b951-d872f2087c98

Make sure we show the restart message if system level Chrome has been upgraded manually by the user.

Also add scoped_allowio until they can be evaluated (see bug).

BUG=66715
TEST=See bug for details.

Review URL: http://codereview.chromium.org/6243007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=48383
TEST=Add or remove some files to a default plugin location and check in about:plugins whether the change got detected. Also part of integration tests.

Review URL: http://codereview.chromium.org/6163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70092
TEST=GoogleUpdateTest.StatsConstent
TBR=cevans

Review URL: http://codereview.chromium.org/6354007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71782 0039d316-1c4b-4281-b951-d872f2087c98

Adjust the Find test for unselectable test so that it has the right expectation now that my change has been merged down.

BUG=68494
TEST=Fixing a test.

Review URL: http://codereview.chromium.org/6289007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71779 0039d316-1c4b-4281-b951-d872f2087c98

To make sure that all policy definitions match the expected format. The checker is called as a presubmit hook, and can also be invoked manually. Run it without any parameters (or with --help) to get usage information.

BUG=69527
TEST=manual: checker reports no errors for correct policy definitions, checker complains for malformed policy definitions, checker is invoked as presubmit hook when policy_templates.json has been changed

Review URL: http://codereview.chromium.org/6299001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71778 0039d316-1c4b-4281-b951-d872f2087c98

(I'm not sure about other platforms; on Linux, GTK has the weird quirk of
firing "context menu closed" before "context menu item selected", so it's
best to use a solution that doesn't try and track the visibility state of the
context menu).

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6335008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71777 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=GoogleUpdateSettings::SetCollectStatsConsent
TBR=cevans

Review URL: http://codereview.chromium.org/6281008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68751
TEST=mac passes


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71772 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hclam

BUG=70076
TEST=browser_tests
Review URL: http://codereview.chromium.org/6241007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71771 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam

BUG=70075
TEST=ipc_tests
Review URL: http://codereview.chromium.org/6304010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71770 0039d316-1c4b-4281-b951-d872f2087c98