- 23 Sep, 2019 40 commits
-
-
Lijin Shen authored
Currently, the selected bookmarks are all cleared whenever there is a change on another device. This behavior does hurt user experience and is also different from that in iOS version. This CL only clears bookmarks which are removed on other devices and keeps the rest of selected ones. Bug: 999269 Change-Id: Ic86a8e6f76b0160118caf712966697c9b3af136c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808014 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#698968}
-
Dave Tapuska authored
The histogram is now expired so remove the code that logs it. BUG=984277 Change-Id: Ib31f0c9347dcd415d5590b8ff539636040c7440e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815089 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#698967}
-
Eric Seckler authored
Change-Id: I2658f64cabdf622071e2d8ba0c2063aa2342e847 TBR: nuskos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815020Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#698966}
-
Joshua Peraza authored
This patch allows enabling Crashpad with a command line switch --enable-crashpad, but leaves Breakpad enabled by default. Bug: 942279 Change-Id: I48ce764efe0f74e7ab5afe35e71725b908d8ddd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765663Reviewed-by:
Prasad Vuppalapu <prasadv@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#698965}
-
Guido Urdaneta authored
Starting in macOS 10.15, screen capture requires system permissions that are disabled by default. This CL updates getDisplayMedia() test expectations to take this into account. Bug: 1002984 Change-Id: I26150e8add754831e40702681719a92b33b55bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819252Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#698964}
-
Ben Pastene authored
This reverts commit 7db5fb15. Reason for revert: likely breaking PFQ, eg: https://ci.chromium.org/p/chromeos/builders/general/Informational/b8901517067800831488 Original change's description: > Enable cros_download_vm flag for betty-pi-arc in DEPS > > Without this flag, VM image for betty-pi-arc is not downloaded when > gclient runhooks is run > > R=bpastene@chromium.org > > Bug: 1000513 > Change-Id: Ice17757549dd3a4ca506a6eec5e8e5f487425cda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815882 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Anushruth <anushruth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698609} TBR=bpastene@chromium.org,anushruth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000513 Change-Id: I2d6ea05b07f78f14a04444636602c5ecfc16adb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819056Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#698963}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b5578f4f0b22..314adcb844e1 git log b5578f4f0b22..314adcb844e1 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@314adcb844e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I19dd13a221c8dbfb28e65d04ea91b3281cfb8f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698962}
-
Elly Fong-Jones authored
It is actually not used anywhere and only set in one place, so we can do away with it. Bug: None Change-Id: Ib6f2445f2fb02dbcaac25caa3f0beae1c473fd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816118 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#698961}
-
Lei Zhang authored
OS_IOS is never set in the chrome/ directory. Also fix lint errors. Change-Id: I6f5f56ed6415b962737262ca15f30c36562177f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816292Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#698960}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Change-Id: If01ba7806eeed18598ba5e449c35803af5452665 Bug: 878390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813307Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#698959}
-
Friedrich Horschig authored
This CL ensures that credential changes are picked up by a new Model Change Processor and forwarded to a ListAdapter. With the help of a ViewBinder, it binds chips to list items. The initial creation of the list items happens in a simple ViewFactory that inflates a new layout. The added helper classes can be reused for any ListView and any type of item inside a ListModel. I consider generalizing them and moving them to the modelutil package but since this would simplify ListView usage (which we usually want to avoid in favor of RecyclerViews), I'd expect soft pushback and will defer that. For our specific use case, RecyclerViews did not work as expected. The reason might be the varying height of the the bottom sheet. I'll reconsider using RecyclerViews once the mocks are final. Until then, this solution makes it dead simple to swap out the list view for a recycler view. Bug: 957532 Change-Id: Id9564ecfbc26b1076604fef297cfa9d03adf94cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815120 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#698958}
-
Brian Sheedy authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/96f125709acf..885b3febcc17 $ git log 96f125709..885b3febc --date=short --no-merges --format='%ad %ae %s' 2019-09-18 tikuta client: increase the number of io worker threads 2019-09-18 tikuta client: reduce disk access when deploy files to destination 2019-09-17 tikuta client: rename delete_and_upload to upload_then_delete 2019-09-16 adoneria [client] Synced auth/ and oauth2/ to upstream repo. 2019-09-06 iannucci [client/util/tools] Correct find_executable. 2019-08-30 bsheedy Find arg0 via $PATH for non-Python cases 2019-08-29 adoneria [swarming] add capability for darwin OS to delete directories/files by providing them sudo capability 2019-08-09 iannucci Update LUCI_CONTEXT.md to describe "luciexe" section. 2019-08-06 tikuta [client] fix _get_recursive_size for junction in windows 2019-08-02 tikuta [client] use scandir on win 2019-08-01 tikuta [client] add symlink test 2019-07-31 tikuta Revert "[client] use scandir to calculate directory size" 2019-07-30 tikuta [client] use scandir to calculate directory size 2019-07-26 tikuta [client] add test for _get_recursive_size 2019-07-25 tandrii Revert "[client] use scandir to calculate directory size" 2019-07-24 tikuta [client] use scandir to calculate directory size 2019-07-23 tikuta [client] move scandir to client 2019-06-19 tikuta client: use Counter to calculate stats collectly 2019-06-17 leilei [client]Update utils/tools.py to make it python3 compatible. 2019-06-14 leilei Reland "[client] Rename third_party/pyasn1-modules to third_party/pyasn1_modules" 2019-06-14 leilei [client] Update httplib2 to include both python2 and python3 versions. 2019-06-11 leilei [client] Update client code to make it compatible with python3 2019-06-10 jbudorick Revert "run_isolated: sleep for 1s while waiting for subprocess completion." 2019-06-07 jbudorick run_isolated: sleep for 1s while waiting for subprocess completion. Created with: roll-dep src/tools/swarming_client Change-Id: I6f4bfe2e7fa7857dbc908eea5f6814b17d20ec89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817336 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Donn Denman authored
Updates the Bar background color in both the old and new layout to match the color used in the top_round assets. BUG=1005558 Change-Id: I8ccd5176039f386ff9df918c1894732185c37916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817152Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#698956}
-
Clark DuVall authored
We really only need the class loader and resources from the remote context (for now). Now we no longer need to pass two contexts into the impl side. We had some places that were wrapping the remote context and overriding methods, others that were wrapping the application and overriding methods. This change wraps the context returned from createRemoteContext, so we only have to do it in one place. Change-Id: Iacecba9aee796009739068e6c283456401801b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815900 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
Previously we calculated layout opportunities by shrinking the available child space by the child's margins. This resulted in layout opportunities which were too small, and would push the new formatting context down to the next opportunity. This logic now allows margins to "overhang" a layout opportunity. At the same time I refactored a lot of the code, as we were adding/subtracting margins for different calculations. Hopefully this is more readable! Bug: 1003193 Change-Id: I6c05b050332afe9880ca7d9a5b426b4b94fde3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808661 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#698954}
-
Theresa Wellington authored
When night mode is enabled pre-Q, typically the default is to follow system settings or battery saver mode. This CL adds a new experiment parameter to default to light theme instead. BUG=1006330 Change-Id: I3439b529555479828ce2c8a10f8e760c83082d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817204 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3c3754a9c0f..c3a8610d6571 Created with: gclient setdep -r src-internal@c3a8610d6571 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I25eb7322d89601f8479f4b0d7e83d71cf0ce3061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819482Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698952}
-
Kaan Alsan authored
Updates test 'external/wpt/css/css-scroll-snap/scroll-margin.html' such that the expected result is consistent. Originally the test's snap areas were equally distant from the scroll position and therefore the area chosen was not consistent. Bug: 964239 Change-Id: I7e8b09719bd526c4e2fb7049131d585ef5e47d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799387Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#698951}
-
Mingjing Zhang authored
This change makes the creation of universal tracker optional for those FrameSequenceTrackerCollections created out of LayerTreeHostImpl (e.g. frame trackers for video and canvas). These trackers currently do not make use of the universal tracker. Furthermore, the presence of the universal tracker in these out-of-cc FrameSequenceTrackerCollections may be related to flaky test failures (https://crbug.com/1001364). Change-Id: I698dc3614018b95bad0b697ce17c3b2cf3214367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811497Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698950}
-
Xida Chen authored
This CL adds a new metric to measure how often paint worklet successfully paint on the compositor thread vs fall back to the main thread. Bug: 1002076 Change-Id: I65ed849e1cfb992f24d594b025995aa1e78eb009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791437 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#698949}
-
Mandy Chen authored
Wrap user facing strings in heap snapshot worker with ls to localize them. Bug: 941561 Change-Id: Ibe416185c7831213df4cfcf15c753cd469502f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809506Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#698948}
-
Yuly Novikov authored
Android FYI Release (Pixel 2) Android FYI SkiaRenderer Vulkan (Pixel 2) were using PQ2A Chrome-GPU pool before. TBR=kbr, bpastene Bug: 1006006 Change-Id: Id80aff4d23509fdeea41099555b6492def9d16ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817202Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#698947}
-
Jérôme Lebel authored
Disable the signed-in account view controller dialog. This patch is to disable it for M-77 and M-78. The right fix will come later with crbug.com/1006717 Bug: 1006744 Change-Id: I537969bb221e165a7a0ca66d4324f8d87580916b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819304 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#698946}
-
Ivana Zuzic authored
PasswordEntryEditor saves changes for a credential record when the Save button is clicked through PasswordEditingDelegateProvider. Bug: 377410 Change-Id: I200e4702945212b847488835a04fad3e5581b139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807308Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ivana Zuzic <izuzic@google.com> Cr-Commit-Position: refs/heads/master@{#698945}
-
Andrew Grieve authored
We no longer support JellyBean. Change-Id: I5dfd1af42f2336d91fea91bf6d1a953c6e964769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814324Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#698944}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3c5f91b74871..f7457e55fe3d git log 3c5f91b74871..f7457e55fe3d --date=short --no-merges --format='%ad %ae %s' 2019-09-23 danilchap@webrtc.org Store PacketBuffer by value instead of as reference counted object Created with: gclient setdep -r src/third_party/webrtc@f7457e55fe3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I476b7c0be05440b0e3ef4e5cd1b38018ac087cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819479Reviewed-by:
-
Christopher Thompson authored
Adds remaining characters from the the Default Ignorable and Formatting character sets to the URL unescape ban list. Bug: 824715 Change-Id: If5efe179a7661667380566f89eacb282d711bddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803833 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#698942}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Change-Id: I85a8952e2d2d5a41ed4e6a81f51fca938fa5e74a Bug: 878390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813505 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Michael Crouse authored
This change adds the proto elements for the Optimization Guide Prediction System. It is used for model storage, requesting updates from the remote OptimizationGuideService, and evaluating models on the client. This proto also contains the model definitions for ensembles and decision trees that will be supported in v1 of the Optimization Guide Prediction System. These are forked versions of the TensorFlow protos for these elements. Bug: 1001194 Change-Id: Ifddddb032076af98b4b0838a9d309f37e1322732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815228 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#698940}
-
Rayan Kanso authored
All the other accesses in the function are guaranteed to be non-null, so this is likely casued by the execution context being detached and returning null. Bug: 1006598 Change-Id: I6835cee2c28f537b902f181024ac32e10c3143af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818521 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#698939}
-
Leonard Grey authored
This reverts commit 480313d9. Reason for revert: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8901505278757132992/+/steps/compile/0/stdout Original change's description: > Remove unused headers from ios/web/public/web_state > > This CL removes web_state_observer.h and web_state.h from > ios/web/public/web_state which are no longer used in downlstream repo > (downstream code was switched to use files from ios/web/public). > > Bug: 942244 > Change-Id: I1480b115343735a69347578cfd0628f983c069ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816807 > Commit-Queue: Yi Su <mrsuyi@chromium.org> > Auto-Submit: Eugene But <eugenebut@chromium.org> > Reviewed-by: Yi Su <mrsuyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698929} TBR=eugenebut@chromium.org,mrsuyi@chromium.org Change-Id: I7f9a7453be97af8ecd702ac4392e73416ce7dc7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815914Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#698938}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0df60d76f437..5073a9e8d71d git log 0df60d76f437..5073a9e8d71d --date=short --no-merges --format='%ad %ae %s' 2019-09-23 bsheedy@chromium.org Fix ChromeOS build dir finding Created with: gclient setdep -r src/third_party/catapult@5073a9e8d71d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:978952 Change-Id: I87099a0da2a36ac9865b3f9c67a25c492731f1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819478Reviewed-by:
-
Allen Webb authored
In order to show notifications about blocked USB devices when appropriate, ash needs to be aware of these events. This CL adds the logic necessary to observe the appropriate D-Bus signal. Bug: 987351 Change-Id: I3eacbc3c401ba2f7d6dc0272a0b56c689ac8cd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772369Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#698936}
-
Maksim Ivanov authored
Rename the AuthorizationMode enum to stop referring to the "extension" that performs authentication. The extension-based authentication was removed a couple of years ago in favor of the webview-based one (see also https://crbug.com/688565 ). Bug: 470893 Change-Id: I80bc9d662719a2bbc83eb42ec04be78dd9527b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816573Reviewed-by:
-
Boris Sazonov authored
Bug: 906581 Change-Id: I22cbf5c482845ba154fcbf5c795bba77567e8c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814823 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#698934}
-
Juanmi Huertas authored
We are now using SharedImage to hold the image for the video renderer, https://chromium-review.googlesource.com/c/chromium/src/+/1616978. That change, together with the change that made the video be deferred, and therefore, use the paintRecorder, let us safely remove the workaround. There was nevertheless the issue of texture lifetime to extend the texture. If the backend texture is the same in the SkImage and the one contained in the cache, we will let skia release it. If they are different, cache has to destroy their own texture, and the one in skia will survive the delete. Bug: 974656, 991792, 993774, 994516, 996083, 1004780 Change-Id: I10b4165febf14a158584eb2b05cdb8c75c59175e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815734Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#698933}
-
Erik Chen authored
WebView already exposes a variety of Resize() methods, as well as VisualViewportSize(), so it's the right place for the method to live. Note that this technically consitutes a slight behavior change, since previously we were returning the main RenderWidget size, and now we're returning the WebView size. For pre-render, this should be functionally identical. Bug: 912193 Change-Id: I884f7c93d7a8ca4549f63689934197207b0cb85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817325 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Leonard Grey authored
This reverts commit 89cc7c83. Reason for revert: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8901507064210139120/+/steps/compile/0/stdout Original change's description: > JNI refactor: Remove unused method from UrlUtilities.java. > > Downstream usages have been updated to use proxy native methods. > > Bug: 929661 > Change-Id: I05cb9a3a520ae58006395f3826487f92f14e5e74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818871 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698919} TBR=estevenson@chromium.org,tiborg@chromium.org Change-Id: Ida116a48b0673d5ace196d33b50cc52354686747 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 929661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816449Reviewed-by:
-
Thomas Tangl authored
The incognito menu code is moved into ProfileMenuView because there is a lot of shared code with regular and guest mode. This also removes special casing during the bubble creation. Screenshot: https://drive.google.com/file/d/1JeyIWItOqCnQ7dJAWI_q0eD0zkaFPIPr/view?usp=sharing Flag: profile-menu-revamp Bug: 995720 Change-Id: Id2778759dbe83a342cb8a0261f74d3ece4572d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819444 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#698930}
-
Eugene But authored
This CL removes web_state_observer.h and web_state.h from ios/web/public/web_state which are no longer used in downlstream repo (downstream code was switched to use files from ios/web/public). Bug: 942244 Change-Id: I1480b115343735a69347578cfd0628f983c069ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816807 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698929}
-
