- 09 Nov, 2018 40 commits
-
-
dpapad authored
Also ensure that JS type checking runs on non-ChromeOS. It was erroneously running on ChromeOS only. Bug: 902959 Change-Id: Ibd67a276325ac1e4461509341f6a198e27e9dabe Reviewed-on: https://chromium-review.googlesource.com/c/1327420 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606688}
-
Ahmed Fakhry authored
1) The Home Launcher used to use the wrong display ID when in Unified Desktop mode. 2) If (1) is fixed, we hit https://crbug.com/902601. The captive portal dialog widget used to be leaked and never destroyed. 3) If (2) is fixed, we crash on the first attempt to press the app list button. The reason is tablet mode triggers a switch to mirror mode. This switch happens asynchronously after the Home Launcher had already been created. Switching from Unified to mirror mode destroys the Unified host and the Home Launcher. That's why we need to ensure that the Home Launcher is recreated. BUG=900956, 902601 TEST=Added a test that crashes without the fix. Change-Id: If6eb9c2255dfa9d442aa115a3274db2d8a4110d7 Reviewed-on: https://chromium-review.googlesource.com/c/1325389 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606687}
-
Martin Kreichgauer authored
This makes fido/win include webauthn.h from //third_party/microsoft_webauthn and drops the USE_WIN_WEBAUTHN_API build flag we previously added due to the missing header file. The implementation remains behind a default-off feature flag. Bug: 898718 Change-Id: I45e100f8b10cc32ea7e32d2842a63c950b5965bb Reviewed-on: https://chromium-review.googlesource.com/c/1325074 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#606686}
-
Anand K. Mistry authored
- Add new files to corpus that cover additional zip features - Cover additional functions BUG=900749 Change-Id: I0cd8b41112035b1ba95ab11155c67aeb8fded29f Reviewed-on: https://chromium-review.googlesource.com/c/1325572Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#606685}
-
Jesse McKenna authored
Bug: 889029 Change-Id: Ia8ab74329953568bda37a324cc3a9b477acf732e Reviewed-on: https://chromium-review.googlesource.com/c/1327548 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#606684}
-
Esmael El-Moslimany authored
Bug: 877109 Change-Id: I1ef50be0c151c691825174c8ff3bbcba5ce17a10 Reviewed-on: https://chromium-review.googlesource.com/c/1323619Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I0dbad4a299ae4ce3be3696da7703822d87d151d5 Reviewed-on: https://chromium-review.googlesource.com/c/1325288Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#606682}
-
Yutaka Hirano authored
With https://crrev.com/a9cbaa7a40e2b2723cfc2f266c42f4980038a949, WebMediaPlayer blindly treats a resource experiencing cross-origin redirects as TAINTED. In fact, it should be treated as TAINTED only when its request mode is "no-cors". The added tests are provided by hongchan@chromium.org. Bug: 899745, 901383 Change-Id: Idb66407552085b053818f3e4a9d8d5ff3ddeaf45 Reviewed-on: https://chromium-review.googlesource.com/c/1325281Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#606681}
-
Josh Pratt authored
The Crostini Installer spec uses a mascot icon without a background rather than the version with the background circle and shadow. This adds the mascot for use in the WebUI Installer. Bug: 867117 Change-Id: Id56d65c625e86f085e43d067b89395fa669c7012 Reviewed-on: https://chromium-review.googlesource.com/c/1319393Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/458e9fd3f8e8..81f7d1dd5fa4 $ git log 458e9fd3f..81f7d1dd5 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 dalecurtis Drop function: prefix in x86util.asm for macOS ffmpeg builds. 2018-11-08 dalecurtis Cleanup a few remaining yasm references in ffmpeg. 2018-11-02 dalecurtis Switch ffmpeg to using nasm for compilation. 2018-10-17 jeremya set install_name on mac when is_component_ffmpeg && !is_component_build 2018-10-16 vtsyrklevich CFI: Disable cfi-icall for ffmpeg component build 2018-10-02 liberato Group gn configs and gn config changes summary into one commit. 2018-10-02 liberato Cleanup of robosushi.py and robo_branch.py . Created with: roll-dep src/third_party/ffmpeg R=chcunningham Bug: 766721 Change-Id: Ic513abcd66ca725b29dd9a745b5b93dd5b99ae26 Reviewed-on: https://chromium-review.googlesource.com/c/1327153 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#606679}
-
Takumi Fujimoto authored
Also use the correct button height const to reflect a recent change. Bug: 881923 Change-Id: I2553c3d8d891a25b981edce8f0578e516d7ebe43 Reviewed-on: https://chromium-review.googlesource.com/c/1327557Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#606678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa347dd67ba1..a6ad2f38573b Created with: gclient setdep -r src-internal@a6ad2f38573b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib1bb8314374ae1eccd690015b8b8cdebb607b696 Reviewed-on: https://chromium-review.googlesource.com/c/1327727Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606677}
-
Kenichi Ishibashi authored
While I was investigating traces I noticed that some trace events in ServiceWorkerSubresourceLoader have the same IDs even for different resource loading. This is probably because different instances of ServiceWorkerSubresourceLoader are happend to be allocated in the same address. These events are not overlapped so this isn't a critical problem but it makes difficult to analyze traces. Use resource_id_ as the trace event id to make analyzing traces easy. Change-Id: I6718bdc82d3aba1df422dbbbcbe3b4f1b06ca8cb Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/1325283Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606676}
-
Steve Anton authored
Bug: 874296 Change-Id: I233cda30e59b696bc6960f1e7366cbee62849bed Reviewed-on: https://chromium-review.googlesource.com/c/1325011 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606675}
-
Alexander Nohe authored
Removed the pointer cursor and focus state when the checkbox is disabled. This should prevent the checkbox from maintaining any unnecessary focus as well as preventing any confusion when hovering over the overwrite changes checkbox. Bug: 888464 Change-Id: I14547deb878f2948e5606f3bf0bbc01b9ba75886 Reviewed-on: https://chromium-review.googlesource.com/c/1318062Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#606674}
-
Jian Li authored
Increase the default snackbar duration to 10s when accessibility mode is on. Also make SnackbarManager to double the custom duration automatically when accessibility mode is on. Bug: 699160 Change-Id: If3762db7eea56eed614ce15ff69a6591c7ae7706 Reviewed-on: https://chromium-review.googlesource.com/c/1327330Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#606673}
-
Dave Tapuska authored
This actually fixes a bug that appeared in the bindings for window. Previously window.scrollTo.length == 2 in Chrome but was 0 in FireFox. This is detected by the cssom-view wpt test. CSSOM View smooth scroll API shipped in M61 https://codereview.chromium.org/2938373003 https://www.chromestatus.com/features/5812155903377408 BUG=243871 Change-Id: I7e2d5b7be38fd7dfc26e633ccd171e435eba51e5 Reviewed-on: https://chromium-review.googlesource.com/c/1323694 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606672}
-
Tommy Nyquist authored
Whenever a device is running an unsupported version of Android, we display a menu item telling the user that Chrome is unable to update. The same menu item is displayed (with different text and visuals) whenever there is an update available. When the user taps the menu item in the update available flow, they start the update flow. However, when the user is shown that they can not update, nothing happens when they tap the item. This can lead to confusing situations when using accessibility mode, since they are informed that they can double tap to activate. This CL changes this behavior to disable the menu item in the unsupported OS case. The item is still possible to tap to inspect though. Bug: 852650 Change-Id: I1385bc798ea0324cc5043c390c20c40a45c2727f Reviewed-on: https://chromium-review.googlesource.com/c/1327567Reviewed-by:
-
Eric Stevenson authored
chrome_modern_public_apk and chrome_public_apk hit the single dex method limit when feed is enabled. This CL re-enables feed while also turning on multidex for the required APKs. Binary-Size: Feed was disabled to fix the multidex method limit issue. Bug: 901488 Change-Id: Ifba41178fad6c206ec1f458d420187ef1c2eb6f3 Reviewed-on: https://chromium-review.googlesource.com/c/1327403 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606670}
-
Justin Donnelly authored
Additionally, update the other patterns to only match at the beginning to avoid inadvertently picking up similarly named directories under other paths (currently just ios/chrome/browser/ui/omnibox). Change-Id: I6da957f06af0de4b13c344cbbcdfae65a7e74821 Reviewed-on: https://chromium-review.googlesource.com/c/1327554Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#606669}
-
Collin Baker authored
This updates tab text colors to both enhance contrast of text over tab backgrounds as well as contrast between active and inactive windows. Bug: 859243, 881916 Change-Id: I98257077fd6a9b7cf9521f845ea40218dcf11a70 Reviewed-on: https://chromium-review.googlesource.com/c/1297185 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#606668}
-
Eric Roman authored
The expectation is that the IPv6 literal not be bracketed. Change-Id: I90631a55cddf1c02684512c8e9989f6d21cdc174 Reviewed-on: https://chromium-review.googlesource.com/c/1327528Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606667}
-
Eugene But authored
DidSuppressDialog callback is unnecessary because PreloadController implements CWVWebStateDelegate and can cancel preload on window.open or showing JS alert. ShouldSuppressDialogs is unnecessary because PreloadController can prevent dialogs via CWVWebStateDelegate callbacks. This CL does not change the behavior. Previously webStateDidSuppressDialog used to cancel the preload. Bug: 777912 Change-Id: Ifbcc6ee48ecee741c2c6ff9a4760d601e3e1b843 Reviewed-on: https://chromium-review.googlesource.com/c/1322358 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#606666}
-
Robbie McElrath authored
The current NetworkChangeNotifierChromeOS implementation won't work with the network service enabled because it listens for network changes from Shill, which only supports a single client. The browser process has other dependencies on Shill, so it has to be the client for the time being, meaning the network service can't directly listen for network changes and has to be notified of them from the browser process. This CL splits the NetworkChangeNotifierChromeOS into two parts; the first will live in the browser process and listen to Shill, while the second is the actual NetworkChangeNotifierChromeOS implementation which will have an instance in both the browser and network processes. Since NetworkChangeNotifierChromeOS can't actually listen for network changes itself, it just gets notified of changes from part 1 via a new method in NetworkChangeManager. When the thing listening to Shill sees a network change, it notifies its local NetworkChangeNotifierChromeOS instance, and calls the new NetworkChangeManager method, the implementation of which then notifies the network service's NetworkChangeNotifierChromeOS instance. Bug: 882610 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 Reviewed-on: https://chromium-review.googlesource.com/c/1274445Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#606665}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc810ab24daa..93cd73d98000 git log fc810ab24daa..93cd73d98000 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-08 bpastene@chromium.org Allow gsutil recipe_module calls to not always be infra_steps. 2018-11-08 martiniss@chromium.org Revert "Roll recipe dependencies (trivial)." Created with: gclient setdep -r src/third_party/depot_tools@93cd73d98000 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:866062 TBR=agable@chromium.org Change-Id: Ib3a90d2e456d199614cc895ed7e4b47d7e2a3208 Reviewed-on: https://chromium-review.googlesource.com/c/1327351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606664}
-
Scott Graham authored
Fairly basic and the connection must be manually torn down for now, but allows requesting an interface implemention from the JS side. Bug: 883496 Change-Id: I8367fd50097403ee2f9911657afbabdd8d461a41 Reviewed-on: https://chromium-review.googlesource.com/c/1324929 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606663}
-
Jun Mukai authored
LoginScreen::FocusLoginShelf() mojo API can be reused. BUG=854346 TEST=trybot Change-Id: Ide7dad98e1da57826d37d5dff4c3e269aee07c14 Reviewed-on: https://chromium-review.googlesource.com/c/1325689Reviewed-by:
-
rajendrant authored
PreviewsState is used in DataReductionProxyURLLoaderThrottle to set some chrome-proxy specific headers to serve previews. Bug: 893728 Change-Id: Ie54f174bb1ba2ff4d77f725c0e64450f8d2aad0c Reviewed-on: https://chromium-review.googlesource.com/c/1327568Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#606661}
-
chrome://ukmNikunj Bhagat authored
BUG=843181 Change-Id: I8b43a72535dd09a175df731a94dc8e216374e7ff Reviewed-on: https://chromium-review.googlesource.com/c/1306660 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606660}
-
Yves Arrouye authored
BUG=chromium:890636 TEST=Enroll using attestation and check UMA Change-Id: Ifdfa408a62cf7af43e7436b4a64b2a43afe7bf18 Reviewed-on: https://chromium-review.googlesource.com/c/1304613 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Brian Sheedy authored
This reverts commit e19fa28d. Reason for revert: Cause of https://crbug.com/903402 Original change's description: > Marks the document object as busy while it is still loading > > Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. > The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. > > R=dmazzoni@chromium.org, aleventhal@chromium.org > > Bug: 897177 > Change-Id: I5d734ff9d32c53b7ba12a6d5d4eeb74b26ba0a02 > Reviewed-on: https://chromium-review.googlesource.com/c/1295769 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606147} TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897177 Change-Id: Ib13f772ecf7fe300afbb48e16952f65bf0d0728a Reviewed-on: https://chromium-review.googlesource.com/c/1327721Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606658}
-
Eric Roman authored
(Previously it would just print -1 if the request failed due to a network error) Change-Id: I5f61bc4461f109c733f56983ac0420b0e5083c27 Reviewed-on: https://chromium-review.googlesource.com/c/1327575Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606657}
-
Varun Khaneja authored
Bug: 889972 Change-Id: I5b0ab0869a526061f0125d5d23beb8f38f81b7ed Reviewed-on: https://chromium-review.googlesource.com/c/1326845Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606656}
-
danakj authored
Importantly, non-visible RenderWidgets include swapped out RenderWidgets which are zombies, without a frame, and which should not be used. This can happen if the RenderWidget swap out races with the posted task from the compositor to make a LayerTreeFrameSink. When swapping out, the compositor would be marked as not-visible, which would stop it from making such requests, but one could already be in flight. In the other case, honoring the request for a non-visible compositor is more benign, but we can delay it until the compositor is actually visible again. This means if a context is lost, backgrounded tabs would not all attempt to reconnect to the Gpu process at once. This is a better followup for the hacky https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which was meant only for merge to a release branch. It reverts that change as part of this one. R=piman@chromium.org Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7 Bug: 896836, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1292714 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606655}
-
Peter Boström authored
Removing TabIcon from a layer used to happen after SetData marks a tab as no longer loading. With the new tab-icon animation we extend the animation period for 200ms past that. This is a speculative fix for the referenced bug that I've been unable to reproduce locally. Bug: chromium:901277 Change-Id: I81c5e5af56fddc90ca210b027a681cd2309d2742 Reviewed-on: https://chromium-review.googlesource.com/c/1327231Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#606654}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b8b52b46f8db..760b1c16f676 git log b8b52b46f8db..760b1c16f676 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 thestig@chromium.org Remove CPDF_DocRenderData::Clear(). Created with: gclient setdep -r src/third_party/pdfium@760b1c16f676 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9b6d7c3304b4db3c9210144d864650e61735def3 Reviewed-on: https://chromium-review.googlesource.com/c/1327350Reviewed-by:
-
Eugene But authored
Bug: 901563 Change-Id: Ia65425e4d47e79bfae1eb7bcd6f08aa0f4b641d5 Reviewed-on: https://chromium-review.googlesource.com/c/1321573Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606652}
-
Jun Mukai authored
I've just noticed that crrev.com/606339 causes a crash, and that's because PrintWindowHierarchy starts from a root window, which do not have a parent, but it tries to call IsToplevelWindow() which assumes the existence of the parent. BUG=none TEST=manually Change-Id: Ie4460302674d057a6c7960e0b012c80b63e06a2c Reviewed-on: https://chromium-review.googlesource.com/c/1327560Reviewed-by:
-
Xianzhu Wang authored
FrameSetPainter paints everything in the foreground phase, so a frame under frameset should paint its box decoration background in the foreground phase. Bug: 902274 Change-Id: Id56af37a478b8503f17199753a485f6fe1261c95 Reviewed-on: https://chromium-review.googlesource.com/c/1326205Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606650}
-
Hiroshige Hayashizaki authored
Keeping scoped_refptr<WebWorkerFetchContext> in WorkerFetchContextHolder cause WebWorkerFetchContext destruction on the main thread, because WorkerFetchContextHolder is destructed on the main thread. To avoid this, this CL passes WebWorkerFetchContext via GlobalScopeCreationParams to WorkerOrWorkletGlobalScope. This CL doesn't change the behavior. Bug: 880027 Change-Id: Idab91d31cafdb33b264662c5f1bef126d93ba9f3 Reviewed-on: https://chromium-review.googlesource.com/c/1198891 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606649}
-
