- 04 Apr, 2019 40 commits
-
-
Jun Mukai authored
When the touch events move very quickly on detaching, some touch events are already queued, those queued touch events aren't processed properly. - Detach() aren't releasing the capture on the source widget. This means those queued touch events are targeted to the source widget instead of the moving widget, but the touch history is already transferred to the moving widget, which makes troubles on gesture recognition. We can release the capture on the detach on this specific situation. - the recognized gestures are sent to the root window of the moving widget and nobody can handle. The new class RemainingGestureEventHandler handles them. - RemainingGestureEventHandler should not handle events originated from ET_TOUCH_CANCELLED -- some test cases actually fail if so. ET_TOUCH_CANCELLED can happen internally within the browser (like Window::CleanupGestureState()), but that's not the intention of this class. Bug: 943316 Test: the new test case in interactive_ui_tests Change-Id: I679562d7707342874960dd7ff4d70d749f1ad437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545113Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#647789}
-
Steven Bennetts authored
This needs to be a separate component for //chromeos/network. For largely mechanical changes: TBR=reillyg@chromium.org Bug: 944665 Change-Id: I6ffb564adcf7e037a6442697bee650d9be9286bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552256 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#647788}
-
Ehsan Karamad authored
All tests suddenly started failing on linux_chromeos_dbg and the root cause is not visible. TBR=wjmaclean@chromium.org Bug: 949565 Change-Id: Ia94f554c8d6a54c7217900407313dd4b437bffc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553033Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#647787}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1240db678cae..3416d48b594a git log 1240db678cae..3416d48b594a --date=short --no-merges --format='%ad %ae %s' 2019-04-04 cepheus@frii.com Update to latest SPIR-V header and bump revision. Created with: gclient setdep -r src/third_party/glslang/src@3416d48b594a The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I94af943f676c573804cad46c363967a2a7e74bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647786}
-
Tommy C. Li authored
This CL removes the ignore_editing parameter of LocationBarModel::GetSecurityLevel. Almost every callsite already has ignore_editing == true, with the exception of one. The larger goal is to make LocationBarModel reflect the current page's navigation state without any knowledge of the omnibox's user input state. This is what the class comment describes. And that's part of the larger goal of improving the omnibox's cross-platform UI architecture. Bug: 912722 Change-Id: I53c8574777b9b2c98ba0bf8ca73244916756705f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546147Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#647785}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id8b0244cec9aaf94e6d879e673510ac0d733a4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553245Reviewed-by:
-
Dan Elphick authored
Uses Context version of Object::Set and calls Check on the result as these are cases where it cannot fail. Bug: v8:7283, v8:8834 Change-Id: I87be160df9552075b2f6a7fca7cad850d1e5ac26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553421 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#647783}
-
Eric Lawrence authored
The Certificate verifier needed to explicitly distrust Cloudflare certificates issued before April 2nd, 2014. Those certificates have now all expired and special distrust is no longer needed. Change-Id: I07d7bfea8496e61725cd5307a57dccf08c3b3536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552099 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#647782}
-
Mohamed Amir Yosef authored
Before this CL: All transaction started in PasswordSyncBridge were always committed even in case of failure which could result in some in consistent DB state (e.g. data written without the metadata) After this CL: Transaction are rolled back in case of error, and committed only if every steps is successful. Bug: 902349 Change-Id: I301087dd596ae35b7af80549aad880a11377a535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552869 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#647781}
-
Nate Chapin authored
They were originally separate because it wasn't clear the framebusting intervention would ship. It has, and is no longer behind a flag, so streamline the logic. Change-Id: Ib771156193c7ab99e8c9f849723bd351ebbe1bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534917Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#647780}
-
Mounir Lamouri authored
This avoids including web_contents_observer.h for consumers of the struct that aren't WebContentsObserver. Bug: 947806 Change-Id: Ide735ae9b78df2d2640ac6a54635428ab47b54da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547057 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647779}
-
Daniel Bratell authored
Code in blink/modules/foo/*.cc often use code in modules:modules which in the build system is not an allowed include. This makes it legal. This has no visible impact since the build order is already ok and gn check errors are disabled for blink, but long term we'd like to enable gn check and this is a small step on that route. Bug: 800764 Change-Id: I083ec02f5190b5ee17e0394e1f5add940d1f4172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552808 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#647778}
-
Austin Eng authored
Bug: 877147 Change-Id: Id718dc6ebd74a8db0925f085c6df305141ee87ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547936Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#647777}
-
Stepan Khapugin authored
Uses the collectionViewContentSize as the cell size for the shortcuts. In order to do this, ShortcutsViewController now is a UICollectionVC. To avoid issues with rotation, configureLayout: method now takes targetSize: parameter that allows pre-calculating the insets when the ShortcutsVC's view transitions to a new size. Change-Id: I9a740289bb60c43e0b443217fb94798e0ac3bc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552846 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#647776}
-
Mike Reed authored
Bug: skia:8937 Change-Id: I38688af3dfe3224541549860b1e1641a6722c0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553161 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#647775}
-
Thomas Tangl authored
|prefs::kSearchSuggestEnabled| is added to the list of synced prefs that are observed during settings opt-in. Bug: 933647 Change-Id: Ia70c75e7dae921552c29afbe1bdb7d312decaf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552873Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#647774}
-
Xiyuan Xia authored
Consolidate display moving logic into ClientRoot's OnWindowRemovingFromRootWindow and OnWindowAddedToRootWindow and avoid sending bounds update in middle of display changing. Bug: 949294 Change-Id: Iab728ea126f056cf4dcb680c2297da00aa100f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552286Reviewed-by:
-
Mugdha Lakhani authored
to support Periodic Sync registrations. Also updates GetSoonestWakeupDelta() to only consider one-shot Sync registrations for the existing wake up task. A follow-up CL will add a wake up task for Periodic Background Sync. Bug: 925297, 948206 Change-Id: I616371da7d6d61b4893acf961043b925dc42195d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524352 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#647772}
-
Mario Sanchez Prada authored
After the cleanup work done to migrate away from net::CompletionCallback() and use net::Completion{Once|Repeating}Callback instead, this file is not needed anymore, so let's remove it to prevent accidental new usages of those generic callbacks, and force using the new ones. Bug: 807724 Change-Id: Ie47786e4e3da64481dde4bf91987844fa6dfcab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552821 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#647771}
-
Miguel Casas authored
This CL teaches GLImageNativePixmap how to map BGRX_1010102 to the DRM one, and adds it to the unit test case list. (needs https://crrev.com/c/1552107). Test: /tmp/ozone_gl_unittests --gtest_also_run_disabled_tests Bug: 949260 Change-Id: Id499073d004e3b6319cb1131fbb5b80507683e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552105Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#647770}
-
Christos Froussios authored
This reverts commit 4e001d88. Reason for revert: Suspected of breaking DataReductionProxyFallbackBrowsertest.ProxyBlockedOnAuthError DataReductionProxyFallbackBrowsertest.RedirectCycle on linux-chromeos-dbg Bug:949577 Original change's description: > Fix quic webdriver test > > Net.QuicAlternativeProxy.* histogram is not recorded with servicification. > So that check is removed in the test. The DataReductionProxy.Quic.ProxyStatus > histogram used in the test should be sufficient. > > Bug: 934875 > Change-Id: I1cdb16e347bd4cf852cc30481887a94dabceef8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551710 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647481} TBR=robertogden@chromium.org,rajendrant@chromium.org Change-Id: I5f8768916c18cc3a2cbf8634672ec49ebf42f9b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552878Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#647769}
-
Gauthier Ambard authored
This CL enables the handling of WebUI pages by WKWebView by default. Bug: 739844 Change-Id: I45853c60c7e598ecfdda4028e86547568bb7bd9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551663 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#647768}
-
David 'Digit' Turner authored
The path-related methods in base::Value currently take either a std::initializer_list<StringPiece> or a std::span<const StringPiece> argument to specify the path of dictionary items, but this turns out to generate larger code than necessary, and even force heap allocations in the case of std::span<> (which is typically used to pass a std::vector<std::string> as an argument). This CL introduces new versions of these methods that take a single StringPiece for the path parameter (using simple dots to delimit path components). In addition to this, type-specialized methods like FindStringPath() or SetIntPath() are also provided to provide a more user-friendly API, and in the case of Set<Type>Path(), more efficient as well. The old methods are not removed yet but tagged deprecated and will continue to function, until all callers have been updated to the new ones. BUG=646113 R=dcheng@chromium.org,jdoerrie@chromium.org,sdefresne@chromium.org,hidehiko@chromium.org Change-Id: Ia28c604d5b2a017eb92508ab230fe9ea2288f3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538292 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
-
Tien Mai authored
- A user is now allowed to bypass entering their old password when updating their windows password if they forgot their old password. - The user's password will be forcefully reset once they confirm they wish to reset their password. This will cause them to lose all their encrypted data. Bug: 912609 Change-Id: I308a41d2ba278c0e15c6976fb41bb0ebcf9bd414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551465 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#647766}
-
Lukasz Anforowicz authored
This CL prepares CanAccessDataForOrigin (which can be called on the UI or IO thread) to support citadel-style enforcement (which requires calling DoesSiteRequireDedicatedProcess). See https://crbug.com/764958 for more details. Bug: 764958 Tbr: servolk@chromium.org (for mechanical //chromecast changes) Change-Id: Iec64cbe3a42164c1993d2e41ee1ec18655160626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546323 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647765}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b053961e125c..9c85e2560369 git log b053961e125c..9c85e2560369 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 lalitm@google.com Merge "trace_processor: fix generation of proto names" 2019-04-04 treehugger-gerrit@google.com Merge "Do not start heapprofd in integrationtest." Created with: gclient setdep -r src/third_party/perfetto@9c85e2560369 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5a942d8f6879586226034e9808079e6e8fdcfa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553030Reviewed-by:
-
Brian Liu Xu authored
A previous update to AXPlatformNodeWin caused get_localizedExtendedRole to return S_OK and empty strings when the role description was not explicitly set. Consequently, the UA would report empty descriptions instead of the implicit defaults. This had wide impact since as most objects do not set their role descriptions. This change ensures that the function returns S_FALSE when the role description is not explicitly set. This tells the UA that it should use the default description. Bug: 947762 Change-Id: I124d2c61d5f6e3d9545bd350cabd674f7f5fe354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545685Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#647763}
-
Michael Ludwig authored
Bug: 948646, 949538 Change-Id: Ib439b1111be76febdd212e00e8895a65cc2b0387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553160Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#647762}
-
Johannes Henkel authored
... to 454b6bcf7d08535681bbd967030f5248bcbc8e6a This bumps the stack limit for JSON / CBOR to 300. Change-Id: I6549765c1d9e23072c488dd4f7ec8437bd8d1a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552648 Auto-Submit: Johannes Henkel <johannes@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#647761}
-
Mike Wittman authored
Makes Frame a top-level class so that it can be reused in unwinding code independent of building a profile. Bug: 909957 Change-Id: I8864863b41f7846eca8efa220cec8476e4875a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543809 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#647760}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6c371ca7005a..21f6fd79ad05 git log 6c371ca7005a..21f6fd79ad05 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 jakobi@webrtc.org Add preemptive rate and preferred buffer size plots to event log visualizer. 2019-04-04 gustaf@webrtc.org AEC3: Remove unused config parameters Created with: gclient setdep -r src/third_party/webrtc@21f6fd79ad05 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib6de7e58af4c8c72ff7cff37b71eb38bfa44d889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553029Reviewed-by:
-
Adithya Srinivasan authored
Currently, after calling OverrideBinderForTesting, we completely drop the existing registered interface binders. This CL modifies this behavior, and lets us fall back to the pre-existing registered binder for an inteface if it hasn't been explicitly overriden by OverrideBinderForTesting. Change-Id: I59673ac42f98615451be518bfd61dd0f8f6b3ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543455Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#647758}
-
Daniel Bratell authored
A missing dependency made chromedriver builds flaky. This was reported as a dependency error by gn check --check-generated after enabling dependency checks of chrome/test/* in .gn so having those dependency checks enabled would have prevented this. Bug: 949518 Change-Id: I3be5864d27e8258be193e67dc9f05f303b7c00fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552849 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647757}
-
Jochen Eisinger authored
Change-Id: Ia520380215f04c3686ad96b88a2db7f170b8852a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552220 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Suffix all GC calls for testing as such to illustrate this these methods should never be called from production code. Rename full GC to forced GC for testing. Bug: 948807 Change-Id: I03e6139ee365b575e7634a4058419af9b0c90cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549259 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Adam Rice authored
* Remove RetainWrapperDuringConstruction(). * Remove warnings about special GC semantics. * Remove holder_ hack from transform_stream_test.cc. Change-Id: Iaf5d5868679b33c1411fb944120c4711d8d00a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547715Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
manuk authored
This is the 5th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. For classification, document suggestion contents and historyUrl suggestion descriptions currently use a) bookmarks::CleanUpTitleForMatching, b) AutocompleteProvider::TermMatchesInString, and c) HistoryProvider::SpansFromTermMatch. Document suggestion descriptions (e.g. 'Google Drive') are not classified, and historyUrl suggestion contents have unique classification logic which this CL does not address. This CL changes document suggestion contents and historyUrl suggestion descriptions to use FindTermMatches and ClassifyTermMatches defined in autocomplete_match_classification.cc instead. These methods were created in the previous refactoring CL's and are based on the methods (a), (b), and (c). But unlike the previous methods, these are located adjacently in a single file and are more generic to allow reuse by ideally all providers. Additionally, this CL removes the AutocompleteProvider::TermMatchesInString method as it's no longer used. Migrating from the previous to the new classification methods has a few behavior changes as well: 1) The document and historyUrl suggestions now check for prefixes matching, where if the user text is an exact prefix of the suggestion text, further occurrences of the user text are not styled. E.g., the user text "the" will bold only the first occurrence in the suggest text "[the] dog ate the moon". 2) The document and historyUrl suggestions do not restrict matches when the user text contains symbols. Previously, the user text 'the-' would match the suggest text '[the-]dog' but not the suggest text 'the dog'. With this CL, symbols in the user text are disregarded unless prefix matching, and 'the-' matches '[the] dog'. Bug: 366623 Change-Id: I48a7d06e05f5c77551033bc085a263b57840cd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552140Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#647753}
-
Tom McKee authored
OnForwardScrollUpdateToMainThreadOnImpl is used to record latency components that aren't used downstream. There is still some follow-on work to remove the unused latency components definitions from LatencyInfo. Change-Id: I7d54a3fcabecd63ddabfc4705924a3c37d2ad480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551063Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#647752}
-
Stepan Khapugin authored
Fixes Cmd+C and Cmd+V in pre-edit. Adds a unit test to prevent future regressions. Currently an EGTest is not possible, as EGTest doesn't have actions for sending keyboard events. Removes a DCHECK for OmniboxTextFieldIOS' delegate to be a more specific subclass, which seems fine as all of the methods of OTFIDelegate are optional Bug: 945024 Change-Id: I216bc8361e01e9874623e2105416e2cfa9ff03aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547747 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
tzik authored
Change-Id: Ib825aec08f3d55d6e4c6cbf25ba63c5f36bb41c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552899 Auto-Submit: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#647750}
-
