GitLab

Bug: 1039309,1037171
Change-Id: Iba3be9ca90fa41d960a9538f603ad473f8c4de40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988848
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729525}

Bug: 1039873
Change-Id: I2ccb3666310bf8b61cedfa84fd0717821e6664e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992186Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729524}

This CL fixes issue with IPv6 address value flashing "Not available"
on connecting when IP address details are configured manually. This was
caused because an additional check to not show IPv6 in this case was
mistakenly removed in a previous CL (https://crrev.com/c/1954929).
Fixed this by restoring the extra check.

Fixed: 1039581
Change-Id: Id6d9d18034577c30da86d9bbb0cf84cfb3eda737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988743Reviewed-by: Jon Mann <jonmann@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729523}

BUG=1011235

Change-Id: Id02f5cefbcd5db88bda7cb2cc64d43500da0171c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989709Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729522}

To use this class from other tests.

Bug: 1038346
Change-Id: I14ac4ec270219314a8a096319cc023842a01f55f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989206Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729521}

This CL moves 31.6 kB of "long tail" resources to the Developer WebUI
Dynamic Feature Module (DevUI DFM), for 9 chrome:// pages whose
resources were in components_resources.pak. These resource reside in
GRDP files. The new PAK file is created by moving GRDP <part> from the
components_resources.grd to newly file dev_ui_components_resources.grd.

7 chrome:// pages that are directly moved are:

  autofill-internals = password-manager-internals
    (IDR_AUTOFILL_AND_PASSWORD_MANAGER_INTERNALS_*)
  crashes (IDR_CRASH_CRASHES_*)
  gcm-internals (IDR_GCM_DRIVER_GCM_INTERNALS_*)
  net-export (IDR_NET_LOG_NET_EXPORT_*)
  policy (IDR_POLICY_*)
  signin-internals (IDR_SIGNIN_INTERNALS_INDEX_*)
  user-actions (IDR_USER_ACTIONS_*)

2 chrome:// pages that needed new GRDP files (to separate DevUI
resources from end user-facing resources) are:

  ntp-tiles-internals (IDR_NTP_TILES_INTERNALS_*)
  interstitials (IDR_SECURITY_INTERSTITIAL_UI_*)

These resources are moved to new file dev_ui_components_resources.pak,
which then feeds into dev_ui_resources.pak. WebUI .cc and .mm files have
their resource include headers updated.

Bug: 927131
Change-Id: I4834288d4d6f64a1b5c21ab66402bb20b60844e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959770
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729520}

When handling shelf drag with extended hotseat, do not start window
drag unless the current drag is moving downwards.

While ShelfLayoutManager::MaybeStartDragWindowFromShelf already checked
whether the scroll direction is not down, it was bypassed when the
method was called from StartShelfDrag (because the scroll value was not
known at this point).

This updates MaybeStartDragWindowFromShelf no to start window drag until
it's clear that the drag is upward drag when hotseat is extended.

Also, removes MaybeStartDragWindowFromShelf call in StartShelfDrag as
it's expected to be no-op with this change.
*   the method is no-op in kShown hotseat state
*   in kHidden hotseat state, drag is started only if drag gets above
    kExtended hotseat bounds (which will not be the case when the drag
    starts)
*   in kExtended hotseat state, the window drag will not start as the
    drag direction is not yet known at this point.

BUG=1039906

Change-Id: Ia8087422d61726316a99cc11cc011b9f90d42d84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992347Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729519}

This is a reland of 834f2092

Original change's description:
> Squash top level error code returned from host resolver.
>
> If the host resolution process fails, the top level error code should
> now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g.
> ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be
> found in ResolveErrorInfo.
>
> Bug: 1016325
> Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678
> Commit-Queue: Katharine Daly <dalyk@google.com>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728725}

Bug: 1016325, 1039639
Change-Id: Ifcf5d1c8d3e5558e81b9efc784d234d034ee9a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990249Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#729518}

This patch fixes an under paint invalidation issue related
to border-radius on a scrolling element.
Before this change we were applying border radius clipping twice,
on the container and on the scrolling background.
This was producing an unnecessary change of background painting
when border radius changes, thus the under-invalidation problem.

To fix this we're avoiding to apply the border radius clipping
when painting the scrolling background.
The main change is at BoxPainterBase::FillLayerInfo::FillLayerInfo()
which gets a new parameter is_painting_scrolling_background,
we use it to avoid setting is_rounded_fill to true.

The test expectation is modified so it also uses composition
by setting "will-change: transform" on the "scroller".
Also the "fixed" elements is moved out of the "scroller"
as the "scroller" is now its containing block,
otherwise it wouldn't be visible,

BUG=1025019
TEST=compositing/overflow/scroller-with-border-radius.html

Change-Id: Ib9b6e2e8b4e8ee42dec413c69b853a3f06336774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984312
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729517}

They have become unused.

Change-Id: I1090f20a31c9f72dc494fff07b08ff49d206d8ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989868
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729516}

This will allow to remove some duplicated code (i.e. thread synchronization)
while at same time removing unnecessary use of inline ASM for Intel features
detection.

A few other advantages:
 - remove some extra logic (e.g. no need to test the platform to include the
   correct CPU detection header).
 - simplifies the buildsystem (i.e. we always include cpu_features.c)
 - get rid of the simd_stub file.

Bug: 1032721
Change-Id: I9427b34ec09dddc41925844a6ec4e6aa4d8f3207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987190Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729515}

Change-Id: I6f8dafe320998b1a624678d0d232f771fdde198e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992359Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729514}

Most TestingDeviceStatusCollector test cases use similar callbacks. It
is unnecessary to assign them explicitly into the constructor every time.
Introducing a struct with all default callbacks, then change one of them
respectively can simplify the codes.

Bug: 1034980
Change-Id: Iea3d9ea3e8a25197dd17eb6d7f95536b5c1e36ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980209Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Anqing Zhao <anqing@google.com>
Cr-Commit-Position: refs/heads/master@{#729513}

ShelfLayoutManager may change display work area while updating shelf
bounds - this can cause a call to OnDisplayMetricsChanged(), which
starts another bounds update. To prevent reentry into bounds update,
ShelfLayoutManager::OnDisplayMetricsChanged() should exit early if
shelf bounds update is already in progress.

BUG=1040177

Change-Id: I6d5bb49e7d333fd83bd87df8a1e7f12dd3c2a983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992584Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729512}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3624da9ce38b..625b71f2a1fc


Created with:
  gclient setdep -r src-internal@625b71f2a1fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ic57b64a650c8c35cf747a861f28b29b6d49aa471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992346Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729511}

Bug: 966270
Change-Id: I193e7b33f60846d488c9d08b62f23d2432710a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794147
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729510}

Extract ChromeBasePreference.java to Settings build target, along with
owned resources.

Bug: 1035928
Change-Id: Icbc92b6b412a33a741ae528b27d70004b359ccc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991730Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729509}

TBR=dmazzoni@chromium.org

Bug: None
Change-Id: If3eab1d8c1ea9bb33d86a5ba69903f7a3be9a3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990196Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#729508}

Bug: 1039873
Change-Id: I114ea6f03b57911b510e449a356907207d21ac32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992163
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729507}

This patch cleans up the find request queue when the main RenderFrameHost
is removed from the FindRequestManager. This ensures that we don't try
to dispatch more requests, which causes a DCHECK.

Note that this patch only affects main frame removal, so it shouldn't
have any user-observable behavior changes.

R=creis@chromium.org

Bug: 1032576
Change-Id: I4d09ba2cf68a71213704b9d2a4a189f5ae2b5489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988679Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729506}

Also adding new flag 'enrollToken' which allows overriding the default token

Change-Id: Idf5d5abee4b8fb885f73c046c3d1440511e35aee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988953Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Xiang Ji <jxiang@google.com>
Cr-Commit-Position: refs/heads/master@{#729505}

Using wpt-import in Chromium a498c649.
With Chromium commits locally applied on WPT:
aa30315c "Reject cookies with empty names and values."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
garykac@chromium.org, pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/clipboard-apis

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Iced7a4074188879783a38305c2a5d7988a5ce196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992281Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729504}

Webviews will be explicitly sized. No need to size them by parent size.
This will allow the embedding window to be sized based on the viewport
such that it allows us to clip contents.

Bug: b/143612326
Test: Manual
Change-Id: Ie3382c094e11b31b3515c7ef3ee76e55169b7a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962980Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729503}

If Tabswitcher is shown, we switch to HomePage which owns fakebox.

Bug: 1039467
Change-Id: I9a59c9dba89acc9a2644a12663fafaba054d0d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989867Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mia Glaese <glamia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729502}

The present CL moves the comment "Attempt to move a window to a
different desk" because the code "item_->SetOpacity(original_opacity_);"
is equally relevant to just dropping the window back into overview.

Bug: None
Change-Id: I9fe75292dbb85280ba89c6fdeee55982524edad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991982Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729501}

This is fairly straightforward.

Bug: 1011446
Change-Id: I75ce7abc27d51e32028c27354fa621de98d05470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990126Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729500}

Set `"shard size": 20` value in tests-config,
expecting to have 2 swarming tasks as
there are 31 test classes in ios_chrome_ui_eg2tests_module.app

Bug: 1033541
Change-Id: I2a3dba9f53bc58d8b9cc7124d795be807c93a6e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962636Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729499}

This fixes pinned extensions becoming visible and their widgets anchoring correctly when the extension is not visible because of extensions container size constraints. The effect of this change is that non-visible pinned extensions will pop in as the furthest left icon in the container and all other non-visible extensions will pop up on the right (just left of the extensions button). Once the anchored widget is dismissed, any previously non-visible icon will then disappear and the container would return to its previous state.

Bug: 995448
Change-Id: I42d9a710dc89a82706e5b8014f823cbb3ee01a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977390
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729498}

Stores in Member constructors are initializing, which means:
1) for Dikstra barrier: the source object is white and the tri-color
invariant is preserved;
2) for generational barrier: the target is older than the source and
doesn't have to be remembered.

This reduces number of executed barriers from 115M to 78M (31%) on
speedometer.

Design doc summarizing results: https://bit.ly/2QTmOly.

Bug: 1021889
Change-Id: I975afeb42eef53f583ce9bb45faf410a0914d264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991622
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729497}

This applies the CSP of the context document to any doc created by calling
DOMParser.parseFromString. The original implementation, as it returned a
pointer to the CSP instance of the context document, which (in some
circumstances) could mean that the CSP of the context document itself was
modified. This makes a copy of the context document's CSP, before assigning it
to the newly created document.

This re-reverts / re-lands
  1975710: Revert CSP application to `DOMParser.parseFromString`.
  1917532: [Trusted Types] Fix Trusted Types for other document types

Bug: 1030830, 951536
Change-Id: I33adff8c376a6f37788c9aee0ef7ca0c3441785f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980183
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729496}

Currently if user puts their mouse cursor on the top of the screen and
press F11 to enter fullscreen mode, the Exit Fullscreen X button and the
"Press [ESC] to exit fullscreen" prompt will overlap (see bug for demo).

This CL fixes this by putting the fullscreen control X button in
cooldown mode if the exit prompt is still in showing-animation. In this
case the user will need to withdraw the cursor from the top buffer area
then move it back to the top of the screen to trigger the X button.
Screen cast: https://screencast.googleplex.com/cast/NjU1MTk3NDQzMjQ3MzA4OHwzNTUxNWRmYi1kZA

A simpler alternative design would be just to suppress the X button
whenever the prompt is showing, and never bother with the cooldown mode,
but that would end up having the X button immediately pop up even if the
user just moves the cursor a little bit after the prompt is fully shown.

Bug: 1038026
Change-Id: If42517c7e87e8b9ab240ac5635f8f7cd33991447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986307Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729495}

AppCache stores cache data on and reads data from disk using async
functions across multiple interfaces.  This makes accessing the cached
data for tests cumbersome.

This CL adds an AppCacheCacheTestHelper class along with a unit test
to simplify the write and read stages of cache info and data on disk.

AppCacheCacheTestHelper will be used by a later CL that modifies
AppCacheUpdateJobTest to verify that, after a 304 request, cached
headers are correctly updated to match the server's response.  Both
the response info and the data has to be verified because our plan
is to create a new cache entry for the updated headers and we'll
want to verify that the data itself is also correctly saved in the
new AppCache cache entry.

Bug: 989611
Change-Id: Ic38880bc17e6fc2dcdbed048e2453649cde0e5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988380
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729494}

BUG=none
TEST=none

Change-Id: I42fa1f35cc3d23d6799a3edfbb9e2bfef9554abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992266
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729493}

Bug: 1039009
Change-Id: Iac72405436958fd43a0ccdc8940fca5754454bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988728Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729492}

More fields have been added to a FIDL Semantic Node. This CL adds
support for those new fields.

Test: Updated existing unit tests.

Bug: fuchsia:41000
Bug: 973095
Change-Id: I7e397875206362ebf68e65b7466f6890255322da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988160
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729491}

R=chrisha@chromium.org

Fixed: 1039223
Change-Id: I314aaaf0682dea7cb962cd247fb1430b4d7e7267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989980
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729490}

Instead, use the explicit setter on DialogDelegate. Thankfully
IDS_APP_CANCEL is already the default for ui::DIALOG_BUTTON_CANCEL :)

Bug: 1011446
Change-Id: Ifc67f637732c07137c2b65b54fbba64f2f0c77d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992189Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729489}

The test flakes regularly on both debug and release bots.

TBR=fdegans@chromium.org

Bug: 1040202
Change-Id: I0b6c822351d0646ba748fc1ce4b4809d0b1ac174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992305Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729488}

This reverts commit 8b4578d6.

Reason for revert:
This change breaks running any tests on macOS systems that do *not* already have MAC_CHROMIUM_TMPDIR set; the generated value for it if it is unset is far too long (eg on my system it is "/var/folders/yd/p_tdv3gs24904_gjb44140tc003h8w/T/.org.chromium.Chromium.VHPP1z/0"), which hits the DCHECK here: https://cs.chromium.org/chromium/src/base/files/file_util_mac.mm?type=cs&q=MAC_CHROMIUM_TMPDIR&sq=package:chromium&g=0&l=35

To repro that failure:
1) build at trunk
2) $outdir/browser_tests

Original change's description:
> Improve temp dir handling for child procs on Windows and macOS.
> 
> Tests may leak files/directories in temp due to ScopedTempDir lifetime
> issues (see linked bug) or as a result of crashes. This CL augments the
> TestLauncher to handle such leaks a bit better. When launching a child
> proc on Windows and macOS, the TestLauncher now directs that child to
> its own dedicated temporary directory. Upon child exit, the launcher
> checks for leaked files/directories in that dir and deletes the dir. On
> test iteration completion, the launcher will emit a list of the tests
> that produced leaks when run with --test-launcher-print-temp-leaks that
> looks a lot like this:
> 
> ERROR: 2 files and/or directories were left behind in the temporary directory by one or more of these tests: PaymentManagerTest.ClearPaymentInstruments:PermissionControllerImplTest.ResettingOverridesForwardsReset:PermissionControllerImplTest.SettingOverridesForwardsUpdates:PermissionControllerImplTest.RequestPermissionsDelegatesIffMissingOverrides:PermissionControllerImplTest.GetPermissionStatusDelegatesIffNoOverrides:PermissionControllerImplTest.GetPermissionStatusForFrameDelegatesIffNoOverrides:PermissionControllerImplTest.NotifyChangedSubscriptionsCallsOnChangeOnly:PermissionControllerImplTest.PermissionsCannotBeOverriddenIfNotOverridable:PermissionControllerImplTest.GrantPermissionsReturnsStatusesBeingSetIfOverridable:PictureInPictureServiceImplTest.EnterPictureInPicture
> 
> Curious developers can binary search in that short list of tests to find
> the one(s) that are leaking and clean them up.
> 
> BUG=546640
> TBR=sky@chromium.org
> 
> Change-Id: If3be7034094827979c225d2eb2beba2d92e6e7ce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978679
> Commit-Queue: Greg Thompson <grt@chromium.org>
> Auto-Submit: Greg Thompson <grt@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728475}

TBR=sky@chromium.org,erikchen@chromium.org,grt@chromium.org,isamsonov@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 546640
Change-Id: Ic1d52021e5505508d271f2b1932f00c3e77377be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991933Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729487}

https://webrtc.googlesource.com/src.git/+log/bd5874accf0f..28209b43f4a1

git log bd5874accf0f..28209b43f4a1 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 086dd4c4..4bca0ab4 (729202:729323)
2020-01-08 jakobi@webrtc.org Remove extra delay field trial.
2020-01-08 srte@webrtc.org Moving FakeNetworkSocket to fake_network_socket_server.h
2020-01-08 srte@webrtc.org Cleanup: Removes redundant includes on message_queue.h

Created with:
  gclient setdep -r src/third_party/webrtc@28209b43f4a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ic1a5708f42e66997b8358c94c283daab743bc526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729486}