- 16 May, 2018 40 commits
-
-
Ted Choc authored
BUG=843596 Change-Id: I4846edc879c2b913ba558cbfb7884836d398aabc Reviewed-on: https://chromium-review.googlesource.com/1062018Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#559179}
-
Dominic Mazzoni authored
Changes to these externs are mechanical and already enforced by a presubmit check, so it doesn't make sense to get owners review most of the time. We'll use our best judgement and loop in an owner if the change is nontrivial. NOTRY=true Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a4ab89ae7cf231cffcf313b631b3c878b693b31 Reviewed-on: https://chromium-review.googlesource.com/1062075 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559178}
-
Randy Rossi authored
Part of ongoing effort to enable ChromeVox in chromecast. This CL added a required message filter to handle I18nGetMessage. Bug: b/73383411 Test: None Change-Id: I5d704397ae789e4ca72c15e0240a079b2ddc43ac Reviewed-on: https://chromium-review.googlesource.com/1058082Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559177}
-
Robbie McElrath authored
This is needed in order to migrate the devicemotion layout tests over to using mock generic sensor services. The old devicemotion events are backed by 3 different generic sensor types, so the MockSensorProvider needs to be able to mock and allow tests to get references to multiple types of sensors at the same time in order for these tests to mock out everything they use. Bug: 802815 Change-Id: I254c37d67db0e9c6feb639080394305b41f6b7e6 Reviewed-on: https://chromium-review.googlesource.com/1060477Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#559176}
-
Evan Stade authored
Previously we used the deprecated NotificationUiService::CancelAll via BrowserCloseManager to do this. That used the MessageCenter singleton directly, which worked with in-process Ash but not oop Ash. By listening for profile shutdown in the NotificationPlatformBridge, we can accomplish the same thing and it works in oop Ash as well. This is a roundabout way of fixing the bug, which AFAICT is a race between the Profile object shutting down and Ash asynchronously (via mojo) notifying of a notification toast closing. I couldn't figure out how to trigger this race, hence no direct test. Bug: 842705 Change-Id: I5913bcb3077450433e26ba6cc7397e17211bc9a6 Reviewed-on: https://chromium-review.googlesource.com/1058491Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#559175}
-
Steven Bennetts authored
Bug: 798569 Change-Id: I476672a73ba64ee28d399686d0ecfc4c26690936 Reviewed-on: https://chromium-review.googlesource.com/1060579Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559174}
-
Matthew Jones authored
The preload functionality causes more problems than it solves. Content that wants to delay loading until the sheet is opened can do so using events provided by the BottomSheetObserver. This fixes a race condition in EoC that would cause the sheet to peek before being requested. Bug: 834923,843267 Change-Id: If5c35e22a502e42f6bc591784b4fb8343e713eff Reviewed-on: https://chromium-review.googlesource.com/1060353 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#559173}
-
Eric Orth authored
Also servicified ClearNetworkErrorLogging as it's extremely similar logic. Moved the clearing on DATA_TYPE_COOKIES to BrowsingDataRemoverImpl as it is not chrome-specific, and left the clearing on DATA_TYPE_HISTORY in ChromeBrowsingDataRemoverDelegate. Especially good cleanup for Reporting data as the two cases were split into two independent Clear... methods in NetworkContext. Bug: 824997 Change-Id: Ie13ef2277d9040f73e87b77be49ba47305462aab Reviewed-on: https://chromium-review.googlesource.com/1045206 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#559172}
-
Ian Kilpatrick authored
Essentially this boils down to during min/max auto/percent/calc should be treated the same, either being border+padding or infinity. And during layout they should be taken into account. I added some tests which now match FF/Edge (004,005) which LayoutNG matches, but existing layout fails. The primary difference is change by passing kContent into ResolveBlockLength during the ComputeBlockSizeForFragment function. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4e0c171a0e29ea5d85a742d85df001647813c1f3 Reviewed-on: https://chromium-review.googlesource.com/1056291 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#559171}
-
Ahmed Fakhry authored
Due to ink drop effects on the caption buttons, they're painted to layers. This doesn't work in immersive fullscreen mode and causes the buttons to disappear. This CL fixes them by adding them temporarily as children of the TopContainerView which is already painting to layer in immersive mode, and is resposible for painting its sibling BrowserNonClientFrameViewAsh. BUG=840242,787640 Change-Id: I8353f3d393fc5113deb7776b742da64aa386c9a0 Reviewed-on: https://chromium-review.googlesource.com/1052675 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#559170}
-
Chong Zhang authored
The test times out randomly (~10%) since Build #13171: http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html TBR=jam@chromium.org Bug: 729849 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2eec60a97836aff470894faaaebc2e3260cce996 Reviewed-on: https://chromium-review.googlesource.com/1062073 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559169}
-
Mikhail Istomin authored
GetFileSize can be used to estimate buffer size if file size is available. So use it as a hint for buffer size for file reading. Also avoid latest fread syscall in reading loop using feof. Bug: 821262 Change-Id: I7dc30483a2f95d4da2c0d3cb0049941d2634a281 Reviewed-on: https://chromium-review.googlesource.com/958861 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#559168}
-
Xiyuan Xia authored
- Add kAnswerCard result type for answer card result; - Pass answer card preferred size via mojo; - SearchResultAnswerCardView creates RemoteViewHost only when the embedding token changes because the token could be used only once; - SearchResultWebContents re-creates RemoteViewProvider to ensure a valid embedding token in case existing token is invalidated when swapping cards but the browser is not aware of that when creating a new card; Bug: 812434 Change-Id: I2a8b61974c46b779d8a61a571e95d8003b2bc123 Reviewed-on: https://chromium-review.googlesource.com/1060280Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Peter Wen authored
Rather than use `third_party/android_tools/sdk` and `third_party/android_ndk`, create and use the default `~/Android/Sdk` directory instead for Android Studio. This allows a consistent dev environment that does not change per-repository and also allows frequent updates without affecting each checkout. Necessary for native support and emulators. This will become the default in the near future. For now, use: build/android/gradle/generate_gradle.py --sdk AndroidStudioDefault Bug: 840542,620034 Change-Id: Ia482cb2982472410fe9c515c5f5f9856f3eadfaf Reviewed-on: https://chromium-review.googlesource.com/1058308 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559166}
-
Ken Rockot authored
Updates platform handle wrapping/unwrapping API signatures to be more extensible for a stable ABI, and adds support to shared memory region wrapping/unwrapping for writable regions, which may be represented by multiple platform handles on some platforms. TBR=bajones@chromium.org Bug: 826213,842037 Change-Id: Ia0e5da7b7e0f4c41853eb3a8d4a12da47071dd8c Reviewed-on: https://chromium-review.googlesource.com/1058440Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559165}
-
Emily Hanley authored
Bug: 831252 Change-Id: Ib447d09769d5ea4de8079a494cfc2e6ceaad5423 Reviewed-on: https://chromium-review.googlesource.com/1061581Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559164}
-
Ivan Sandrk authored
Componentisation CL for "Assessment Assistant". PRD: https://docs.google.com/document/d/15CNvkRKuuA6_n5TEtq4vYqb6MDQIy2lq-Ci6lSKMPac DD: https://docs.google.com/document/d/1x8JB5nMiCztrpnl7IseIkFRym1Ww3bRWSaXSObfsRHo Bug: chromium:813711 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I11b62d6a4b59962065c437030085f5b2300b3e2a Reviewed-on: https://chromium-review.googlesource.com/1030452Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
David Black authored
Previously this was stubbed in using a background color. Now, we will show the desired icon when using keyboard input modality. See bug for demo. Bug: b:79770465 Change-Id: Ib053e5aa7cb21edf8420c695710b10ed43f284a4 Reviewed-on: https://chromium-review.googlesource.com/1060429Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch fixes RTL 'text-align: start|right|center' not to shift the line by the amount of trailing spaces. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I99165bae187f7e76f183da20ce7a1909b10d1fc5 Reviewed-on: https://chromium-review.googlesource.com/1061273 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#559161}
-
Devlin Cronin authored
Enterprise policy allows for blocking extension access to a set of hosts (defined by URLPatterns). In the code, these are referred to frequently as RuntimeBlockedHosts; however, this is confusing with the RuntimeHostPermissions feature. Instead, name the enterprise policy-restricted hosts PolicyBlockedHosts to avoid ambiguity. Leave the string entry in the policy the same for backwards compatibility. Bug: None Change-Id: Icfa455e2912e3c05da58f0a0b0b8e53395d4e103 Reviewed-on: https://chromium-review.googlesource.com/1060526 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559160}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/41835253..f6054012 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibc05c77051c21bf58f16c3faa66615a3ae0603d5 Reviewed-on: https://chromium-review.googlesource.com/1061593Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#559159}
-
Vaclav Brozek authored
PasswordBranding was an experiment to change how Chrome's password manager is called. It has been removed from Chrome over a year ago [1], but the last reference in the test config was forgotten. This CL removes it. [1] In 57.0.2958.0, by https://codereview.chromium.org/2579823003. Bug: 799180 Change-Id: Ic003dcb375c490e5d72be6d495962e9860e8bbb1 Reviewed-on: https://chromium-review.googlesource.com/1061694Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559158}
-
Eric Karl authored
This change updates CompositorImpl and DelegatedFrameHostAndroid with the necessary logic to create a Viz process. TBR=piman@chromium.org Bug: 732555 Change-Id: I9290aeec317a95cd375a8a3ba0867a3c1548c52f Reviewed-on: https://chromium-review.googlesource.com/1055626Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559157}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/045e7f9ee4f9..08d5b1f33af8 $ git log 045e7f9ee..08d5b1f33 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 jaeheonlee Use NULL instead of nullptr, for pre-C++11 builds. 2018-05-07 jaeheonlee Fix the bug where ad_hoc_test_result() functions of UnitTest and TestCase objects would return failures registered at TestCase and UnitTest scopes, respectively. Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Change-Id: Ifb056d881111f364644cd76331e833961ad9042d Reviewed-on: https://chromium-review.googlesource.com/1061579Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#559156}
-
khmel@google.com authored
This fixes the issue when ARC++ window goes in/out full-screen or minimized/restored. In this case a window is removed deep inside the top ARC++ window and this triggers the wrong logout time activation. On removing l This CL checks removing window that belongs to tracked top windows and ignored hierarchy change events for other child windows. Test: Manually + unit test Bug: b/79169326 Change-Id: I825dd9d16d32ce305d43003fb2e77194cfc5ca7c Reviewed-on: https://chromium-review.googlesource.com/1045827 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/818075 moved the chromium.clang waterfall to generated json files. It tried to match the existing waterfall setup, but the difference in tests wasn't really intentional (and I was on leave when that change happened and nobody else familiar with the waterfall was cc'd on that change), so undo most of the exceptions added there. While here, also remove now-nonexistent bot 'ThinLTO Linux ToT', and latency_tests to 'Linux Tests', run nacl_helper_nonsfi_unittests on 'Linux Chromium OS ASan LSan Tests (1)', and metrics_python_tests on 'Win7 Tests (dbg)(1)'. On chromium.clang, adds - nacl_helper_nonsfi_unittests - services_unittests - viz_unittests - blink_heap_unittests - blink_platform_unittests - crashpad_tests - webkit_unit_tests - wtf_unittests - net_unittests - components_browsertests - extension_browsertests - gn_unittests - native_theme_usertests - nacl_loader_unittests - storage_unittests - latency_unittests - mac_installer_unittests - content_shell_crash_test - metrics_python_tests - device_unittests - views_unittests on at least one of the bots. Most of these should pass at least, and since they run on swarming hopefully they won't slow down the bots too much. Maybe I'll have to undo some of this again as a follow-up though. Bug: 843511 Change-Id: I3b6f0619c97d86d8768d10572a3c8beca20cea67 Reviewed-on: https://chromium-review.googlesource.com/1060293 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559154}
-
Tommy C. Li authored
We no longer need Narrow dropdown UI experiment because it's been adopted as part of the Material Refresh spec. Bug: NONE Change-Id: Iaf33efbd7e6f86321956290165d13dad69272c48 Reviewed-on: https://chromium-review.googlesource.com/1056148 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#559153}
-
Michael Spang authored
This adds a new component //gpu/vulkan/init that fills the same role as //ui/gl/init. It will allow ozone ports to provide the factory functions for surface types while still having a centralized entry point for initializing vulkan. Certain factory functions (e.g. VulkanSurface::CreateViewSurface) moved into a new VulkanImplementation factory object; platforms override those functions in order to build the right surface type. Common code for surface creation moved into VulkanSurface from its single anonymous subclass (VulkanWSISurface). This means VulkanSurface is not a pure interface anymore, but neither are any of the other wrapper classes. We could alternatively keep the pure interface and provide a "base" subclass to inherit from, but it's not clear that such a separation is useful. This also removes the VkInstance from the global scope. Nothing depended heavily on the fact that it was global, and since the vulkan API supports instancing of vulkan itself, it seems better to pass the instance directly into any components where it is needed. This makes any sharing explicit and makes instancing possible. Also, the VkInstance could not previously be destroyed, but now this is supported and exercised by the test suite. The Android code is also moved into this scheme, although it seems incomplete prior to this change, does not compile, and is therefore untested. Bug: 581471 Test: vulkan_tests Change-Id: Icefe29b0bfd4fe5ff2c951cefc47b0472250bce7 Reviewed-on: https://chromium-review.googlesource.com/1055824 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#559152}
-
Jacob Dufault authored
The hashing algorithm changes depending on the authentication method, and also possibly based on state in cryptohome (see cryptohome_authenticator.cc). A cryptohome key can dynamically specify which hashing algorithm it uses. Remove the SyncPasswordData mojom type; it will be computed automatically with the plain-text password. In the future, all cryptohome-related logic should be moved to ash. This will be more feasible after webui login is gone. Then, we should be able to eliminate the browser process ever having access to the plain-text or hashed password. In terms of security, this causes no regression compared to webui-based login. Bug: 826773 Change-Id: I9258be00afe151ffc0b8f61aafeb2b42ba8d12ff Reviewed-on: https://chromium-review.googlesource.com/1052381Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Ria Jiang authored
Viz hit-test doesn't work with mash completely yet so some mash_browser_tests would fail (e.g. [1]) when we enable Viz hit-test (feature VizHitTestDrawQuad) by default. Deleting that codepath in this CL since it's not used anyway and will revisit/debug when we need to add support for WS in Viz hit-test. [1] https://chromium-swarm.appspot.com/task?id=3d693515ea5b4310&refresh=10&show_raw=1 Bug: 842351 Change-Id: Id75b342427e231b209c90dbc1b603d65c5639fd0 Reviewed-on: https://chromium-review.googlesource.com/1058438Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#559150}
-
Tommy C. Li authored
The Copy URL adjustment code interacts poorly with ZeroSuggest, because it is subtly wrong. To be specific: If the popup is open, it would use the current match's URL even if the input text is not an exact match. This mostly affected MacOS. This CL fixes the bug and adds a test. Bug: 838541 Change-Id: Ia6e5d58aa473033c8f17783ce7fbcbce3b687938 Reviewed-on: https://chromium-review.googlesource.com/1059857 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559149}
-
Brian White authored
Crashes from Android indicate that the page_size being returned is zero. Set it to 1KiB for the check. It's probably 4KiB but this is sufficient for the test. Bug: 836875 Change-Id: Ifedbcd648157ac4e39560640048c0640f97e5416 Reviewed-on: https://chromium-review.googlesource.com/1059728Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#559148}
-
Mark Pilgrim authored
Bug: 714018 Change-Id: I6424da4665e0f5e4bdb8ad03b30ad5ff41d28b1f Reviewed-on: https://chromium-review.googlesource.com/1061813Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559147}
-
Steve Kobes authored
Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id64ba29f5105f8adb3e6f65fd1da5c8eec28dd89 Reviewed-on: https://chromium-review.googlesource.com/1061584Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#559146}
-
Luna Lu authored
As part of an effort to implement feature policies to improve performance issues with images, "max-downscaling-image" policy restricts images whose sizes are more than X times bigger than its containing block. Images will be rendered with inverted color when violating this policy. Bug: 837349 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I66d6e61b190d68750a458e2aa21a66683fd9d06a Reviewed-on: https://chromium-review.googlesource.com/1033449 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#559145}
-
danakj authored
This removes all std::unique_ptr<WebLayer> and pass around cc::Layer* directly instead of WebLayer*. R=pdr@chromium.org Bug: 838693 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic36930e83f8d5f64780c7f6b46632c9bd90888f6 Reviewed-on: https://chromium-review.googlesource.com/1060351Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#559144}
-
Sadrul Habib Chowdhury authored
ImageTransportSurfaceOverlayMac needs to notify its delegate when the presentation-callback is run, because the delegate (implemented by GLES2CommandBufferStub in regular chrome) is what ultimately sends the IPC for presentation-callback back to the gpu/viz-host. BUG=811961, 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic0538eae3dbe2bfbd92f1ffdc1a4d5bdf4b248a0 Reviewed-on: https://chromium-review.googlesource.com/1060741Reviewed-by:
-
Dave Tapuska authored
Improve the reliability of the windows virtual keyboard by using the InputPane class. This Windows RT API takes care of figuring out if the keyboard should be displayed or not (ie. if a hardware keyboard is connected, or a touchscreen connected etc.) BUG=817501 Change-Id: Ie310b7f485ff4096bb4f8943d43d84dced652ac6 Reviewed-on: https://chromium-review.googlesource.com/946152 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Victor Costan authored
cookieStore methods receive individual UMA counters. The getters for CookieChangeEvent and ExtendableCookieChangeEvent also receive UMA counters, mostly so that we can count apps that call subscribeToChanges() when a service worker installs, and then consume the 'cookiechange' events, without calling another cookieStore method ever again. TBR=kinuko Bug: 729800 Change-Id: I0c2aa37700cb6af7e1dc16b695e40dbffb33688f Reviewed-on: https://chromium-review.googlesource.com/1060624 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#559141}
-
Eric Robinson authored
Splitting this into its two constitutuent components (finding the highest priority active configuration, and computing the activation decision). This is being done to aid with crrev.com/c/1058087, which looks at all of the highest priority active configurations (for a redirect chain) and bases the activation decision off of the highest amongst those. Change-Id: Iee1c9d615e5008edd15a2ab363e602c6edd4d9e9 Reviewed-on: https://chromium-review.googlesource.com/1059893Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559140}
-
