- 20 Jan, 2020 40 commits
-
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 1042208 Change-Id: I62ff45d28f228e1db14f013d511e7a334062272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010762 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733327}
-
ewannpv authored
- Converts MobileDownloadFileUIShown MobileDownloadFileUIInstallGoogleDrive metrics to histogram - Makes IOSDownloadInstallDrivePromoShown histogram obsolete - Replaces UMA_HISTOGRAM_*() with base::UmaHistogram*() Bug: 1027570 Change-Id: I4fff49d5d610379014fb392557a9c35199ff97da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944351 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#733326}
-
Henrique Ferreiro authored
Move //third_party/blink/public/common/README.md into //third_party/blink/public/README.md, putting it together with the public/web and public/platform documentation. Bug: None Change-Id: I560e1c419939ae026f1704d0b1fa0597069cfb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007746Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#733325}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/52c3688f08ac..73387823a715 git log 52c3688f08ac..73387823a715 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 srte@webrtc.org Cleanup: Removes MessageQueue header and alias Created with: gclient setdep -r src/third_party/webrtc@73387823a715 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I62b60aa0e28365f56d3cf2647c6643be52054f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733324}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0aba975494ce..0c10c9522a3b git log 0aba975494ce..0c10c9522a3b --date=short --first-parent --format='%ad %ae %s' 2020-01-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src b6ac1e60cd3a..ca9b61a4455f (1 commits) Created with: gclient setdep -r src/third_party/angle@0c10c9522a3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Ic526e5e0007e58a2a208aab56925a2401356e37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010166Reviewed-by:
-
Vasilii Sukhanov authored
- PasswordManager.InaccessiblePasswords - PasswordManager.LoginDatabaseInit Bug: 1037193 Change-Id: I8a5312c8a59caf547568cfdd41bbcebb6a518dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007708Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3903ed28c1bc..d1608370012b Created with: gclient setdep -r src-internal@d1608370012b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I126f61704cdcc642e8aeef1534afbbbef2b22a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733321}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=ioanap@chromium.org Bug: 1042208 Change-Id: Ide0309af716e265046f44128eef5f886bd6ce6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007461 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#733320}
-
Colin Blundell authored
This CL prepares BlockedInterceptionBlockingPage as part of the preparation for componentizing //chrome's SSLErrorHandler. There are no //chrome-level dependencies after a predecessor CL, so the componentization is trivial. Bug: 1030692 Change-Id: Ica21033a720d26ec2ae47c6f3059a064d8bea414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000762 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#733319}
-
Colin Blundell authored
Currently SSLErrorHandler internally checks for whether the app is enterprise-managed as part of showing a man-in-the-middle interstitial. However, this check involves //chrome-level concepts and hence cannot be brought down into //components when SSLErrorHandler is componentized. This CL moves the check into ChromeSecurityBlockingPageFactory, which *is* the //chrome-level configuration for this interstitial. As part of this change, the infrastructure for overriding the value for tests is made significantly simpler. We also eliminate unittests of SSLErrorHandler that overrode the value and checked that the overridden value was honored; these tests are no longer relevant as those unittests don't use ChromeSecurityBlockingPageFactory, and the browsertests that remain provide a superset of that coverage in any case. Bug: 1030692 Change-Id: If1c8ed4813d80ba4bde5c83503ebcaa5d57858ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007211 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Md. Hasanur Rashid authored
Changes GetAccountsForDicePromos to return all accounts that have a token. Implement separate function GetSingleAccountForDicePromos to retrieve single account to use. Fixed: 1006167 Change-Id: I0b801216fe7bcd033bb8eabc6ab77ab5dc9ea9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007309 Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Reviewed-by:
-
Himanshu Jaju authored
Previously we were renaming the devices and then filtering them based on enabled features and updated time. The updated version first filters the devices and then renames them for a better UX. Bug: 1042243 Change-Id: I65d6de664cc0570ff6278335abbc22f5514f1624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007712 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#733316}
-
Roman Sorokin authored
Fixed: 1024239 Change-Id: I7685dcf0177213fa27262759b2c6af961d6d13d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002869Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733315}
-
Denis Kuznetsov authored
In multi-user session, only the primary user can use fingerprint authentication. Fix code that was using Active user instead. Bug: 1043283 Change-Id: I2d5b796838def792e1ee85d9533f225cb1e9fe54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007634Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#733314}
-
Simon Zünd authored
This is a reland of 61f91381 Tentative reland of the CL as-is because: - in the same time there was a general issue with crashing layout tests (especially on Mac) - the issue is not re-producible locally Original change's description: > Remove event races in two breakpoint decoration tests > > This CL changes two layout tests to follow the pattern of: > 1. Install an instrumentation promise > 2. Run and await an async action > 3. Await that the instrumentation is called > 4. Dump breakpoint information > > This CL is also in preparation for asyncification of source mapping, > hence making the "action" async. > > Drive-by: Re-baseline one of the layout tests that seems to be fixed > now. > > Bug: chromium:1032016 > Change-Id: Ibad4160fe9ab32aa3f818cdd4937112c3f4e6f08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000023 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731171} Bug: chromium:1032016 Change-Id: I34ec151749a56a1820330546cd0214b0c22c9eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007458 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#733313}
-
Ali Juma authored
This CL makes components/safe_browsing/core/db buildable on iOS, and makes unit tests in this directory along with unit tests in components/safe_browsing/core/common run on iOS as part of components_unittests. Change-Id: I1c973eb9b9427ec82d48945d5a26d9d10d178c2b Bug: 1028755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001580Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#733312}
-
Shobhit Goel authored
Move the surface management code used in ContentViewRenderView ctor and onNativeLibraryLoaded() to separate and protected functions, so that subclasses can have finer control over surface management. BUG: None Change-Id: I04e7c83215af9b091ef85ea234b5f87680761243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895270Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#733311}
-
Finnur Thorarinsson authored
Use PostDelayedTask instead of a Timer, and only update the duration while the fade out animation hasn't completed. Bug: 895776, 656015 Change-Id: Id8c668bf89552cbd6c00c6cde0f002b0009c00c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007632 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#733310}
-
Kazuki Takise authored
IT's pretty dangerous to access an iterator in a function where the item is erased from the container. BUG=b:147640138 TEST=Closed a few ARC apps and confirmed the apps didn't crash. Change-Id: I6d66c2f7b5d2c77393681208e378fd6abd817a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006899Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#733309}
-
Jan Krcal authored
Some of the the single client wallet tests used imprecise and possibly flaky waiting routines -- waiting for PDM to trigger OnPersonalDataChanged() once. This can signify that it has reloaded new data from the WebDB but this notification is also triggered in various other situation so it can mean nothing. This CL removes this approach from all remaining tests (except for one where there's no better solution and where it arguably cannot cause flakiness) The CL replaces the previous approach with a more robust waiting loop that waits for such notifications until PDM has provably loaded new data. This CL also cleans up various helper functions. The CL only re-enables one disabled test, other tests will be enabled by follow-up CLs provided we see no new flakes. Bug: 1001975 Change-Id: I555a72ec07f0884285a39f0bdb5d184f70147fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998520 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#733308}
-
Kamila authored
Fieldtrial config for enabling MacSystemMediaPermissionsInfoUI feature. Change-Id: I488af1efd8e977a8cea94cc095282b300d366052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005148Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Swapnil authored
If the force installed extension fails to install after 5 minutes, report the session type using UMA histogram. A new histogram is created: Extensions.ForceInstalledSessionType Existing user manager returns the session type for sessions like: guest, kiosks, regular etc. using the GetType() method. Additional check is required in case of new regular users to differentiate sign-ins into existing profiles and new ones. Unit tests are added in InstallationTracker for checking Managed Guest Session and Guest Session. Bug: 981891 Change-Id: I27e1a30e450de09ddf534d3d2383ec53e45caede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970992 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#733306}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20775957bc71..3903ed28c1bc Created with: gclient setdep -r src-internal@3903ed28c1bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If6f48af779d0455340a08e3a7cff3cecf578a99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010210Reviewed-by:
-
Eriko Kurimoto authored
This CL implements static import for module script. The feature is still behind the flag. This CL also adds SharedWorker with type 'module' Web Platform Tests. Dynamic import is not yet supported, so WPTs which include dyamic import is expected to fail. Bug: 824646 Change-Id: I3b4a239f392736d226a736c011e3f5eb0a3e0d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006995 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#733304}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/89e4a3082402..5029dac177fc git log 89e4a3082402..5029dac177fc --date=short --first-parent --format='%ad %ae %s' 2020-01-20 sigurds@chromium.org Provide frameId getter on Script 2020-01-20 sigurds@chromium.org [karma-tests] Add more tests for TextRange Created with: gclient setdep -r src/third_party/devtools-frontend/src@5029dac177fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032561,chromium:1043120 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I475e2c1c94ee301cf25687c250dd11334ec2452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010209Reviewed-by:
-
Gauthier Ambard authored
This CL reloads the SearchEngine TableView if it has changed while the user was editing it. This can happen because when the user select a Search Engine as default it is updated in the TemplateURLService. But as the table view is being edited, for now this change is ignored. With this CL, when the TemplateURLService is updated while the user is editing the TableView, a comparison with the current TemplateURLService state and the state of the TableView is done. If it is different, the TableView is reloaded. It also re-enable TestChangeProvider which was disabled because of that. A visible UI change introduced by this CL is that when a custom search engine is selected, it should be displayed in the first section. Because we weren't updating the TableView when selecting a search engine, previously this was only visible if the user left the search engine screen then re-enter it. Now this is happening instantaneously. Bug: 1036445 Change-Id: I2a28c030a443663d9ea4dbd5c5dcfe0c5c805dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002585 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733302}
-
Sean Harrison authored
Bug: 1007223 Change-Id: Ib232ced2a0d7f987e108afa24a8f31b9631a0182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005208Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#733301}
-
Ulan Degenbaev authored
This uses a new v8::Isolate::MeasureMemory API to compute the JS memory footprint of each v8::Context that has the same security origin and the same JS agent as the calling context does. The V8 API takes a delegate with two methods that are implemented here: 1) ShouldMeasure(context) for selecting the contexts to measure. It fetches the security origin and the JS agent of a context by going through Context => ExecutionContext. 2) MeasurementComplete(context_sizes, unattributed_size) is called by V8 when the measurement is done. The function constructs an object representing the result and resolves the promise with it. # Disable audit_non_blink_usage std::vector check per reviewer's comment NOPRESUBMIT=True Bug: 973627 Change-Id: Ibd0fb3463978184f1d467be306063d1f40105fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986795 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#733300}
-
Gauthier Ambard authored
This CL adds the HTML to display an error page. It also adds the class to be able to load and display it. Based on crrev.com/c/1959041. Bug: 991608 Change-Id: I06aad97bc2d1cde54162d16d8518780de998ce92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984300 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#733299}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c6d670ac06ee..5546abd6b001 git log c6d670ac06ee..5546abd6b001 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 phoglund@google.com Fix bugs where I assume some optional fields were required. Created with: gclient setdep -r src/third_party/catapult@5546abd6b001 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: sadrul@google.com Change-Id: Ic2ee58303b4b87ea370a4772d1790cad1516abc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010570Reviewed-by:
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: I281da0afc27ea6e9ac676986655d9807dec3395e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009591Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#733297}
-
Yoshifumi Inoue authored
This patch intorudces |NGInlineItemsBuilder::DidFinishCollectInlines()| to populate collected inline data to |NGInlineNodeData| at one place to ensure valid |NGInlineNodeData|, e.g. valid value of |is_bidi_enabled_|. Background: Before this patch, we processed RTL text as LTR text when text is modified with |LayoutText::SetTextWithOffset()| by Text.{append,replace}Data() and chunked append at loading. Bug: 1038254 Change-Id: I645f78f853e89704120d50b9db3234806f65c1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010590 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#733296}
-
Friedrich Horschig authored
This CL extends flags for a few smaller autofill experiments that aren't launched yet but still on our list. It extends the keyboard accessory flag since more experimentation time will be needed. Lastly, removing izuzic@ as flag owner from editing. Bug: None. Change-Id: I7c6141ecac2b21c1fbc0213612a6f09520ab3411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007284Reviewed-by:
-
Clemens Backes authored
Lazy compilation might become one candidate configuration for Liftoff on mobile. Hence we add the flag now so it will be available in the next beta release for finching. R=rmcilroy@chromium.org, jochen@chromium.org Bug: 1040030, 1040061 Change-Id: Icb86a4d3c075afc111978f6797634aabd5b98020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002568Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL adds PRESUMBIT check for blink's mojom namespaces rule. When mojom interfaces of Blink are using in Blink, we should use blink::mojom::blink::T or mojom::blink::T in Blink. Bug: 1043557 Change-Id: I7009c6fbe04a7b937889d97ca69ec92d505b6941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010448Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to remove unused - DEFINE_SVG_PROPERTY_TYPE_CASTS from t_p/b/renderer/core/svg - DEFINE_AX_OBJECT_TYPE_CASTS from t_p/b/renderer/modules/accessibility Bug: 891908 Change-Id: I4a6164f88da586f19f748696b294276384cb4da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010450Reviewed-by:
-
Roman Sorokin authored
Bug: 1012502 Change-Id: If4df2204899acb6c6757fcb6ca8272ded58b9284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002917 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#733291}
-
Roman Sorokin authored
Follow-up for CL:1972837 Bug: 1021297 Change-Id: Ieb8d7f33fb525297436a6c0c32cd96c4c47ec2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002613Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f89c1760. With Chromium commits locally applied on WPT: 62f8d5f0 "Enable Scroll To Text by default" 363313c0 "Sort the registrations returned by getRegistrations() by registration ID." 8a985066 "[Trusted Types] Implement require-trusted-types-for" 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie7985258879dfbbe91a5dd2fdaaacb4cf3073fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008154Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733289}
-
Hirokazu Honda authored
This is a reland of 93395999 CHROMEOS_LKGM becomes new enough to pass the tests running on waterfall. Original change's description: > media/gpu/vaapiVEA: Call NotifyEncoderInfoChange() at the end of initialization > > This notifies VEA client VideoEncoderInfo of > VaapiVideoEncodeAccelerator (VaapiVEA) at the end of the > initialization. > Since VaapiVEA doesn't update fps allocation and qp values, > NotifyEncoderInfoChange() is not called except the end of the > initialization. > > Bug: 1031965 > Test: webrtc.RTCPeerConnection* > Test: webrtc.DecodePerf.* > Change-Id: If2a8b7ff16644d55b20e273502a5f20078c96121 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978458 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731147} TBR=mcasas@chromium.org Bug: 1031965 Change-Id: I2b5f5afc6f1cc87299d1daf969b8b8cce9637062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010241Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#733288}
-
