GitLab

Bug: 1112970
Change-Id: If19c5dbb08ad1648b23b260481bcf31c12287264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342067Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796012}

https://webrtc.googlesource.com/src.git/+log/f7721fb24619..fe4688edfa48

2020-08-07 jonaso@webrtc.org Fix visibility of network_monitor_enums
2020-08-07 nisse@webrtc.org Remove rtp test dependency on VideoCodec class
2020-08-07 terelius@webrtc.org Add missing tests for DTLS state logging in RTC event log.
2020-08-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9c0fc3b7..2f197110 (795492:795842)
2020-08-07 nisse@webrtc.org Delete left-over TODO comment
2020-08-07 elrello@microsoft.com Add new fmtp parameter for H.264

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I8c48ec99e7eea42df5eafda11f136ec7202a110e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343367Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796011}

GetSubstringBounds rounds up on both sides (so it guarantees that the
rectangle returned will be >= than the substring). this causes the
ElideAnimation gradient mask to sometimes cover the unelided section of
the URL by one pixel. This CL adds an extra pixel of margin to ensure
this never happens. Tests are also modified to reflect the new
expectations.

Bug: 1112848
Change-Id: Ic120f74f276f1baffdca9509784b2700b7649175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341397Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796010}

Mixin extracted from the Eula browsertests.
Mixin to be reused for the OobeEndToEnd tests.
Also removed DISABLED on MSAN code - covered by oobe msan filters.

Bug: 1032194, 1041188
Change-Id: I96e192dd86f59e4634779d824898c3097cf18d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343074Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796009}

Change the label of topic source group in the Settings page to "Photo
Frame".

Bug: none
Test: manual
Change-Id: I3df69244186fde84874bfa3fd828b8a577d24712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342304
Auto-Submit: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796008}

Broken by https://crrev.com/c/2327633.

Bug: 1015315
Change-Id: I4032732fc8aaa9fab359d7bf99cb4b0eeb38648a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342132Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Arthur Eubanks <aeubanks@google.com>
Cr-Commit-Position: refs/heads/master@{#796007}

Adds a handler to the DmServerUploadService for handling
APP_INSTALL_EVENT messages.

Bug: chromium:1078512
Change-Id: If95ec4e80d9002c13ff9a0a62994cc495fcce0a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284087Reviewed-by: Leonid Baraz <lbaraz@chromium.org>
Commit-Queue: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#796006}

Bug: 1086114, 1092444
Change-Id: Ic1cec5c5ffcf944a7f1c3235429f0625ef704272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341648
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796005}

Bug: 1113823
Change-Id: I052a334fd30ed4db4c7ed6891f70fcecad1273b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340506
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796004}

This exception may happen when trying to notify WebView we are running
in-process, but it is fine to ignore.

Change-Id: Id9b17ab8cbad42a28559dbb505ef403e8d1105e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343227
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796003}

Bug: 163028167
Test: Locally on android Q device
Change-Id: I463f133981530e5ca936d62d6e1f10cb701e2e2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342579Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Rohan Parab <prohan@google.com>
Cr-Commit-Position: refs/heads/master@{#796002}

- The host override no longer affects the actions endpoint.
- A new actions endpoint override was added.
- Status for the last action upload is now saved and presented
  on the internals page.

Bug: b/163071541
Change-Id: I372dd1cc091937381aeb25f6a1f9f74f710d58b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343304Reviewed-by: Ian Wells <iwells@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796001}

Change-Id: Ia526d76219659edce6478b16b69410f674073041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341396
Auto-Submit: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796000}

The spoken message for snackbars now sounds like "Snackbar message. <pause> Action. <pause> Options near the bottom of the screen."

Bug: 1103062
Change-Id: If3747989e82d34d19d1505fbf86aa1e2f967d64f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342054Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795999}

This reverts commit 879b5cdf.

Reason for revert: investigating a browser hang during video playback.
Reverting this CL seems to be fixing the hang. Will reland this change
with a fix to cache surfaces.

Original change's description:
> ui/gl: Ensure surface reparenting during surface destruction.
>
> When destroying a surface, it is important to also detach it from its
> parent to ensure the surface is deleted.
>
> Bug: 1076258
> TBR=sunnyps@chromium.org
>
> Change-Id: I27987a6340e92a1f6d717ada5d74d40e5f6e2e38
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172124
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Auto-Submit: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#763670}

TBR=sunnyps@chromium.org,khushalsagar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1076258, 1105508
Change-Id: I5d632aecd01ccc8c4aa873cd297dd511bec7036f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341235Reviewed-by: vikas soni <vikassoni@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795998}

Bug: 1106032
Change-Id: Ief0ecdbe51aa75a174c71f748958b2ac62e717a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317570
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795997}

* Include the previously excluded "Check now" button in the Settings
  search. This lists safety check as a result when searching for "Check
  now" if the button is visible at the moment the search is done.

Bug: 1015841,1114020
Change-Id: I09ba5e15b27371cf6a4aff2105a7bc8f4a33d706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339996Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795996}

Bug: 1106948
Change-Id: I87b1f29822abe681ab75b703d36c3c7da70c25f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343346
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795995}

Promotes ScriptId to a template parameter, so that the script injector
can be used for multiple purposes on a given platform.
Specifically, it will allow the use of uint64 script IDs on
FrameImpl, and base::StringPiece in bindings tests.

Migrate OnLoadScriptInjectorHost implementation from .cc to .h.


Bug: 1104369
Change-Id: Idfacd460d8d12038cfc2c00896e538ee87c55a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341837
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795994}

histogram ContentSuggestions.Feed.VisitDuration

Also fix 'open in new tab' so that it opens in the background
instead of the foreground.


Bug: 1044139, 1113773
Change-Id: Ib746afa1b94f47aa04c996e74a214cafa0d8abc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336816
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795993}

Reverse the order of logs appearing on the logging tab so newest logs
appear on top, as well as change the color of verbose logging to gray,
as seen here: https://screenshot.googleplex.com/rAtwCW4rJbN.

Bug: 1093634
Change-Id: I88b3ed8abefec7d5512a261db41f6d464ef23947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336311Reviewed-by: Josh Nohle <nohle@chromium.org>
Commit-Queue: Juliet Levesque <julietlevesque@google.com>
Cr-Commit-Position: refs/heads/master@{#795992}

Corresponds to cl/322580232

Bug: 1106431
Change-Id: I68c3dc8318c051fa84a5285294f796ac92171303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317571Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795991}

The code used to read the version string as provided by the uname
command but the native host reads the string from the /etc/os-release
file. This CL unifies the API implementation with the native host but
preserves the uname approach as a fallback in case the file is not
present or does not follow the expected format.

BUG=1114196
TEST=unit_tests:EnterpriseReportingPrivateGetDeviceInfoTest.GetDeviceInfo

Change-Id: Ie07314ef4cdbdbbbc8b1abf0784b8e54d454217a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339631Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795990}

Change:
* PaymentRequestImpl#getClient adds null check for
ComponentPaymentRequest.

Bug: 1114133

Change-Id: Id994b6a4d20d24f54a088a6b08b46cca330f538d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341219Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795989}

Update latest file on gcs.

Bug: 1109287
Change-Id: Ibcd6540a5ebfd838e2f31bf4e71fb56b516d083e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342636Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795988}

ReadyToActivateToActivationDuration2 metrics are covered by the EndCommitToActivation of the CompositorLatency metrics, so the methods used for reporting them is removed from compositor timing history.

Bug: 1037244,1089454
Change-Id: I2e197bf34d777b051f60fa16059b13d642135762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341664Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795987}

Adds new item in the Discover feed header top-level menu for 'Manage
Activity', which leads to a web page. Also slightly refactors how menu
items that lead to web pages are handled. Only shows this item and
'Manage Interests' if the user is authenticated.

Bug: 1085419
Change-Id: I66be67659ccbc04121f0eb02657a7e20cfe66e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341805
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795986}

With Xcode 12.3 beta and iOS14, there was an issue with Open URLs
in Chrome In Incognito Siri shortcut during cold start. For example,
open a few NTP tabs in Incognito and then kill the application.
Then when triggering the shortcut, the URLs are not loaded.
It seems like the order of the restoration functions during cold start
changed, so that what worked before no longer works. To solve this
issue, a function similar to how Open URL in Chrome is handled in
ContinueUserActivity is written and is modified to handle multiple
URLs. This way, the tabs are opened directly after ContinueUserActivity
is invoked and no longer depend on the restoration functions during
cold start.

Bug:1113529

Change-Id: Ie6a8c91cad307bb5e510d300695a4490116a7491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336185Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795985}

The secure connect API for Mac OS is not trying to clear a potentially
existing but corrupted secret before recreating it.

BUG=none

Change-Id: I80ecb09aba0b633df093a305f76b457740db77d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339532Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795984}

A new method was added but never called in ASAN builds, causing an
unused function warning.

BUG=None

Change-Id: Ibca08fb8ab291790fcb58f617844bc6a0730c8fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341807Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795983}

XCUIElement queries used in ARQuickLook are broken on Xcode 12 beta 4
when running on the iOS 12 simulator.  Disable until Xcode is fixed.

Bug: 1114202
Change-Id: Ib16458ee93e6821b5520cbd791e3ba8e6beccfe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341220
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795982}

This CL adds a mojo::Remote<mojom::Logger> in CastAppDiscoveryService to
log unavailable (app_id, sink_id) pairs and socket not found errors.

Bug: 687380, b/154273698
Change-Id: Ib50c74cd9a0e66c9c05b3f36fdf653e2565d8048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332329Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/heads/master@{#795981}

M84 is crashing because OmahaService::Stop() is somehow called before
the OmahaService singleton is created. This causes Stop() to try and
create a new service object during shutdown, which crashes.

This CL sidesteps the crash by making it safe to create a new
OmahaService object, even at shutdown. The unsafe portions of the
constructor were already in StartInternal(), which now needs to be
explicitly invoked by OmahaService::Start().

BUG=1105799

Change-Id: Idd9531ab0ac79e4520deaa2145e9d3efc20bb01d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339719Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795980}

Past metrics show that the main cause of failure for
base::CreateDirectory in IndexedDB is the device being out of space.
This CL plumbs the error code through so we can properly report this
as a QuotaExceeded exception.

An alternative would be to retry the operation, but if the disk is
truly full then its likely any further operations will run into disk
exhaustion anyway.  For now lets just report the problem as accurately
as we can.

Bug: 1113829
Change-Id: Idc66d2f43b474e1a97229e0057031ba12c96d677
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343305Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795979}

The histogram is Clipboard.Read/Write, not
Clipboard.Format.Read/Write.

Bug: 1113963
Change-Id: Ica50afa9a751e32e5510f02899d79bb61f30c182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340881
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795978}

Allow browse as guest button to be shown in user creation screen in oobe.
Hide browse as guest button in user creation screen during add person flow.

Bug: 1101318
Change-Id: I235cbf486f11f3b0275adec3f44cdb9c31adb945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341640
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795977}

This is a new file on macOS 11 Big Sur.

Bug: 1113952
Change-Id: I8280ef793f6da3fe6e85ba9d23a7d5e8188f2371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342573Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795976}

Hoping that this will aid in debugging out of memory failures.

Bug: 1113246
Change-Id: Ibf2baf859598a2af2d08d911c82d3c65f2249d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328190
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#795975}

The dependent CL adds an entrypoint for Tab Search in the tab strip.
As a result the current toolbar button entrypoint is no longer
necessary.

Bug: 1099917
Change-Id: I68a0fdbb4bf1bbc08e65f048c132593fa5229d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341942Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795974}

This CL prevents WebRTC clients from changing the VP9 lossless-color
property via a VideoControl message. This is because WebRTC handles
that setting via the SDP codec parameter "profile-id=1", which means
an SDP offer/answer exchange is needed to properly control this
setting. Non-WebRTC clients are not affected and they can still toggle
lossless-color via a VideoControl message.

This CL also adds logging to the VP9 encoder so we can verify what
settings are being applied at the codec level.

This also fixes a bug where the SDP parameter for lossless-color was
not being respected.

Bug: 1113499
Change-Id: I15ca83b0fcc157a3b63d3a3ca3509039ed47b24f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342126
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795973}