GitLab

To support Clients.matchAll(options)

* Add ServiceWorkerClientQueryOptions param to GetClients IPC msg (renderer -> browser)
* Add client_type field to ServiceWorkerClientInfo for DidGetClients IPC msg (browser -> renderer)

Spec links:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworker-client-query-options-dictionary
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-getall

1/2: https://codereview.chromium.org/958933004/ (blink)
2/2: THIS PATCH

BUG=455241,460415
TEST=to be added after we add actual impl

Review URL: https://codereview.chromium.org/970693003

Cr-Commit-Position: refs/heads/master@{#319588}

BUG=133097

Review URL: https://codereview.chromium.org/982643003

Cr-Commit-Position: refs/heads/master@{#319587}

WebRTC 8643:8646
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/d6bd5e2..a2bd4b8

This roll includes a fix for the build configuration issue we ran into on Mac debug.

TBR=

Review URL: https://codereview.chromium.org/990703002

Cr-Commit-Position: refs/heads/master@{#319586}

Cr-Commit-Position: refs/heads/master@{#319585}

No behavior change.

BUG=none

Review URL: https://codereview.chromium.org/985403002

Cr-Commit-Position: refs/heads/master@{#319584}

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/985253002

Cr-Commit-Position: refs/heads/master@{#319583}

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/985243002

Cr-Commit-Position: refs/heads/master@{#319582}

CL generated with data from dead-code analysis using
.../scythe:remove_dead_code

Dead code removal.

Merge internal change: 87991626
https://codereview.chromium.org/987693006/

Add 'explicit' to the PacketWriterFactoryAdapter constructor, as
complained about by Lint.

Merge internal change: 87956343
https://codereview.chromium.org/988963002/

Adds an assert to confirm that QUIC's session flow control window is
always larger than the stream flow control window, and fixes some tests.

Merge internal change: 87837841
https://codereview.chromium.org/987943003/

Implement the "sanity checks" described in b/9509040:  Incoming packets
whose connection ID is not associated with a session and is not recorded
as being in time-wait state are tested for reasonableness before a
session is created for them.  This won't protect much against deliberate
DoS but will screen out a reasonable fraction of truly junk packets.

Add sanity tests so we do not create connections for initial packets
with truncated connection IDs.

Merge internal change: 87831756
https://codereview.chromium.org/981193003/

Change the null value for packet sequence numbers to
kInvalidPacketSequenceNumber (== 0), which cannot appear as a packet
sequence number.

Update QuicFecGroupTest::UpdateAndRevive and
QuicFecGroupTest::UpdateAndReviveOutOfOrder to generate packet numbers
starting with 1 rather than 0.

Change the null value for packet sequence numbers to
kNullPacketSequenceNumber (== 0).

Merge internal change: 87819844
https://codereview.chromium.org/989743003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/990533002

Cr-Commit-Position: refs/heads/master@{#319581}

This patch adds a whole bunch of small targets that
had either already been done but weren't mentioned
in the 'gn_all' group, or needed to be done.

In theory this should produce no change on any platform
other than Linux, except for one small windows target.

R=brettw@chromium.org
TBR=dtu@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/975123003

Cr-Commit-Position: refs/heads/master@{#319580}

Aura specific code in ExtensionPopup won't compile with MacViews.
Refactor them into an Aura specific subclass.

BUG=425229

Review URL: https://codereview.chromium.org/980663003

Cr-Commit-Position: refs/heads/master@{#319579}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5bd3ef0..27dc83a

TBR=

Review URL: https://codereview.chromium.org/989953002

Cr-Commit-Position: refs/heads/master@{#319578}

BUG=449754

Review URL: https://codereview.chromium.org/988633004

Cr-Commit-Position: refs/heads/master@{#319577}

TBR=fukino@chromium.org
BUG=463853

Review URL: https://codereview.chromium.org/984963003

Cr-Commit-Position: refs/heads/master@{#319576}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9ce30e1..82966b5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/989033002

Cr-Commit-Position: refs/heads/master@{#319575}

* Added 'cause' parameter to mute method to indicate if muted state was changed by a user or by an extension.
* Added support for audible and muted event listeners.

A future patch that relies on these changes will update an API to make the audible and muted states available to extensions.

BUG=438903

Review URL: https://codereview.chromium.org/757033005

Cr-Commit-Position: refs/heads/master@{#319574}

This regex can be simplified down to a single-one.

Similar to the way we already do elsewhere, like in //cc
(https://chromium.googlesource.com/chromium/src/+/master/cc/PRESUBMIT.py) and
ui/app_list
(https://chromium.googlesource.com/chromium/src/+/master/ui/app_list/PRESUBMIT.py)

BUG=None
TEST=git cl presubmit -uv
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/984073005

Cr-Commit-Position: refs/heads/master@{#319573}

GetClientDocuments is posting on task to the UI thread for every
clients it is currently controlling. This is coalescing the requests
into one task in order to reduce resource usage.

This also gives a better snapshot of the clients state given that
all the information are gathered during the same event loop iteration.

BUG=None

Review URL: https://codereview.chromium.org/985113002

Cr-Commit-Position: refs/heads/master@{#319572}

BUG=none

Review URL: https://codereview.chromium.org/984173003

Cr-Commit-Position: refs/heads/master@{#319571}

Revert of base: Remove operator& from ScopedAuthorizationRef. (patchset #1 id:1 of https://codereview.chromium.org/986563003/)

Reason for revert:
Breaks the official Mac bot:

../../remoting/host/installer/mac/uninstaller/remoting_uninstaller.mm:155:21:error: no matching function for call to 'AuthorizationCreate'
  OSStatus status = AuthorizationCreate(nullptr, kAuthorizationEmptyEnvironment,
                    ^~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Security.framework/Headers/Authorization.h:253:10: note: candidate function not viable: no known conversion from 'base::mac::ScopedAuthorizationRef *' to 'AuthorizationRef *' (aka 'const AuthorizationOpaqueRef **') for 4th argument
OSStatus AuthorizationCreate(const AuthorizationRights *rights,

Original issue's description:
> base: Remove operator& from ScopedAuthorizationRef.
>
> The operator& is dangerous and makes it unclear what you are doing.
> Replace it with a get_pointer() method.
>
> R=Nico
> BUG=464816
>
> Committed: https://crrev.com/845755856c54aabac7022ee373618468b92f2e61
> Cr-Commit-Position: refs/heads/master@{#319565}

TBR=thakis@chromium.org,danakj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464816

Review URL: https://codereview.chromium.org/988113002

Cr-Commit-Position: refs/heads/master@{#319570}

WebRTC 8622:8643
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/235b9ab..d6bd5e2

Libjingle 8616:8639
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3f3cd14..c9f4c13

TBR=

Review URL: https://codereview.chromium.org/980393005

Cr-Commit-Position: refs/heads/master@{#319569}

This macro should be private to make the constructors hidden, making
them fail at compile time if called, instead of at link time.

R=Nico
BUG=464816,447156

Review URL: https://codereview.chromium.org/986623004

Cr-Commit-Position: refs/heads/master@{#319568}

Fix a race where RenderFrameProxy::OnCompositorFrameSwapped message can arrive after the RemoteFrame was swapped with a LocalFrame.

Enabled NavigateRemoteFrame tests, merged NavigateRemoteToDataURL and NavigateRemoteToBlankURL into NavigateRemoteFrameToBlankAndDataURLs.

BUG=446575

Review URL: https://codereview.chromium.org/881413005

Cr-Commit-Position: refs/heads/master@{#319567}

View unittest builds on assumption of exact invalidation rect being
used. Impl side would change that assumption. Adjust unittests to test
for both impl-side-painting and non-impl-side-painting.

R=danakj
BUG=314185

Review URL: https://codereview.chromium.org/976923002

Cr-Commit-Position: refs/heads/master@{#319566}

The operator& is dangerous and makes it unclear what you are doing.
Replace it with a get_pointer() method.

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/986563003

Cr-Commit-Position: refs/heads/master@{#319565}

As of webrtc roll https://chromium.googlesource.com/chromium/src/+/724ab4480d4af0c4a64752078a7cd5046782789c
a longer aggregation window is used and we can now match it to simplify the query.

BUG=450193
TESTED=locally on Mac

Review URL: https://codereview.chromium.org/982333002

Cr-Commit-Position: refs/heads/master@{#319564}

[Reland of https://codereview.chromium.org/945743002]

PolicyCompiler runs in a normal process context, so it doesn't require
the extra low-levelness of SANDBOX_DIE.

BUG=449357

Review URL: https://codereview.chromium.org/985933002

Cr-Commit-Position: refs/heads/master@{#319563}

Dialog contents now match the Views implementation.
Dialog UI elements are not hooked up to CardUnmaskPromptController yet.
Screenshots and video attached to bug: https://code.google.com/p/chromium/issues/detail?id=448572#c3

BUG=448572

Review URL: https://codereview.chromium.org/929293005

Cr-Commit-Position: refs/heads/master@{#319562}

Cr-Commit-Position: refs/heads/master@{#319561}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d6185423..51bf7a79

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/985183002

Cr-Commit-Position: refs/heads/master@{#319560}

This reverts commit eefeef59.

Revert reason: failure on WinXP builder

BUG=459812
TBR=dschuyler@chromium.org, msw@chromium.org

Review URL: https://codereview.chromium.org/989853002

Cr-Commit-Position: refs/heads/master@{#319559}

Cr-Commit-Position: refs/heads/master@{#319558}

We normally send all providers a Stop() call after a certain amount of time
(1.5 seconds I think) under the rationale that revising the suggestions
list that late is disruptive to the user's experience.

This doesn't make sense for explicitly-invoke omnibox extensions, which
could be doing long-running processes under the hood.

This change revises the AutocompleteProvider API to allow providers to
differentiate these two types of Stop() calls.  It makes KeywordProvider
ignore the Stop() calls due to this inactivity timer.

BUG=462501

Review URL: https://codereview.chromium.org/985503002

Cr-Commit-Position: refs/heads/master@{#319557}

Make it using base::android::OnJNIOnLoadRegister().

BUG=447393

Review URL: https://codereview.chromium.org/981323002

Cr-Commit-Position: refs/heads/master@{#319556}

OpenItem() now takes an OpenItemType parameter that should specify
expected type of the object to be opened. It verifies the type of the
object before invoking platform specific logic for opening the item.

Code that assumed that the target of OpenItem() was always a folder
should now no longer unintentionally open or execute the file at the
target location when this assumption was found to not be correct.

In addition to the checks performed by OpenItem, the platform specific
logic used to open folders fail if the target type is not a directory.

BUG=387037

Review URL: https://codereview.chromium.org/352393002

Cr-Commit-Position: refs/heads/master@{#319555}

This upstreams the bulk of ios/web/public. Mostly this is new files,
but also some diffs to existing files (where those don't introduce build
dependencies that aren't available yet).

All files in this CL are added to the build.

BUG=464810

Review URL: https://codereview.chromium.org/986743003

Cr-Commit-Position: refs/heads/master@{#319554}

Revert of Revert of [MemSherrif] Uninitialized Read (patchset #2 id:40001 of https://codereview.chromium.org/986763002/)

Reason for revert:
DrMemory bots still hit the bug: http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%286%29/builds/3752

Original issue's description:
> Revert of [MemSherrif] Uninitialized Read (patchset #1 id:1 of https://codereview.chromium.org/969073002/)
>
> Reason for revert:
> Uninitialized read should now be fixed (and there is a test). Should this revert break the DrMemory bots, this revert should be reverted.
>
> Original issue's description:
> > [MemSherrif] Uninitialized Read
> >
> > BUG=463204
> > TBR=reed@chromium.org, thestig@chromium.org
> >
> > Committed: https://crrev.com/94d1b7498d7b5c4fc25e3337be117f8c9ef1dbf2
> > Cr-Commit-Position: refs/heads/master@{#318760}
>
> TBR=thestig@chromium.org,groby@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=463204
>
> Committed: https://crrev.com/82417f64ce69c98a93f82f59e6adda1c9c2e510c
> Cr-Commit-Position: refs/heads/master@{#319503}

TBR=groby@chromium.org,bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463204

Review URL: https://codereview.chromium.org/984073007

Cr-Commit-Position: refs/heads/master@{#319553}

The SessionConnector is intended be a core component that is shared between
app remoting and desktop remoting. It2Me is desktop remoting specific and
should not be there.

This CL pulls out all the It2Me connection logic into It2MeConnectFlow.

BUG=464614

Review URL: https://codereview.chromium.org/984793003

Cr-Commit-Position: refs/heads/master@{#319552}

* Generalizes WebappMetrics as LaunchMetrics to allow recording
  information about Home screen bookmark launches, which are
  handled as Tabs.

* Removes the previous count metric without marking it as
  obsolete because the downstream calling code never landed.

* Splits the previous RAPPOR metric into two to differentiate
  between shortcut and web app launches.  Again, calling code
  never landed.

BUG=462745

Review URL: https://codereview.chromium.org/989523003

Cr-Commit-Position: refs/heads/master@{#319551}

Current string: Signed in as [email]. Manage your synced data and devices on Google Dashboard.
New strings: Signed in as [email]. Manage your synced data and devices on chrome.com/sync

BUG=402615

Manual test:
launch chrome by chrome --force-fieldtrials="ChromeDashboard/Enabled/"
log in chrome, and then go to settings, on the top of settings, there should be the new string, click the "chrome.com/sync", it should bring you to new URL(chrome.com/sync).

Review URL: https://codereview.chromium.org/959343003

Cr-Commit-Position: refs/heads/master@{#319550}

All tab capture platforms have supported capture via event-driven
compositor updates for quite a while now.  The "notification of backing
store change" code path never triggers, except in certain edge cases
where extra frame captures will be started.  The extra frame captures
are bad for the user experience, since the extra frames reduce video
playback smoothness.  The extra frame captures were also throwing-off
the "out-of-order frame delivery" logic, causing wanted frames to be
dropped.

BUG=464475

Review URL: https://codereview.chromium.org/989683004

Cr-Commit-Position: refs/heads/master@{#319549}