GitLab

Remove some code (that had no test coverage), that I initially thought
we'd need, but it's actually incompatible with how an upcoming CL will
deal with float fragmentation.

Bug: 1043787
Change-Id: I9a5cb7c2334c8c17360b6c20e2fb4de078072b79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260612Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781497}

(Test-only change.)

There are a few cases where a test wants to parse the response to an
assertion, and I'll shortly be adding some more. Pull out some common
code for this into a function.

Change-Id: I9a2b53c58d5fe58565e3bc111b67ece28994c3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255211
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#781496}

Bug: 1076543
Change-Id: I1286243c1e85a9c7409c5f1f9e326e9ecc337422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250161
Commit-Queue: Mila Green <milagreen@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781495}

Used to be a single zip file of all languages which is more inconvenient
format for the further steps of the pipeline that copy this files over
to the public documentation page.

BUG=1082694

Change-Id: I89faec3b5262e443cf768341172b1091bc15596f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256206
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781494}

Roll Chrome Win32 PGO profile from chrome-win32-master-1592917001-0fc7f1d9ca8aa2b3be882f696f21c14836e980c4.profdata to chrome-win32-master-1592920709-d1856a35d8275495ca631105d3b73ea9c8fbb208.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I1c0c0e2e81a8b4d7b93c9cb6b9b8b086ef65ce56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260921Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781493}

Add guidance and documentation regarding upcoming certificate lifetime
changes.

Bug: 1097982
Change-Id: If6073b63774b80e8a01a6940d7c262b603c1ff70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258690Reviewed-by: Andrew Whalley <awhalley@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781492}

It was determined that https://crbug.com/1091423 is caused by multiple
getAuthToken() calls running simultaneously. All getAuthToken() requests
go through IdentityMintRequestQueue that actually manages multiple
queues, one per (ExtensionTokenKey, IdentityMintRequestQueue::MintType)
tuple.

When the remote consent is approved, the request needs to go through
a queue one more time because its ExtensionTokenKey might have changed.
The request, however, needs to update the global cache before any
other request might be run to avoid showing the consent UI again.

There is also the case when a request will be canceled after the
remote consent is approved if the queue already has a
MINT_TYPE_INTERACTIVE request scheduled. This CL makes sure that this
condition is no longer triggered.

Bug: 1091423
Change-Id: I639b7a0bc8274179163c4d19ffc234fafbece791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260658
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781491}

Previously DisableCompositingQueryAsserts triggered DCHECK failure in
CompositeAfterPaint.

Change-Id: I9f341a7fb176d357aa325f2cde9c497cf4536fbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261176
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781490}

Flaky test (conformance/glsl/misc/shader-with-non-reserved-words.html)
is set to RetryOnFailure on Nexus 5.

TBR=kbr@chromium.org

Bug: chromium:1098311
Change-Id: I81ea05c38836d7a248fc36615acdac9a2f40f590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261355Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781489}

1. a fieldtrial param for controlling the time day of the second promo
2. update fieldtrial_testing_config.json

Bug: 1090103
Change-Id: Id9eab63dea1f7534f1078d0ca7c573acbb1b280b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258893Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#781488}

This will let us evaluate the frequency of an issue that leads to the
Trust Tokens database failing to open in an indeterminate number of
cases.

R=csharrison

Bug: 1098019
Change-Id: I7fa18bf3a4477ed02699a9872c13aafb6dce1ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261155
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781487}

This also removes the Connector implementation's dependency on the
legacy features.

Bug: 1069069
Change-Id: Ie6c9365789a0a593f0ff51c6fb8b5edfb52d121b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254448
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781486}

Roll Chrome Mac PGO profile from chrome-mac-master-1592913526-8a6b109b6b3679eaf9b2e9a04d6e6b258b48adc2.profdata to chrome-mac-master-1592935173-d1033b26c7b78c08aca84bf70b5b5eb9d34e3499.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I4a585498ff59d807f2ac9e0d4563337c5a46c386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260928Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781485}

TBR=ryansturm@chromium.org

Bug: 1087736, 1087876
Change-Id: I42837be8d16e6534b97bb3e8fd6154d39411ab26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260397Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781484}

Shelf may have delayed bounds setting via animation using BoundsAnimator.
An ink drop created during this animation can be shifted. This patch
adds an layer transform observer for shelf buttons which uses a new
API in ink drop to set the ink drop root layer transform.

This sounds like ink drop should handle transforming hosts or maybe
views code itself. But this is intended to merge, so this solution is
ideal for now.

Test: added test, manual
Bug: 1097044
Change-Id: I783d86161c8415e5fe419c6e9505bc7b9be77f93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258687
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781483}

Currently, MediaRemotingIntegrationTest.SeekWhilePlaying is flaky, and
has been disabled. After looking at the logs, the primary reason is that
media::PipelineIntegrationTestBase::OnEnded is called multiple times,
resulting in a DCHECK and test failure. The stack for the second
OnEnded call is:

media::PipelineImpl::RendererWrapper::CheckPlaybackEnded
media::AudioRendererImpl::Render

Logs:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890990219267312400/+/steps/media_unittests__with_patch_/0/logs/Flaky_failure:_MediaRemotingIntegrationTest.SeekWhilePlaying__status_CRASH_SUCCESS_/0

Turns out, this is actually a bug in the AudioRendererImpl, where the
old method for determining if the content is ended is flaky, resulting
in multiple calls to OnEnded. This bug has been resolved by a change made on the
AudioRendererImpl, moving to an explicit EndedPlayback signal:

https://chromium-review.googlesource.com/c/chromium/src/+/2021292

Bug: 1043812
Change-Id: I8ca939e5166c3fa3c40f33c7a4e34f3a29d0e06b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258342
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781482}

Thread priority should not be modified after a test.
If that is happening, it needs to be fixed in the code.

This CL remove the code that disable the priority checks.

NOTE TO SHERIFF:
 * please paste failure logs when reverting, the goal is
   to remove flaky tests related to thread priority.
 * assigned flaky test to etienneb@

Bug: 1097092
Change-Id: I557727e9ab91ff5bdb4e87e54ba8f56b9313a1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254442Reviewed-by: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781481}

This feature has two problems:

- its name is bad and non-inclusive
- it's no longer needed with inlined typemap definitions

This converts the one remaining dependent typemap to an inlined
typemap configuration in GN.

Fixed: 1097211
Change-Id: I9515ada1bc833f1306f12b2bcae14a59f1257645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255123
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#781480}

Previously we would send the hmac-secret extension to authenticators
that didn't advertise support for it. That's fine because it'll be
ignored but, in the future when we have more support for hmac-secret, it
gets expensive.

This change adds the basic infrastructure for that and stops sending the
extension unless the authenticator advertises support.

Change-Id: I0dc2806c91ab0e032598c1f9ce54899c0b47d269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255210
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#781479}

Remove myself from OWNERS in //weblayer

Change-Id: I978fd3c19a58c29542bc37199dd5ed03b2ed6471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261221
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781478}

- Guard the PersistentHistogram init code in WebView.
- The feature is still disabled by default.
- Will use the finch to rollout LocalMemory backed PersistentHistogram.
- The Renderer process metrics will work, but the unsent metrics will
  lost on crash or app being killed.

Tested manually

Bug: 1090682
Change-Id: I3033c853bf2738a2f2dd24efeac6b3913dd79890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259377Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781477}

Adds support for Fast Initiation advertising to NearbySharingService.
When StartAdvertising() is called, the service will acquire a
BluetoothAdapter and use it to create a FastInitiationManager, which
will handle broadcasting the advertisement.

Bug: b:154846208
Change-Id: I5ea0de14901bf14d7f20dd80ef21582c21b10665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211132Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Cr-Commit-Position: refs/heads/master@{#781476}

Bug: 966270
Change-Id: I6c886591d656d1aa681aa5620d682104f4d4b7ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259379Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781475}

Change-Id: Id5672338460fc8ceb4ad0acb93534f520c4f5c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056759Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781474}

For crbug.com/889952 a flush was introduced to get messages sent to the
renderer process compositor thread to be handled (and bounced to the
main thread) before navigating and starting the test on the renderer
main thread.

A second flush was also added at that time to the main thread, which
would ensure those bounced compositor-thread things would be handled
there before proceeding. But since those events don't have side effects
that need to be received by the browser before proceeding, this second
flush is not needed. The tasks for compositor-thread events bounced to
the main thread will be run before the main thread navigates and starts
running the test regardless.

The fast/selectors/selection-window-inactive.html test was disabled as
flaky for bug 889952, but the flushes added to that test did not
actually stop it from being flaky.

R=avi@chromium.org

Bug: 889952, 953991, 1084377
Change-Id: Iea96b364efd36d057f156f940aee19a64aaacf39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261156Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781473}

This ensures no accidental copies of the underlying objects.

Removing the assignment operator requires use of uniform initialization.

This is broken out of
  https://chromium-review.googlesource.com/c/chromium/src/+/2204539

which in turn is broken out of
  https://chromium-review.googlesource.com/c/chromium/src/+/1557854

Bug: 1083392
Change-Id: Ia40eafa902e514d2c261489cb0a91a147d389415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258781
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781472}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b7db183f0206..37b62e51e50c

2020-06-23 brucedawson@chromium.org Get roll-dep to handle \ separators

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I6399572a0b73e711f9dfb1c4835b6751e081b582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260927Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781471}

This file is only compiled when the GN arg
|enable_fake_assistant_microphone=true| is used,
which is why it was broken without people realizing.

Bug: N/A
Test: N/A
Change-Id: Ibeae35d306506710d2d7a3a9687a2d16db3a7a79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260940
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Commit-Queue: Tao Wu <wutao@chromium.org>
Auto-Submit: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781470}

Add support in the contextMenus API for the generic "action" key,
similar to the support available for "page_action" and
"browser_action". Expand testing to cover this case.

Bug: 893373
Change-Id: I248c4fd84bf309bc617b95e1e2a13f05b1b51684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159955
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781469}

Similar code was already removed from tab_group_underline.cc

Change-Id: I5bf15a201b07942123218a56a4c06dbb00aaf881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261157
Commit-Queue: Dana Fried <dfried@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781468}

Bug: None
Change-Id: I88ce75f25fc62b2fefb56f0b9b82a49624141f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255019
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781467}

This CL adds mappings for the JC-U4013SBK (the wired version) and
JC-U4113SBK (wireless) when they're in "D" (DirectInput) mode.
(https://crrev.com/c/2252469 adds XInput support for the JC-U4113SBK,
and XInput support for the JC-U4013SBK is still to come.)

Bug: chromium:1097173, chromium:1096754, b:159466838, b:159368181
Test: Connect gamepads in "D" mode, load gamepadviewer.com, and check
that pressing buttons and moving axes is correctly reflected on-screen.

Change-Id: I30dae3bd586b5b4ceeccb0a4ae3c02bb8a91447a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259012
Commit-Queue: Harry Cutts <hcutts@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781466}

Enforce publicly trusted TLS server certificates have a
lifetime of 398 days or less, if they are issued on or after
2020-09-01.

Certificates that violate this will be rejected with
ERR_CERT_VALIDITY_TOO_LONG and will be treated as misissued.

Bug: 1097982
Change-Id: I0fdccd93cc9fd0ee1011b37be7b584a8ce6653d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258372Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781465}

If user turns on the instant-fetch flag after the first initial flow,
and turn off again after fetch is done, the code path was broken and
could never trigger the next normal flow.

Fix is mark the first flow completed when ever OnFetchCompeleted called.

Have unit test to cover this corner case.



Bug: 1087476
Change-Id: Id763b2ad328b9ca0be3ad6849f778aca182c989f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259013
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781464}

No changes in test logic.

Bug: 1024850
Change-Id: I9f97de7f1d0a31f7184f0856f025aec219fe79a9
Tbr: dtrainor@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261159Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781463}

The bug that caused flakiness was fixed.

Bug: 1097332
Change-Id: I26b741a59244ad46121ec5738955a6f607dea2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259843Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781462}

set_sources_assignment_filter() causes files to be magically excluded
from sources lists based on path substrings. It is considered a
mis-feature of gn, see bug.

Convert BUILD.gn to use conditionals to include source files only on
the platform where they are used.

Bug: 1018739
Change-Id: If699383ea8b1d936f5a4d30a1b072291841a4183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255316
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781461}

This was recently found by a manual audit after an ASAN fuzzer found
a similar issue.

BUG=1098226

Change-Id: I4a91ec58ccceadd92719774cf0047cb7a184c5be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261392
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781460}

Since circular_deque.h only contains base::circular_deque, it is easy to
grep for headers that include circular_deque.h, but not
base::circular_deque. Fix IWYU lint errors along the way.

Change-Id: I85e8c7cfb255535eecdeaaf91703a21e507c8f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258431Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781459}

Without this cl changePaymentMethod would fail when the "details" key
did not exist in input bundle. With this change the "StringifiedDetails"
passed to changePaymentMethodfromInvokedApp()[1] will have the default
stringified empty JSON object value.

[1]https://cs.chromium.org/chromium/src/components/payments/content/android/java/src/org/chromium/components/payments/PaymentRequestUpdateEventListener.java?l=32

Bug: 1026667
Change-Id: I55ac9d3e5d6dc6923290223317164d1dfdd3faa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255656
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781458}