GitLab

Galaxy S4 requires a surface texture in order for the media player to report correct video size.
So bind a texture to MediaPlayer whenever the video is HLS

BUG=400145

Review URL: https://codereview.chromium.org/478403002

Cr-Commit-Position: refs/heads/master@{#291184}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291184 0039d316-1c4b-4281-b951-d872f2087c98

permission and resource manager.

BUG=372607

Review URL: https://codereview.chromium.org/475193002

Cr-Commit-Position: refs/heads/master@{#291183}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291183 0039d316-1c4b-4281-b951-d872f2087c98

This test was flaking on ChromeOS ASAN bots.  See bug for details.

TBR=miu@chromium.org
NOTRY=true
BUG=406051

Review URL: https://codereview.chromium.org/496093002

Cr-Commit-Position: refs/heads/master@{#291182}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291182 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/2322

Original issue's description:
> Add ui_unittests to GN build.
> 
> Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file.
> 
> Remove special filtering out in GYP build of base/ime/chromeos/character_composer_unittest.cc and base/ime/input_method_chromeos_unittest.cc since the standard filtering patterns match both of these.
> 
> R=sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291154

TBR=sky@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/496843002

Cr-Commit-Position: refs/heads/master@{#291181}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291181 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Multiprofile security: Show a warning messagebox when desktop casting/sharing is turned on upon user (patchset #3 of https://codereview.chromium.org/496563002/)

Reason for revert:
Broke Linux ChromiumOS Tests on waterfall:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/47585

Original issue's description:
> Multiprofile security: Show a warning messagebox when desktop
> casting/sharing is turned on upon user switch
> 
> Purpose of this change:
> 
> Asks the user with a system modal dialog box if he wants to
> turn off screen sharing/screen casting and then switch users
> or abort switching users.
> 
> BUG=353170
> TEST=TrySwitchingUserTest.*
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291152

TBR=jennyz@chromium.org,jamescook@chromium.org,skuhne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353170

Review URL: https://codereview.chromium.org/473953004

Cr-Commit-Position: refs/heads/master@{#291180}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291180 0039d316-1c4b-4281-b951-d872f2087c98

It's bouncing emails if you send mail directly (instead of from reitveld)

NOTRY=true

Review URL: https://codereview.chromium.org/492913003

Cr-Commit-Position: refs/heads/master@{#291178}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402882

Review URL: https://codereview.chromium.org/467043003

Cr-Commit-Position: refs/heads/master@{#291177}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291177 0039d316-1c4b-4281-b951-d872f2087c98

When converting those bots to recipes in r287833, "unit" was replaced with
"unit_tests". In fact, "unit" is a composite step that includes 5 other targets
besides "unit_tests". This CL adds those targets back.

This CL also adds accessibility_unittests and gfx_unittests, which presently run
on the linux_asan trybot and on other waterfalls, but not on chromium.memory.
The same should be done to cast_unittests and google_apis_unittests, once they
are green under ASan.

BUG=none
R=glider@chromium.org
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/498443002

Cr-Commit-Position: refs/heads/master@{#291176}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291176 0039d316-1c4b-4281-b951-d872f2087c98

With the --extension-action-redesign switch, hiding an extension action should
cause it to go to the overflow menu (rather than disappearing completely).
Enable this functionality.

BUG=403824

Review URL: https://codereview.chromium.org/476873002

Cr-Commit-Position: refs/heads/master@{#291174}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291174 0039d316-1c4b-4281-b951-d872f2087c98

Previously, if you specified an empty resource ID file in the grit template in the GN build, it would send "-f" with no argument to grit, and this would cause the command line parsing to get messed up and it wouldn't generate any files.

This patch just omits the "-f" argument in this case.

R=jam@chromium.org

Review URL: https://codereview.chromium.org/495183002

Cr-Commit-Position: refs/heads/master@{#291173}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291173 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291172}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291172 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/470403005

Cr-Commit-Position: refs/heads/master@{#291171}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=404766
TEST=Using a sample extension,
"commands": {
  "foo": {
    "suggested_key": {
      "chromeos": "Search+Shift+L"
...

and adding a listener to onCommand, pressing Search+Shift+L results in triggering of the callback. (on linux, this is lwindows+shift+l).

Review URL: https://codereview.chromium.org/392313003

Cr-Commit-Position: refs/heads/master@{#291170}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399146

Review URL: https://codereview.chromium.org/461323005

Cr-Commit-Position: refs/heads/master@{#291169}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302040
TBR=noelallen@chromium.org

Review URL: https://codereview.chromium.org/357623003

Cr-Commit-Position: refs/heads/master@{#291168}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291168 0039d316-1c4b-4281-b951-d872f2087c98

This changes lastchange.py in two ways:
1) If the commit it finds is a Git hash, it outputs the whole hash, not just
   the first 7 characters.
2) It only looks at HEAD to see if there is a git-svn id. Previously, it used
   --grep=git-svn-id, which would find the most recent commit containing a
   git-svn id. This would be broken after the switch to git, as it would always
   find the last commit before the switch. Now, it only inspects the most recent
   commit, and falls through to pure-Git if that fails.

R=dilmah@chromium.org, stip@chromium.org
BUG=399113

Review URL: https://codereview.chromium.org/488733002

Cr-Commit-Position: refs/heads/master@{#291165}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291165 0039d316-1c4b-4281-b951-d872f2087c98

version of the tested websites.
Some of the tested websites have changed over the last weeks. This cl
updates the password manager python tests so they can support
the new version of websites.
This cl adds also the tests for Twitter.
BUG=404647

Review URL: https://codereview.chromium.org/483763002

Cr-Commit-Position: refs/heads/master@{#291164}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291164 0039d316-1c4b-4281-b951-d872f2087c98

Example flake here:http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/8184/steps/%5Bswarming%5D%20content_browsertests%20%28with%20patch%29/logs/OverscrollNavigationTouchThrottling

BUG=

Review URL: https://codereview.chromium.org/491083002

Cr-Commit-Position: refs/heads/master@{#291163}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291163 0039d316-1c4b-4281-b951-d872f2087c98

When in fullscreen we should give back the fullscreen icon's width to the tabstrip.

Before: https://drive.google.com/open?id=0B1B1Up4p2NRMdXloQ3phSElBeEk&authuser=1
After: https://drive.google.com/open?id=0B1B1Up4p2NRMM2JNRE56aC1uRDA&authuser=1

BUG=403561

Review URL: https://codereview.chromium.org/493803002

Cr-Commit-Position: refs/heads/master@{#291162}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291162 0039d316-1c4b-4281-b951-d872f2087c98

This master CL lands recent SPDY changes through 73573949, extending them
with Chromium-specific updates to constants and enums, protocol negotiation
tokens, and tests.  This CL is intended to be commited but not reviewed, and is
the union of the following changes, which in turn are intended to be reviewed
but not commited.  (Most recent on top, oldest on bottom.)

Fix bug in HTTP/2 frame size limits.  This lands server change 73573949.
https://crrev.com/478903004

Update npn/alpn tokens to HTTP2-draft14.
https://crrev.com/486493003

Add kSpdyMaxControlFrameSize and kControlFrameSizeLimit constants.  This lands
server change 73427537.
https://crrev.com/486873002

Add TODO.  This lands server change 73426819.
https://crrev.com/479313002

Add an extra byte to the length field for HTTP/2 frame headers.  This lands
server change 73424406.
https://crrev.com/479303002

Change order of tests.
https://crrev.com/483863002

Remove reference set and exchange header and static table in HPACK.  This lands
server change 73299534.
https://crrev.com/480573003

Add new settings to SPDY4 for h2-14.  This lands server change 72726557.
https://crrev.com/480183002

Add kHttp2VersionString.  This lands server change 72173526.
https://crrev.com/485813002

HTTP2 draft 13: support unknown frame types and settings types as extensions.
This lands server change 70895882.
https://crrev.com/483843004

Allow unrecognized error codes as part of HTTP/2 extensions.  This lands server
change 70873693.
https://crrev.com/475043002

BUG=400336

Review URL: https://codereview.chromium.org/485833002

Cr-Commit-Position: refs/heads/master@{#291161}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291161 0039d316-1c4b-4281-b951-d872f2087c98

When user removes the last item (folder/page) from 'Other bookmarks' folder,
the folder itself is hidden; hence adding (empty) button is unnecessary. So
just close the folder before hiding it.

TEST=
1) Launch chrome and bookmark a page or folder into 'Other Bookmarks'.
2) Right-click on the bookmarked page/folder in the 'Other Bookmarks' from Bookmark bar.
3) Choose to 'Cut'/'Delete' and observe.
4) (empty) placeholder button should not remain after 'Other bookmarks' folder is hidden.

BUG=257538
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/485003002

Cr-Commit-Position: refs/heads/master@{#291160}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291160 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/486283002/ which fixed only some of the cases. This CL ensures the bubble is updated also when the profile name is changed due to selecting a different avatar.

BUG=405050

Review URL: https://codereview.chromium.org/497453002

Cr-Commit-Position: refs/heads/master@{#291159}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291159 0039d316-1c4b-4281-b951-d872f2087c98

This CL is premised on the theory that the memory corruption and related
crashes are due to invalid input data being fed into the sessions sync
code.  See the linked bug for more details.

Adds two tests that expose the scenario that is believed to be the cause
of the bug.  If checked in on their own, they would crash during
destruction of the SyncedSessionTracker.

Adds a CHECK to prevent the SyncedSessionsTracker from getting in to
a bad state.  The goal of this CHECK is to ensure that all crashes
caused by misuse of the tracker cause a crash immediately, rather than
corrupting the memory allocator's internal data structures and possibly
causing crashes in unrelated code.  The newly added tests would trigger
this CHECK, if not for the last component of this CL.

Adds a filter for incoming sync_pb::SessionHeader values.  Before acting
on the session, the SessionsSyncManager will now verify that the header
does not contain any duplicate tab IDs.  If verification fails, the
header will be ignored.  This part of the CL allows the new tests to
pass.

BUG=360822

Review URL: https://codereview.chromium.org/495593003

Cr-Commit-Position: refs/heads/master@{#291158}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291158 0039d316-1c4b-4281-b951-d872f2087c98

Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file.

Remove special filtering out in GYP build of base/ime/chromeos/character_composer_unittest.cc and base/ime/input_method_chromeos_unittest.cc since the standard filtering patterns match both of these.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/496473003

Cr-Commit-Position: refs/heads/master@{#291154}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291154 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/483703002/

Turns out you can have a profile image, but no profile URL. Handle this case by resolving the image URL against a dummy https URL.

BUG=404671

Review URL: https://codereview.chromium.org/495003003

Cr-Commit-Position: refs/heads/master@{#291153}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291153 0039d316-1c4b-4281-b951-d872f2087c98

casting/sharing is turned on upon user switch

Purpose of this change:

Asks the user with a system modal dialog box if he wants to
turn off screen sharing/screen casting and then switch users
or abort switching users.

BUG=353170
TEST=TrySwitchingUserTest.*

Review URL: https://codereview.chromium.org/496563002

Cr-Commit-Position: refs/heads/master@{#291152}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405486
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/489983003

Cr-Commit-Position: refs/heads/master@{#291151}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291151 0039d316-1c4b-4281-b951-d872f2087c98

Remove duplicate reference of content_switches which causes link errors.

Add dependency on theme_resources from apps (it includes the generated file).

R=miket@chromium.org

Review URL: https://codereview.chromium.org/496763002

Cr-Commit-Position: refs/heads/master@{#291150}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291150 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/491103004

Cr-Commit-Position: refs/heads/master@{#291149}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291149 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291148}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291148 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180694:180708&mode=html
TBR=dglazkov@chromium.org,wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/495013002

Cr-Commit-Position: refs/heads/master@{#291147}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291147 0039d316-1c4b-4281-b951-d872f2087c98

These are regularly flaking on the build bots.  See bug for details.

NOTRY=true
TBR=miu@chromium.org
BUG=406018

Review URL: https://codereview.chromium.org/496053002

Cr-Commit-Position: refs/heads/master@{#291146}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291146 0039d316-1c4b-4281-b951-d872f2087c98

The skia bug suspected to cause this has been fixed.

R=tonyg@chromium.org
BUG=399125

Review URL: https://codereview.chromium.org/491583003

Cr-Commit-Position: refs/heads/master@{#291145}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/498473002

Cr-Commit-Position: refs/heads/master@{#291142}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291142 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the whitelisting of all Qualcomm GPUs on
Android 4.4 with whitelisting all Android 4.4 devices
with GL ES version >= 3.0.

BUG=405646

Review URL: https://codereview.chromium.org/468103003

Cr-Commit-Position: refs/heads/master@{#291141}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291141 0039d316-1c4b-4281-b951-d872f2087c98

See
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5481
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5503
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5542

BUG=291249
TBR=jdduke@chromium.org

Review URL: https://codereview.chromium.org/492303005

Cr-Commit-Position: refs/heads/master@{#291139}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291139 0039d316-1c4b-4281-b951-d872f2087c98

Bug=352290

Review URL: https://codereview.chromium.org/486903002

Cr-Commit-Position: refs/heads/master@{#291138}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291138 0039d316-1c4b-4281-b951-d872f2087c98

Cross-origin HTTP auth dialogs are shown over a blank interstitial.
This didn't work nicely with other interstitials, e.g. an HTTPS resource
that triggered a basic HTTP auth dialog would show the SSL warning, and when
the user clicked through the warning, the login interstitial would show
on top of the SSL interstitial, rather than a blank page.
crrev.com/410373003 accidentally fixed that issue. This CL adds tests
for the scenario described above.

BUG=393597
TEST=LoginPromptBrowserTest.LoginInterstitialShouldReplaceExistingInterstitial

Review URL: https://codereview.chromium.org/397453002

Cr-Commit-Position: refs/heads/master@{#291137}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291137 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ckocagil@chromium.org
BUG=406012

Review URL: https://codereview.chromium.org/482493003

Cr-Commit-Position: refs/heads/master@{#291136}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291136 0039d316-1c4b-4281-b951-d872f2087c98

Disable AppWindowInteractiveTest.ESCLeavesFullscreenDOM and AppWindowInteractiveTest.ESCDoesNotLeaveFullscreenWindow as they are flaky on Mac.

TBR=mlamouri@chromium.org
BUG=406009

Review URL: https://codereview.chromium.org/490293002

Cr-Commit-Position: refs/heads/master@{#291135}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291135 0039d316-1c4b-4281-b951-d872f2087c98