GitLab

Bug: 795636
Change-Id: Ifbeaf7eab76b992ac41a4dc7f23ec46f72ad8ca2
Reviewed-on: https://chromium-review.googlesource.com/c/1412827
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625734}

Before this CL when MyFilesVolume flag is enabled users couldn't select
other folders inside MyFiles, only inside MyFiles/Downloads, this CL
fixes it.

The flag MyFilesVolume will be enabled by default in follow up CL.

this CL when MyFilesVolume flag is enabled

Test: browser_tests --gtest_filter=DownloadPrefsTest only passes with
Bug: 873539
Change-Id: I8dc172412a1fd7b7cc69bc82f75c39f29e2f984e
Reviewed-on: https://chromium-review.googlesource.com/c/1433635
Commit-Queue: Min Qin <qinmin@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625733}

In current code, the mask layer of AppsGridView uses the wrong
recording size because the paint recorder is not given correct
scale factor when created. As result, during painting, AppsGridView
has different size from its mask layer. It is the reason why there
is an one-pixel line shown. This CL fixes the issue by giving the
correct scale factor.

Bug: 921274
Change-Id: I91cfd8ced16e266400e91c1b8e4b0566f10736e7
Reviewed-on: https://chromium-review.googlesource.com/c/1432894
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625732}

Change-Id: Id01a46f3ca42ef49a2ebbcb8bd161dfd88574581
Reviewed-on: https://chromium-review.googlesource.com/c/1429383
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625731}

There are no 0 width png files, so we should throw.

Change-Id: I888f28a134f647381b33efd784361d2cc57dd063
Reviewed-on: https://chromium-review.googlesource.com/c/1407203Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625730}

I am removing NetworkHandler dependencies from network_icon.cc to
simplify the pending migration to mojo APIs in //ash.

Bug: 923444
Change-Id: I99c7cd5d515a676e8be9d83b9f6166db2dbeb67b
Reviewed-on: https://chromium-review.googlesource.com/c/1423089Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625729}

Add Ctrl + W key combo for Assistant to close UI.

Bug: 910765
Test: local compile and manually test.
Change-Id: I8d4d7b45fbb5ca70dececd92989036beba6cb010
Reviewed-on: https://chromium-review.googlesource.com/c/1423563
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625728}

This allows Skia to hide GrGpuResource::abandon() from its public API.

Change-Id: Ib649d40cc6635180a95db2eb2b85b4b4930616ea

BUG=skia:7966

Change-Id: Ib649d40cc6635180a95db2eb2b85b4b4930616ea
Reviewed-on: https://chromium-review.googlesource.com/c/1434519Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#625727}

https://chromium.googlesource.com/catapult.git/+log/b9dbf6c17c96..46e3f0707549


git log b9dbf6c17c96..46e3f0707549 --date=short --no-merges --format='%ad %ae %s'
2019-01-24 crouleau@chromium.org Revert "Devil: string constants for ABIs"
2019-01-24 sky@chromium.org makes tab closing behavior before starting tests specific to !android
2019-01-24 bsheedy@chromium.org Fix sum field in gtest_json_converter
2019-01-24 ntfschr@google.com Devil: string constants for ABIs


Created with:
  gclient setdep -r src/third_party/catapult@46e3f0707549

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:916107,chromium:921342
TBR=sullivan@chromium.org

Change-Id: I77e5f01bf4756549932e566d568aa43af9fbf662
Reviewed-on: https://chromium-review.googlesource.com/c/1434100Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625726}

Store the successful runs of account migration to Chrome OS Account
Manager in Prefs. This will be checked at the start of migrations to
figure out if we should run migrations again.

Bug: 923947, 904128
Change-Id: I9360c56c85810f80f58f1d35ecbf1a3f3106be2e
Reviewed-on: https://chromium-review.googlesource.com/c/1433762Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625725}

This is a reland of b99afc65 plus
a build fix for ios_simulator_debug.

Original change's description:
> Tracing: Start the tracing service on-demand
>
> Instead of each process connecting to the tracing service
> on startup, the tracing service is now instead brought
> up on demand (when something binds the Coordinator interface)
> and will then pass pointers to the AgentRegistry and
> PerfettoService to the other services so they can register themselves.
>
> This is a prerequisite to having the tracing service run as a
> sandboxed service (or we would always have a new background process
> running): https://chromium-review.googlesource.com/c/chromium/src/+/1412016
>
> Requires these prior CLs for service_manager manifest support:
> * https://chromium-review.googlesource.com/c/chromium/src/+/1410124
> * https://chromium-review.googlesource.com/c/chromium/src/+/1410384
>
> TBR=yusukes@chromium.org (for trivial CrOS change)
>
> Bug: 914579
> Change-Id: Ia1c92fe2aa75e3411efbd119cb9443e8a78e4c8f
> Reviewed-on: https://chromium-review.googlesource.com/c/1377593
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#625059}

TBR=rockot@google.com,haraken@chromium.org,tsepez@chromium.org

Bug: 914579
Change-Id: I4bd8bb1706dc7543b24cafc2c62c154190dad81d
Reviewed-on: https://chromium-review.googlesource.com/c/1434518Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625724}

A PaintChunk's raison d'être is to associate a sequence of display items
with paint properties. These paint properties should never be null, but
crashes in https://crbug.com/923729 indicate they are. This patch CHECKs
that PaintChunk's properties are non-null and any resulting crash stacks
should guide us towards the source of these null paint properties.

Bug: 923729
Change-Id: I56421d41a36c107418200f6df4ec1c7784f38e1d
Reviewed-on: https://chromium-review.googlesource.com/c/1434557
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625723}

lowLatency as it is implemented right now is not working on Mac,
because the IOSurface backing the GMB cannot be held simultaneously
by Chrome and the OS. This CL disables it and the associated tests;
it also disables the associated pixel_tests to recreate the ref
images (that for some reason are displaced by a pixel).

low latency ofc).

Tbr: bajones@ for content/test/gpu/gpu_tests/pixel_expectations.py
Test: https://codepen.io/miguelao/full/ZjJNNw works (albeit w/o
Bug: 922218
Change-Id: I7be4b1f3345e0447718025bf19770a65ac4b2c62
Reviewed-on: https://chromium-review.googlesource.com/c/1412856
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625722}

Bug: 923332
Change-Id: Icf6aafb9022df865621d17ace3509d51c0000b90
Reviewed-on: https://chromium-review.googlesource.com/c/1421899Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#625721}

In bug 894982 we fixed an error path to delete the simple cache's
fake index file if that file failed to write to disk.  Previously we
could have left a partially written file on disk.  Further, this
particular path would only trigger for new simple caches that had not
yet had any entries populated.

This CL follows up on that work in order to recover previously
corrupted simple cache directories.  Since that previous error only
triggered for empty caches we should be able to delete the partial
fake index and start again.

Bug: 923138
Change-Id: Ib584ed39fd6d22748f322e5dc7af2ff0217eac7a
Reviewed-on: https://chromium-review.googlesource.com/c/1419262
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625720}

Bug: 916991
Change-Id: I117dfd4adb883a1d679de07ee48509e322bacd2c
Reviewed-on: https://chromium-review.googlesource.com/c/1434655Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625719}

This is a reland of a0764266

The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010

TBR=kojii@chromium.org

Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] https://github.com/w3c/csswg-drafts/pull/2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}

Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}

In fact it is not necessary to set this env var but it is worth
mentioning to show that VA-API also works when the gpu process
is running in sandbox mode.

Bug: 917091
Change-Id: I0d7b43dcff4d7887e945b5d54d8d13d5244d1544
Reviewed-on: https://chromium-review.googlesource.com/c/1433032
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625717}

In current code, we have no constraints on gesture event's location.
As result, when window is dragged by touch-gestures to the edge of display,
gesture's location may be in a wrong display. It will lead to system crash.
In this CL, constraint on gesture event's location is added

Change-Id: I2c03d369df0b7bed143edb3f04a9c7aad5968d4a
Test: ash_unittests
Bug: 917060
Reviewed-on: https://chromium-review.googlesource.com/c/1413416
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625716}

This CL disables the feature again on ToT. The reason is that the launch
to M71 Stable failed due to unexpected highly increased traffic. The
plan is to investigate and fix the underlying bug and restart the
launch.

Bug: 924447
Change-Id: Id76cc3865fefe22785f40bac66295c3ccc4b3da3
Reviewed-on: https://chromium-review.googlesource.com/c/1430080
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625715}

This fixes an apparent recent regression where the Contextual Search
panel sometimes stays showing even when the user scrolls.  This is
very hard to reproduce, but sometimes happens when the user scrolls
while the selection is being expanded. Once the scroll is ignored,
all subsequent scrolls are ignored.

The problem seems be be that a recent change to handle interaction
with the Ephemeral Tab introduced a delay as a workaround to not having
an effective way to check if the TTS panel is currently shown. This
is because when the panel is first requested to show it is not yet
visible, and that's the measure of it being shown or not.

This CL adds a notion of "active" to the Overlay Panel that covers
the case where it's been requested to show but not yet physically
visible due to animation.  This provides a reliable way
to know if the panel is active for TTS.

BUG=916689

Change-Id: I95cfa10c8f1af20bc52a76cce1e5451965089445
Reviewed-on: https://chromium-review.googlesource.com/c/1417111Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625714}

Add 5 different types of overviews according to user management status.
Finalize other messages from the management page.

Bug: 879146
Change-Id: I9749c2eca89d04974816c472a8772cf8c8d9c20d
Reviewed-on: https://chromium-review.googlesource.com/c/1421903
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625713}

Bug: 916176
Change-Id: I178eeb3a1bead8af93a99b3099e8ffd9703d9526
Reviewed-on: https://chromium-review.googlesource.com/c/1409354Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625712}

Pausing worklet animation now holds the time. This works as expected for
main thread animations. Implementing this for composited worklet
animations will be done in a follow up patch.

Major changes:
 - Add and expose pause() method pausing the animation.
 - Introduce hold_time that is used when animation is paused.
 - Rework how current time is computed, it is now closer to
   regular animations i.e., we either compute it based on
   "start time and timeline.currentTime" or use "hold time".
 - Instead of setting start time we now set the current time
   which then works backward to compute either the start time
   or the hold time based on the animation state.
 - When transitioning animation play state, we now always set
   the current time. Previously this was adhoc and inconsistent.
 - Introduce has_started_ to differentiate when playing an
   animation for the first time vs playing it from pause.


TEST:
  * wpt/animation-worklet/worklet-animation-pause.https.html: js test for basic current time calculations
  * wpt/animation-worklet/worklet-animation-pause-immediately.https.html: reftest for basic pause
  * wpt/animation-worklet/worklet-animation-pause-result.https.html: reftest for pause/resume.
  * WorkletAnimationTest.PausePlay: unit test for basic state transition and time calc

Bug: 821910

Change-Id: Ie4b00129398159b3b5b83212bb63c43f2ce8bf4e
Reviewed-on: https://chromium-review.googlesource.com/c/1383298
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625711}

Bug: 904648
Change-Id: I82cd7c15e1e797b6f61883e8f57fe3577ca21102
Reviewed-on: https://chromium-review.googlesource.com/c/1434554Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625710}

Not doing this causes a DCHECK failure at startup (issue 917698) but also causes
the Chrome message loop not to interoperate properly with the native message
loop.

Bug: 917698
Change-Id: Ife2e789a2eb8679bc32bc5b8349fef1dbebb0c80
Reviewed-on: https://chromium-review.googlesource.com/c/1432652
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625709}

Removed unwanted headers related to token service and signin manager
from in identity_apitest.cc

Bug: 921605
Change-Id: Id5dbabebf75648b2699ca7776ecaa7fbfd4ceb67
Reviewed-on: https://chromium-review.googlesource.com/c/1424057
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625708}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/695e7cf35258..4d965ee2d8cc


git log 695e7cf35258..4d965ee2d8cc --date=short --no-merges --format='%ad %ae %s'
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@4d965ee2d8cc

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ibd8a8722ee4065ff25380d6d3c6aa6a9a34b2e8c
Reviewed-on: https://chromium-review.googlesource.com/c/1434556Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625707}

This change updates the hot tracked button in MenuController to update
the hot track button whenever there is a button at the current mouse
location.

Bug: 918209
Change-Id: I462f72c24498b7d89d9b30d913a25c88c4828c4d
Reviewed-on: https://chromium-review.googlesource.com/c/1418494
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625706}

Bug: 902364
Change-Id: I1e130fa4d9de041e4345e1bf8887487cd19cfb97
Reviewed-on: https://chromium-review.googlesource.com/c/1422898Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625705}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c683e1e6a3aa..6588e2f70fe8


Created with:
  gclient setdep -r src-internal@6588e2f70fe8

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I39944619005e11f2e7011846dc91ea983fbb6bf8
Reviewed-on: https://chromium-review.googlesource.com/c/1434555Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625704}

This previous CL:
https://chromium.googlesource.com/chromium/src/+/09932bf92b6ad1aa4410015ee9af2f20a3df900b
was addressing an issue where the omnibox bounding box
was incorrect when focusing the fakebox, but the fix broke
pasting text.  This patch restores any existing text after
toggling focus.

BUG=924908

Change-Id: Id0a5832aa310780753ab37011d52ce7fc3a6d50b
Reviewed-on: https://chromium-review.googlesource.com/c/1434315
Auto-Submit: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625703}

Use PrerenderURLLoaderThrottle instead, which is now usable even without
network service.

Bug: 755921
Change-Id: Ib9e15e9e762c39c3e37052aa0c36f4711e00db5b
Reviewed-on: https://chromium-review.googlesource.com/c/1427540Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625702}

Since http://crrev.com/556458 there have been two (or three) completely
different ways of ‘returning’ events from an EventRewriter:

- The original output parameter on RewriteEvent(), with the clunky
  NextDispatchEvent() to produce multiple events.

- Calling SendEventToEventSource(source, event), when the replacement
  event must pass through later event rewriters. (This had the problem
  of not tracking the original source.)

- Several EventRewriters do an end run around the rewriter system in
  some cases, e.g. calling WindowEventDispatcher::OnEventFromSource()
  after a timeout, since the original RewriteEvent() interface could
  only produce events in response to incoming events.

This CL replaces all the above cases with a consistent return mechanism,
using Send…() functions. This is inspired by SendEventToEventSource(),
but has the caller provide the output functions explicitly, so that
multiple sources can correctly share an EventRewriter (as Ash does).

This CL contains the EventRewriter/EventSource revision, under
//ui/events, plus conversions of ‘trivial’ rewriters (essentially those
that only used RewriteEvent()). Other rewriters will be converted in
separate CLs for review by their respective OWNERS, because removing
NextDispatchEvent() or asynchronous dispatch generally requires some
logic change.

This CL includes a compatibility shim for the old API, which will be
removed once all rewriters have changed.

How to convert an EventRewriter:

How to convert an EventRewriter:

- When the incoming event is accepted unchanged, replace old API uses of
     return EVENT_REWRITE_CONTINUE;
  with new API
     return SendEvent(continuation, &incoming_event);

- When the incoming event is to be discarded, replace old API uses of
     return EVENT_REWRITE_DISCARD;
  with new API
     return DiscardEvent(continuation);

- When the incoming event is to be replaced, replace old API uses of
     *rewritten_event = std::move(new_event);
     return EVENT_REWRITE_REWRITTEN;
  with new API
     return SendEventFinally(continuation, replacement_event);

- When the incoming event is to be replaced, and the replacement event
  should pass through later rewriters, replace old API uses of
     return SendEventToEventSource(source, replacement_event);
  with new API
     return SendEvent(continuation, replacement_event);

- When the incoming event is to be replaced by multiple events, replace
  old API uses of
     *rewritten_event = std::move(new_event_1);
     // record new_event_2 … new_event_N
     return EVENT_REWRITE_DISPATCH_ANOTHER;
  with new API
     details = SendEventFinally(continuation, new_event_1);
     ⋮
     return SendEventFinally(continuation, new_event_N);

Bug: None
Change-Id: I4d217cee5aa1a2f2dbf178ce642ef1b6e2338c25
Reviewed-on: https://chromium-review.googlesource.com/c/1203882Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625701}

This will allow us to run an experiment comparing memory usage of the
no-op process vs memory usage of the network process to determine if
memory is being overcounted in the Memory.Total.PrivateMemoryFootprint
UMA.

Bug: 923101
Change-Id: Iac578d2367f2af176d096fbe00ee758f6e642bbd
Reviewed-on: https://chromium-review.googlesource.com/c/1417836Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625700}

This change disables the animation for the frame buttons when entering tablet
mode.  There was no actual animation before (the buttons would instantly
disappear), so the animation delay caused tabs to resize too late after entering
tablet mode.  Here's a before/after to clarify:

https://drive.google.com/open?id=1ogjl8lniXlqa6j7busvG3CtK_aizSKI6

BUG=881371
R=sky

Change-Id: I3eca2546fe3d3381c97d37bc40b57ede3d0f98c9
Reviewed-on: https://chromium-review.googlesource.com/c/1427247Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625699}

Bug: 924507
Change-Id: I837537c61a90b88933e980c1707dcd00746ad217
Reviewed-on: https://chromium-review.googlesource.com/c/1434515Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625698}

This CL adds the necessary plumbing to propagate
OnRemotePlayStateChange events back to WMPI.

This is used when the FlingingRenderer detects that a video playing
remotely was paused/resumed by an external device.

A follow up CL will add that adjusts WMPI's play/pause state to reflect
the current state of the remotely playing video

Bug: 790766
Change-Id: I6ddd4fb2ff273f095008e796e9d676c8e759dab2
Reviewed-on: https://chromium-review.googlesource.com/c/1413234
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625697}

Add boolean histogram that gets logged every time the user tries to
enter the VR browser without the VR DFM installed. Logs true in case of
success, and false in case the VR browser is blocked or started in
2D-in-VR mode.

Bug: 923545
Change-Id: I804ef724fbf55ecdb161c1c6fdd2eb4c5bb34982
Reviewed-on: https://chromium-review.googlesource.com/c/1431481
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625696}

This CL removes provisionally saving when the credentials autofilled
which removes calling of ShowManualFallback for autofilled credentials,
and this is the right thing to do, because we don't need to show a manual
fallback until the user start typing something and anyway autofilled
credentials are already saved.

Bug: 831123
Change-Id: I2f9a84a81612e38878f1c772ca260efd933c620c
Reviewed-on: https://chromium-review.googlesource.com/c/1434194
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625695}