GitLab

In preparation for more printing related servicification (PDF to EMF
converter, printer capabilities...), creating a new Chrome printing
service to host these interfaces and moving PdfToPwgRasterConverter
service there.

There is no change in logic.

Bug: 792225
Change-Id: I2c71a9e035dafc1ade84e71da6d71a9ca38277cd
Reviewed-on: https://chromium-review.googlesource.com/809619Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523950}

Previously, we didn't reset |shared_tab_loader_| every time when a test cast
got torn down, resulting in DCHECK failure when we tried to restore tabs in
another test case. This patch resets |shared_tab_loader_| every time when a
test cases is being torn down.

BUG=793625

Change-Id: Ic21faedd1748f6c9d26f1d493d97f7679c8e2dca
Reviewed-on: https://chromium-review.googlesource.com/823250Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523949}

This new class avoids having separate mock definitions in
render_widget_host_view_(aura|mac)_unittest.(cc|mm).

Having a single mock definition will simplify writing
common tests for occlusion tracking in
RenderWidgetHostView(Aura|Mac).

Bug: 668690
Change-Id: I7d7c0c39bf266014374df0b307eecc2a9047820d
Reviewed-on: https://chromium-review.googlesource.com/797851Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523948}

I modified this file manually in the previous patch, and made a
typo.

BUG=711468
R=skobes@chromium.org

Change-Id: I63cc6c285ea47a10dd41aec4de4049413311a0ed
Reviewed-on: https://chromium-review.googlesource.com/824946Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523947}

https://pdfium.googlesource.com/pdfium.git/+log/2614250d4f11..604f5b9e0422

$ git log 2614250d4..604f5b9e0 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 rharrison Refactor CFXA_*List constructors

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I706ee144900976b61077f4f466dbb4709d5e9abb
Reviewed-on: https://chromium-review.googlesource.com/825983
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523946}

Otherwise it results in a situation that keydown is delivered to the
client but keyup is not. The consequence is never-ending key repeat
in the client side.

BUG=794442
TEST=manually on Google Sheets app.

Change-Id: I573b75ad62c37603dc0074de6ceffa7a773b5f8b
Reviewed-on: https://chromium-review.googlesource.com/823372Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523945}

As described.

Test: Manually + browser test extended
Bug: b/70525239
Bug: b/70525068
Bug: 794698

Change-Id: I3f3280e25ccaaea8cfc9636fcd5a700f3eb7dbaf
Reviewed-on: https://chromium-review.googlesource.com/822768
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523944}

The DefaultProtocolHandlers TabMetrics field is limited to schemes
the user has accepted the site as the default protocol handler for.

Bug: 784639
Change-Id: I21f5c924a668c1b983744fcec4656c6b04245452
Reviewed-on: https://chromium-review.googlesource.com/797355
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523943}

mDNS discovery can trigger a firewall prompt on a fresh user-level
Chrome install on Windows or if there are no existing firewall rules
for mDNS traffic(?). This patch applies the same gating logic to
the mdns logic in in-browser cast discovery.

TODO: merge this patch back to M64.

Bug: 794317
Change-Id: I5df1a2f60eb3a8411b642fc8996f2e0279912401
Reviewed-on: https://chromium-review.googlesource.com/823244
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523942}

Bug: 786173
Change-Id: Idca7bbe2c209c8cf75930550e4462ca2b7ccdda3
Reviewed-on: https://chromium-review.googlesource.com/824702
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523941}

Replaced elements (except SVGRoot which uses the normal overflow clip/
border-radius clip rule) with border-radius will apply border radius clip
on their foreground, so we need to output InnerBorderRadiusClip for them,
and set proper chunk properties when painting their foregrounds.

Bug: 794295
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I206db7fcf55a99187cf1f8961f5f286d482f1bf2
Reviewed-on: https://chromium-review.googlesource.com/823177
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523940}

Bug: 
Change-Id: Ia72a555a03f5eb6a4b9ec9f5639f137c1ac60450
Reviewed-on: https://chromium-review.googlesource.com/826162Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523939}

On Windows, the folder upload prompt previously used "OK" as the default
button text, leading to the possibility that the user would not
understand that their selected folder would be uploaded to the server.

This CL matches other platforms and uses a localized string ("Upload")
as the text of the prompt's commit button.

Bug: 780881
Change-Id: I256d42fc8ba3fdd72d5af360585509b6573b7900
Reviewed-on: https://chromium-review.googlesource.com/777681Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523938}

kMaxBufferCount is defined in the anonymous namespace in two places in
//services/video_capture, which conflict in jumbo builds.  But since
each is only used in one location, they can be converted into function
statics instead.

BUG=794692

Change-Id: Ibf930a73d426ff7ef53fb921ec146952b84bc3de
Reviewed-on: https://chromium-review.googlesource.com/825823Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#523937}

https://crrev.com/c/795479 does the resizing at
|CompositorViewHolder.onLayout| but it is not the ideal place to
get the content view size/browser control info in. The view size can
still remain zero when a tab is being initialized from links on CCT
as reported int the bug.
The better place where we can be sure |ContentView.onSizeChanged|
was invoked and the size is set as expected is
|LayoutChangeListener.onLayoutChanged|.
This CL moves resizing logic accordingly.

Bug: 794288
Change-Id: I12fc771ba5850b79a418a003618b7cbc94678207
Reviewed-on: https://chromium-review.googlesource.com/822316Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523936}

Bug: 598854
Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Change-Id: I9aae58daee5ba3eedbfc4601e1fabdab18013912
Reviewed-on: https://chromium-review.googlesource.com/822953
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523935}

Document that chromeos::PowerManagerClient's
SetBacklightsForcedOff method doesn't support multiple
callers, and that ash::BacklightsForcedOffSetter should be
used instead.

Bug: 760730
Change-Id: Id083f9e1b3d1b252fa259ae519cf12c07135fa5f
Reviewed-on: https://chromium-review.googlesource.com/825948Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523934}

Bug introduced with: crrev.com/c/652867
The sync cell didn't include an image when having an error. This was the cause of an UI glitch.

Updating to EarlGrey tests to make sure an image is set in the sync cell.

Bug: 793822
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I189becd8e30ddaf5ee8d2d20f9cbd20258a20014
Reviewed-on: https://chromium-review.googlesource.com/821230
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523933}

Bug: 794688
Change-Id: I2e57bc570e8a8dc249c5fb53f83b561997caab5a
Reviewed-on: https://chromium-review.googlesource.com/825628Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523932}

This CL implements exising metrics reported by CRWPassKitDownloader.
UMA constants are duplicated, which is fine because old constants will
be removed along with CRWPassKitDownloader class.

Bug: 789735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I455e9247ed4493dbc7f3d59a74e1f5806e167956
Reviewed-on: https://chromium-review.googlesource.com/822528Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523931}

This change would allow us to propagate extension install source to
the component updater protocol builder.

Bug: 
Change-Id: I8daa94f9a07c15b9301b1ca2a3f8cacdfd7fa894
Reviewed-on: https://chromium-review.googlesource.com/823289
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523930}

This reverts commit b592ae80.

Reason for revert:
Caused LLD assert on Google Chrome Linux x64.

Original change's description:
> Roll clang 318667:320471.
> 
> Bug: 787920
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
> Change-Id: Ifcb76b0d95acc65eafbf58da624f9fbc920f7924
> Reviewed-on: https://chromium-review.googlesource.com/823219
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523910}

TBR=jorgelo@chromium.org,hans@chromium.org,rnk@chromium.org,pcc@chromium.org,rsesek@chromium.org

Change-Id: Icbbd0da2640660ba0529236d5b800d1cfde357f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787920
Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Reviewed-on: https://chromium-review.googlesource.com/826322Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523929}

net/data/verify_certificate_chain_unittest/.

Moves the utility code to net/data/gencerts for easier re-use by other
tests.

Change-Id: Ifa6172def50f185e1a5b7d42e4073e2da003fbd9
Reviewed-on: https://chromium-review.googlesource.com/823288Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523928}

In ARIA 1.1, aria-posinset and aria-setsize was added
to "article" role.

This patch will add above properties to article,
and include some changes for "aria-posinset"
in content_browsertests.

Bug: none
Change-Id: I98647cc4d938a0dcf054290f55bbddbdc7eab087
Reviewed-on: https://chromium-review.googlesource.com/810328
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523927}

This CL updates unit tests as a preparation for
CachedMetadataHandler changes in [1].

This CL
- Calls Resource::SetResponse() in ScriptStreamerTest.cpp and
  V8ScriptRunnerTest.cpp, because [1] will depend on
  SetResponse().
- Sets ResourceResponse's URL, because CachedMetadataHandler
  depends on response URLs.
- Uses http: URLs instead of data: URLs in ResourceTest, because
  CachedMetadataHandler is not set for data: URLs.

These are also natural, as
- SetResponse() is called and response URLs are set in non-test code.
- revalidation never occurs on data: URLs.

This CL also adds ResourceTest.RevalidationFailed, and
adds unit test assertions related to CachedMetadataHandler.

[1] https://chromium-review.googlesource.com/786410

Bug: 784875
Change-Id: Ia58d3c6c9b2ad20c502d8ed9c69d505aa73be03b
Reviewed-on: https://chromium-review.googlesource.com/812569
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523926}

This is workaround for b/70566216 to unblock tests and functionality
until it is properly adrressed. This manually corrects right call order
for ArcAppListPrefs.

Test: Unit tests passed, cheets_AuthPerf passed without perf regression.
Bug: b/70566216
Bug: b/70530828
Change-Id: I18e8455c3e46a7160b7719d1ca400c41cba6f5f9
Reviewed-on: https://chromium-review.googlesource.com/821562Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#523925}

Work around a High Sierra fullscreen bug by getting rid of fractional pixel differences in video aspect ratio.

When a 720x1280 video is made fullscreen on a 1440x900 DIP screen, this
happens to its dimensions:

    720x1280 -[scale]-> 506.25x900 -[integer]-> 506x900

The AVSampleBufferDisplayLayer used for video content layers has its
videoGravity set to AVLayerVideoGravityResize, which doesn't preserve
aspect ratio. Under certain circumstances, the small difference in
aspect ratio triggers a macOS bug with low power detachment where the
video's x position changes rapidly each frame as long as the window
stays in detached mode. I've been able to make it happen if:

- The machine is a MacBook Pro.
- The OS is at least 10.13.
- The display is set to native 2x resolution ("Looks like 1440x900").
- The machine is running on integrated graphics if it has dual graphics.

A recording of the issue is attached to the crbug.

This workaround is sort of terrible and maybe Apple can suggest a better
one: when a video layer's aspect ratio can be made to exactly match the
source aspect ratio by adding a fractional pixel to either dimension, do
so (making sure to keep the video centered).

Bug: 792632
Change-Id: I8b149606cbccb6033c36d3ad400f7a63a4d462ce
Reviewed-on: https://chromium-review.googlesource.com/812114
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523924}

Bug: None
Change-Id: I8d447df58d9231f2b112ef261ee6b522fafe0fc1
Reviewed-on: https://chromium-review.googlesource.com/826047Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523923}

After starting a chrome native app in --mus, the top 33 pixels of the
screen no longer accept mouse input. This was because code that is mash
only (which set the non-client area for a new window) was being run in
all mus contexts, meaning opening an app gave the ash RootWindow a
non-client area.

This was especially bad since a native welcome app is launched on first
login, meaning under --mus, you couldn't interact with the skyline
during your first session.

Bug: 794285
Change-Id: I1dc69dc8fd48fb174ecc1db3198844a74b8a0e44
Reviewed-on: https://chromium-review.googlesource.com/825651Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523922}

Use SystemCookieStoreUtil to provide the requestContextGetter with the correct
base cookie store (either NSHTTPCookieStore or WKHTTPCookieStore).
This means that when WKHTTPCookieStore feature flag is enabled and it's iOS11+
 cookie store will be using WKHTTPCookieStore.

Bug: 779106,759229
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I97695aef8c75d88861d0694c2cf4983447bfe128
Reviewed-on: https://chromium-review.googlesource.com/809744Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523921}

This CL is a step toward using Polymer 2. It converts some uses of <content>
(the Polymer 1 way) to <slot> (the Polymer 2 way of slotting in items).

Bug: 739532
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I745ccd5ace1bde2254ce4daa63e254184281affe
Reviewed-on: https://chromium-review.googlesource.com/820556Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523920}

Bug: 69007670
Test: None
Change-Id: Ia34bfb0d1f6c7dfbb9ea52bfba6c9d14294aa796
Reviewed-on: https://chromium-review.googlesource.com/820637Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523919}

R=dnicoara@chromium.org

Change-Id: I8d0b0827c9622a3ecaaafe33b9784eab201808ef
Reviewed-on: https://chromium-review.googlesource.com/825662
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523918}

In this refactor CL:
https://crrev.com/4f6bce25c2f94e59611343ddab1fffcc13f79f07
overlays got disabled by accident, causing performance regressions
on mac.

BUG=792952

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8acdd0f9157ab4fb31c5cfe62366387cdae7a4ca
Reviewed-on: https://chromium-review.googlesource.com/825702Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523917}

To make ResourceResponse constructible from a KURL only, and
reduce ResourceResponse::Set.*() calls.

This CL merges SetURL() and SetMimeType() calls into the constructor,
and removes redundant |expected_length| and |text_encoding_name|
parameters to the constructor.

Bug: 794651
Change-Id: Id85981184a86c30fe6304453c1158126b09e81c7
Reviewed-on: https://chromium-review.googlesource.com/823262
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523916}

https://chromium.googlesource.com/catapult.git/+log/a51f10541a1c..4b6b02f390d2

$ git log a51f10541..4b6b02f39 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 eakuefner [TBMv2] Clone singular histograms when merging
2017-12-13 dtu [pinpoint] Allow RunTest to use "configuration" or "dimensions".

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic061347ae7eef05aa7d382dc1ea402c5572a6c3c
Reviewed-on: https://chromium-review.googlesource.com/825630
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523915}

With this CL, we should have full Monorail integration, but the switch
is *not* turned on yet ('--auto-file-bugs' needs to be added to the
recipe to actually enable Monorail API).

The CL introduces a simple abstraction for Monorail issues and API,
which also helps testing. Dependencies of Monorail API are introduced
via wpt-import.vpython. See vpython docs:
https://chromium.googlesource.com/infra/infra/+/master/doc/users/vpython.md#script_specific-specification

Lastly, LocalWPT.commit_subject is removed as the information is
already available through LocalWPT.commits_in_range.

Bug: 765334
Change-Id: Ia0f2f8d1ba34301e7756ac6ac25bcae8c4235579
Reviewed-on: https://chromium-review.googlesource.com/820813
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523914}

With --mus the browser process hosts viz so we must directly talk to
HostFrameSinkManager to add a VideoDetectorObserver instead of going
through the ui service which has no access to viz whatsoever.

Tested on my workstation both --mus, --mus=viz and --mash.

Bug: 792575
Change-Id: Ifba73334ddc667af0a2b6076c3add9ada59f3362
Reviewed-on: https://chromium-review.googlesource.com/823103Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523913}

R=dmazzoni@chromium.org, dougt@chromium.org

Bug: 793876
Change-Id: I6bf7e0258aac8dd388e435b7ee123b7ad183c8aa
Reviewed-on: https://chromium-review.googlesource.com/825585
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523912}

This patch is a follow up of crrev.com/770606. We make getProperties
and getIterationEntries non-virtual. To override behaviour, subclasses
just need to implement one function:

    void ForEachProperty(const IterationCallback&);

which should iterate through every property in the style map and
invoke the callback. Both getProperties and getIterationEntries
can be implemented from this function.

This reduces duplicate boilerplate code across different style maps.
Note: Most of the change is combining getProperties and
getIterationEntries and moving the code to StylePropertyMapReadonly

Bug: 785132
Change-Id: I829a50191774a7730b534b8e4cdf419ca935fe8f
Reviewed-on: https://chromium-review.googlesource.com/770674
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523911}