- 04 Aug, 2020 40 commits
-
-
Yue Li authored
QuickAnswersUiController should not try to access the quick answers view in destructor, since the view is owned by view hierarchy. Set the pointer to null instead and added a unittest case for it. Bug: b/162806534 Test: Run the newly added test in ash_unittests Change-Id: Iedc5ca63c178a62b54b55525d5469874e97704c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336495Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#794736}
-
wutao authored
Change the transition animation duration to 500 ms. Bug: b/162782654 Test: manual Change-Id: Ic7ee30843bc04c4666a29e56ff859343acb29b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337376Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794735}
-
Mitsuru Oshima authored
Bug: None Change-Id: I699335142351d8a33e031db7d8d921536d06a3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336496Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#794734}
-
Eric Orth authored
Included a minor change to make DnsQuery copyable because previously only allowed copying while changing to a new ID. Bug: 1112786 Change-Id: Ie2f741358b74fa2629142b76b47f965dc3378fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336300Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#794733}
-
Dale Curtis authored
Per Microsoft, there are threading issues in the older versions of the vpx decoding dlls. R=zmo Bug: 1062849, 1094840 Change-Id: I404c35cfaf7bac714c05f3da11b5f341042e3fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333079Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#794732}
-
Fred Mello authored
https://docs.google.com/document/d/1_hupTnjnQoEnguC1PXv-WJcS9ViVeNJsuWSNWWYYB2c Submitted a request to create a new component in crbug (UI>Browser>Accessibility): https://bugs.chromium.org/p/chromium/issues/detail?id=1112889 Bug: 1112872 Change-Id: I7fb752e14576613bbab1c84754ec4b54444cec3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337256 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#794731}
-
Muyao Xu authored
- Log the current available media sinks users can see in the Cast Dialog when users close the window. - Log when useres start/stop a cast session. - Replace some DLOG()s with the native component logger. Bug: 687380, b/154273698 Change-Id: I383ea07adc0a5b1a9a59898be17127f0cd87dc20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303568 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#794730}
-
Swapnil authored
We want to improve the installation time for force installed extensions. For this, we need to first gather the statistics regarding which installation stages are time consuming. We collect the UMA statistics for the time taken to verify the signature of CRX. Following histogram is added: Extensions.ForceInstalledTime.CRXDownloadCompleteTo. VerificationComplete Bug: 1102369 Change-Id: Ic1b38abcff8557fba1cd1c6b59de716d489355d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336080Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#794729}
-
Yu Han authored
Bug: 1112778 Change-Id: I781e82988f137cdf2edf01634c94510a5642fad4 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335756Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794728}
-
Lei Zhang authored
Check for FPDF_StructElement_CountChildren() result for negative values, which means error. Do not continue on error. Also check the children count earlier in the function, and return early when possible. Change-Id: If7365ef32054bc9d6200482c458cfc2471af8bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337127 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Adam Langley authored
All caBLE work can actually be done in by a single upcall from the content/ layer rather than needing three functions. BUG=1002262 Change-Id: Ibf995b9266808b75101d46960b5a96baf50908b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333867Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#794726}
-
Brian Sheedy authored
Bypasses Skia Gold functionality in all Gold-backed tests, as there appears to be a Gold outage which is affecting bots. TBR=kainino@chromium.org No-Try: true Bug: 1112946 Change-Id: I0ce096473c6378a6771cee16417cfcb600914279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337264Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794725}
-
Matthew Mourgos authored
This change checks whether images to be standardized have a height equal to their width, and if needed, adds padding to ensure the width and height of the image are equal. Bug: 1110496 Change-Id: I2879c0ad821074a30b7a983ae89541a7aade613d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336636Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#794724}
-
Becca Hughes authored
This will open a feedback dialog when clicked. BUG=1111981 Change-Id: I8a7091181231ffb405f0369aa67e423b191bcdf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333371Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#794723}
-
Noah Rose Ledesma authored
The Global Media Controls (GMC) UI will allow the user to change the audio output device used for a webpage. This change adds a method to the RenderHostImpl allowing normal output device authorization to be bypassed for a single device selected by the user. The bypass works by storing a single device id hashed for a particular security origin in the AudioOutputAuthorizationHandler. The result of access permission checks will then be overwritten if the requested device has the same id as what was stored. Bug: 1105132 Change-Id: I9d22e617c502ed8d69fdddc06571017c7ba1f33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295824 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#794722}
-
Rebekah Potter authored
This reverts commit 4af05312. Reason for revert: Breaking ash_unittests and browser_tests on chrome os builders, see https://bugs.chromium.org/p/chromium/issues/detail?id=1112924 Original change's description: > Change hiding timer logic for password textfield on login/lock screen > > 5-second instead of 3-second timer for password/PIN going back to masked format. > 5-second timer will reset upon character being entered to keep the password/PIN visible during revision. > > Bug: 1101326 > Change-Id: I962139aef26bd9fb68e5110d5169d0f486a5bce4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314176 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Thomas Tellier <tellier@google.com> > Cr-Commit-Position: refs/heads/master@{#794602} TBR=rsorokin@chromium.org,tellier@google.com Change-Id: I2cb94561e291ccadf623af2bd4529cd4c9bd23de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337388Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#794721}
-
Jan Wilken Dörrie authored
This change includes the last fixes to fully migrate chrome_cleaner to use std::wstring instead of base::string16 in its implementation. In order to be future proof, this change also adds explicit conversions when interfacing with cross-platform APIs, that rely on using base::string16. Bug: 911896 Change-Id: Id2ffe83831012b7ece1c51457325c151a9310774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333839Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#794720}
-
Claude van der Merwe authored
The "Keep wi-fi on during sleep" setting was deprecated in https://chromium-review.googlesource.com/c/chromium/src/+/2163040. Removed kWakeOnWifiDarkConnect / wake_on_wifi_darkconnect from the code and the setting from the UI. Bug: 1077126 Change-Id: I6753e8296e5fd1652fce0027b8069e41c4a9c87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335481Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#794719}
-
mark a. foltz authored
Replace with more inclusive terms per Chromium style guide. Bug: 1106011 Change-Id: I815f93eab2c860f191827342e6489b80a717c2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335319 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#794718}
-
Rebekah Potter authored
This reverts commit 3cea47a9. Reason for revert: This CL is a likely suspect for breaking fullscreen/compositor-touch-hit-rects-fullscrean-video-controls.html test from blink_web_tests across multiple platforms. Original change's description: > Composite fullscreen videos with composited descendants. > > This fixes the referenced performance regression in which some such > videos stopped being composited. > > Bug: 1108972 > > Change-Id: Ia77d33c1c50cf25427d825ae3969a120a8cde640 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335648 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794573} TBR=pdr@chromium.org,chrishtr@chromium.org Change-Id: I1e1ea71e70e557b867e03f66496bfc97cc182165 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108972, 1112884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337261 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
This also clean some of the code in base/memory/memory_pressure* (as a reply to some comments on one of the early patchsets). Bug: 1105630 Change-Id: I74332c5ada89139a4d73728d65dc24a8b700a97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310906Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#794716}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9969655224d7ca76d5ad35880312095065108d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336905 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794715}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46b0d8780f66..7176f54720e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I37fed8d5dffc78513fc5d4dd762b1ede9c358cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336191Reviewed-by:
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/95d85af7aa56..dd5382a4449c $ git log 95d85af7a..dd5382a44 --date=short --no-merges --format='%ad %ae %s' 2020-08-04 renjietang Change return type of QuicSession::stream_map_size() 2020-08-03 danzh Refactor QuicConnection::UpdatePacketContent() 2020-08-03 danzh N/a add new interface to quic::CertificatePrivateKey. Not protected. 2020-08-03 fayang Neuter CRYPTO data in HANDSHAKE level when discarding handshake keys. Protected by gfe2_reloadable_flag_quic_fix_neuter_handshake_data. 2020-08-03 renjietang Prevent QUIC subclasses from accessing stream_map_.size(). 2020-08-03 fayang In QUIC, when creator is consuming data in fast path, close connection if stream data is sent in the wrong encryption level. Protected by gfe2_reloadable_flag_quic_check_encryption_level_in_fast_path. 2020-08-03 renjietang Deprecate gfe2_reloadable_flag_quic_fix_gquic_stream_type 2020-08-03 fayang Deprecate gfe2_reloadable_flag_quic_stop_sending_duplicate_max_streams. 2020-08-03 fayang Deprecate gfe2_reloadable_flag_quic_fix_undecryptable_packets. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=renjietang@chromium.org Change-Id: Ifde4e2cc1c02d63f50055b2c11631d6a7e9b5a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336016Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794713}
-
Fred Mello authored
https://docs.google.com/document/d/1dlgqV5__s8Jyl-YmmmMhRaOp8NwVQ8_Y_O44cKR14ak Bug: 1112872 Change-Id: I542c37f03d3f33cce0765a06223c322fbfaee493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336297 Commit-Queue: Fred Mello <fredmello@chromium.org> Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#794712}
-
Ahmed Mehfooz authored
Bug: 1111484 Change-Id: I05a1629833f26b03092d61b0db419e26dcbb4345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331516 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#794711}
-
Avi Drissman authored
Do comparisons on int-casted enums; it's easier to work out what's going wrong if you don't have to convert from hex. Use explicit capturing in the lambda; it's clearer than the implicit reference capture. This does not change the functionality of the test. It still fails on Big Sur but it's more clear how it fails. Bug: 1101426 Change-Id: I3a636129b62589b5cbccb5779c1e23920fc9da1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337106 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#794710}
-
Changwan Ryu authored
For Android L and M, we use a complicated mechanism to activate keyboard such that we can use IME thread to block on synchronous IME requests. This mechanism has been regressed by some change in AndroidX. When the content view is coming back from a recycler view based window, the IME gets activated, but the logic in the old window seems to dismiss the IME after some delay. There are about 20% users who are using L and M, but as no one is maintaining the framework code, it is extremely challenging to debug Android L and M framework code to understand this further at this point, so landing a workaround to delay IME activation, which seems to fix the problem. Note that this only applies to the specific scenario of 1) Window focus loss 2) (Optional) view focus loss 3) View focus gain 4) Window focus gain to minimize the impact. Bug: 1108237 Change-Id: I3da5a17b69e49fd16e773e8dfa8535ac474de818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335822Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794709}
-
Jonathan Mengedoht authored
Implements the behaviour for .well-known/change-password urls, analogous to the WellKnownChangePasswordNavigationThrottle Bug: 927473 Change-Id: Ib3eed87306ed6b3b5bc1f49f4aa8b91369c614dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317952 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#794708}
-
Hiroshige Hayashizaki authored
This CL also removes ScriptState::Scope and isolate null checks that look unnecessary. Bug: 1111134 Change-Id: I89ae40f566ca68acbc0ee9a70b6f479214c063e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331758 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794707}
-
Lan Wei authored
We will add a new input source type to simulate the mouse wheel scroll to the Webdriver Action API, https://github.com/w3c/webdriver/pull/1522. In this CL, we are adding the wheel input source in the ChromeDriver's ExecutePerformActions function, which implements the Webdriver Action API in Chrome and we will use Devtool's input protocol, Input.dispatchMouseEvent with a type of "mouseWheel". I added some waiting time to wait for the action to be executed to fix the failure on Mac 14 test. TBR=johnchen@chromium.org Bug: 1040611 Change-Id: I348c71bacc32b403ba995c1c736b6bfb230b65aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337255Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#794706}
-
Joel Hockey authored
Currently we are only allowing users to open files with a Windows app if the file is within 'Windows files'. This is changed to allow any files in dirs which are already shared. Note: We do not automatically share files when they are opened with a Windows app as we do for crostini since Windows apps require the entire dir to be shared in order to allow file dances. Bug: b/162771563 Change-Id: Ib2dc963c33629be896638ae3b0b8776295115745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336333 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794705}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a50dc7ad. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" 14e278af "Revert "Reland "Use border box or layout overflow rect for layout shift tracking""" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I33da7c014ca2debe63945a37e1e5d2f0adbd7f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337153Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794704}
-
Mike Wittman authored
The last executable offset calculation was assuming that the ELF image's relocation offset is always equal to its base address. This is not true for non-relocatable images, or those with load-bias. Expose and use elf_reader.cc's GetRelocationOffset() to fix this. Bug: 1105170, 1101023 Change-Id: I0d1e49ccf665173b8f0836e9df9eb545f864ba31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305590 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794703}
-
Brian Malcolm authored
By making TypeCheckingPolicyHandler, SchemaValidatingPolicyHandler, and SimpleJsonStringSchemaValidatingPolicyHandler all derive from the same class we can allow SimpleDeprecatingPolicyHandler to work with all of them. BUG=chromium:1112810 Change-Id: I67a75965c123989e227efc7a9fad47bd4b7f405e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337118 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794702}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4fdf56254f58..a0c3f906bc6f 2020-08-04 tandrii@google.com Roll lucicfg tool to @ 61acc468 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112433 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3f2dca7a6fb4d49ca2221e6face82cbfdfbbf9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336903Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596542250-9615b306cb5f76d5a757426ea1c30fa3bd674a0e.profdata to chrome-win32-master-1596549454-7f993c1fb49036aa3a3eb3f7c44ae7cd093767bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I05a29c0816f9f22cbd6aafa40a7ea88e4b15a583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336900Reviewed-by:
-
Daniel McArdle authored
The wav_audio_handler_fuzzer constructed an input that causes ParseWavData to get stuck in an infinite loop. On this input, ParseWavData's |offset| variable kept overflowing into a smaller value before the loop condition (offset < total_length) could become false. This CL hides the pointer arithmetic inside a base::BigEndianReader and byteswaps integers that were actually little-endian to recover the correct values. Bug: 1112100 Change-Id: Ia4a6c987888d748db4962e4e38fb8ceb0e290e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335563 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#794699}
-
Yuke Liao authored
linux-lacros-compile-rel mirrors linux-lacros-builde-rel, which is defined under chromiumos instead of linux. Bug: 1104318 Change-Id: Iebaa73683f811c737695275b6f21f273f86cdf5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335029Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#794698}
-
Fred Mello authored
https://docs.google.com/document/d/1dx_0f2sILQWO0hsDI9gROEJ_MNqNXhk99mx9utfHR9M Bug: 1112872 Change-Id: I7608dfa677fd50e5f0f99a1ad8f40a12e7a93924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337098Reviewed-by:
-
