- 17 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/da2f64ae4a74..064614205d70 git log da2f64ae4a74..064614205d70 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 janscheffler@chromium.org Add localized error to selected network rows 2019-12-17 szuend@chromium.org Revert "Let console asserts show up in the test results" 2019-12-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. 2019-12-16 janscheffler@chromium.org Remove line from BUILD.gn 2019-12-16 aerotwist@chromium.org Migrates internal refs of ui/ to esm 2019-12-16 tvanderlippe@chromium.org Let console asserts show up in the test results Created with: gclient setdep -r src/third_party/devtools-frontend/src@064614205d70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1030258 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I564f1d2a1cbefecc861a89875d1b8463f4eaa552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725470}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibe75c49875fd59b44b1e746a11d79f66f9e997c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971259Reviewed-by:
-
Virender Singh authored
This CL moves MockRenderThread::IsUseZoomForDSF implementation to be consistent with declaration order. Bug: 1007169 Change-Id: Iae5cc30bd5320a6c1f7780dddd13fafde21b1e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952783Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#725468}
-
Eugene But authored
Remove references from GN to files which no longer exist. Bug: None Change-Id: I4e6f63d3d4daf34bfb5371c716ed059bd0cc8c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969056 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#725467}
-
Sigurd Schneider authored
Previously, blink would react to the v8_enable_raw_heap_snapshots flag, but this flag is about to get deprecated, as the option may be controlled via an argument to V8's inspector interface in the future (takeHeapSnapshot). Bug: chromium:1034504 Change-Id: I9fd6082853ce1e80214f236d5f50bd620bafbbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969579 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#725466}
-
Kuo Jen Wei authored
Focus to confirm button right after entering review video page. Focus to confirm button after play button hidden. Bug: 1020239 Test: Manually test with chromevox. Change-Id: Ibb33be2cc6648bde4c4cc33b11e3411ee42f798a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971299 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#725465}
-
Peter Marshall authored
There are potential ordering problems with sending all messages over the IO session, as it is not associated with the DevToolsAgent mojo interface, like the normal session is. We don't actually need this part to fix the bug we're trying to fix so this CL reverts that part of the change. Bug: 1010534 Change-Id: I8509a283dc454e53275e83f60f3f3c1c0c1df1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967184Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#725464}
-
Oriol Brufau authored
If a marker uses viewport units (vw or vh), they should be recalculated when the size of the viewport changes. This patch updates node traversal methods to include ::marker, so that it's taken into account when updating viewport units. However, this is only fixed for markers with non-normal content, since otherwise they aren't implemented as real pseudo-elements yet. BUG=457718 TEST=external/wpt/css/css-pseudo/marker-content-014.html The test still fails because it includes cases with 'content: normal'. Change-Id: I7495dd5c4bbd84d6286635a63199bfcc663c62c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970015Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#725463}
-
Benoît Lizé authored
A recent change (see crbug.com/983348) made the allocation of discardable memory return nullptr in some cases, instead of crashing. Skia is not expecting this, triggering a nullptr dereference. This goes back to the previous behavior (crash in case of allocation failure), while the proper fix is to make skia expect a nullptr return value. As a consequence, this fix is temporary until upstream skia is updated. Bug: 1034271, 983348 Change-Id: Idc3937898e897a19ca4e6793ab4e79626fe1b319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968985Reviewed-by:
Mike Reed <reed@google.com> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#725462}
-
Ilia Samsonov authored
Manual tests should not flake on win bots anymore. Bug: 993020 Change-Id: Ia9e8109cc062afd43622f319a50e902c7fc4cc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966287 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#725461}
-
Frédéric Wang authored
No behavior change. Bug: 6606 Change-Id: I94cc3088f8aa8d670261a4d9f12293245e8a051b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970611 Auto-Submit: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rob Buis <rbuis@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#725460}
-
Tomasz Moniuszko authored
This fixes testing namespace mismatch in base/test/test_suite.h. Bug: 1033442 Change-Id: Iaa9d621dffc8a5e17d3357e9307f0cf834b23f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963853Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#725459}
-
Sergio Villar Senin authored
We are doing this as part of the removal of individual file dependencies from chrome/browser/DEPS. The web_input_event.h file has many dependencies that could prevent it from moving to public/common (as common cannot depend on other parts of blink). We can remove most of them to the files which actually have dependencies. Bug: 1008303 Change-Id: I51839f97473363ca86132d548ad5882eb17e1013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969673Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#725458}
-
James Cook authored
Chrome OS SplitSettingsSync has a separate control for syncing OS data types that isn't controlled by the browser's sync-the-feature. Change ModelType::WEB_APPS to run using the transport layer when kSplitSettingsSync is enabled and the OS sync feature is on. Manual test: Run chrome --enable-features=SplitSettingsSync,SyncManualStartChromeOS, DesktopPWAsWithoutExtensions,DesktopPWAsUSS Add an account Enable OS sync in the first-run dialog Verify chrome://sync-internals shows Web Apps are syncing, even though browser sync is off. Also added automated tests to sync_integration_tests. Bug: 1013466, 1031549 Change-Id: I2cdb4ccf6b4027ce45044d945f02913482ad239d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970290 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#725457}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/96354f5047bf..38d7fbaad0a3 git log 96354f5047bf..38d7fbaad0a3 --date=short --first-parent --format='%ad %ae %s' 2019-12-16 afdx@google.com spirv-fuzz: Transformations to add types, constants and variables (#3101) 2019-12-16 greg@lunarg.com Make Instrumentation format version 2 the default (Step 1) (#3096) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@38d7fbaad0a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I1c000795bd1a56663a5cd581a3bc5cc19e873fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971258Reviewed-by:
-
Mario Sanchez Prada authored
This CL migrates the code using the unsafe static_cast to using the new mechanism to downcast to subclasses of WebUIController, implemented in crrev.com/c/1959199. Bug: 1006361, 1002647 Change-Id: I72797397f0427450b988897335c43903a96dc80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962253Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
Now that all the Fourcc producers return only valid instances, we can remove the invalid Fourcc constructor as well as the invalid state itself. Bug: 1031082 BUG=b:143498574 Test: Chromium builds for arm-generic and Eve. Change-Id: Ic603fbe3e8e50a2d88eeaf851261d26021a1358c Change-Id: If3960b8f56269109a15e2f82f39cf456b5b61528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961303 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#725454}
-
Alexandre Courbot authored
ToVaFourCC() is not guaranteed to return a valid value for any of the Fourccs we recognize, so make it return an Optional in case the conversion cannot be performed to force the user to check the returned value. BUG=1031082 BUG=b:143498574 TEST=Chrome compiles on Eve. Change-Id: I6910fccc871bb3baf86ca8ed1431419cfbc7743b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957200Reviewed-by:
-
Kent Tamura authored
- Update comments - Remove unnecessary code - No 4th argument - No need to unlink the original generated header because it must have been renamed to foo.h. - We don't need to try *.cpp.h and *.hpp because now we require Bison 3.4 or later. - Rename variables for better readability This CL has no behavior changes. Change-Id: I4f825a3ea5cf006d60c6c765c33a6de3d579f4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971300Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#725452}
-
Jan Scheffler authored
This cl updates the testresults for crrev.com/c/1959000. Tbr: yanngguo@chromium.org Bug: chromium:1026879 Change-Id: Ieee4172ea5a9485dc0f20c6daaf4b7a378a7984e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967237 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#725451}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/304bb2fe9236..bd963dc11651 git log 304bb2fe9236..bd963dc11651 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 eseckler@google.com Merge "build/logging: Disable info logs in chromium" Created with: gclient setdep -r src/third_party/perfetto@bd963dc11651 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I31dd23914c3ed634f316af79c7704385e7534edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971257Reviewed-by:
-
Kent Tamura authored
If an implementation applies Unicode careless comparison incorrectly, 's' can be matched to U+017F. Bug: 627682 Change-Id: I9dd26abea13d06a2067e834a902aea76b3421c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971185Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#725449}
-
Hitoshi Yoshida authored
Also updates some BUILD.gn files to stop the current IDL compiler generate code of dictionaries, if |use_idl_compiler_v2_for_dictionary| is set true in gn.args. Bug: 839389 Change-Id: I69bd10cf4e7f57cd1d9873c4b2202a917ed67ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969318 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#725448}
-
Kent Tamura authored
Make it match to Blink Python style. - Rename variables - Wrap the top-level code with main() function This CL has no behavior changes. Change-Id: If7f7fdba757e03b71b3d7c386de6771ad98fb3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971293 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/45a70dc772a6..ba22253ee917 git log 45a70dc772a6..ba22253ee917 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 dberris@chromium.org Reduce calls to Change.FromDict(...) Created with: gclient setdep -r src/third_party/catapult@ba22253ee917 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1034373 Tbr: rmhasan@google.com Change-Id: I3985c2ade3f91635254a640cd1bfa767c2bda31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971252Reviewed-by:
-
Ken Rockot authored
Fixed: 1007751 Change-Id: I9d0d2ddea7c44ca218652d0417c1019ae8db51d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970576Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#725445}
-
Kent Tamura authored
In order to follow Blink coding style as much as possible, - Rename token types from UPPER_SNAKE_CASE to kCamelCase - Rename %parse-param from 'parser' to 'parser_'. It becomes a data member of the generated YyParser class. This CL has no behavior changes. Change-Id: Iaedbfdf68346b8a0b96960a72e689340ed22dfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971187Reviewed-by:
-
Mitsuru Oshima authored
Bug: 1032899 Test: covered by unittest Change-Id: Ie96d7ba7237aa466a1f3b9039240b24f9f07f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961578 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#725443}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.66-1575889638-benchmark-80.0.3987.5-r1 to 80-3987.0-1576496920-benchmark-80.0.3987.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0234f9aa4ebee78d41925538d9a32d3f65e6e501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971256Reviewed-by:
-
Jiewei Qian authored
This relands https://crrev.com/c/1955247. Some refactors in origin CL breaks official build tests, they are deferred to https://crbug.com/1034361. Original change's description: > Revert "system-web-apps: add support to pass launch_files to running Apps" > > This reverts commit 42bdc71e. > > Reason for revert: https://crbug.com/1034456 (All/SharedPWATest.MixedContentInPWA/1 failing on linux-chromeos-chrome bot) > > Original change's description: > > system-web-apps: add support to pass launch_files to running Apps > > > > - Clean up ShowApplicationWindow logic, split it into sub functions. > > - Remove SetInitialFocus, which is no longer necessary. > > - Remove extra HostedAppBrowserController::SetAppPrefsForWebContents > > during app launch. HostedAppBrowserController already does this. > > - Set launch files before showing the window. > > > > Fixed: 1023742 > > Change-Id: I074a917bb0ed557d1a967a04cb3042c9ee29113b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955247 > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#725054} > > TBR=msw@chromium.org,ericwilligers@chromium.org,ortuno@chromium.org,joelhockey@chromium.org,qjw@chromium.org > > Change-Id: Ic5e4c4afec085827e7ac879bd1f67f84e100be4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969341 > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725069} TBR=msw@chromium.org,ericwilligers@chromium.org,ortuno@chromium.org,joelhockey@chromium.org,hendrich@chromium.org,qjw@chromium.org Change-Id: I1753cb42ff8b47d4862cffa7677784df1b8fb88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971046 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#725441}
-
Nate Fischer authored
This creates AwStabilityMetricsProvider, which listens to content layer notifications to implement some stability metrics. This is a subset of what ChromeStabilityMetricsProvider does at the moment. This now implements: * system_profile.stability.launch_count (all that was necessary was to persist a pref) * system_profile.stability.page_load_count * system_profile.stability.renderer_hang_count * system_profile.stability.renderer_launch_count Other stability fields will be implemented in a follow-up change. Fixed: 994834 Bug: 994839 Test: run_android_webview_unittests --gtest_filter=AwStabilityMetricsProviderTest.* Test: Manual - verify fields with AndroidX demo app Change-Id: Ibf199889b2caf138c62a6aee71749a3cefbbb625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966697Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#725440}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3945.66-1575891900-benchmark-80.0.3987.5-r1 to 80-3987.0-1576497572-benchmark-80.0.3987.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If1ffa0bb8535f66e40feb09f74997acb87888782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971253Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6153165d78f2..fdb2b7d53038 git log 6153165d78f2..fdb2b7d53038 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 herb@google.com Add more thread annotations to SkStrike 2019-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d1860ea17e8e..5407aaa089ac (11 commits) Created with: gclient setdep -r src/third_party/skia@fdb2b7d53038 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I3e2869d32502c01df2b38462dd112b4fef6a27de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971250Reviewed-by:
-
Alan Cutter authored
ShowPWAInstallBubble() was assuming the browser for the WebContents had a PWA install icon when this is not always the case. Bug: 1033608 Change-Id: I29026b6cacbfc6f73a84e62935f395df11eacbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970306 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#725437}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/408a0c7a..29760046 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icee17c1aad134f9565b3e66c27dbc1bc3c217413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970148Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725436}
-
Fergus Dall authored
memlog_browsertest.cc includes //chrome/common/chrome_switches.h which depends on a generated //chrome/common/buildflags.h, but does not specify this dependency in its BUILD.gn. Because of this, the build will sometimes fail, depending on the order objects are built in. TBR=ajwong@chromium.org TBR=alph@chromium.org TBR=erikchen@chromium.org Bug: 952918 Change-Id: I3d9e80b9e32fe32f008299b047f5ada815d51f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971183Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#725435}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_party/blink/renderer/core/layout only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - CustomScrollbar::CreateCustomScrollbar Bug: 939691 Change-Id: I8d36d02e45569591cf40aaa90b8206090b704b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971032Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#725434}
-
Fergus Dall authored
TBR=layout-dev@chromium.org Bug: 1034839 Change-Id: I4213c437d76e9868f50b1525a6d2ac7b6d1d6456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971176Reviewed-by:
-
Timothy Loh authored
Change-Id: I951eec1d645a17278742386e58a24bd4883daf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971182Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#725432}
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I8e40c2f97ac725ff1db8e3ee50e0ca62a3877d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970143 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
