GitLab

It is uninteresting to fuzz messages received from the trusted broker process
to non-broker client processes. On Windows it's also effectively impossible
to safeguard against invalid HANDLE transmissions in such cases, and this is
the mode the existing channel fuzzers have effectively been emulating. The
result is crashy fuzzers.

This changes the Channel and NodeChannel fuzzers to more closely emulate the
trusted broker environment, where junk HANDLEs from untrusted clients can be
effectively detected and discarded without risk of crashing.

Bug: 925213
Change-Id: I562df5e3b97b3f109a649b34300cbbe18d2151f0
Reviewed-on: https://chromium-review.googlesource.com/c/1436887Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#626260}

1. make updates so that the ChromeVox menus are up to date (e.g. remove the prefix key command, remove the ChromeVox activate/deactivate command from the menus).
2. apply the |disallowOOBE| bit to appropriate commands; remove it from the help command.
3. add support for |disallowOOBE| to CommandHandler

Bug: 921803
Change-Id: Ia3ff73c90b2c4aa94a455ccd9cc15ec20f4c0a41
Reviewed-on: https://chromium-review.googlesource.com/c/1436016
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626259}

TBR=piman@chromium.org

Change-Id: I8b7e62b44c596e95f14a4644c27bc4e99d883a5e
Reviewed-on: https://chromium-review.googlesource.com/c/1432293
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626258}

Use the IdentityManager and observe events from IdentityManager::Observer
to replace all direct usage of AccountTrackerService's APIs, leaving for
now just a reference to AccountTrackerService, required to initialize the
chromeos::AccountMapperUtil private member from the constructor.

Bug: 922785, 922786
Change-Id: Ieec3c3818a6993739fa204b112add0e5cc2f7f7b
Reviewed-on: https://chromium-review.googlesource.com/c/1437194
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626257}

This code change results in a nearly 50% speedup of the
line_breaks test in blink_perf.accessibility by avoiding
the use of Positions.

Also fixes CSS first-letter accessibility, the inline text
boxes were missing the first letter and in fact the
Layout NG code seemed to have extra logic to duplicate
the broken behavior.

Bug: 921789
Change-Id: I58a21de6286e040ba0c10a9a591932de52908fa5
Reviewed-on: https://chromium-review.googlesource.com/c/1419222Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626256}

Make sure we use the correct format/usage bits when using AImageReader
with videos requiring a secure surface.

R=liberato@chromium.org

Change-Id: I898535f38e1d2e8d1693c52e1e4c2aa01486cca8
Bug: 889328
Reviewed-on: https://chromium-review.googlesource.com/c/1428407Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626255}

Flyby fix, test was crashing with
dbus[37655]: dbus message iterator has already been closed, or is uninitialized or corrupt

BUG=None
TEST=chromeos_unittests --gtest_filter=ShillManagerClientTest.GetNetworksForGeolocation

Change-Id: Ifc50110746348ecb917f0beb09c1351eb9be36c5
Reviewed-on: https://chromium-review.googlesource.com/c/1436045
Auto-Submit: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626254}

Flow:
1. AndroidTelemetryService::OnDownloadCreated called on UI thread.
   Calls MaybeCaptureSafetyNetId() on the UI thread.
2. If safety_net_id_on_ui_thread_ is already set, END.
   Otherwise, schedules SafeBrowsingDatabaseManager::GetSafetyNetId on
   the IO thread and the result of that is scheduled to go to
   AndroidTelemetryService::SetSafetyNetIdOnUIThread on the UI thread.
3. When SetSafetyNetIdOnUIThread() gets called, it sets
   safety_net_id_on_ui_thread_ on the UI thread.

Also, if chrome://safe-browsing is open, sends CRSBLOGs to DLOG also.

Bug: 907280
Change-Id: Id65ed62817f37ed911e5b3b8a623bc1e1c74ea5f
Reviewed-on: https://chromium-review.googlesource.com/c/1436186
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626253}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfb698e79191..4420ef0c7306


Created with:
  gclient setdep -r src-internal@4420ef0c7306

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I11751ea6a93a18c2eb352b278fcf8b3fb38c1dc4
Reviewed-on: https://chromium-review.googlesource.com/c/1436763Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626252}

This reverts commit d0364f52.

Reason for revert: Branch point is over. Button titles should be re-enabled.

Original change's description:
> [Password Generation] Disable button titles calculation in Beta, Stable
>
> Button titles are not used in Beta, Stable channels at the moment. They will be crowdsourced later (as a part of crbug.com/896719).
> Button titles inference is expensive, especially, for <form>less forms. See the metric PasswordManager.ButtonTitlePerformance.NoFormTag. This will be fixed as a part of new parser refactoring.
> This CL temporarly disables button titles before branch point.
>
> Bug: 910546
> Change-Id: I55ac7d3bcbdc895e165cd3a46288fe089b558967
> Reviewed-on: https://chromium-review.googlesource.com/c/1432854
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org>
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625600}

TBR=dvadym@chromium.org,kolos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=dvadym@chromium.org

Bug: 910546
Change-Id: I16766fbd93ce627b5385965ce334f78c59a04631
Reviewed-on: https://chromium-review.googlesource.com/c/1437614
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626251}

Validate the profiles as soon as their validity states become out of
date and before updating the database. Also,
- Refactoring the personal data manager unittests.
- Validator should have a copy of the profile, as the pointer may
get out-dated.
- Handle delayed validations.
See go/af-pdm-scheduling for explaining the algorithm.
See go/autofill-use-validation.
Bug: 899254

Change-Id: If8a173302ec0766a4a549efa84faa4885d546b8c
Reviewed-on: https://chromium-review.googlesource.com/c/1395832
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626250}

When forced mirror mode for tablets is enabled, external
displays should not be considered as candidates for mirror
mode restore.
This CL also fixes an issue with display prefs being saved
when they should not be during forced mirror mode for tablets.

BUG=919994
TEST=Added new test.

Change-Id: I3e2bfc7ec7339baa19e4a0f43a753d30fe1cb7f5
Reviewed-on: https://chromium-review.googlesource.com/c/1436142
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626249}

This is the second out of two CLs that convert
user_policy_signin_service_unittest.cc away from using SigninManager and PO2TS
APIs directly, in favor of the IdentityManager APIs.
The first CL migrated it away from SigninManager in [1]

[1] https://chromium-review.googlesource.com/c/1301814

At this time, the CL makes use of a newly added IdentityTestEnvironment API
named IsAccessTokenRequestPending to keep the testing functionality unchanged.

BUG=916262

Change-Id: I9fbea90856313b442c26ec24929f1ad08896eee7
Reviewed-on: https://chromium-review.googlesource.com/c/1418818
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626248}

https://pdfium.googlesource.com/pdfium.git/+log/148c14459dd2..578e24839231


git log 148c14459dd2..578e24839231 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 tsepez@chromium.org Store properties/attributes in CXFA_Node as span<>
2019-01-25 tsepez@chromium.org Pass attributes and properties to CFXA_Node as span<>


Created with:
  gclient setdep -r src/third_party/pdfium@578e24839231

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3918dc0d1e1ea47bd57bf88041835f86825abcc0
Reviewed-on: https://chromium-review.googlesource.com/c/1435725Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626247}

LoginInterstitialDelegate should take a OnceClosure, and all these
static methods (probably predating base::Callback) can be normal
methods.

This is some small cleanup to make the upcoming big change to
LoginHandler smaller.

Bug: 908926
Change-Id: Idec46fe691ac82b298ed6e90f8e5bcaac31e4a32
Reviewed-on: https://chromium-review.googlesource.com/c/1388039
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626246}

Gab, I've used your refactoring script for this, the rule is:
  content = refactor_lib.ReadFile(file_path)

  # Assume fwd-decls are correct in first pass.
  if 'class OneShotTimer;' in content:
    return False

  if 'class RepeatingTimer;' in content:
    return False

  if 'class RetainingOneShotTimer;' in content:
    return False

  matches = re.compile(r'(\n *[^/\n][^/\n][^/\n]*base::(OneShotTimer|RepeatingTimer|RetainingOneShotTimer)\b[^*])', re.DOTALL).findall(content)

  if not matches:
    return False

  found = False
  for match in matches:
    constant = 'YADAYADA'
    match_mod = match[0].replace('OneShotTimer', constant).replace('RepeatingTimer', constant).replace('RetainingOneShotTimer', constant).replace('const ', '')
    if not 'std::unique_ptr<base::%s' % constant in match_mod:
      found = True
      break
  if not found:
    return False

  updated_content = refactor_lib.AddInclude(file_path, content, "base/timer/timer.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

TBR=gab@chromium.org

Change-Id: I5a6a19371e5d7dc864ce9c8ae117e9ee9d54dd80
Reviewed-on: https://chromium-review.googlesource.com/c/1435748Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626245}

https://chromium-review.googlesource.com/c/chromium/src/+/1432881
changes the shield widget not be animated if the wallpaper blur is not
animated, and also delays the creation of the shield widget in some
cases. This CL adds a test for that logic.

Test: ash_unittests OverviewSessionTest.GridShieldAnimation
Bug: 924395
Change-Id: I0a9bbc415def682b7450d612b70a98ab6cdec1b4
Reviewed-on: https://chromium-review.googlesource.com/c/1432874
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626244}

Bug: 887150
Change-Id: Ic388bcf3a0bbce983f5537640d4cfe2b5affbd95
Reviewed-on: https://chromium-review.googlesource.com/c/1418732Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626243}

This patch adds updateAndCommit() which updates the subtree cooperatively
and then commits.

R=chrishtr@chromium.org

Bug: 882663
Change-Id: I14b906ff1ccf2ed57df082bfe883bb5d4c6e9ac3
Reviewed-on: https://chromium-review.googlesource.com/c/1422867
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626242}

This logic isn't needed any more, since cloud destinations get
fetched when login state changes, and we update the recent list when
destinations are inserted. It may also be contributing to some bugs
that so far are not reproducible.

Bug: 923914, 924889
Change-Id: Ibfef7f183a66da373d7d7f4775896d9ba39c22c3
Reviewed-on: https://chromium-review.googlesource.com/c/1436193Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626241}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60574b5f91b9..db34d87aff44


git log 60574b5f91b9..db34d87aff44 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@db34d87aff44

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ie46749243c66a9a6b7def0fe7044fcb4b084171e
Reviewed-on: https://chromium-review.googlesource.com/c/1437397Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626240}

There are no metrics being recorded for clean task completion (ie. no
chrome crashes or OOMs during task running). This cl adds new
start/finish metrics to native background task in order to get a
percentage of tasks that fail unexpectedly.

Bug: 924644
Change-Id: Ic1a70ff5aad5aca633c5e50ed32b1dc53b60120f
Reviewed-on: https://chromium-review.googlesource.com/c/1428092
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626239}

Bug: 924341, 923634, 924539, 924811, 924866
Change-Id: I66c22718e7c0cdad0195504ee897a3991e1208f0
Reviewed-on: https://chromium-review.googlesource.com/c/1437054Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626238}

Clusterfuzz doesn't like it when there are two SimpleMenuModels in
existence. This CL fixes the reported TSAN crash, although I don't
completely understand why.

Bug: 918794
Change-Id: Ia3d9b341a1dc42cb8a956c283cac381dbb28e48c
Reviewed-on: https://chromium-review.googlesource.com/c/1435712Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626237}

Using wpt-import in Chromium 37c22eb5.
With Chromium commits locally applied on WPT:
f643497e "[resource-timing] Modify is_secure_context_ based on resource"
20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix"
40748e1e "Upstream fast/workers to external/wpt/workers: first batch."
6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I8d9aab2c79610e5284f7d36611b6e7d08e5ec089
Reviewed-on: https://chromium-review.googlesource.com/c/1435703Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626236}

Wrap the callback that notifies of changes instead and trigger updates
off of that. Remove the notion of Disabling the ETW exporter itself,
instead just use whether the provider is enabled or not.

Leave the flag for now and continue to conditionally enable. Follow
up change will remove the flag and always have the ability to export
trace events to ETW.

Bug: 781991
Change-Id: Ifb0d3c5669fca255ca4c0bcd9f84e4034995761b
Reviewed-on: https://chromium-review.googlesource.com/c/1423559Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#626235}

See bug for spec and screenshots.

Bug: b:123376557
Change-Id: I57a92c76edd72fbb2ed427483834aead6ab330cd
Reviewed-on: https://chromium-review.googlesource.com/c/1436183Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#626234}

https://chromium.googlesource.com/catapult.git/+log/1879ca54b916..514fe3e70db8


git log 1879ca54b916..514fe3e70db8 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 behdadb@chromium.org 95% Confidence Intervals for mean statistic:
2019-01-25 perezju@chromium.org [Telemetry] Remove video capture feature


Created with:
  gclient setdep -r src/third_party/catapult@514fe3e70db8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:908893,chromium:921000
TBR=sullivan@chromium.org

Change-Id: Ie1f76f37bd0f344d4ac0ed6673e4c5e12eaa4b4f
Reviewed-on: https://chromium-review.googlesource.com/c/1437012Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626233}

The observer uses a repeated field because a tab or window can be
backgrounded and foregrounded multiple times.

Bug: 921703
Change-Id: If03a3444a237d7c5abf0740a0a3c9c684caea013
Reviewed-on: https://chromium-review.googlesource.com/c/1421681Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626232}

Since the patch in CL1406976 for crbug.com/833797 landed (see [1]), there
is not any need to monitor this event since AccountManagerUIHandler is no
longer taking accounts out of the UI while data is being fetched, and so
there is no need to do this extra effort to make sure that such accounts
were added back once that fetch was complete.

Additionally, removing this method now paves the way to migrate away from
AccountTrackerService APIs entirely from AccountManagerUIHandler, and use
IdentityManager's APIs instead, so let's do it now as a precursor CL.

[1] https://crrev.com/c/1406976

Bug: 922785
Change-Id: I068e89eb7fa7774c3be0f9bf67e02a0b8dfb642d
Reviewed-on: https://chromium-review.googlesource.com/c/1437175Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#626231}

The callback received by this method as a parameter is only meant
to be run once, so let's make it a base::OnceCallback to be more
explicit, and to make the lifetime of such callback more clear.

Bug: 924102
Change-Id: I3492b59c055d61ed91c65a0b5d9418c925048213
Reviewed-on: https://chromium-review.googlesource.com/c/1429984Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#626230}

This ensures that the 'wake-lock' feature is not parsed in feature
policy directives unless the WakeLock runtime flag is enabled.

Bug: 925454
Change-Id: Ic8043be2f499295f4246d99866180c2aab222ad7
Reviewed-on: https://chromium-review.googlesource.com/c/1436201Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626229}

AudioSinkAndroidAudioTrackImpl::SetPaused() only checked
pending_data_bytes_already_fed_, whereas FeedDataContinue() requires
both this and that pending_data_ exists. Hence we protect this call with
an additional check on pending_data_.

AudioVideoPipelineDeviceTest.Mp4Playback and
AudioVideoPipelineDeviceTest.PcmPlayback both pass reliably on android.

Bug: internal/123356146
Change-Id: Ibb562ab04c9dca1fdaca5b4df743b4a59ec49cbb
Reviewed-on: https://chromium-review.googlesource.com/c/1437192
Auto-Submit: Nate Steinbock <steinbock@google.com>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626228}

https://skia.googlesource.com/skia.git/+log/094ab18b457e..d41c1876d834


git log 094ab18b457e..d41c1876d834 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 borenet@google.com Add chromium_revision tag to SKP CIPD package
2019-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 59b1ed4a60fc..59d756e530c5 (1 commits)
2019-01-25 brianosman@google.com Remove --readPath/-r from DM
2019-01-25 bsalomon@google.com Actually reuse GrTexture if SkPromiseImageTexture used with multiple
2019-01-25 brianosman@google.com Switch DM JSON output to use SkJSONWriter
2019-01-25 bsalomon@google.com Remove GrGpuResource::abandon from the public API.
2019-01-25 bsalomon@google.com Change the meaning of GrBudgetedType::kUnbudgetedUncacheable.
2019-01-25 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2019-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6ab37b0f2ca0..86f8bdb2934c (1 commits)
2019-01-25 bsalomon@google.com Require explicit GrWrapCacheable specification in more places.
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 76e400246439..6ab37b0f2ca0 (1 commits)
2019-01-24 ericrk@chromium.org Invalidate Vulkan CB state after vending it out via drawable
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9d803dd2..7fafb7b5 (477 commits)
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 47ca1b2fa399..59b1ed4a60fc (1 commits)
2019-01-24 bungeman@google.com Use only icu c api in shaper.
2019-01-24 bsalomon@google.com Replace bool purgeImmediately with enum GrWrapCacheable.
2019-01-24 halcanary@google.com gm: delete boilerplate
2019-01-24 hcm@google.com Update Skia milestone to 74
2019-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4806a9be530f..76e400246439 (1 commits)
2019-01-24 brianosman@google.com Remove SkColorSpace::Gamut enum
2019-01-24 brianosman@google.com Remove nearly all use of SkColorSpaceTransferFn
2019-01-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-01-24 djsollen@google.com Revert "Implement XP factory dumping"
2019-01-24 halcanary@google.com gm: use DEF_GM macro consistantly


Created with:
  gclient setdep -r src/third_party/skia@d41c1876d834

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:922851,chromium:922851,chromium:900965,chromium:922851
TBR=djsollen@chromium.org

Change-Id: Ib518e49466c2365644e176043f1b37a0418ac279
Reviewed-on: https://chromium-review.googlesource.com/c/1437009Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626227}

https://chromium.googlesource.com/angle/angle.git/+log/59d756e530c5..5904ee3f58e3


git log 59d756e530c5..5904ee3f58e3 --date=short --no-merges --format='%ad %ae %s'
2019-01-25 syoussefi@chromium.org Vulkan: Fix timestamp query units


Created with:
  gclient setdep -r src/third_party/angle@5904ee3f58e3

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: Ib412bcc3af35f41c37a8ef6483023e1a81ea80f6
Reviewed-on: https://chromium-review.googlesource.com/c/1437496Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626226}

The class has most functionality implemented, so it's more of a test
helper class than a mock.

Change-Id: I70b8bd66835b65e9f6af83827a0ea3682e954b4a
Reviewed-on: https://chromium-review.googlesource.com/c/1435685Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626225}

This change is to support the Switch Access focus ring style described
in this spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQBEKUk1sS_U/files/MCHtA7U1iMGr6-mR9r6ArPGAjSutDL__KP4

Bug: 925103
Change-Id: I6aeda730fd8717282cb49867840010aea7a92f83
Reviewed-on: https://chromium-review.googlesource.com/c/1435435
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626224}

I had voiced concerns about this when NoDestructor was introduced as a
strictly preferred alternative to LazyInstance @
https://groups.google.com/a/chromium.org/d/msg/cxx/rs_iizoAu6w/Gi6s0pmwBQAJ.
This CL migrates LazyInstanceTest.PriorityInversionAtInitializationResolves
to the NoDestructor thread-safe scoped-static-initialization paradigm.

It seems to be okay after all and this CL locks this in on all platforms.

Bug: 925323
Change-Id: I679beaf23934840b6070a8592dd6d678992d6943
Reviewed-on: https://chromium-review.googlesource.com/c/1436198
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626223}

This CL adds the '-f FAKE' flag to apk_operations.py. This complements
the '-m MODULE' flag, but performs fake bundle module install instead.
Changes:
* Always delete the fake module directories:
  /data/local/tmp/modules/
  /data/data/<package_name>/files/splitcompat/ (needs root)
* If -f flags is given:
  * Constraints:
    (1) '-f base' is illegal.
    (2) Explicit '-m base' is required (prevents potential ambiguity
        in the future).
    (3) FAKE and MODULE must be disjoint.
  * Print warning if command line flags not set up for fake modules.
    This requires chrome/android/BUILD.gn to specify
      command_line_flags_file = 'chrome-command-line',
    which get passed to apk_operations.py: _InstallBundle() so it can
    read the command line flags and check.
  * Extract the FAKE module split APKs, then copy them to
    /data/local/tmp/modules/.
* Update chrome/android/BUILD.gn to specify
  which get passed to apk_operations.py: _InstallBundle() so that
  it can check for '--fake-feature-module-install' in command line,
  and print warning if missing.

Bug: 922051
Change-Id: I5bba49e1e7e66a4a00f1ed1ca4128a805d995e95
Reviewed-on: https://chromium-review.googlesource.com/c/1435515Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626222}

ASAN makes this fuzzer sufficiently slow that it hits the Run() timeout,
so disable the timeout in ASAN builds.

Bug: 924030
Change-Id: I38055a3a8982564d2300fe10d717651f27d32dfc
Reviewed-on: https://chromium-review.googlesource.com/c/1433392
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626221}