- 20 Nov, 2020 40 commits
-
-
Joe Downing authored
This CL adds the class which logs any ETW events received to the Windows event log. Bug: 1144185 Change-Id: I3972e2c5ef91ace511f5bebfa41fa00ff68ac521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545564 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#829862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/108b4ee97ef9..a08962107ef6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbansal@google.com,waffles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150459 Tbr: tbansal@google.com,waffles@google.com Change-Id: Ie8f08aad9287c6452ddebfcfbb98e17a944773d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552887Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829861}
-
Olivier Yiptong authored
This implements the content interface for embedders to enumerate fonts in the upcoming chooser UI, which can be found at https://crrev.com/c/2543603. Bug: 1138621 Change-Id: Iae647eb04417a865590595b8bb1b1f1e1e3a3c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531180Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#829860}
-
Chris Palmer authored
Also fix a bug: `PCHECK` may itself allocate, creating re-entrancy problems, so we can't use it as a way to learn the `errno`. Instead, create a `PA_PCHECK` macro that uses `base::debug::Alias`. Bug: None Change-Id: Ic17e7c09d620e8f1f38da8b64a45fbfeeeac3b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546084 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829859}
-
Ken Rockot authored
Upstream Chromium no longer uses an InterfaceProvider to expose browser interfaces to render frames. Cast Shell still does this for a small handful of interfaces registered by downstream internal-only logic. In order to support the transition of the internal repository away from this mechanism, this CL introduces a bit of redundancy: interfaces registered with CastWebContents through either of its two registration mechanisms will now be exposed to *both* InterfaceProvider consumers as well as BrowserInterfaceBroker. Once this lands, internal renderer code can simply be rewritten to use RenderFrame::GetBrowserInterfaceBroker instead of RenderFrame::GetRemoteInterfaces(), and then upstream Chromium can completely remove all its gnarly support for a browser-exposed InterfaceProvider. Bug: 977637 Change-Id: I21ae1fc31b35b0ca77ab2a00645feafe0ac67a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547054Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#829858}
-
Garrett Beaty authored
This will reduce the amount of manual change that must be made when updating configuration for a branch and put more values inline in the config. Change-Id: I033beff961f1d88a30795e12ca7f784abd0c331a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551668 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#829857}
-
Jimmy Gong authored
cr-card-radio-button does not properly implement the paper-ripple effect and as a result the paper-ripple effect is at the root of the document. This results in a ripple effect to appear in the top left of the page. More details in the attached bug. Bug: 1150617 Fixed: 1148515 Change-Id: I60363c440f792d24f4b7e5957e89f156906164ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548366Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#829856}
-
Maria Kazinova authored
Unlike login forms, change password forms are often kept on page after successful submission. This CL allows to detect submission for change password forms that are cleared field by field with HTMLInputElement::SetValue(), by setting an empty value. Bug: 1149948, 1147363 Change-Id: Ia5d8e27f91b4a9e36784517e87fff41167551ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537697 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#829855}
-
Andrew Xu authored
This CL is a part of the efforts to create multipaste menu items for copied files. This CL does the following jobs: (1) Create a new type for `ClipboardHistoryDisplayFormat` called `kFile`. (2) Move the code related to the text label out of ClipboardHistoryText- ItemView. Instead, create `ClipboardHistoryLabel` for the text label used by the multipaste menu. Right now a `ClipboardHistoryTextItemView` instance is built for a clipboard data whose display format is `kFile`. So this CL does not introduce any visual difference. Bug: 1134392 Change-Id: I7fb4b9ce5d37fcd298b5cfefcd9dcee0ad160c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547225 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#829854}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7a005c70ab6fad58e5fc014efc62fa2dca978f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829853}
-
Khushal Sagar authored
Bug: 1056730 Change-Id: I0515616e5524d002859d4f1c8ce7b8f8c930a119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299535 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829852}
-
Sophie Chang authored
This matches the enum checked into google3 Bug: 1146151 Change-Id: I934ae52656e765992c755733f4108773d6446f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552760 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#829851}
-
James Hawkins authored
This change fixes a crash where the device name is fetched from the DeviceNameStore, which is not initiatlized when the flag is off. R=khorimoto@chromium.org Bug: 1151252 Test: none Change-Id: I314b6bd27f3bfe1ff7bce9ebf9ebd7c28edf8188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552671Reviewed-by:
-
Jing Wang authored
This is required for cl/342559961 Bug: 1137621 Change-Id: Ic7fffc07a2ec9c62c4b92c894e0d961ab6d56382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536427Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#829849}
-
Kyle Milka authored
Subclass ScreenshotCoordinator to create LongScreenshotCoordinator. For now this class only overrides captureScreenshot() to launch the bottom bar after capture instead of directly launching the editor. Bug: 1142520 Change-Id: I378f1809ed1cf9a74df2f028a6a6ca0d75a06d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542924Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
-
Alison Maher authored
This change overrides the ColorIncludingFallback() function for fill, stroke, -internal-visited-fill, and -internal-visited-stroke. This allows us to use ComputedStyle::VisitedDependentColor() instead of ComputedStyle::ResolvedColor(). This change shouldn't result in any functional difference. Bug: 970285 Change-Id: I6a5b85cdbf1abe8dc9d255ba73c7f6c6e8530a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519272 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#829847}
-
Clark DuVall authored
Feed V2 has fragment classes that are not retained, so on configuration changes these are recreated using reflection. This change keeps track of isolated split ClassLoaders that were created for inflation, and checks if fragment classes can be loaded with these. Bug: 1151456 Change-Id: I46a64a1959e8879680babdb94fa33f4e928ff863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552205 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829846}
-
Daniel Rubery authored
We have some BUILD targets related to the URL lookup service that both depend on and are depended on by //chrome/browser/safe_browsing:safe_browsing This seems to be causing occasional build flakes (see bug). The solution is to merge these BUILD targets. Bug: 1151202 Change-Id: Id73c8a737f1f93bf0430b21f8ec770e865f5175a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552571 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829845}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/32b14552d662..1286f58c2996 2020-11-20 apodtele@gmail.com Downgrade property tracing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC drott@google.com,thestig@google.com,bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: drott@google.com,thestig@google.com,bungeman@google.com Change-Id: I927897cd23df6500c22d70f2973254689a93ebcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552580Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829844}
-
Jacques Newman authored
NGGridLayoutAlgorithm::ComputeMinMaxSizes is fairly complicated, and would like to modify its internal data to make the algorithm easier to read. There does not seem to be any reason we must guarantee ComputeMinMaxSizes needs to be const. Bug: 1045599 Change-Id: I57f6ded3757b19694601b506747ccdd1c48d84a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552705 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#829843}
-
Stephen Roe authored
Bug: 1105654 Change-Id: Ief7bbafd18ce534400d674024b4239b17fe19dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532768 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#829842}
-
Dave Tapuska authored
Previously the message would just get dropped if the opener frame was discarded as it would be on a shutdown channel. Ultimately this code should go away if we didn't have the pending_contents_ list. I've created a separate issue for that because this change likely needs to be merged into M88. BUG=1149833, 1150976 Change-Id: If46b130a0c79a2e09ba7680ca6e3dfea881f39ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550250Reviewed-by:
-
rajendrant authored
This CL renames HttpsImageCompressionBypassDecider to LitePagesServiceBypassDecider. This class will be used for fetching compressed images and robots rules from LitePages service. This CL also renames the relevant histograms. Bug: 1147565 Change-Id: Id01134e496015f104c9e32639b8fa19afe1f075e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552822 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#829840}
-
Dale Curtis authored
MP3, FLAC, and AV1 are all codecs that were added in Chromium and Chrome. R=ddorwin Change-Id: I4c0cfed8eb68a56489d9147d4e35a7148bdc58b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552985 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Stephen Martinis authored
This reverts commit ce0f2cd4. Reason for revert: Landing after build side change Original change's description: > Revert "Remove Mac 10.10 builders" > > This reverts commit f983ad81. > > Reason for revert: Broke CI builder mac-updater-builder-rel https://ci.chromium.org/p/chromium/builders/ci/mac-updater-builder-rel/1198 > > Original change's description: > > Remove Mac 10.10 builders > > > > Bug: 1149560 > > Change-Id: Ib9798ca9e092edfba05dff7fa7f641e156182cb2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548680 > > Auto-Submit: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#829364} > > TBR=martiniss@chromium.org,gbeaty@chromium.org > > Change-Id: Ie979df929b64896c01ca4858909b8cbe902e7a25 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1149560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551638 > Auto-Submit: Gregory Guterman <guterman@google.com> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829417} TBR=martiniss@chromium.org,gbeaty@chromium.org,guterman@google.com # Not skipping CQ checks because this is a reland. Bug: 1149560 Change-Id: Id8920e3b96033cbce6422ef2263c4fb96df7077d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551641Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#829838}
-
Reilly Grant authored
This allows the SerialConnectionEvent interface to be removed because the port attribute is superfluous given the target attribute. Bug: 884928 Change-Id: I1e646c03a093cc9dd09776946597ec534e86636f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542923Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Remove unused method now that downstream has been updated. See: https://crrev.com/i/3409426. Bug: 1102812 Change-Id: I59a8ce9629041fd290b2ca606497a7e733c81da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541671Reviewed-by:
-
Kevin McNee authored
Bug: None Change-Id: I77f2d4e364d8b2458c29fa28969e8abdb6d0f537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551777Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829835}
-
Matthew Mourgos authored
When a long press occurs on shelf app icons the icon is scaled up. This change adds an animation for scaling the notification badge with the shelf app icon during scaling. Bug: 1131076 Change-Id: I3372c305a46f22d3bd4381794cbc93855e81ecbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552085 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829834}
-
Clark DuVall authored
There were two definitions of createFeedContext(), and one did not have the original dark mode fix. See bug for more details. Bug: 1147705 Change-Id: Id930163d69cedbe07dcd272cf88246b5bb7da3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552642 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#829833}
-
Devlin Cronin authored
Add support for injecting a file in the scripting.executeScript() and scripting.insertCSS() APIs. The file property should point to a relative path in the extension's package, which will then be loaded and executed. The property in the schema is an array of strings `files` to allow use of multiple files in the future. Add browser tests for the same. Bug: 1148880 Change-Id: Ie425c39d0c4be258bf2e8140fca219412a33f3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538204 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829832}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fd3678a79ddd..361d02972a3d 2020-11-20 kahinds@microsoft.com [Loc] Migrate developer_resources to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iff65eb3a637af755a09e165927cd0e149849d751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551570Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7784fce44d7b..c4ca12e32e6a 2020-11-20 m.maiya@samsung.com Vulkan: Support the single-sampled targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ic0b41f63ef6049d29321a4cf25475c16341c7746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550629Reviewed-by:
-
Joel Riley authored
Currently only the Exit button is hooked up. AX-Relnotes: When #select-to-speak-navigation-control chrome://flag enabled, floating panel appears next to focus ring when Select-to-speak is activated. STS will no longer autodismiss when this feature is enabled. Currently, only the stop button works. Bug: 1143814 Change-Id: Ic703fb4fe1ad0675c007d2ba84e49c169a1d0fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538544Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#829829}
-
Daniel Rubery authored
Since we're wrapping up one experiment for CSD on Desktop (vision-based CSD) and moving immediately into another (the new DOM-based model), take this opportunity to remove the legacy usage of GetVariationParamValue on Desktop. Change-Id: Idc153248827e48fdd53d6b062fc32285644d3204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551458Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#829828}
-
Weiliang Chen authored
This CL starts display actual web vital metrics in the HUD overlay. This CL creates a WebVitalMetrics data structure, and hooks up its source from Blink to display in cc. This CL also initialize the actual value for largest contentful load and first input delay in the WebVitalMetrics class. R=sadrul Bug: 1149385 Change-Id: I8d89dd5a689c52abb8f400a484f0a9087edd3a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541806 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#829827}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d2953cff41e7..41b3f9c1e4aa 2020-11-20 bryan.bernhart@intel.com D3D12: Support caching DX shaders. 2020-11-20 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 36d9a061c847 to 7f075c2a88c0 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ibefd8e6dfde742372ee30cadebbee3163c0d919d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552764Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/de9e649438ed..aeb3616301c8 2020-11-20 amaiorano@google.com marl: fix extra ';' warning 2020-11-20 amaiorano@google.com Make vk-unittests load/unload swiftshader only once per suite 2020-11-20 bclayton@google.com Vulkan: Fix use-after-destruction of VkFence event If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iea49a01e499d28b8850b5d8d9eef8c42b78adf4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552672Reviewed-by:
-
David Van Cleve authored
This is a no-change reland of the following CL, except that it contains a rework of the test's "wait for a completed navigation" logic to avoid what was presumably a race. ======= Original description ======= SecurityOrigin currently returns identical objects when constructed from KURLs with ports explicitly set to 0 and KURLs with ports equal to their schemes' defaults. This is inconsistent with the //url implementation (and the HTML spec!). This CL makes two changes to ensure that AreSameOrigin(KURL("https://a.com:0"), KURL("https://a.com")) starts returning false. (1) It updates SecurityOrigin(KURL) to set the origin's "effective port" field to the given URL's protocol's default port when the URL's parsed port is empty. (2) It updates SecurityOrigin::IsSameOriginWith to use SecurityOrigin::effective_port_ for comparison rather than SecurityOrigin::port_. (SecurityOrigin::effective_port_ and SecurityOrigin::port_ differ in that `effective_port_` takes into account empty/default ports, and `port_` doesn't; prior to this change, `effective_port_` was being initialized incorrectly to the default port for SecurityOrigins constructed from URLs with port explicitly set to 0.) This CL adds serialization behavior for port-0 origins that is incorrect but matches url::Origin's. Port-0 origins' serializations should include the port, but they currently don't (crbug.com/1136966). A subsequent change will implement this fix for both SecurityOrigin and url::Origin. (Doing one at a time is tricky because some tests check equality of origins' serializations.) Test: Adds unit tests covering same-originness and effective_port_. Change-Id: I70f1e7e257340da1b96ed22128dfbfac3c2c53d5 Fixed: 1136678, 1138540, 1100794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472460 Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:Charlie Reis <creis@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#828240} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545446 Cr-Commit-Position: refs/heads/master@{#829824}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16973d613fed..2f47910c9ce3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibf12e7cd1fe53521f2325ce7a9ce6e8f2877400a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552558Reviewed-by:
-
