- 06 Oct, 2020 40 commits
-
-
Ben Pastene authored
This moves that particular test to the main chromium.tests pool while also configuring it to use a named cache on the test bot. This cache won't be used to store any files, but will simply let us target (via swarming dimensions) bots that already have this cache (i.e. bots that have already ran a CrOS VM url_unittests). This is done by also adding an additional task slice to the test that will wait 60s for a bot with that cache already present. If one isn't available in time, it will run on any bot. In the latter case, that bot will then have our magic cache created on it, allowing it to run future CrOS VM url_unittests. Bug: 1132206 Change-Id: If8630a84bb9892065deb8e3639e3d0780e2ffc83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438776Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#814279}
-
Jeff Yoon authored
The machines have successfully upgraded to Mac 10.15, so we're setting the OS dimension accordingly. Bug: 1135264 Change-Id: Ie1bcf9e434e75510a673f93ac430474c5fbcf7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450896 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Tim Volodine authored
The test is flaky on some android bots, in particular on Lollipop Phone Tester and Marshmallow Tablet Tester. BUG=1135601 TBR=altimin@chromium.org,hbolaria@chromium.org Change-Id: I72916ef172ecc76d6a2b92e3482314e52751c91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453390Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814277}
-
Dan Harrington authored
For context, enable_feed_v1=false removes the v1 version of the NTP feed from the build. This CL fixes various problems with that configuration: * fixed some tests * fixed some unused resource errors * some tests were more difficult to fix, i've made some assertions conditional. Instant start isn't yet implemented for v2, so it's likely these require more than test updates. Bug: 1129187 Change-Id: If1cfbdd9e596c61c082565279a545326f1dba244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441958Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#814276}
-
Alex Rudenko authored
This CL makes a few improvements in handling the case when the overlay agent gets disabled: - Moves the agent status check to the top of the SetInspectTool. - Adds a check for the agent status in the input event handler so that events are not handled when the agent is disabled. - SetInspectTool returns an error response if the agent is disabled that gets propagated to the client where applicable. This CL is a follow up for the previous fixes in this area [1][2]. [1]: https://crrev.com/c/2387560 [2]: https://crrev.com/c/2235553 Change-Id: Iee68ca735c8990ab15832b0f35c086cceeb98510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397735Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#814275}
-
Elly Fong-Jones authored
This change adds two new methods to WidgetDelegate, both of which allow setting the WidgetDelegate's contents view, thus removing the need to override GetContentsView(). The two new methods are: * SetContentsView(unique_ptr<View>), which takes ownership of the given View * SetContentsView(View*), which doesn't Each method can only be used with the appropriate ownership protocol, so SetContentsView(unique_ptr<View>) will DCHECK if the provided view is owned_by_client(), and vice versa for SetContentsView(View*). This effectively forces clients into one of these two ownership protocols and away from the "sometimes owning" pointer semantics of overriding GetContentsView(). This is part 2 of the following plan: 1) Introduce WidgetDelegate::TransferOwnershipOfContentsView() and migrate to it in places that are trying to take ownership 2) Introduce WidgetDelegate::SetContentsView(), which will either: a. Store the provided view in a unique_ptr, if it is not owned by client, or b. Store the provided view in a raw pointer, if it is owned by client 3) Replace all existing overrides of GetContentsView() with uses of SetContentsView() 4) Require that !owned_by_client() in SetContentsView(), which will likely require intense surgery of client classes 5) Have SetContentsView() take and TransferOwnershipOfContentsView() return a unique_ptr<View> rather than a View* as laid out in 1206dbae. Bug: 1075649 Change-Id: Ifa35af1d87ad958a7d544ed74d6b1f980e416463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449919 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#814274}
-
Makoto Shimazu authored
This reverts commit 8a93811e. Reason for revert: https://crbug.com/1134552 Original change's description: > ServiceWorker: Start the timer immediately after queuing an event > > This CL makes the timer start immediately after an event is enqueued, > and erases the event from the queue when it has not started to run yet > and the timeout happens. Also, this CL updates kUpdateInterval because > the minimum possible timeout is 10 seconds for offline events. > > Bug: 965802 > Change-Id: Ib84c6f3164aa00d525d2f936385a152fdad1fa49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423698 > Commit-Queue: Asami Doi <asamidoi@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812028} TBR=falken@chromium.org,shimazu@chromium.org,asamidoi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965802, 1134552 Change-Id: I61e03383b7147d40ebfa0413a7fe6345202e015d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452092Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814273}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0ecf543..090d2b61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6cb2add1af26661a98f6300a5196ccc95cbce62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452555Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814272}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601942192-fa539b08a521491a2633981acf18458f1a2ef415.profdata to chrome-win32-master-1601974327-16d759bfb740e331cae500f5af505af81f39b1ea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2f5e7ab40ef6b80c11a0ad31e7087cee0ce604c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814271}
-
Frank Liberato authored
This reverts commit d92b6c97. Reason for revert: new test fails on the bots Bug: 1135654 Original change's description: > [CORS-RFC1918] Add UseCounter integration tests. > > These tests are defined in chrome/, as opposed to content/, because the > UseCounter integration with UMA histograms relies on chrome/ code. > > Bug: chromium:1124358 > Change-Id: I9faa667e2ced9e92f0c8bd10652ccc2f225c3b13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442013 > Commit-Queue: Titouan Rigoudy <titouan@chromium.org> > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814235} TBR=droger@chromium.org,arthursonzogni@chromium.org,titouan@chromium.org Change-Id: Id40979616b58d0390a070ad5953fd4400954e8ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1124358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453571Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#814270}
-
Keren Zhu authored
* Transparent background was used in button and was problematic on Windows and Linux. See screenshot http://shortn/_PJngbEljUE Fix using an explicit color. * Use SetEnabledTextColors to set button text color. This sets color for NORMAL, PRESSED and HOVERED states. On Windows and Linux, setting only NORMAL but omitting others will render text in other states in black, which is not desired. Bug: 1121399 Change-Id: Ica95095855a619220a5dd9cf62c67b87acb6be0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452554Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814269}
-
Tommy Li authored
Just cleans up some no longer operational flags and features that are now useless since ZeroSuggestVariant is gone. Followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2430227 Developers that wish to make a standalone about:flag that triggers a variation ID, refer to how this CL did it: https://chromium-review.googlesource.com/c/chromium/src/+/2422473 Bug: 1124050 Change-Id: Ib96f024c6bdc0d82fd76dab8eef762cbd05c71de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451395 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#814268}
-
dpapad authored
The former is deprecated and no longer receives any updates. Reland notes: Temporarily making PathToUglify an alias for PathToTerser until internal code gets updated to use the latter directly. Bug: 1087970 Change-Id: Ib5359063951793981302c6985408d124b909951b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451913Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#814267}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e017318956fd..10071897de1e 2020-10-06 jacktfranklin@chromium.org Fix conflicting scroll instructions in Breadcrumbs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie92ef47e6dee7c7b270002e1753a2ade43691885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452869Reviewed-by:
-
Andrey Kosyakov authored
Bug: 930356 Change-Id: I1b1223bd6bbf11786090addf4e8f52135a5763d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451869 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#814265}
-
Colin Blundell authored
Currently, ContentSubresourceFilterThrottleManager is owned by ChromeSubresourceFilterClient, which is a WebContentsUserData. This ownership model means that: (a) the expected lifetime/ownership model of ContentSubresourceFilterThrottleManager is unclear at the level of //components (b) other SubresourceFilterClient implementations would need to duplicate this structure (c) it is only possible to get at the ThrottleManager from WebContents at the //chrome-level, which impedes componentization of related classes This CL changes the ownership model so that the ThrottleManager is the WebContentsUserData and it takes in the SubresourceFilterClient instance as a unique_ptr. This model will greatly simplify embedding of the ThrottleManager in //weblayer and further componentization. We leave two static methods in ChromeSubresourceFilterClient for convenience: - CreateThrottleManagerWithClientForWebContents() abstracts the creation of a ThrottleManager that is configured for //chrome, as this is done multiple places in //chrome - FromWebContents() gets the ChromeSubresourceFilterClient instance (if any) from a given WebContents via the ThrottleManager, as several places in //chrome access the API surface of ChromeSubresourceFilterClient itself. NOTE: For the latter, I expect to trim at least some of these by moving the relevant functionality into ThrottleManager for sharing with //weblayer. Bug: 1116095 Change-Id: I7ee85e19a8a152dec2431b995d042ab482b18b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443653Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#814264}
-
Jazz Xu authored
This CL modifies media controls detailed view such that it won't navigate back to main menu until user clicks the back button or close the menu. Bug: 1135212 Change-Id: Ic63984ba87e44ab85ca62ab83e71a8093ef62ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450312Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814263}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 556 histograms that show frequent access in the past 90 days. These are the 92% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-01-04. TBR=chromium-metrics-reviews@google.com Change-Id: I50c60c47e8934ffdb2421244c9e5a984b7b35f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451403Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#814262}
-
Dominique Fauteux-Chapleau authored
This disables NotificationPlatformBridgeWinUITest.SynchronizeNotificationsAfterClose as it fails on windows builders. TBR=knollr@chromium.org Bug: 1135576 Change-Id: I29e0d264aaeabe4012720b291d69ba82d0505bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452556Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814261}
-
Wei Li authored
Bug: 1108460 Change-Id: I5035011d8533c7f6de436c1384d110efa92636af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451524 Auto-Submit: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#814260}
-
Oriol Brufau authored
No need to check 'style.Display() == EDisplay::kBlockMath' inside a conditional with the same condition. Change-Id: I537e857a9b4b638f8bd13e8e51a4466b4c5e24be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452729Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#814259}
-
Sergey Ulanov authored
Added the following flags for content_shell when running layout tests: --use-vulkan --enable-gpu-rasterization --force-device-scale-factor=1 This ensures that the web tests flag on Fuchsia matches the flags used in WebEngine. Bug: 1067477 Change-Id: I39fe18d4a70cf76f6f422173c65403ede70379fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446541 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814258}
-
Bill Budge authored
- PPB_Flash_MessageLoop - PPB_Flash_DRM - PPB_Flash_Menu - PPB_Flash_Clipboard - PPB_Flash_Print - PPB_Flash_File - PPB_Flash Bug: chromium:1064652 Change-Id: Ie9b661cab12c79dfc0ba2528989a661a1d4b49f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446525Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#814257}
-
Ken Rockot authored
An upcoming change will introduce generation of JS modules for mojom bindings. While most of the boilerplate in the existing jinja templates remains the same, there are enough differences to warrant forking them. This CL copies existing templates to new files with a _for_module filename suffix. No changes are made here, so that the CL which actually implements JS modules support can change the new files in-place, making the differences easier to review. Bug: 1004256 Change-Id: I37b95929b070ed6cb41406cc529f7dba84065720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451270 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#814256}
-
Dirk Pranke authored
This reverts commit 9bdc5ccb. Reason for revert: Reverting until I can fix the `import six` issues more cleanly. Original change's description: > Roll catapult to 532e564 and update for changes in it. > > This CL rolls //third_party/catapult to > 532e564f622742fc93a7f91dd3556d711e778a7e and picks up > > https://chromium-review.googlesource.com/c/catapult/+/2450450 > > which removes zipfile_2_7_13.py as a dependency. This CL > also updates the corresponding Chromium .pydeps files that mentioned > it. > > That change also added a dependency on `six`, which seems to be > pervasively assumed in other parts of the catapult codebase as > present in the environment; however, it isn't guaranteed to be > there in the chromium compile-time python build, so this adds > that as needed as well. > > TBR=bsheedy@chromium.org > > Bug: 1112471 > Change-Id: I849355a5bdc18847dcbf39f3d3a9e9fbf428e3be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449938 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814062} TBR=dpranke@google.com,bsheedy@chromium.org,johnchen@chromium.org Change-Id: I8dc0ccc9819eb5cd7de6d9fab4ec9a23c485ca09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112471, 1135502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453150 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
Tibor Goldschwendt authored
This new tabs will allow users to disable NTP modules. Bug: 1135393 Change-Id: I734742fe098010dbb57c6b3ec3f703fac01c6ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451526 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Sébastien Séguin-Gagnon authored
Adds a link-to-text button when clicking on selected text in the browser container. Creates and hooks up a mediator and tab helper to handle the click on the new link-to-text button. Bug: 1134703 Change-Id: I72196fc7a95b81ea32700414c70a645af16bfc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446202 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#814253}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9dc82411. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Id75cd07aa44b76b20aca77ef14af11e6d40a8cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452553Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814252}
-
Aaron Leventhal authored
See https://github.com/w3c/dpub-aam/pull/4 Bug: 1134999 Change-Id: Idb42f8e7ab9d3b603c39e8c757cf7a9993aa728f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451975 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#814251}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //tools. Bug: 1113033 Change-Id: I4ee4da92c3c51ad639a17c96265ab34c1fd94944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450742Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e2c6940c36e4..8e5cf441141c 2020-10-06 bsalomon@google.com SkImage_GpuYUVA doesn't take origin 2020-10-06 robertphillips@google.com Separate mask creation from drawing in draw_shape_with_mask_filter 2020-10-06 kjlubick@google.com [canvaskit] Update to 0.18.1 (including typescript types/docs). 2020-10-06 kjlubick@google.com [canvaskit] Add docs/types for Skottie and Particles 2020-10-06 kjlubick@google.com [canvaskit] Add docs/types for paragraph If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ibc66ed4cea15367ac54f029d55af3d861981c17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452830Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I276656a5128181e9b5c93fc8c93df9fd5d255999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445416Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814248}
-
David Tseng authored
In Play Books, the app uses anchors which are focusable but have no name. ChromeVox continuous "read from here" (Search+R), uses readable text to get end callbacks from tts to know when to continue reading the next item, so this breaks the feature from continuing. Fix by explicitly skipping empty nodes. R=hirokisato@chromium.org empty items. Bug: none Change-Id: Iaa90677a89e8fbfea3da72d52fcb5a191e425c3c AX-Relnotes: in Play Books, ChromeVox will keep reading even when encountering Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448993 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#814247}
-
Mohamed Amir Yosef authored
This class will encapsulate the logic for saving address profile. This CL doesn't introduce any behavioral change. Bug: 1135178 Change-Id: I4bda0220f56f3e1f5377c24cd47cd0e0b42ae8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450282Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#814246}
-
Henrique Ferreiro authored
Before this change, starting Chromium in a HiDPI display would load a regular cursor (e.g. instead of 2x) until the display settings were changed. Bug: 1127962 Change-Id: Ib6f34458a72d551e832387bb4b5c7df0f1dce805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443610Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#814245}
-
Maksim Sisov authored
This is a follow up CL that implements OzoneUIControlsTestHelper in Ozone/X11. It basically reuses the X11UIControlsTestHelper that was extracted to ui/base/x in https://crrev.com/c/2445109 Test: all interactive_ui_tests with Ozone/X11 pass Bug: 1134495 Change-Id: Ic9c123c74a5f425b78b5a51f8f4fd452029c0971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443850 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#814244}
-
Josiah K authored
Just noticed test was missing this.newCallback(), so added it, to make sure test runs and waits for callback before finishing. AX-Relnotes: n/a Change-Id: I72baf27159706853672d18af00410c07cfef91b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450794 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#814243}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e6a8f4ed40bb..972e0ab44119 2020-10-06 saklein@chromium.org package_info: Refactor usages of SplitPV to parse. 2020-10-06 gbiv@google.com cros_setup_toolchains: package rust 2020-10-05 michaelirani@chromium.org Fix typing issue in cros_analyze_image.py 2020-10-05 skau@chromium.org licensing: Allow net-print/brother_mlaser for Google-TOS 2020-10-05 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-05 engeg@google.com cbuildbot: fix spelling of 'finished' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2fd18a23b570c8f571d202857678b1c266812882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452829Reviewed-by:
-
Matt Menke authored
We're getting crashes that imply it can be null here (though it can't be null in NavigatorUAData::getHighEntropyValues(), apparently). Bug: 1134994 Change-Id: Ie361625dc6df4d25592bfe167a82119a7b00167d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450289Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#814241}
-
Mitsuru Oshima authored
Bug: 1134279 Test: covered by unittests Change-Id: Ic8a411f57e8401321454f187dbcace2bd3c3c85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451709Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#814240}
-
