- 11 Jul, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/08859344..8885d8b2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2f2ca58a2d7665e92d0f7164307a33bf75ab5d40 Reviewed-on: https://chromium-review.googlesource.com/1132851Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574130}
-
“asish.singh” authored
Replace all hardcoded months in the tests by NextMonth() function. BUG=792475 Change-Id: I6ccfdbd7c8dce43b8156e540bb17b6379f43dba5 Reviewed-on: https://chromium-review.googlesource.com/1133038Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#574129}
-
Javier Ernesto Flores Robles authored
This CL fixes a cosmetic issue where the autofill bar was side to side while the keyboard wasn't. The code mimics what Cocoa does when an UITextField has an InputAccessoryView. Before: https://goo.gl/fzjqtq After: https://goo.gl/RU7ZkU Bug: 847523 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7277c456d2ce307c1d29484340a4bc96abc3491a Reviewed-on: https://chromium-review.googlesource.com/1122400Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#574128}
-
Fredrik Söderquist authored
Remove the methods in blink::TimerBase that either take or return a time delta as a double. These methods are mostly unused - a few calls to StartOneShot and NextFireInterval, and it should be preferable for new code to use the TimeDelta methods. The non-Delta-suffixed names are kept - i.e they take on the name of their removed equivalent where applicable. The few users of StartOneShot(double, ...) are open-coded instead, and uses of other methods are adjusted as needed. The unit tests for Timer is overhauled to use TimeTicks and TimeDelta throughout. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47c0449a9ea68e6e984c371e19f03f747bb5b1e0 Reviewed-on: https://chromium-review.googlesource.com/1131131 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574127}
-
Greg Kraynov authored
Bug: 859837 Change-Id: I1bc8a175055ddd5400a96ac97c86f2d71539e9f6 Reviewed-on: https://chromium-review.googlesource.com/1131934Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#574126}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 858ba7c4. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21165 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc bjonesbe@adobe.com: external/wpt/css/css-shapes cbiesinger@chromium.org: external/wpt/css/css-flexbox chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source domenic@chromium.org, ricea@chromium.org: external/wpt/streams drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI foolip@chromium.org: external/wpt/fullscreen garykac@chromium.org: external/wpt/clipboard-apis jsbell@chromium.org: external/wpt/IndexedDB jsbell@chromium.org, mek@chromium.org: external/wpt/webstorage kojii@chromium.org: external/wpt/css/css-writing-modes kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents rego@igalia.com: external/wpt/css/css-ui external/wpt/css/selectors rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card external/wpt/payment-method-id external/wpt/payment-request worker-dev@chromium.org: external/wpt/workers TBR=foolip No-Export: true Change-Id: I84c9c097b5067b4ab3706aaf97ab2f0b7b3c679b Reviewed-on: https://chromium-review.googlesource.com/1132850 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574125}
-
Renee Wright authored
Change-Id: I0a0dd5bbc6d61b82015827e2a19f526f069412ed Reviewed-on: https://chromium-review.googlesource.com/1128789 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#574124}
-
Sylvain Defresne authored
Bug: 798411 Change-Id: I67778d6987e52ecd556aba7c90428a7a6f933e00 Reviewed-on: https://chromium-review.googlesource.com/1129230Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#574123}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61cc9fabf255..2229b76258f7 git log 61cc9fabf255..2229b76258f7 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 569b9cb983b1..a6a7842fdbf5 (2 commits) Created with: gclient setdep -r src/third_party/skia@2229b76258f7 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I39f36cc94a3d41809a91dd8eb2e7289c0a7b1ecb Reviewed-on: https://chromium-review.googlesource.com/1132655Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574122}
-
Tanja Gornak authored
TBR=pavely@chromium.org Bug: 799905 Change-Id: Ib736c2f4e74bd025c1f3a70fac59c4c8cbf78a4a Reviewed-on: https://chromium-review.googlesource.com/1125923 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#574121}
-
Matt Falkenhagen authored
Bug: 838410, 854993 Change-Id: I8babef268fe2dd299370904f30517aa1cacc0b72 Reviewed-on: https://chromium-review.googlesource.com/1132910Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#574120}
-
Dominik Röttsches authored
r572930 moved FontConfig out of process access from a global file descriptor to Mojo messages. In one instance, PepperFlashFontFileHost, an IPC performing FontConfig method was replaced with one that tries to access FontConfig inside the sandboxed process, which fails. The mimehandler process needs access to FontConfig as well for providing fonts matching to PDFium. This CL fixes mimehandler out of process font access and moves back to using the MatchFontWithFallback FontConfig logic which was previously used in this file, before it was moved to using Skia font matching like on Windows. This implies that on Linux additional font fallback logic is used again, which finds replacements for non-existing fonts such as SimSun. Bug: 862051 Change-Id: I67136d51b45f72db0ae74201353369e34885f2ef Reviewed-on: https://chromium-review.googlesource.com/1131938 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#574119}
-
Colin Blundell authored
This reverts commit 5e93ea19. Reason for revert: FindIt reported this CL as introducing flake (crbug.com/862478). Example failure: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941342327988612400%2F%2B%2Fsteps%2Fcontent_browsertests%2F0%2Flogs%2FTracingControllerTest.EnableAndStopTracingWithFilePath%2F0 Original change's description: > Fix OOPIF hit testing in layout tests. > > If we haven't received an activated surface yet ensure that we fallback > to querying the renderer for the target of input events. > > BUG=601584 > > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781 > Reviewed-on: https://chromium-review.googlesource.com/1131219 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573789} TBR=kenrb@chromium.org,dtapuska@chromium.org Change-Id: Id34a56853b93c66469a9ae4487f99f94ce3d5817 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 601584 Reviewed-on: https://chromium-review.googlesource.com/1133018Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#574118}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/88ca18ba..08859344 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3cb5f4fb90a5fe033ca12561ec14a1b4efac2031 Reviewed-on: https://chromium-review.googlesource.com/1132842Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cfd0a11a. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21164 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I12f52d4715c8df2f7207557920f98ce11fcc2c6f Reviewed-on: https://chromium-review.googlesource.com/1132844 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2f043d847dd..a6a7842fdbf5 git log a2f043d847dd..a6a7842fdbf5 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 jiawei.shao@intel.com ES31: Support atomic functions on D3D11 - Part I Created with: gclient setdep -r src/third_party/angle@a6a7842fdbf5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I76e2e62d0893c9473d1b720e740960409bdead1c Reviewed-on: https://chromium-review.googlesource.com/1132756Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574115}
-
Hitoshi Yoshida authored
In order to make their lifetime clear in Unified-GC, this CL makes ScriptState inherited from GC. This allows to have a cyclic reference between v8::Context, ScriptState, and V8PerContextData in Unified-GC world. Bug: 773605 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibbea4f8a15c8b5e2508b53aa4ddec38d82f6d8ad Reviewed-on: https://chromium-review.googlesource.com/928189Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Change-Id: I7b61ee7d2bbbd3b18e66958d6a0e863d5b199f2e TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1131953Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#574113}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/10041796ae14..345d3323ed4a git log 10041796ae14..345d3323ed4a --date=short --no-merges --format='%ad %ae %s' 2018-07-11 dtu@chromium.org [pinpoint] Use --benchmark argument for performance_webview_test_suite. Created with: gclient setdep -r src/third_party/catapult@345d3323ed4a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I88509cd9044cf8e3654f0618e79b3d913d513fe8 Reviewed-on: https://chromium-review.googlesource.com/1132754Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574112}
-
Adam Rice authored
Constructing a Response from a non-stream will currently succeed even if creating the ReadableStream for the body failed. In this case response.body will be undefined. Add a test to verify that it is undefined, and touching it does not crash the renderer. Bug: 853189 Change-Id: I7fcf5ebc8b347c859b40b3d403d40bc048504211 Reviewed-on: https://chromium-review.googlesource.com/1132833 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#574111}
-
Matt Falkenhagen authored
NavigationURLLoaderImpl holds raw pointers to objects owned by NavigationHandleImpl, namely AppCacheNavigationHandle. Therefore the handle should outlive the loader. If the handle is destroyed before the loader the following sequence can happen: 1. (UI) |navigation_handle_| is destroyed. This destroys |appcache_handle_| which posts a task to the IO thread to destroy |appcache_handle_->core_|. 2. (Background thread) Another thread (e.g., ServiceWorkerDatabase) posts a task to the IO thread that results in |request_controller_| being called. 3. (UI) |loader_| is destroyed. This posts a task to the IO thread to destroy |request_controller_|. 4. (IO) |appcache_handle_->core_| is destroyed. 5. (IO) The task from 2. runs, and accesses the raw pointer to appcache_handle_->core. No test added because I don't see a good way to test this. Bug: 857005 Change-Id: I7c44312a2072836f53475559ddfe9ca1fdc8e18a Reviewed-on: https://chromium-review.googlesource.com/1132715Reviewed-by: -
David Roger authored
Dice headers were not sent when cookies are blocked, which is the same behavior as Mirror. However, in the Mirror case, not sending the header was disabling the feature much earlier (i.e. we would not even show the signin page). For Dice, the signin page is shown anyway, and thus there is no point in having this extra check. Removing that check allows the Gaia page to better detect what is going wrong, and show a better error page to the user (telling to the user to re-enable their cookies, instead of a generic "Something went wrong" message). Bug: 860038 Change-Id: I63cca38737ac85df420f011d9d59b699ccb3f104 Reviewed-on: https://chromium-review.googlesource.com/1128870Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#574109}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8d674dd7cef..61cc9fabf255 git log e8d674dd7cef..61cc9fabf255 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@61cc9fabf255 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Iba07e552bc9511bc2bff4fe124fb17d001b211a6 Reviewed-on: https://chromium-review.googlesource.com/1132755Reviewed-by:
-
Mohamed Amir Yosef authored
This CL addresses the remaining work to fix the attached bug which includes: 1. Detecting a cache_guid mismatches in ClientTagBasedModelTypeProcessor::ConnectIfReady(). 2. Ignore sync metadata in that case, and tell the bridge to delete it (treat as DisableSync/EnableSync). Change-Id: Ibf2f4c0b89872884f1c09a3a2e8fec1136014b93 Bug: 820049 Change-Id: Ibf2f4c0b89872884f1c09a3a2e8fec1136014b93 Reviewed-on: https://chromium-review.googlesource.com/1130527 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#574107}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I37f962245e818a16b31ed9666b5c918233d355e9 Reviewed-on: https://chromium-review.googlesource.com/1132846Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574106}
-
Kinuko Yasuda authored
We are seeing a crash that happens while the frame's subresource_ factories are null and it's last commited URL is for about: schemes (e.g. about:srcdoc or about:blank). This situation doesn't really make sense (e.g. prefetches shouldn't come to the browser process for about:blank), so we suppose there's probably a race somewhere. This change does two things: - send URLLoaderFactory for prefetch on NavigationCommit (so no race) - remove PrefetchURLLoaderService related code Bug: 849929 Change-Id: If350afa26daaeb0c679091b74b2013ab7f121531 Reviewed-on: https://chromium-review.googlesource.com/1116411 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
Currently in some cases, ShadowRoot.elementsFromPoint may not return the document element even when Document.elementsFromPoint returns the document element such as when the document element height is shorter than the hit-tested element's position. This CL fixes it by removing a check in TreeScope::ElementsFromHitTestResult. See example live case detailed in this comment: https://bugs.chromium.org/p/chromium/issues/detail?id=843215#c16 Bug: 843215 Change-Id: I5b774d1a091f3c3f72345c55bca188fad309ba58 Reviewed-on: https://chromium-review.googlesource.com/1131023 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#574104}
-
Daniel Bratell authored
Both syslog and the base namespace have LOG_INFO symbols and in certain cases (which include, but is not limited to, jumbo builds) those will clash. This patch undefs the syslog LOG_INFO macro as is already done with LOG_WARNING previously. Change-Id: Iff59a2ef079d3bb38378af76932b21a128507353 Reviewed-on: https://chromium-review.googlesource.com/1027611 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Aleks Totic authored
Static position needs to be adjusted based upon block container padding box, not upon inline container padding box. Bug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib6a5fbb27a56f7a724a52366988cfbd5063d2e36 Reviewed-on: https://chromium-review.googlesource.com/1132532Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#574102}
-
Kunihiko Sakamoto authored
This completes the htxg -> sxg renaming. Bug: 856530 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idf5243b0ff08acc761313299415bcb7fa32b333d Reviewed-on: https://chromium-review.googlesource.com/1132835Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Sam McNally authored
Bug: 854153 Change-Id: I3a7bb8ff09a5fc366ef918dea8e821ed6606fe0e Reviewed-on: https://chromium-review.googlesource.com/1132261 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574100}
-
Yutaka Hirano authored
Some entries are missing, some are fixed, some are not specific to virtual/outofblink-cors. This CL removes fixed/missing ones and reorders entries which are not specific to virtual/outofblink-cors. Bug: 736308 Change-Id: Ic39ce52e5ccd730ccf476bc9be7804d04bcc3f19 Reviewed-on: https://chromium-review.googlesource.com/1130558 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#574099}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7a0a490d. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21163 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc TBR=kereliuk No-Export: true Change-Id: Ic94e54953c4c6609ba8a3b5d26878adb23893748 Reviewed-on: https://chromium-review.googlesource.com/1132683 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Test: manually verified Bug: 858957 Change-Id: I31c2b69ca92680ea38ab38ba65f13169e0e11b45 Reviewed-on: https://chromium-review.googlesource.com/1128822Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574097}
-
Lily Houghton authored
Bug: 821027 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I597a7ee5d5cd423474232dc3d996055b0962dc60 Reviewed-on: https://chromium-review.googlesource.com/1104800 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#574096}
-
Tomasz Moniuszko authored
Change-Id: I5558e93ca31e5ab546457b0e07a73e5f1a60c614 Reviewed-on: https://chromium-review.googlesource.com/1125074Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#574095}
-
tanvir.rizvi authored
This patch changes 15381.html to utilize |selection_test()|. Follow up patch will rename it to |justify-center-do-not-modify-rootEditableElement.html| for better readability and information. Bug: 679977 Change-Id: I41a2816aa3dfb19d7068983d39a7bd726e4272eb Reviewed-on: https://chromium-review.googlesource.com/1128899Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#574094}
-
Tarun Bansal authored
Bug: 852484 Change-Id: I4b62bc03266d9e754e01cb7983d841635d9a347b Reviewed-on: https://chromium-review.googlesource.com/1132689Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#574093}
-
Christopher Cameron authored
Avoid checking the full input |text| string, rather, only examine the part that sits inside |range| and its adjacent context. Note that we still need the full string (or at least we need to know the offset into it that we are using), because that will affect the output. Pre-compute the input hash, to avoid re-computing a string's hash at every comparison. Add comments regarding key hash computation and thread use, and mark members as const (requested in previous patch's review). Bug: 860612 Change-Id: I9dd73e0a2d0247a7139131edfb33b3d99138b103 Reviewed-on: https://chromium-review.googlesource.com/1130159 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#574092}
-
Tarun Bansal authored
blink-dev approval thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/G_rkd0yo2AM/WaVhRALcAQAJ Bug: 826950 Change-Id: If511883b7428f30136642302862b51f14ffe4894 Reviewed-on: https://chromium-review.googlesource.com/1132612Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#574091}
-
