GitLab

Currently if suggestion popup is visible and options menu is
invoked from hardware options button then in that case suggestion
popup and options menu are overlapping.
Added code to dismiss suggestion popup if options menu is shown.

BUG=412757

Review URL: https://codereview.chromium.org/552373004

Cr-Commit-Position: refs/heads/master@{#294575}

Changing in the intialization order of WeakPtrFactory in src/athena module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/564073002

Cr-Commit-Position: refs/heads/master@{#294574}

The blink scheduler needs to know when input events are received since
it uses that as a signal to prioritize compositor tasks
over other main thread tasks which reduces queueing durations and
input event latency.

BUG=391005, 411520

Review URL: https://codereview.chromium.org/557403002

Cr-Commit-Position: refs/heads/master@{#294573}

Forward compositor tasks to the Blink scheduler so that they can be
prioritized over other work as necessary. We now route input and
compositor tasks through the same scheduler queue to preserve their
relative ordering.

BUG=391005

Review URL: https://codereview.chromium.org/547693003

Cr-Commit-Position: refs/heads/master@{#294572}

This class is used to perform a full text search on bookmarks, powered by the server side. The superclass will be used for other services in subsequent CLs.

BUG=None

Review URL: https://codereview.chromium.org/538903003

Cr-Commit-Position: refs/heads/master@{#294571}

BUG=413219
(for trivial refactoring)
TBR=willchan@chromium.org,rsleevi@chromium.org,nkostylev@chromium.org

Review URL: https://codereview.chromium.org/560303002

Cr-Commit-Position: refs/heads/master@{#294570}

Maintaing the proper WeakPtrFactory destruction order to avoid the runtime
issue like unrleased memory,etc...
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/509453002

Cr-Commit-Position: refs/heads/master@{#294569}

BUG=none
R=marja@chromium.org

Review URL: https://codereview.chromium.org/568523002

Cr-Commit-Position: refs/heads/master@{#294568}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/565013003

Cr-Commit-Position: refs/heads/master@{#294567}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/567873003

Cr-Commit-Position: refs/heads/master@{#294566}

We wait to verify that the user hasn't blacklisted a form before offering
generation. This fixes a bug where we may exit early due to no credentials
being autofillable and not inform the renderer that generation is allowed.

BUG=412496

Review URL: https://codereview.chromium.org/550563002

Cr-Commit-Position: refs/heads/master@{#294565}

Currently links in pdf open on mouse down. This doesn't
give user any chance to cancel the action by moving the mouse
without releasing the click.

This patch adds the fix to make sure pdf opens link on mouse up
and not on mouse down.

BUG=409753

Review URL: https://codereview.chromium.org/553433002

Cr-Commit-Position: refs/heads/master@{#294564}

This makes windows with a shape implicitly non-resizable and
non-maximizable.

BUG=408737

Review URL: https://codereview.chromium.org/552313003

Cr-Commit-Position: refs/heads/master@{#294563}

CL 93333002 added a main_render_frame() method to RenderFrameImpl,
then about a week later CL 107893003 added a virtual
GetMainRenderFrame() method with the same implementation.
To avoid confusion, we could just use the latter and remove
main_render_frame().

BUG=304341

Review URL: https://codereview.chromium.org/554743009

Cr-Commit-Position: refs/heads/master@{#294562}

Hooking it up where it makes sense in other mounts.

BUG=https://code.google.com/p/chromium/issues/detail?id=413397
TEST=None
R=binji@chromium.org

Review URL: https://codereview.chromium.org/565763002

Cr-Commit-Position: refs/heads/master@{#294561}

BUG=N/A
TEST=N/A

Review URL: https://codereview.chromium.org/565843002

Cr-Commit-Position: refs/heads/master@{#294560}

This CL cleans up some tile size code and centralizes the calculation of
the apps grid's size.

It also incidentally fixes a bug where the padding between pages was
smaller than it should have been.

BUG=411775

Review URL: https://codereview.chromium.org/553763002

Cr-Commit-Position: refs/heads/master@{#294559}

This gets rid of console warning on startup when maximized.

BUG=

Review URL: https://codereview.chromium.org/555723003

Cr-Commit-Position: refs/heads/master@{#294558}

I'm seeing my previous logging with empty window titles.

TBR=sky

Review URL: https://codereview.chromium.org/549713004

Cr-Commit-Position: refs/heads/master@{#294557}

Removed some unused code.
Updated interfaces from plain pointers to scoped_ptr<>
SaveTo(base::FilePath) replaced with SaveTo(base::File).

BUG=408184
TBR=sgurun@chromium.org

Review URL: https://codereview.chromium.org/568633002

Cr-Commit-Position: refs/heads/master@{#294556}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/570513002

Cr-Commit-Position: refs/heads/master@{#294555}

Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings.

This patch adds the necessary plumbing required for the webkit_unit_tests target.
As the resources are being moved into blink_resources.grd, this generates blink_resources.pak.
This pak doesn't exists as a separate pak file but its repacked into "content_shell.pak".
The same must be loaded into the data_pack_ of the TestContentClient so that the webkit (blink) unit
tests run successfully.

Part 1: https://codereview.chromium.org/436843004/
Part 1 with conditional: https://codereview.chromium.org/440683004/
Part 2: https://codereview.chromium.org/422023008
Part 3: https://codereview.chromium.org/438843004/

BUG=312586

Review URL: https://codereview.chromium.org/456413002

Cr-Commit-Position: refs/heads/master@{#294554}

Revert of Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays (patchset #4 id:60001 of https://codereview.chromium.org/559213002/)

Reason for revert:
I am reverting this as it resulted in test VirtualKeyboardUsabilityExperimentTest.VirtualKeyboardWindowTest consistently crashing on Linux ChromiumOS Tests, see:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31731
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/2914

Stack trace:

Objects involved in the operation:
sequence "this" @ 0x0x3e568fbdcc90 {
}
Received signal 6
#0 0x7fcb9c8936fe base::debug::StackTrace::StackTrace()
#1 0x7fcb9c893230 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fcb8c474cb0 \u003Cunknown>
#3 0x7fcb8bbc4425 gsignal
#4 0x7fcb8bbc7b8b abort
#5 0x7fcb8c1c75ad __gnu_debug::_Error_formatter::_M_error()
#6 0x7fcb9a306513 std::__debug::vector\u003C>::operator[]()
#7 0x7fcb9a2fbba9 ash::DisplayManager::GetCurrentDisplayIdPair()
#8 0x7fcb9a2d96cf ash::DisplayController::PostDisplayConfigurationChange()
#9 0x7fcb9a2d98bc ash::DisplayController::PostDisplayConfigurationChange()
#10 0x7fcb9a2fd22a ash::DisplayManager::UpdateDisplays()
#11 0x7fcb9a2fdbe8 ash::DisplayManager::SetDisplayRotation()
#12 0x7fcb9a33425b ash::VirtualKeyboardWindowController::FlipDisplay()
#13 0x7fcb9a3340d7 ash::VirtualKeyboardWindowController::UpdateWindow()
#14 0x7fcb9a2d92df ash::DisplayController::CreateOrUpdateNonDesktopDisplay()
#15 0x7fcb9a2d937f ash::DisplayController::CreateOrUpdateNonDesktopDisplay()
#16 0x7fcb9a300ea9 ash::(anonymous namespace)::NonDesktopDisplayUpdater::~NonDesktopDisplayUpdater()
#17 0x7fcb9a300df1 ash::DisplayManager::CreateMirrorWindowIfAny()

Original issue's description:
> Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays
>
> When changing from software mirroring mode to sinlge display mode, it
> is possible there is no need to update |displays_| and we early out
> UpdateDisplays(). But we still want to run the PostDisplayConfigurationChange()
> cause there are some clients need to act on this, e.g.
> TouchTransformerController needs to adjust the TouchTransformer when
> switching from dual displays to single display.
>
> BUG=chrome-os-partner:31868
> TEST=tested on Big, after existing software mirroring mode, the touch location
>      transformation is still correct.
>
> Committed: https://crrev.com/4802a8552a40e1f80606ca7171dc2f79930e7fb3
> Cr-Commit-Position: refs/heads/master@{#294481}

TBR=oshima@chromium.org,miletus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chrome-os-partner:31868

Review URL: https://codereview.chromium.org/569553002

Cr-Commit-Position: refs/heads/master@{#294553}

Revert of Do not create proxy hosts in the subtree of navigating frame. (patchset #11 id:200001 of https://codereview.chromium.org/536143002/)

Reason for revert:
SitePerProcessBrowserTest.ProxyCreationSkipsSubtree repeatedly fails on Mac with ASAN reporting use-after-free, see:

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/2174
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.8%20Buildrunner/builds/19009

@Nasko, as there are some simultaneous breakages right now, so I could not investigate this further and opted to revert the whole thing to get the tree green ASAP.

Snippets from test log:

ASSERTION FAILED: !localFrame || (localFrame->isLocalFrame())
../../third_party/WebKit/Source/core/frame/LocalFrame.h(253) : blink::LocalFrame *blink::toLocalFrame(blink::Frame *)
../../content/browser/site_per_process_browsertest.cc:690: Failure
Value of: child->child_count()
  Actual: 2
Expected: 0U
Which is: 0

Original issue's description:
> Do not create proxy hosts in the subtree of navigating frame.
>
> When a frame is navigating cross-process, its existing document will be completely destroyed and all child frames will be gone. This means that we don't need to create proxy objects for the new SiteInstance in the subtree of the navigating frame.
>
> BUG=357747
>
> Committed: https://crrev.com/faab4288197b20b73610aad3e5579751b0c3a97b
> Cr-Commit-Position: refs/heads/master@{#294520}

TBR=ajwong@chromium.org,kenrb@chromium.org,jam@chromium.org,creis@chromium.org,dmazzoni@chromium.org,nasko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357747

Review URL: https://codereview.chromium.org/565103002

Cr-Commit-Position: refs/heads/master@{#294552}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/565833002

Cr-Commit-Position: refs/heads/master@{#294551}

When WM supports _NET_ACTIVE_WINDOW notification, we get OnActiveWindowChanged() from two places:
 - X11DesktopHandler::ProcessXEvent (FocusIn)
 - X11DesktopHandler::DispatchEvent (PropertyNotify)

One is enough, two can lead to confusion. FocusIn/Out should not be handled if WM supports active window.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/549713003

Cr-Commit-Position: refs/heads/master@{#294550}

TBR=sky

Review URL: https://codereview.chromium.org/569513003

Cr-Commit-Position: refs/heads/master@{#294549}

With the CL, https://codereview.chromium.org/456413002, we are migrating from embedding inline resources
inside blink towards using chromium's grd resource system. As part of this effort, most of the tests
would require to use the 'pak' files packaged as android application assets.

These assets need to be extracted to the application data directory during the startup of the test
application. The native libraries would be able to work with these 'pak' files only after the extraction
from the asset manager.

To achieve this goal, we would require that ResourceExtractor.java to be moved inside the org.chromium.base
pacakge so that it can be utilized in ChromeNativeTestActivity.java

BUG=312586

Review URL: https://codereview.chromium.org/548023002

Cr-Commit-Position: refs/heads/master@{#294548}

https://skia.googlesource.com/skia/+log/fbe4136845fd68f583f9f9bfb628706c4b87480b..1f777e8580a67f2f975151bc414a1695696aa635

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/570533002

Cr-Commit-Position: refs/heads/master@{#294547}

This binds mojo's html_viewer to a compositor implementation that uses surfaces
to present. It reuses the bindings for the WebLayer* types in cc/blink and adds
a new implementation of blink::WebLayerTreeView that shares some things with
content/renderer/gpu/render_widget_compositor.cc but is distinct enough to be
its own class. Whenever the compositor resizes (and thus needs a new surface id)
it passes the surface id to the view manager client lib.

This also adds mojo bindings for a few new quad types that are used on the web.
We don't yet have support for video quad types, but we don't have the media
system hooked up to html_viewer yet either so these will not be generated.

Review URL: https://codereview.chromium.org/558343004

Cr-Commit-Position: refs/heads/master@{#294546}

It's unlikely but possible that beginBatchUpdates() is executed on another list
thatn endBatchUpdates(). As a result, one of the lists will become unusable.

TEST=Tested manually with a fakely added delay for end-update-files.
BUG=234039

Review URL: https://codereview.chromium.org/560273002

Cr-Commit-Position: refs/heads/master@{#294545}

Remove deprecated extension notification from panel.

BUG=411568

Review URL: https://codereview.chromium.org/557273003

Cr-Commit-Position: refs/heads/master@{#294544}

TBR=sergeyu@chromium.org,cpu@chromium.org,thakis@chromium.org,jamesr@chromium.org,zea@chromium.org,nduca@chromium.org

Review URL: https://codereview.chromium.org/560883003

Cr-Commit-Position: refs/heads/master@{#294543}

Currently there is no way to move suggestion item text to omnibox
to refine suggestion in a single step.
With this change an arrow will be appearing along with suggestion text
and url. On clicking the arrow corresponding suggestion text is moved
to omnibox and suggestions are refined accordingly.

BUG=

Review URL: https://codereview.chromium.org/557263002

Cr-Commit-Position: refs/heads/master@{#294542}

Sometimes ppapi tests fails due to race condition.
It's safer to use _beginthreadex than _beginthread. If the thread
that's generated by _beginthread exits quickly, the handle that's
returned to the caller of _beginthread might be invalid or point to
another thread. However, the handle that's returned by _beginthreadex
has to be closed by the caller of _beginthreadex, so it is guaranteed
to be a valid handle if _beginthreadex did not return an error.

R=bbudge@chromium.org
BUG=

Review URL: https://codereview.chromium.org/547543002

Cr-Commit-Position: refs/heads/master@{#294541}

In the following situations the registration may be already uninstalled.
So existing_registration->GetNewestVersion() could return NULL and crash in ContinueWithRegistration().

- register the ServiceWorker
- open the page in the ServiceWorker scope
- unregister the ServiceWorker
- register the ServiceWorker to the same scope and close the page quickly.

ServiceWorkerRegisterJob::Start() is called to register the ServiceWorker.
 next_step is set to ContinueWithRegistration.
 GetUninstallingRegistration() returns the uninstalling registration.
 RunSoon() calls PostTask(next_step)

ServiceWorkerRegistration::Clear() is called because there is no controllee.

ContinueWithRegistration() is executed.
But at this moment the registration is already uninstalled.
And crashed while calling existing_registration->GetNewestVersion()->script_url().

https://codereview.chromium.org/506043002/ is reverted because of this crash.
So I created the revert of revert cl.
https://codereview.chromium.org/547743003

BUG=398355,408048
TEST=http/tests/serviceworker/unregister-then-register-new-script.html http/tests/serviceworker/register-same-scope-different-script-url.html in https://codereview.chromium.org/547743003

Review URL: https://codereview.chromium.org/556003006

Cr-Commit-Position: refs/heads/master@{#294540}

Review URL: https://codereview.chromium.org/564583003

Cr-Commit-Position: refs/heads/master@{#294539}

> Fix an issue that android Download Manager doesn't handle OMA files correctly
>
> For OMA files, it looks like that android download manager cannot correctly download it.
> Some of the files cannot be downloaded, and some of the files downloaded has different binary content as the ones downloaed on chrome desktop.
> Bypass android download manager for OMA mime types.
>
> BUG=382698
>
> Review URL: https://codereview.chromium.org/331143010

TBR=tedchoc@chromium.org
BUG=382698

Review URL: https://codereview.chromium.org/567733002

Cr-Commit-Position: refs/heads/master@{#294538}

Splits accessibility_messages.h into single and multiply included sections
along the lines of other message files.

Review URL: https://codereview.chromium.org/551263006

Cr-Commit-Position: refs/heads/master@{#294537}

The clang rewriter must not have caught this since it's #ifdef'd.

BUG=none

Review URL: https://codereview.chromium.org/563973002

Cr-Commit-Position: refs/heads/master@{#294536}