GitLab

R=nzolghadr@chromium.org
BUG=647095
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2340203002
Cr-Commit-Position: refs/heads/master@{#418880}

There is a bug destroying one of the XWindows created for the
VSyncProvider. When that bug is fixed the default should be GLX again.

BUG=646982

Review-Url: https://codereview.chromium.org/2339413002
Cr-Commit-Position: refs/heads/master@{#418879}

Things within a component should have a namespace that matches its name.

BUG=646685
TBR=jam

Review-Url: https://codereview.chromium.org/2343463003
Cr-Commit-Position: refs/heads/master@{#418878}

Review-Url: https://codereview.chromium.org/2332333005
Cr-Commit-Position: refs/heads/master@{#418877}

This merges ResetProfileSettingsOverlay and
TriggeredResetProfileSettingsOverlay into a single class.

BUG=636435
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2334003006
Cr-Commit-Position: refs/heads/master@{#418876}

This is a mechanical change, using
 $ sed -i -e ''s/\([Uu]\)nscopeable/\1nscopable/g' *
Plus, updates a test file LayoutTests/fast/js/unscop(e)able.html
to use testharness.html.  It also removes the expected file.

BUG=647133

Review-Url: https://codereview.chromium.org/2341673004
Cr-Commit-Position: refs/heads/master@{#418875}

The histograms are obsolete, and this code walks the frame tree!

BUG=595742

Review-Url: https://codereview.chromium.org/2332423003
Cr-Commit-Position: refs/heads/master@{#418874}

Revert of [TTS] Gather surrounding text on Tap before any UX. (patchset #13 id:240001 of https://codereview.chromium.org/2211353002/ )

Reason for revert:
Suspected of causing try flakes in ContextualSearchManagerTest#testPromoTapCount:

https://bugs.chromium.org/p/chromium/issues/detail?id=647210

Original issue's description:
> [TTS] Gather surrounding text on Tap before any UX.
>
> Extract the text tapped on to use as a signal in Tap Suppression.
> The text is extracted before any UX is displayed in order to allow the
> tap to be totally ignored when appropriate.  Feeding the surrounding
> text into the logic of TTS will be done separately.
>
> This adds several files that are part of the 2016-refactoring.
> See crbug.com/624609 and go/cs-refactoring-2016.
>
> This CL is part of the refactoring-2016 effort, see go/cs-refactoring-2016
> for details.
>
> BUG=634136, 624609
>
> Committed: https://crrev.com/3f11e42880b1b7b6608e2d57fa538552318367ae
> Cr-Commit-Position: refs/heads/master@{#418464}

TBR=twellington@chromium.org,pedrosimonetti@chromium.org,tedchoc@chromium.org,donnd@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=634136, 624609

Review-Url: https://codereview.chromium.org/2348443002
Cr-Commit-Position: refs/heads/master@{#418873}

BUG=647058,645609
TBR=mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2341073002
Cr-Commit-Position: refs/heads/master@{#418872}

TBR=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2340983003
Cr-Commit-Position: refs/heads/master@{#418871}

The problem was that a rectangle was shifted by offsetFromColumnSet() after
having been made physical. However, offsetFromColumnSet() is semi-logical
(flipped block direction coordinate, like e.g. LayoutBox::m_frameRect), so we
need to add it in before flipping the rectangle.

This caused all fragmentainer groups but the first one to be translated
incorrectly.

Review-Url: https://codereview.chromium.org/2344813003
Cr-Commit-Position: refs/heads/master@{#418870}

https://chromium.googlesource.com/skia.git/+log/14e7a602d0ca..09b352f75f95

$ git log 14e7a602d..09b352f75 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 mtklein Tidy up DM blacklists.
2016-09-15 rmistry Roll recipe DEPS
2016-09-15 mtklein Clean up unused SkPictureRecorder::optimizeFor()

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2341843003
Cr-Commit-Position: refs/heads/master@{#418869}

It contains a number of methods that don't conceptually belong on
RootScrollerController. This is also a natural step towards making this feature
work with out of process iframes.

The main changes in this CL are:

  -TopDocumentRootScrollerController is no longer a subclass of
   RootScrollerController

  -TopDocumentRootScrollerController is now owned by FrameHost

  -All the methods on RootScrollerController that really only belonged on
   the Page level object have been removed.

The class will be renamed in a followup CL to be more representative of these
changes.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2285253003
Cr-Commit-Position: refs/heads/master@{#418868}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3fc897f5..6f1ef12e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2338423003
Cr-Commit-Position: refs/heads/master@{#418867}

This paves the way to allow Variations initialization to occur without
MetricsService initialization. Deferring MetricsService inititalization
is needed for the Browser Task Scheduler work as the underlying
metrics providers will post asynchronous tasks.

BUG=636518

Review-Url: https://codereview.chromium.org/2333283005
Cr-Commit-Position: refs/heads/master@{#418866}

Make virtual/rootlayerscrolls/scrollbars/custom-scrollbar-reconstruction-on-inserting-style-sheet.html expectation apply to all platforms.

It was failing on the Win 10 bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/14833

BUG=492785
TBR=sataya.m@samsung.com,skobes@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2347623002
Cr-Commit-Position: refs/heads/master@{#418865}

ObjectProxy's real method calls Bus::AssertOnOriginThread()
and causes in some log spam (but surprisingly doesn't
crash). Override the method in MockObjectProxy to prevent
this.

Also update chromeos::PowerManagerClientTest to expect this
call.

BUG=646912

Review-Url: https://codereview.chromium.org/2340683003
Cr-Commit-Position: refs/heads/master@{#418864}

Enables writing a minimal minidump for wrapping a StabilityReport protocol buffer. The minidump is meant to be valid for registration with the Crashpad reporter (includes the Crashpad info stream).

BUG=620813

Review-Url: https://codereview.chromium.org/2327043002
Cr-Commit-Position: refs/heads/master@{#418863}

The moved tests are always expected to fail due to stack-space issues
or incompatible test flags. Also update the comment as to what belongs
in NeverFixTests.

Two tests that were in NeverFixTests are just Slow now, so re-enable them.

R=dpranke@chromium.org
BUG=381840,601669,646528

Review-Url: https://codereview.chromium.org/2334893002
Cr-Commit-Position: refs/heads/master@{#418862}

This CL (hopefully) removes all calls to these methods in net:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=agl@chromium.org

Review-Url: https://codereview.chromium.org/2315873002
Cr-Commit-Position: refs/heads/master@{#418861}

This extends the #mark-non-secure-as flag to use for the HTTP-bad phase
1 (passwords and CC form detection) work. It currently behaves exactly
like the existing kMarkNonSecureAsNeutral switch, although presumably
that will change as we make progress.

BUG=646221

Review-Url: https://codereview.chromium.org/2337103002
Cr-Commit-Position: refs/heads/master@{#418860}

Reverted by:
https://codereview.chromium.org/2338213002/

Reason for reland:
Now gn gens for enable_resource_whitelist_generation = true

Main motivation for this is to more easily add per-target
repack_whitelist.

TBR=michaelbai@chromium.org,thakis@chromium.org,agrieve@chromium.org,estevenson@chromium.org,rsesek@chromium.org,brettw@chromium.org
BUG=645716

Review-Url: https://codereview.chromium.org/2339213003
Cr-Commit-Position: refs/heads/master@{#418859}

http://heycam.github.io/webidl/#es-iterator

If an interface has indexed property getter and length attribute,
then @@iterator must be %ArrayProto_values%.

Plus, @@iterator must be {writable: true, enumerable: false,
configurable: true}.

BUG=632935

Review-Url: https://codereview.chromium.org/2341643003
Cr-Commit-Position: refs/heads/master@{#418858}

Add GLOzoneEGLGbm and remove old API calls.

BUG=643368

Review-Url: https://codereview.chromium.org/2327813002
Cr-Commit-Position: refs/heads/master@{#418857}

LayoutBox::scrollRectToVisible will return if the new rect to be scrolled is
empty after clipped by layerBounds. However, the rect to be scrolled might be
an empty rect originally. A common case is empty <a> elements used as named
anchors for navigation. This patch sets the size of the empty rect to 1 so that
it can still be scrolled.

BUG=646738

Review-Url: https://codereview.chromium.org/2339653003
Cr-Commit-Position: refs/heads/master@{#418856}

Also while here:
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (helps avoiding unnecessary refcount bumps:
    https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/discussion)

BUG=646443

Review-Url: https://codereview.chromium.org/2338363002
Cr-Commit-Position: refs/heads/master@{#418855}

BUG=646443

Review-Url: https://codereview.chromium.org/2344593003
Cr-Commit-Position: refs/heads/master@{#418854}

This API can be used from any task from which
SequencedTaskRunnerHandle::Get() returns a SequencedTaskRunner (i.e. in
particular, it can be used from SINGLE_THREADED and SEQUENCED tasks
running in base/task_scheduler). As opposed to the existing API which
is only available from single-threaded tasks running in a
MessageLoopForIO.

Threads that want to support this API must instantiate a
FileDescriptorWatcher. The constructor of FileDescriptorWatcher takes
as argument a MessageLoopForIO to use to watch file descriptors for
which callbacks are registered on the thread on which it is invoked. The
MessageLoopForIO does *not* have to run on that thread. When the
MessageLoopForIO detects that watched file descriptors are readable
and/or writable without blocking, it posts a task to run the callback on
the sequence on which it was registered.

Design doc:
https://docs.google.com/document/d/1F5CjON2JNtCtdEug3LOL8-avj188k_xOgqzdv288Q_s/edit?usp=sharing

Discussion on chromium-dev:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/voOAab4mV9A/S9xXdpPkBgAJ

BUG=645114

Review-Url: https://codereview.chromium.org/2332923004
Cr-Commit-Position: refs/heads/master@{#418853}

This cl splits the big CL with changes to net/ folder and
has changes only to net/cert_net according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9
Review-Url: https://codereview.chromium.org/2330873002
Cr-Original-Commit-Position: refs/heads/master@{#418014}
Cr-Commit-Position: refs/heads/master@{#418852}

R=mbarbella@chromium.org, ochang@chromium.org
BUG=643275

Review-Url: https://codereview.chromium.org/2340813002
Cr-Commit-Position: refs/heads/master@{#418851}

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459,646905

Review-Url: https://codereview.chromium.org/2340793002
Cr-Commit-Position: refs/heads/master@{#418850}

BUG=none
R=noyau@google.com

Review-Url: https://codereview.chromium.org/2342833002
Cr-Commit-Position: refs/heads/master@{#418849}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
TBR=gab@chromium.org, mattm@chromium.org, haven@chromium.org, phajdan.jr@chromium.org, gene@chromium.org, reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2321573002
Cr-Commit-Position: refs/heads/master@{#418848}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/06fda3c9..3fc897f5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2339333002
Cr-Commit-Position: refs/heads/master@{#418847}

BUG=646288

Review-Url: https://codereview.chromium.org/2342663002
Cr-Commit-Position: refs/heads/master@{#418846}

Currently there are const char* and std::string varieties of strings in
RTCStatsMember objects ("StaticString" and "String"). The const char*
version is going away so that we don't have two string types.

This CL removes references to the "StaticString" types so that a WebRTC
CL can remove it without breaking Chromium. Only rtc_stats.cc have to
be updated, not affecting any code because rtc_stats is not used yet
(a CL is in the works that will use it and add unittests for it that is
blocked on a WebRTC CL that is under review).

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2340603004
Cr-Commit-Position: refs/heads/master@{#418845}

Revert of Disabled the v8.todomvc reference build due to missing clock sync markers (patchset #2 id:20001 of https://codereview.chromium.org/2340033002/ )

Reason for revert:
Root issue should be fixed.

Original issue's description:
> Disabled the v8.todomvc reference build due to missing clock sync markers
>
> TBR=nednguyen@chromium.org
> BUG=646925
>
> Committed: https://crrev.com/2c1a2b054e002dd463cdf88df02b3e20d550d0dd
> Cr-Commit-Position: refs/heads/master@{#418632}

TBR=nednguyen@chromium.org,oysteine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=646925

Review-Url: https://codereview.chromium.org/2347493004
Cr-Commit-Position: refs/heads/master@{#418844}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599

Review-Url: https://codereview.chromium.org/2321453002
Cr-Commit-Position: refs/heads/master@{#418843}

After https://codereview.chromium.org/2317203002 and
https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/21220

BUG=607205,575210
TBR=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2336393002
Cr-Commit-Position: refs/heads/master@{#418842}

This CL adds a browser test for desktop geolocation where persistence is
toggled off, ensuring that the underlying content setting isn't changed.
Additional checks of the content setting are added to the existing grant
and block tests.

This CL also simplifies the feature list setting used in the
PermissionContextBase test.

BUG=632269

Review-Url: https://codereview.chromium.org/2338173002
Cr-Commit-Position: refs/heads/master@{#418841}