- 06 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/32decd42e68a..f79f298cc9cb 2020-10-06 sigurds@chromium.org Fix CSS priority for generated dark-mode themes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135123 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a720b9d513b66ed48d67eeeef26cdf3fac4134a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814146}
-
Mikel Astiz authored
The metric has collected sufficient data and the team considers it sufficient to rely on Sync.PostedClientToServerMessageLatency. Change-Id: I5e53d623c058999a6bc5c7adb7b623141abe92f4 Fixed: 1105063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445151 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814145}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601899131-c43b6187adc90e2cb7e0fb0be3a8513091bf4fd9.profdata to chrome-win32-master-1601942192-fa539b08a521491a2633981acf18458f1a2ef415.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie4653559492a162b60d116d3be8f0a22ee3abbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451750Reviewed-by:
-
Nohemi Fernandez authored
This reverts commit 4f68ef3f. Reason for revert: Failing bot MAC Asan 64 tests https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/65394 Original change's description: > Desktop PWAs: Browser tests wait for registry > > The browser test helper methods in web_app_browsertest_util.cc > that install PWAs (InstallWebApp, InstallWebAppFromManifest, > PendingAppManagerInstall) now wait for on_registry_ready(). > > Bug: 1119807 > Change-Id: I60c16e04b75603a8d0979fd09e9f6746335cd788 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450133 > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Auto-Submit: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814065} TBR=dmurph@chromium.org,ericwilligers@chromium.org,alancutter@chromium.org,loyso@chromium.org Change-Id: I23471abd515c34d6262def80bc83613420f90622 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119807,1135469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450319 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#814143}
-
Nohemi Fernandez authored
This reverts commit 430b7621. Reason for revert: Failing builder https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel Original change's description: > [LayoutNG] Don't truncate margins after spanners. > > A column spanner forcefully breaks a column, so any leading margins on > content right after the spanner shouldn't be discarded. > > Bug: 829028 > Change-Id: I767466677d72be2760306ddd531e847f52cfa8ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445482 > Reviewed-by: Alison Maher <almaher@microsoft.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813892} TBR=ikilpatrick@chromium.org,mstensho@chromium.org,almaher@microsoft.com Change-Id: I535ec21071aacd85f22968286e0f920fd2870324 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450062Reviewed-by:
-
Alexander Bolodurin authored
Split fileManagerPrivate.getThumbnail() into getDriveThumbnail() and getPdfThumbnail() to allow implementation-specific arguments: PDF thumbnailer supports size arguments, Drive thumbnailer only supports crop and, in future, others that may have their own (and different) argument needs. For getPdfThumbnail(), pass through size arguments from the image loader request to the PDF thumbnailer and pull up default values from C++ to the image loader JS code, to make them usable in other thumbnailers that take explicit dimension arguments. Bug: 1049966 Change-Id: Ia17a32028a7fb510c1755c9fa0283f9a37978331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434013 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814141}
-
Boris Sazonov authored
PrimaryAccountManager.IsAuthenticated was only checking sync account and wasn't fitting into the new consent-aware API for the primary account. This CL introduces HasPrimaryAccount(ConsentLevel) and replaces existing calls to IsAuthenticated with HasPrimaryAccount(kSync). Subsequent CLs will replace HasUnconsentedPrimaryAccount with HasPrimaryAccount(kNotRequired) and so on. Bug: 1046746 Change-Id: I2118ecbfc2295b9c437de304fd8617e1d13665aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440621 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#814140}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org NOTRY=True Bug: 1134724 Change-Id: I8b3bf9d6e9c204854d16a082ff3a2c7987a36755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452090Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814139}
-
Patrick Brosset authored
When initiator objects are created for parser and script type requests a line number is passed, so that clients can possibly link http requests to locations in source files. For some reasons, only the line number is passed and not the column. This means that for minified files (where all content is on one line) it is impossible to link to the exact location. Furthermore, clients like DevTools which know how to re-format minified files won't be able to link to the right line once a file is re-formatted. The column number is already available in the TextPosition object that is set in FetchInitiatorInfo, so in this change, we just return it to the client too. Corresponding frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2444236/ Bug: 1134064 Change-Id: I297924c3a22176309bd0fe4b613f7f1a42163ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442367Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814138}
-
Kenichi Ishibashi authored
This CL removes AppCacheResponseReader dependency from ServiceWorkerResourceWriter by re-implementing resource writing logic. See [1] for the reasoning of the rewrite. [1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/edit?usp=sharing This CL should not have behavior changes, and existing tests like ServiceWorkerResourceStorageTest cover this change. Bug: 1117369 Change-Id: I2fe4075ddff1c185768e0dd245e49f1ac5c26962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430687 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814137}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/da61c40e99c3..08142700a841 2020-10-06 ianelliott@google.com Work-around test runner & DebugAnnotator 2020-10-06 jmadill@chromium.org Test Runner: More docs. 2020-10-06 cclao@google.com Vulkan: Defer the depthStencil buffer layout change to endRenderPass 2020-10-06 ianelliott@google.com Plumb EntryPoint & Context to DebugAnnotator/EVENT() 2020-10-06 cclao@google.com Vulkan: Add plumbing to render pass when ImageHelper gets deleted If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I5459486104af4c641a700789b2e449d91fdb139f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451893Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fa5ff7d234b8..00dc0bcb4d54 2020-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 500704812409 to 77e3d0ae97b6 (22 revisions) 2020-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b3c1e71eb1cb to afe6ca45b6da (4 revisions) 2020-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2cd17d78 to 4259b6b6 (463 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Test: Test: Test: Temple Run on multiple systemsTest: Test: angle_perftests --gtest_filter="*Trace*" Change-Id: Ie7a8889ac3d4d4390b9ef9d9b334824a79ca6387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451692Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601942192-5610f8208d2a00c81b789319176c3ce4858b86b7.profdata to chrome-linux-master-1601963930-28f0c2d12f0ac8a2122590ec137db80f0d74ffd6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I19c0bcfbccf4170d2f7bcbb699eeeb19beb57858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451898Reviewed-by:
-
Yuki Shiino authored
Adds a unittest for the change of https://crrev.com/c/2418513 . Also removes unnecessary "#if defined" guards. All test cases in allocator_shim_unittest.cc depend on USE_ALLOCATOR_SHIM, so the entire contents of the file should be guarded with it. Currently it's done at: https://source.chromium.org/chromium/chromium/src/+/master:base/BUILD.gn;drc=625ee4c0eea632fed7825725d54843ef3cd6ca2c;l=3352 Bug: 1111332 Change-Id: I2204d88b676365b317e27f21baa0fb5ba8df213c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449869 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#814133}
-
Fredrik Söderqvist authored
This is largely a revert of the code-change from a77da2a9, since that workaround should no longer be required now that the visual rect no longer has bounds of clip-path, mask and filter baked in. Also replace the check of LayoutObjectCanHaveResources() with a DCHECK since this is guaranteed by the callers. Bug: 1028061, 1028063 Change-Id: I3cd7eef130468ca1bb2e6473535fac815a7bda1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450151Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#814132}
-
Gyuyoung Kim authored
This CL replaces all uses of EditingBehaviorType with mojom::EditingBehavior to reduce unnecessary type conversion. Bug: 1097943 Change-Id: I013e40a725d7b12f1f9d88a37f068e4163d1d399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#814131}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f76601902650..32decd42e68a 2020-10-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0ddbb9dc49f4002b274f65f39e88a5e80b7d7144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451645Reviewed-by:
-
Morten Stenshorne authored
Suspecting crrev.com/2333083 , but didn't check. TBR=ikilpatrick@chromium.org Change-Id: Idf7a1156bccdf78adf6743ae4e7d703a9198cb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450059Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#814129}
-
Fredrik Söderqvist authored
Rather than letting the container of the LayoutObject manage the SVGResources, have it manage it itself via InsertedIntoTree() and WillBeRemovedFromTree() overrides. This allows limiting the checks in the called methods a bit since we know what LayoutObjects it's being called on. Bug: 1028063 Change-Id: I54b28336649c6c200dcf4c220fd869fe66770119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450050Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ibbe33355abdb999f7afb612bb3ab6c8b9b93178c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451812Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814127}
-
Colin Blundell authored
This CL splits out the ContentSubresourceFilterThrottleManager test implementation of SubresourceFilterClient from the test fixture class. This is necessary for an upcoming change which will have the ThrottleManager own the client instance as part of simplifying the embedder-side responsibilities in advance of WebLayer bringup. It is also IMO more readable in any case. Bug: 1116095 Change-Id: I85fc42e393ecfa9cdaaa2148ee08f74f2324d00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443010 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#814126}
-
Marc Treib authored
The verifier profile doesn't always exist; notably it doesn't when running against external servers (aka E2E_TEST, aka KitchenSync). This fixes a test crash when running in that mode. Bug: 1135195 Change-Id: I163583c74e2139cd50f9d658657832d57550a3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450290 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814125}
-
Gauthier Ambard authored
This CL fixes which URL is used to set the document URL. The previous implementation was using the WebView URL. Some times this is not the same as the URL of the navigation. For example on the following workflow: 1. Start a navigation to about://newtab 2. Once the navigation1 reach DidStartNavigation, start a navigation to another page (e.g. http://example.com). 3. The URL of WebView is updated to http://example.com 4. The provisional navigation to http://example is starting 5. The navigaation1 (to about://newtab) is committed. At step 5, the documentURL should be the URL of the committed navigation (i.e. about://newtab), but the URL of the WebView is http://example.com. Fixed: 1127025 Change-Id: Icc271b87c1877bf005ee4454c863126aacb81127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418856 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#814124}
-
Sigurd Schneider authored
Follow-up to https://crrev.com/c/2450031, unlocks https://crrev.com/c/2450032 Bug: chromium:1135143 Change-Id: I792677962aa6de9ffcf20e7f4e6fe9300fbe0b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450149Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#814123}
-
James Cook authored
Move the ChromeOS.* prefixed metrics into their own file/directory. Most of these metrics are not general Chrome browser metrics, and this will let us have a separate OWNERS file once we train up some reviewers. Bug: none Change-Id: If42613c021c44e0e0639ec68db6f012416046c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446519 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#814122}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 988a0b63. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Ied524cd5922082cd36afb646f732ab9c96ce2eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451534Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814121}
-
Anders Hartvoll Ruud authored
We currently have several unit tests that check that some selector list containing :is or :where either fails or passes parsing. That's all well and good when selector lists are parsed the normal way, but with <forgiving-selector-list> [1] support (in a future CL), a simple selector :is(...) can't really fail parsing: it will just end up empty in the worst case. Hence, this CL makes preparations such that it's easier to write tests for these "partial" parse failures. While at it, tests are also converted to parametric tests. This makes it easier to run individual tests when something is failing. There should be no behavior change, nor any change in test coverage. [1] https://drafts.csswg.org/selectors/#typedef-forgiving-selector-list Bug: 568705 Change-Id: I81119599d378a5067cd3d08c5dbdc7e3de2f1ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450153Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#814120}
-
Takashi Sakamoto authored
AllocNewSlotSpan allocates kSuperPageSize memory if there is no available pages, but returns only 1 slot span. So AllocNewSlotSpan should make 1 slot span accessible. (the slot span size is provided by get_bytes_per_span()). This patch also fixes total_size_of_committed_pages. For normal buckets, total_size_of_committed_pages are updated in the following way: - PartitionBucket::AllocNewSlotSpan increases by get_pages_per_slot_span()*PartitionPageSize(). - PartitionBucket::SlowPathAlloc increases by get_bytes_per_span() when recommitting pages. - PartitionPage::Decommit decreases by get_bytes_per_span(). get_bytes_per_span() is not always equal to get_pages_per_slot_span()*PartitionPageSize(), because get_pages_per_slot_span() is a natural number of PartitionPages (calculated by get_system_pages_per_slot_span()). E.g. num_system_pages_per_span is 3 (0 < num_system_pages_per_span < MaxSystemPagesPerSlotSpan()). Change-Id: Ie46c9099086bd88afa6ee9f654cd98f21935d493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444671 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
Ce Chen authored
header into anonymous namespace. For simplicity I did not make any changes other than moving declarations, adjusting orders for these private functions/nested classes. Bug: 925072 Change-Id: Iafeaa2d71b18328061844721187e061bedeb32a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444674Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#814118}
-
Shakti Sahu authored
This CL 1 - Moves the top level Java code from chrome/android to chrome/android/app/video_tutorials 2 - Some other fixes from a previous CL Change-Id: I94ed7c3d97cfb537ff9c26c50b785fb7144defa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444131 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#814117}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org NOTRY=True Bug: 1134723, 1134724 Change-Id: I5e0cf1d84d01c37fbcaa47ea002179739b572880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451990Reviewed-by:
-
Fergal Daly authored
It is no longer called. Only 1 real implementation existed. Delete SetAsInterstitial from ContentSettingsAgent, it's unused now. Change-Id: I995a6944115e192a4c213b8f3689130414458927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397110 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#814115}
-
Marko Ivanovich authored
The test ChildFrameCrashMetrics_ScrolledIntoView might fail if we wait for WidgetHostMsg_WaitForNextFrameForTests_ACK, because it is sent from compositor thread, almost independently from FrameHostMsg_UpdateViewportIntersection, which is sent from main thread. Problem can be reproduced deterministically if we put sleep in RenderFrameProxy::UpdateRemoteViewportIntersection, to simulate preemption by OS scheduler. What we really want to wait for in this test is viewport intersection update in UI thread. Only after that we can check histograms. If we wait for lifecycle update, that will guarantee that all IPCs are processed in browser, including FrameHostMsg_UpdateViewportIntersection. Change-Id: I1ff2e6632b2f1391a3dee82b2bc6667bb20bf71d Bug: 1115096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307373Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#814114}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/315b9a55a9b5..f76601902650 2020-10-06 kimanh@chromium.org Skip wasm stepping tests until naming is fixed in v8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134531 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I40c50dc7dd68070cf496c36b432e1e3c6bff179a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451427Reviewed-by:
-
Aaron Leventhal authored
This will help online word processors such as Google Docs mark which elements in the page are repeated content. There are no specific ATK/IA2 role mappings currently. For now, ATs on Windows and Linux can use the xml-roles object attribute. See https://w3c.github.io/dpub-aria/#doc-pagefooter and https://w3c.github.io/dpub-aria/#doc-pageheader AX-Relnotes: Add new doc-pageheader and doc-pagefooter roles from DPUB-ARIA 1.1. Skip-Translation-Screenshots-Check: True Bug: 1134999 Change-Id: If360a51eb44c1cf2beb1315f1ba48134513dddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448689 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814112}
-
Ramin Halavati authored
Metrics are added to measure different code paths in off-the-record profile destruction, specifically when destruction is delayed due to delayed RPHs. Bug: 1033903 Change-Id: Ibc8c82c3f8c4d569c34e57aad1b508eff9eb32c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440625Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#814111}
-
Kent Tamura authored
Move the main logic of |LayoutTextControl:: ComputeIntrinsicLogicalWidths()| to TextAreaIntrinsicInlineSize() and TextFieldIntrinsicInlineSize() in layout_box.cc like other form controls' intrinsic sizes in order to share the code with LayoutNG. * CalculateMinMaxSizesIgnoringChildren() and |LayoutBlock:: ComputeIntrinsicLogicalWidths()| <textarea>'s intrinsic size should not depend on scrollbar existence. So we need to subtract the scrollbar thickness if a scrollbar exists. This CL has no behavior changes. Bug: 1040826 Change-Id: If864ca96c0cdc4409b465b90cb4be018dd0f14c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449673Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/347e5dc37127..fa5ff7d234b8 2020-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ed3a93f690de to 326e14f34bb5 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I0c5b069efa5da017a9ee6583900a619a6ec1c454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451642Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fca083c57b5f..3a384ed186dd 2020-10-06 thestig@chromium.org Use DCHECK_IS_ON() in cfx_char.cpp. 2020-10-06 nigi@chromium.org Roll v8/ c577d027e..88d84cce1 (632 commits) 2020-10-05 nigi@chromium.org Roll buildtools/ ff93f3ea1..4be464e05 (3 commits) 2020-10-05 nigi@chromium.org Roll third_party/instrumented_libraries/ 3c52ccdd3..6ba978ccb (1 commit) 2020-10-05 nigi@chromium.org Roll third_party/skia/ d20e8e933..4c3486e6f (572 commits; 1 trivial rolls) 2020-10-05 nigi@chromium.org Disable embedder tests which fail with Skia/SkiaPaths enabled. 2020-10-05 nigi@chromium.org Roll third_party/libjpeg_turbo/ 9d4f8005b..d5148db38 (12 commits) 2020-10-05 nigi@chromium.org Roll third_party/zlib/ d53accfbd..26211a5a8 (6 commits) 2020-10-05 tsepez@chromium.org Pass spans of floats to CPDF_ColorSpace::GetRGB(). 2020-10-05 thestig@chromium.org Make variable naming consistent in CPDF_TextPage::GetRectArray(). 2020-10-05 thestig@chromium.org Replace ASSERT() with DCHECK() in various xfa dirs. 2020-10-05 nigi@chromium.org Roll third_party/icu/ 79326efe2..aba3f0dfe (8 commits) 2020-10-05 thestig@chromium.org Move FPDFText_GetLooseCharBox() logic into cpdf_textpage.cpp. 2020-10-05 nigi@chromium.org Roll third_party/depot_tools/ ed15af5c4..422c039e8 (82 commits; 44 trivial rolls) 2020-10-05 thestig@chromium.org Move CAgg_PathData out of fx_agg_driver.h. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I032363e1edfff4cdb5378ca692070f30fef64097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451889Reviewed-by:
-
Yusuf Sengul authored
Bug: 1133940 Change-Id: I814be90c998fbfae5f9456c00f62f82c5f518af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441297 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#814107}
-
