GitLab

Revert of Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes (patchset #2 id:20001 of https://codereview.chromium.org/1626163002/ )

Reason for revert:
Broke compile:
../../ui/accelerated_widget_mac/display_link_mac.cc:94:69: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
      CVDisplayLinkSetOutputCallback(display_link_, nullptr, nullptr);
                                                    ~~~~~~~         ^

Original issue's description:
> Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes
>
> The CVDisplayLink is tied to a ScopedTypeRef data member of DisplayLinkMac.
> However, there may be other references. Since there's no guarantee that
> ~DisplayLinkMac() will invoke the last CVDisplayLinkRelease(..) and clear
> the callback automatically, clear it explicitly in ~DisplayLinkMac.
>
> BUG=564780
>
> Committed: https://crrev.com/2286ddf0119516f7a93feaff4f8ce2edff8c4543
> Cr-Commit-Position: refs/heads/master@{#371648}

TBR=ccameron@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=564780

Review URL: https://codereview.chromium.org/1637313002

Cr-Commit-Position: refs/heads/master@{#371724}

https://chromium.googlesource.com/chromium/src/+/38858c577

BUG=568196
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1641513002 .

Cr-Commit-Position: refs/heads/master@{#371723}

https://chromium.googlesource.com/chromium/src/+/4c58d12a8

BUG=570611
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1640603002 .

Cr-Commit-Position: refs/heads/master@{#371722}

This change ensures we don't add when we should be replacing
composited "points" animations when list lengths are mismatched.

BUG=530436

Review URL: https://codereview.chromium.org/1635363002

Cr-Commit-Position: refs/heads/master@{#371721}

BUG=n/a
TEST=n/a; no behavior change

Review URL: https://codereview.chromium.org/1634603003

Cr-Commit-Position: refs/heads/master@{#371720}

https://chromium.googlesource.com/chromium/src/+/99aaed809

BUG=569950
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1640593002 .

Cr-Commit-Position: refs/heads/master@{#371719}

Common practice is to call Handle{Open/Read/Write}Result() when
using the leveldb database. Those functions will close the db
upon error - invalidating any open iterators. These calling
functions use scoped_ptr's for iterators which, upon error,
would delete an invalid leveldb::Iterator instance.

ServiceWorkerDatabase::DeleteResourceRecords()
ServiceWorkerDatabase::DeleteUserDataForRegistration()
ServiceWorkerDatabase::GetAllRegistrations()
ServiceWorkerDatabase::GetOriginsWithForeignFetchRegistrations()
ServiceWorkerDatabase::GetOriginsWithRegistrations()
ServiceWorkerDatabase::GetRegistrationsForOrigin()
ServiceWorkerDatabase::ReadResourceIds()
ServiceWorkerDatabase::ReadResourceRecords()
ServiceWorkerDatabase::ReadUserDataForAllRegistrations()

BUG=579624

Review URL: https://codereview.chromium.org/1635223002

Cr-Commit-Position: refs/heads/master@{#371718}

https://chromium.googlesource.com/chromium/src/+/7003bed16

BUG=453040
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1638223002 .

Cr-Commit-Position: refs/heads/master@{#371717}

https://chromium.googlesource.com/chromium/src/+/19dc3bf7a

BUG=568559
TBR=yjaeseok@gmail.com

Review URL: https://codereview.chromium.org/1640073002 .

Cr-Commit-Position: refs/heads/master@{#371716}

Cr-Commit-Position: refs/heads/master@{#371715}

This CL updates the site engagement service's score value for user input
events. In order to maintain compatibility with current tests, old score
values that are used for testing have been hard coded into
SiteEngagementService.

BUG=464234

Review URL: https://codereview.chromium.org/1622413002

Cr-Commit-Position: refs/heads/master@{#371714}

https://chromium.googlesource.com/chromium/src/+/eec72142e

BUG=524134
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/1640063002 .

Cr-Commit-Position: refs/heads/master@{#371713}

leveldb iterators must be deleted before closing the database or
else a crash will ensue.

BUG=581474

Review URL: https://codereview.chromium.org/1639043002

Cr-Commit-Position: refs/heads/master@{#371712}

We do it in command buffer so it's duplicated validation.

BUG=570453
TEST=webgl_conformance
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/1639103002

Cr-Commit-Position: refs/heads/master@{#371711}

This allows <style> tags in HTML files to be checked for style guide
errors.

BUG=None

Review URL: https://codereview.chromium.org/1639863004

Cr-Commit-Position: refs/heads/master@{#371710}

This is part of my (apparently neverending) goal to get the battor agent
unit tests on the waterfall.

TBR=zhenw@chromium.org,nednguyen@google.com

Review URL: https://codereview.chromium.org/1634263004

Cr-Commit-Position: refs/heads/master@{#371709}

Having deprecated stylesheet links with unsupported MIME types in
https://codereview.chromium.org/1501393003, this patch removes the
capability, updates the affected tests, and removes the UseCounter and
deprecation warning.

This patch also updates the preload scanner to ensure that the resources
are not preloaded, and adds a test to check for this.

BUG=286682

Review URL: https://codereview.chromium.org/1623403002

Cr-Commit-Position: refs/heads/master@{#371708}

The only caller ResourceLoader::willFollowRedirect() has ASSERT on
redirectResponse. So, we can assert that it's not null here too.

BUG=none
R=mkwst

Review URL: https://codereview.chromium.org/1634943003

Cr-Commit-Position: refs/heads/master@{#371707}

These macros are defined such that trailing semicolons (or inner
semicolons) have no effect, and they are overwhealmingly used without
semicolons, as per the documentation in ipc_message_macros.h.

Review URL: https://codereview.chromium.org/1639713002

Cr-Commit-Position: refs/heads/master@{#371706}

BUG=576864
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1640483003

Cr-Commit-Position: refs/heads/master@{#371705}

process_->GetProcess() will fail in this case, so don't bother with these checks. In this case they don't matter because the GPU isn't being sandboxed anyway.

BUG=580921

Review URL: https://codereview.chromium.org/1638623002

Cr-Commit-Position: refs/heads/master@{#371704}

BUG=

Review URL: https://codereview.chromium.org/1638563002

Cr-Commit-Position: refs/heads/master@{#371703}

This CL adds missed uniform type in
https://codereview.chromium.org/1349793004. Full supported uniform type
can be found in Table 2.10, es spec 3.0.4 page 64.

BUG=429053

Review URL: https://codereview.chromium.org/1635973002

Cr-Commit-Position: refs/heads/master@{#371702}

Fixing up unit tests was somewhat complex due to XP being
used as a key test case throughout. We have essentially
updated the unit tests here to treat Win7 as the new XP,
and Win10 the way Win7 was previously.

Also remove dead ALL_BASELINE_VARIANTS constant and
accessor methods, and document the one remaining
(used by queries_unittest.py) for subsequent cleanup.

BUG=581240

Review URL: https://codereview.chromium.org/1624373005

Cr-Commit-Position: refs/heads/master@{#371701}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/713f7a351c2c..e314e3752a98

$ git log 713f7a351..e314e3752 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1639963003

Cr-Commit-Position: refs/heads/master@{#371700}

Our handling of it is pretty incorrect, leading to very poor results. See the testcase in the bug.

This was caused by https://codereview.chromium.org/1421423005

BUG=580196
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1631033003

Cr-Commit-Position: refs/heads/master@{#371699}

The image is suitable for -webkit-border-image layout tests wanting a
border image with a color profile (sRGB in this test image).

TBR=radu.velea@intel.com
BUG=537077
NOTRY=true

Review URL: https://codereview.chromium.org/1636503007

Cr-Commit-Position: refs/heads/master@{#371698}

This patch introduces |SelectionAdjuster| class to consolidate functions
adjusting DOM tree version and composed tree version of selections in
|VisibleSelection| class and |SelectionEditor| in one place to avoid having
six parameters constructor, and rude name function |createWithoutValidation()|
to simplify source code for improving readability.

Note: For ease of reviewing to compare changes, this patch doesn't leave
functions in original place. Following patch moves them to
"SelectionAdjust.{cpp,h}".

This patch is a preparation of introducing |m_hasTrailingWhitespace| into
|VisibleSelection| class, which makes six parameters constructor to seven
parameters constructor without this patch.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1630903005

Cr-Commit-Position: refs/heads/master@{#371697}

The ozone gbm overlay candidate maintains a cache of layer configurations
that have previously been validated by the kernel display system. This is
unnecessary. Relocate the cache to the global overlay manager to simplify
the implementation of pluggable host to gpu communication.

BUG=558602

Review URL: https://codereview.chromium.org/1631073002

Cr-Commit-Position: refs/heads/master@{#371696}

 * Do not convert inputs for child frames because they're already converted
 * Use 1x dsf for the child frame's surface. This is a stopgap solution. I'll address it in a separate CL.
 * Convert the guest view size to css in browser_plugin as all use of the size expects css coordinates.

BUG=485650
TEST=WebViewWithZoomForDSFTest.*

Review URL: https://codereview.chromium.org/1586923002

Cr-Commit-Position: refs/heads/master@{#371695}

Workaround to fix playback of some 22050 Hz sample rate TuneIn radio
stations that do not play through optical out on some AVRs. In
particular, Denon receivers do not support 22050 Hz optical out
playback.

The audio is resampled to either the current mixer output sample rate
(if valid) and kFallbackSampleRate (48000 Hz) otherwise.

BUG=internal b/26385501
TEST=fling 22050 Hz sample rate WAV file
     1) to a freshly booted device, and
     2) to a device that was playing a 64 kHz sample rate WAV file.

Review URL: https://codereview.chromium.org/1632393002

Cr-Commit-Position: refs/heads/master@{#371694}

Use a list of observers instead of creating a new one each time, so we
only have one per tab.

BUG=577735

Review URL: https://codereview.chromium.org/1637613003

Cr-Commit-Position: refs/heads/master@{#371693}

This removes a dependency on the NACL_WINDOWS macro, which is defined
in non-public native_client headers.

It also gets the benefit of the error-checking that base/ does for
close()/CloseHandle().

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Review URL: https://codereview.chromium.org/1640523002

Cr-Commit-Position: refs/heads/master@{#371692}

This change adds one HittestData structure per surface and a HittestDelegate in RenderWidgetHostInputEventRouter that can reject surfaces based on the HittestData.

BUG=491334

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1489913003

Cr-Commit-Position: refs/heads/master@{#371691}

BUG=581575
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/1640483004

Cr-Commit-Position: refs/heads/master@{#371690}

Part 7.

Add menu item to Media Router contextual menu to toggle the cloud services preference. It will be checked if cloud services is currently enabled.

This will only appear in Chrome branded builds.

BUG=560457

Review URL: https://codereview.chromium.org/1582143002

Cr-Commit-Position: refs/heads/master@{#371689}

https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/e654eb7..f85e852

BUG=579384

Review URL: https://codereview.chromium.org/1639053002

Cr-Commit-Position: refs/heads/master@{#371688}

ResourceDispatcherHostImpl::AddResourceContext() is called on the UI thread,
but all other users of |active_resource_contexts_| access it on the IO thread.

Review URL: https://codereview.chromium.org/1600263002

Cr-Commit-Position: refs/heads/master@{#371687}

Revert of MSE: Relax the 'media segment must begin with keyframe' requirement (patchset #13 id:240001 of https://codereview.chromium.org/1091293005/ )

Reason for revert:
Two regressions:
BUG=581125,581458

The latter causes NFLX playback stall. Reverting to fix canary, even if the latter's eventual fix might be external (e.g. NFLX web app).

To allow revert to currently failing code format rules:
NOPRESUBMIT=true

Original issue's description:
> MSE: Relax the 'media segment must begin with keyframe' requirement
>
> The current version of the MSE spec no longer requires that media segments
> start with a keyframe. This change reworks the MSE implementation
> so that it now allows tracks within media segments to not begin
> with a keyframe.
>
> To accomplish this requirement's relaxation, this CL:
> 1) Separates media segment signaling from coded frame group signaling:
>    MSE stream parsers need to report whether or not they are currently
>    in the middle of parsing a media segment, such as a WebM cluster, to
>    comply with spec disallowance of certain operations like changing
>    SourceBuffer appendMode when appendState is PARSING_MEDIA_SEGMENT.
>    However, SourceBufferStream only needs to be signaled when a new coded
>    frame group is beginning, for example when buffers are appended
>    following a discontinuity.
> 2) Since the FrameProcessor now can transitively signal SourceBufferStreams
>    when a new coded frame group is beginning (which might span multiple
>    media segments), the SourceBufferStream can rely upon the fact
>    that the next buffer appended must be a keyframe if it's been told
>    that a new coded frame group is starting. A CHECK() is included.
> 3) New ChunkDemuxerTests.
> 4) Various test cleanup to conform to the distinct "new coded frame group"
>    and "new media segment" signaling separation, as well as removal
>    of decode error verification when a media segment doesn't begin
>    with a keyframe.
>
> Note that the FrameProcessor already drops non-keyframes prior to the
> first keyframe processed for a track following a discontinuity,
> and the SourceBufferStream already drops non-keyframes prior to the
> first keyframe processed for a track following a range removal that
> removed the last appended position in the current coded frame group.
>
> BUG=229412,459546
> R=chcunningham@chromium.org
> TEST=Updated ChunkDemuxerTests, SourceBufferStreamTests,
> FrameProcessorTests. Also locally tested: bug 459546's
> original report no longer fails. A sample webm VP9 file
> from b/26524063 no longer fails. GPM webm vp9/opus test no
> longer fails. Bug 518854's original report's "flags_all.mp4"
> no longer fails.
>
> Committed: https://crrev.com/3d152e528e97024860822d3e75109c0c597bf4de
> Cr-Commit-Position: refs/heads/master@{#371018}

TBR=chcunningham@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=229412,459546

Review URL: https://codereview.chromium.org/1637213002

Cr-Commit-Position: refs/heads/master@{#371686}

Revert of [Android] Set enable_remoting=true by default (patchset #1 id:1 of https://codereview.chromium.org/1619913002/ )

Reason for revert:
This CL broke some of the internal builders which are building "all".

remoting_cardboard_extract_native_lib should be behind an target_arch=="arm" if statement

Original issue's description:
> [Android] Set enable_remoting=true by default
>
> We set enable_remoting=true in the command line on the official builders. Set
> enable_remoting=true as the default on Chromium as well.
>
> BUG=544298
>
> Committed: https://crrev.com/9fdef29316fae0cf8ba6c7258b434432d40eb175
> Cr-Commit-Position: refs/heads/master@{#371604}

TBR=lambroslambrou@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=544298

Review URL: https://codereview.chromium.org/1634353003

Cr-Commit-Position: refs/heads/master@{#371685}