- 05 Mar, 2020 9 commits
-
-
Nina Satragno authored
When an excluded credential is found, the spec says InvalidStateError should be returned. The test was expecting a NotAllowedError, fix that. Bug: 875444 Change-Id: I034ea2c270909895f8935a5c5a4d659b6c7327dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088000 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#747018}
-
btolsch authored
TBR=tbarzic@chromium.org Bug: 1057814, 1057777 Change-Id: Iedad8ba38e635ad969e55e971394d30f71c994b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088672Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747017}
-
Alexey Baskakov authored
Historically, we stored OS-specific shortcut files in a directory, specified by GetWebAppDataDirectory function: <ProfileDir> Web Applications _crx_<app_id> From now, we have a clear separation between Manifest Resources vs. OS-specific integration Resources. (see https://chromium-review.googlesource.com/c/chromium/src/+/2084215) We should rename GetWebAppDataDirectory function to GetOsIntegrationResourcesDirectoryForApp to reflect this change. We can't rename the underlying directory name: it would require a migration for all existing user profiles in the wild. This CL doesn't introduce any behavior changes. Bug: 877898 Change-Id: I41a636b2a86afa4196d68e5cc3f236d3e813cdbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086459 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#747016}
-
Daniel Cheng authored
Change-Id: Ic7b137d39ac73f280c307e0af53125df957451c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088015Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747015}
-
Tomasz Wiszkowski authored
Link to recent failures: http://shortn/_HrAAo0lrn8 TBR=sandromaggi@chromium.org Bug: 1058599 Change-Id: I71a98fb1b0a38e65eef9b331ac544cf955d3b33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088298Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#747014}
-
Pavol Marko authored
The feature is being used for packaged licenses and maybe also for initial enrollment soon, so the histograms are still interesting. Bug: 1053198, 1053197, 1053196, 1053195, 1053194 Change-Id: I6a1857c08e0150491b3511b7740d04f5174a662b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078912 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#747013}
-
Daniel Clark authored
Reland "Fix null check preventing AXObjectCacheImpl from registering as popup document lifecycle observer" The change was reverted because a couple of the updated tests were failing on older mac platforms. Apparently opening the date/week popops fires different numbers of events on these platforms. Since the point of the tests is to observe events fired from focus changes in an opened popup, I changed the tests to start logging events only after opening the popup. I've also modified them to provide some logging in the event of a failure instead of just timing out opaquely. Initial change description follows: Fix the polarity on a couple of null checks that were preventing AXObjectCacheImpl from registering as a lifecycle notification observer for popup documents. This failure to register was preventing AX focus events from being fired when focus changed inside of a popup. The week-picker-ax.html test was passing prematurely because of focus events received when opening the popup, without validating that additional events were fired when changing focus in the popup. Update that test to confirm that events are also fired for a focus change in the popup itself. There were a couple of analogous tests (date-picker-ax.html, month-picker.html) that were deleted when we purged old date popup tests in favor of new tests written for the new popup implementation (crrev.com/c/1967608). I don't see replacements for these in the new tests, so this change also restores those tests, updates them for the structure of the new form controls, and ensures that they are checking that focus events are fired due to changes in the popups and not just from events fired when the popups open. TBR=aboxhall@chromium.org Bug: 1022920, 1057036, 1057044 Change-Id: I8792ea074e89967c7ff68e21dfda8e0f6ba6f9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080459 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#747012}
-
Jae Hoon Kim authored
DlcserviceClient should make the life of callers as easy as possible. Since dlcservice returns a busy status: - when a platform side dlcservice client starts an installation. - when update_engine is busy performing actions. This change allows callers in Chrome to not worry about the busy status. BUG=chromium:1053745 TEST=out/Default/unit_tests --gtest_filter=Dlcservice* Change-Id: Iae6a75567345c3615662dddde2479141ab80098a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079213Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#747011}
-
Richard Townsend authored
armasm64.exe is Microsoft's reference compiler for 64-bit Arm assembly code. This is needed to make sure that V8 can be tested and cross-compiled under MSVC for Windows on Arm systems. Bug: v8:10012 Change-Id: Id1b9ab7bb0cc96179a707e9746f9e78e8da30de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071941 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#747010}
-
- 04 Mar, 2020 31 commits
-
-
Tina Wang authored
- CreatorMetaData stores the creator's general info. - Pass NavigationHandle object to EntryPointCoordinator as a input to fetch data. - Delete ProfileCardData because the creator meta data and the content preview data will be fetched separately. - Added DEPS Bug: 1057256 Change-Id: Iba41128235f04663c33a05f241e99faefe603304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079268Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747009}
-
James Forshaw authored
This CL adds support to the sandbox to define a random restricted SID for a single process. This combined with modifications to the DACL allows a process to access itself but no other process defined using the same lockdown type. This CL does not currently enable it for any sandbox type. Bug: 1057218 Change-Id: Iadd98cdc7331f5fe0c9ae8f414be8af64c5eeb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085751Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#747008}
-
Bailey Berro authored
This change adds a boolean histogram to track the result of a user reaching the DisplayChangeDialog Bug: 1051235 Change-Id: I483742dff98bd542dadfe1b46854e43b85ded6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050791 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#747007}
-
Bailey Berro authored
This change extends Hardware.Display.Count.OnStartup and Hardware.Display.Count.OnChange through June. Change-Id: I9a4e4fc1a72be7dc7d8d3a527bcd29ccfaa05777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071328 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of moving OS specific strings from settings_strings.grdp to os_settings_strings.grdp, specifically app section page strings. Bug: 967883 Change-Id: If69eedde2e9ee88c06aea91d73b3f744340249a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064827 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#747005}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e894e9c5869f..31b40ecf7208 git log e894e9c5869f..31b40ecf7208 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 mathias@chromium.org Revert "Support emulating vision deficiencies" Created with: gclient setdep -r src/third_party/devtools-frontend/src@31b40ecf7208 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003700 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1038ebb64527f7efca10948bafc7d8cb7ed91e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747004}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2e6cd9c400d1..a095711c5d77 git log 2e6cd9c400d1..a095711c5d77 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 amaiorano@google.com Subzero: implement Short4::Short4(RValue<Float4) Created with: gclient setdep -r src/third_party/swiftshader@a095711c5d77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9899645606962122893e59889a3d34fac2e0ac01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088269Reviewed-by:
-
Daniel Cheng authored
The last few enums being recorded were for geolocation and appcache. Both of these are disallowed for insecure origins already. This happens to remove the last usage of several RAPPOR helpers in Blink, which ends up transitively removing the usage of a lot of other code as well. :) Fixed: 1031597 Change-Id: I52b048f64ddeafad64c59372173e6009174c2780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081355Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ddac4370..da29ae6f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2737ae47e27426d629cf6ae6f2dabb690f11fb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088068Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747001}
-
Miguel Casas authored
gfx::BufferFormat::BGRX_1010102 was landed as a Chromium-name for XR30 to support GMBuffer allocation of GL_RGB10_A2, particularly on Mac. This was a bit of a misunderstanding on my side: we should operate using an alpha format and only use the opaque format when trying to import a buffer of this type via EGL on CrOs Intel, similar to e.g A/XB24 etc (See GetFourCCFormatForOpaqueFramebuffer()). This CL does **only**: - sed -i -e 's/BGRX_1010102/BGRA_1010102/g' `grep -rn BGRX_1010102 cc components gpu media ui | cut -d: -f 1 | uniq` - sed -i -e 's/image_xr30/image_ar30/g' `grep -rn image_xr30 cc components gpu media ui content | cut -d: -f 1 | uniq` Leaving fixing resource_format_utils.cc and gl_image_io_surface.mm for the new format, and the DRM related changes to the follow up CLs. TEST=display and gl_unittests passing and http://crosvideo.appspot.com/?codec=vp9.2_30&loop=true&mute=true reproducing correctly on Mac. Bug: 949260 Change-Id: I9ccb3d39d4c4b6ac4465fa575cb6e5001100b040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068722Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#747000}
-
Yuwei Huang authored
This CL makes the host log the last time it receives an FTL pong before sending out a heartbeat to help us debug and see if the unresponsive host is caused by a dead FTL connection. It also CHECKs that to make sure the channel isn't inactive for too long. Bug: 992722 Change-Id: I2c93266ee6cc7586e9192ca8fde98e1ded37dd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086322 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#746999}
-
Shakti Sahu authored
Bug : 1058541 Change-Id: If4c7c67979ea3726b4e8216ae2f4c7baa9c0229b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083408 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746998}
-
btolsch authored
This test is failing consistently on linux-chromeos-dbg. TBR=antrim@chromium.org Bug: 1058582 Change-Id: I377b7ab4308c64195ab6fc1b6a36dfbf5643901f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088350 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/fafbe9aa6586..783d9f6c614f git log fafbe9aa6586..783d9f6c614f --date=short --first-parent --format='%ad %ae %s' 2020-03-04 rwkeane@google.com Discovery: E2E test #4 Created with: gclient setdep -r src/third_party/openscreen/src@783d9f6c614f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I53c6429955d322e52e5123b34c7498797a22b217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088451Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c8921b8e2f4..7ef887c89d5c Created with: gclient setdep -r src-internal@7ef887c89d5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:10052460,chromium:1052490 Tbr: jbudorick@google.com Change-Id: Ifb9cc0ffbd565143e829ec83672e93bc046cc3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088268Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746995}
-
Michael Sun authored
Add a new function in cras_audio_client to support propagate media track duration/length to Chrome OS via DBUS CRAS Control Interface. As Bluetooth Stack (BlueZ) and MPRIS defined media duration to be a part of metadata, SetPlayerDuration function will wrap the duration informatio into the metadata format and forward it to DBUS. BUG=b:147365563 TEST=chromeos_unittests Change-Id: I3a6b91247a58f8898fa05f0dfe89195cdbfe7c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081262 Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746994}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec2a6ce2706a..1a83da1f41e9 git log ec2a6ce2706a..1a83da1f41e9 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 ehmaldonado@google.com git-cl: Fix Python 3 bugs Created with: gclient setdep -r src/third_party/depot_tools@1a83da1f41e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1058318 Tbr: agable@chromium.org Change-Id: I4f6b1c0882eb697c877ebe9249fec838dfc34aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088270Reviewed-by:
-
Alex Cooper authored
crrev.com/c/2076431 revealed an underlying race condition from the "TestDeviceServiceDisconnect" test case, where there is essentially a race between when the IsolatedVRDeviceProvider receives the disconnect from the underlying device provider and when the BrowserXrRuntime would receive it's own disconnect from the underlying device. If the IsolatedVRDeviceProvider wins the race, the BrowserXRRuntime may be removed before it can notify the VRService that it (and the session it is responsible for) is being ended. Because the renderer process has its own pipe to the device process, it is notified of the disconnect (and ended session), even if the Browser doesn't till it about this termination. The end result is that the only state that doesn't end up eventually getting cleaned up is that of the session metrics helper, which thinks that a session is still active, and may hit a DCHECK when attempting to start a new session. Change-Id: I5a448130cab0bc245cd4f3e6ef77e44512a89652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081528 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#746992}
-
Tomasz Wiszkowski authored
Link to recent failures: - http://shortn/_sGovNZOiod Bug: 1058304 TBR=aluo@chromium.org Change-Id: I1202e6b29c4a60b7f4ca0c7e470b95c1795796ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088631Reviewed-by:
-
Tomasz Wiszkowski authored
Failing recent runs: - http://shortn/_iuToiRvilM TBR=aliceywang@chromium.org Change-Id: Ia619f29f09f803017c825c9eff8b63479ec05947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088505 Commit-Queue: Ender <ender@google.com> Reviewed-by:
-
Fergus Dall authored
This fixes a crash that occurs because when the crostini installer processes a cancelation, it will abort the running restart and then call another method that cancels all restarts. This causes the completion callback to be run multiple times. Bug: 1052262 Change-Id: I4d7f18db7506162994000363fb687cc322c9c32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086467Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#746989}
-
Ken Rockot authored
Adds an ErrorPolicy setting to base::FileEnumerator. By default (ErrorPolicy::IGNORE_ERRORS) all FileEnumerators behave as they always have. If set to ErrorPolicy::STOP_ENUMERATION however, a FileEnumerator will cease enumeration as soon as it encounters any error, and the corresponding error code can be retrieved from the FileEnumerator. The motivation for this change is that some existing logic in third_party/leveldb/env_chromium.cc duplicates most of FileEnumerator's behavior just to work around the lack of error reporting. This change will allow the code to be de-duplicated without disturbing error reporting histograms. Bug: 1052045 Change-Id: I0639029403fe42d1baef12075898e3cc9ec7f6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082559 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#746988}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.31-1583147204-benchmark-82.0.4072.0-r1 to 82-4044.31-1583147204-benchmark-82.0.4075.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6b91c89d4ff3c37a2ea21fb8b202dc41db2932c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088460Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements the changeCompromisedPassword Extension API in chrome.passwordsPrivate. It adds corresponding functionality to PasswordCheckDelegate and adds an id member to CompromisedCredential to be able to uniquely identify a given credential. Bug: 1047726 Change-Id: I3a136b1048bcd44c7f498c85cd0295839b106d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080556 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746986}
-
Nicholas Verne authored
When a Chrome session crashes, a Linux VM may still be running. We detect this case on Chrome startup by testing a call to VmConcierge via the CrostinManager's ListVmDisks call. If the call succeeds, Concierge is still running and we assume a Vm is still running. When next the user launches a Crostini app, we show the CrostiniRecoveryView and they can select between (shutting down and) Restarting Crostini, or launching the terminal in the current VM so they can attempt to recover data manually via the command line. Bug: 1057899 Change-Id: I337d9721a642555d9cd1f7b034d5c680b38cb9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084213 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#746985}
-
Dmitry Gozman authored
Merge the following callbacks, which are being called at the same time: - DidStartProvisionalLoad; - DidCreateNewDocument; - call_before_attaching_new_document; - DidCommitProvisionalLoad. All of the above is replaced with DidCommitNavigation. Drive-by: removed TestHistoryChildWebFrameClient, which can be replaced by GetDocumentLoader()->ReplacesCurrentHistoryItem() call. SubresourceFilteringWebFrameClient claimed importance of setting subresource filter before navigation commit. This is not relevant anymore, since main resource does not use loader and subresource filter for a long time already. Next step would be to simplify similar RenderFrameObserver callbacks. This corresponds to steps 7.d, 7.i from the doc linked to the bug. Bug: 855189, 555773 TBR: tommycli@chromium.org, thestig@chromium.org Change-Id: Ia424b7f9b6761f2c5c354f10e120c2b3419b920a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882575 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746984}
-
S. Ganesh authored
The unit test failed with ERROR_DUPLICATE_SERVICE_NAME, "The name is already in use as either a service name or a service display name.". The service name is unique each time, but the display name is being re-used, so no wonder. Fixing that here. Bug: 1057891 Change-Id: I5e62258471038d3189286033277a1a5f68738a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086211 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746983}
-
Michael Sun authored
Add a new function in cras_audio_client to transmit updated metadata to Chrome OS via DBUS CRAS Control Interface. The metadata that will be transmitted are media title, album, and artist. BUG=b:147365563 TEST=chromeos_unittests Cq-Depend: chromium:2081187 Change-Id: I02e92e1f70612a0e5528b4e00cebe501a2934bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083731Reviewed-by:
-
Kalvin Lee authored
This change adds printing support for reading margin values from printers and adjusting the printable area accordingly. Bug: 976056 Change-Id: Idb0ec6b10cd42576764e6b69146a29eceaea134e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085845Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746981}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/27a813089d83..9459bae14b65 git log 27a813089d83..9459bae14b65 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 cnorthrop@google.com Capture/Replay: Add Vertex Array Object support to mid-execution capture 2020-03-04 cnorthrop@google.com Capture/Replay: Add TransformFeedback Object support to mid-execution capture 2020-03-04 lexa.knyazev@gmail.com D3D11: Implement OES_draw_buffers_indexed 2020-03-04 ianelliott@google.com Vulkan: Disable forceOldRewriteStructSamplers for SwS-Android 2020-03-04 jmadill@chromium.org Fix up EGLSurfaceTest. Created with: gclient setdep -r src/third_party/angle@9459bae14b65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Ibca6a5351b07ce11bc92c0fa140cbbb78fbdccee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088266Reviewed-by:
-
Becca Hughes authored
This makes the store API private and moves it to MediaHistoryKeyedService. This is so we can create a read only version of MHKS in the future for incognito. BUG=1051239 Change-Id: Ia2f2b6f548eeb6d305dbdd1d7d3cf8de58878d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088401Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#746979}
-
