GitLab

https://webrtc.googlesource.com/src.git/+log/8e5014a3925e..a837dd790d96


git log 8e5014a3925e..a837dd790d96 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 aleloi@webrtc.org Reset Agc2 on analog gain changes.
2018-08-08 srte@webrtc.org Limits reported cumulative packets lost to 0.
2018-08-08 nisse@webrtc.org Fix comment on RtpVideoSender's ownership of Rtp modules.
2018-08-08 nisse@webrtc.org Change Channel::GetRtpRtcp to return only RtpRtcp, not RtpReceiver.
2018-08-08 sakal@webrtc.org Release output buffer when dropping frame in HardwareVideoDecoder.


Created with:
  gclient setdep -r src/third_party/webrtc@a837dd790d96

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I072b7a9f02e84dcb8d21d80ffef97ac18561cb59
Reviewed-on: https://chromium-review.googlesource.com/1167583Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581670}

When there are nested oopifs, an out-of-process subframe may have
nested out-of-process subframe of its own. In such cases, we
should link custom data field of PaintRecord to its place-holder
SkPicture as well. This CL adds such processing in subframe
printing.

BUG=853942

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib81e376839be8bd28258fd92ba22e29da566548d
Reviewed-on: https://chromium-review.googlesource.com/1163829
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581669}

The interaction between & and std::move() caused this DCHECK to be
hit on Windows: https://cs.chromium.org/chromium/src/net/server/http_server.cc?q=http_server.cc&dr&l=61

Change-Id: I5899b9030e4eaae872f9663d852634edf0087a0f
Reviewed-on: https://chromium-review.googlesource.com/1167559Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581668}

Due to a bug (https://crbug.com/750512) even if the lower layer returned
null, a session description was surfaced from content to blink with
default sdp and type "".

With this CL, null is surfaced as a blink::WebRTCSessionDescription
whose IsNull() returns true. blink::RTCPeerConnection already correctly
handles this case and returns null for localDescription and
remoteDescription.

WPT expectations updated accordingly.

Bug: 750512
Change-Id: I51737f55165e767a5a1d1e9c519af9a535b5de70
Reviewed-on: https://chromium-review.googlesource.com/1167055
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581667}

This is a heuristic intended to allow the toolbars to be shown when
navigating to an AMP page, assuming that these navigations are coupled
with URL-changing history state updates (i.e. navigating to AMP pages
from the Google search results page).  This is likely too broad of a
condition, and should be updated to include a more robust heuristic that
checks the DOM of loaded iframes for AMP markup.

Bug: 866018
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I325d4339707e47bb2ae8f1b3c2c83538056be400
Reviewed-on: https://chromium-review.googlesource.com/1166188Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581666}

NSS 3.30 introduced PK11_HasAttributeSet, which allows callers
to query the PKCS#11 tokens for given PKCS#11 attributes. The
same release also added attributes to the default NSS trust
store indicating they were part of the default store - i.e.
they were not added by admins.

Prior to NSS 3.30, the only way for determining 'default'
trust was to query the token and slot name, as nssckbi.so,
the read-only default trust store. Unfortunately, other
libraries, such as p11-kit-trust, decided to emulate that, but
also included administrative and user-added roots in the store,
resulting in user-added roots being subjected to public trust
requirements.

While the issue is in p11-kit-trust not observing the
semantics that NSS relied on (e.g. by adding themselves as a
separate token/slot, or preserving the 'default-only' nature
of the .so), work around this by adding a short-circuit when
the PK11_HasAttributeSet symbol is resolved.

This short-circuit can be reasoned about as safe, as the other
change in M68 - to use GetNetTrustAnchorHistogramForSPKI -
ensures that publicly trusted roots are recognized as such. This
path only handles the "old Chrome, new trust store" scenario,
which is quite rare.

Bug: 868811
Change-Id: I21989ee3e0c59dd9bfd199a6b13334637f0772c5
Reviewed-on: https://chromium-review.googlesource.com/1167479Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581665}

While this does not fix the complete set of synchronization issues, it does result in smooth playback on my Linux machine.

Bug: 819914
Change-Id: I66f78e2d22d276c8dc2c67cb96626aab42ce0efe
Reviewed-on: https://chromium-review.googlesource.com/1162928
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581664}

Using Googletests's testing::_ eliminates the need to separate
mock methods into the actual and a private mock method solely
for the purpose of ignoring untested parameters.

Leaving two methods unchanged as the override test method
does (or wants to do) extra work.

This is a cleanup CL and is only related to issue 840390 in that
it factors some of the cleanup done in that CL to simplify that
review.

Bug: 840390
Change-Id: Iaaba1d1d259df621fee0d9b98173f7f42ad261a9
Reviewed-on: https://chromium-review.googlesource.com/1163902Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581663}

Also ProcessControllerInput is now private to RenderLoop, to reduce the
risk of updating the controller more than once per frame.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iae8b797027d7be147f2139276acd3b6e1264a4fe
Reviewed-on: https://chromium-review.googlesource.com/1165834Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581662}

This is an update per request from the favicon service owners.

Bug: 870583
Change-Id: I93b466ee704ac0eb3b0c2d90b5ba40c639b89a55
Reviewed-on: https://chromium-review.googlesource.com/1163836Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581661}

When a user selects a suggestion, the editing word range is selected
for replacement with the suggestion's text. Currently, that selection
causes a call to WebContentsObserver::DidChangeTextSelection() which
updates the TextSuggestionsTouchBarController's text selection to the
editing word range. This change in text selection modifies the
appearance of the touch bar which is undesired.

The change in text selection for replacing the editing word should be
ignored by the TextSuggestionsTouchBarController. A variable,
|shouldIgnoreReplacementSelection_|, is set to YES when the
TextSuggestionsTouchBarController modifies the current text selection
to replace the editing word. When the that text selection update
reaches TextSuggestionsTouchBarController, the selection will be
ignored and |shouldIgnoreReplacementSelection_| will be reset to NO.
This fixes the behavior where the touch bar appearance changes before
showing suggestions post-replacement.

A browser test was added,
TextSuggestionsTouchBarControllerTest.IgnoreReplacementSelection, to
test that a text selection is only ignored when necessary and that
other selection updates are not ignored.

Bug: 717553
Change-Id: Ib442d98b96e499acd73856399bcd89adf0f9c1d9
Reviewed-on: https://chromium-review.googlesource.com/1164167Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Cr-Commit-Position: refs/heads/master@{#581660}

Bug: 776589, 715630
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5a9bb9c857e3ec68df8c8ef1133cb418071f1e41
Reviewed-on: https://chromium-review.googlesource.com/1167553Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581659}

BUG=851090
TBR=hubbe@chromium.org
NOTRY=true

Change-Id: I445f06df0d88d0f840d1d82829aa2d4cac92fa67
Reviewed-on: https://chromium-review.googlesource.com/1167909
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581658}

The more explicit Time::FromDeltaSinceWindowsEpoch() is used instead,
and produces the same value given the same int64_t.

The registry keys consumed by this code are written by code in
chrome/chrome_cleaner/logging/registry_logger.cc (not yet moved there
from the internal repo), which already uses the corresponding
Time::ToDeltaSinceWindowsEpoch().

Bug: 634507
Change-Id: I75348bf8e55a0cc3d93412563e5527ddb04ce390
Reviewed-on: https://chromium-review.googlesource.com/1156861
Commit-Queue: Mathieu Guay-Paquet <mguaypaq@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581657}

Originally the chrome://sandbox page displayed "SUID Sandbox" as red
when the SUID sandbox was off, even if the namespace sandbox was on. To
avoid indicating that anything is wrong, this combines "SUID Sandbox"
and "Namespace Sandbox" into one row that displays green for namespace,
yellow for SUID, and red for neither.

Also, when the Chrome renderers are sandboxed with user namespaces,
any process in the parent namespace with the same UID is able to
ptrace the renderer. However, the chrome://sandbox page displays Yama
LSM as enforcing. This makes it clear that Yama LSM is not protecting
the renderer processes from ptrace by adding "Ptrace Protection with
Yama LSM (Non-broker)" to the webpage.

start chrome with all three sandboxing possibilities, run
./browser_tests --gtest_filter="Sandbox*"

Bug: 870527, 870534
Test: start chrome with Yama disabled, enabled, and with SetUID sandbox,
Change-Id: I2e4735363a4dceee4947757a74451e3e102c4250
Reviewed-on: https://chromium-review.googlesource.com/1162764
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581656}

This is currently blocking import. Upstream issue:
https://github.com/web-platform-tests/wpt/issues/12301

TBR=robertma@chromium.org

Bug: 870526
Change-Id: I1f9026391e3ef44c399472121a32b88b3197e9e1
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1167847Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581655}

Observe remote mojo apps (like keyboard shortcut viewer) for disconnect.
Inform accessibility extensions via the automation API that they can
destroy the AX node tree for the app. This handles both normal app
shutdown and app crashes.

Also rename ShowKeyboardShortcutViewer() to Toggle, since that's what
it actually does.

TBR=xiyuan@chromium.org

Bug: 871414
Test: added to LoggedInSpokenFeedbackTest.KeyboardShortcutViewer
Change-Id: I463d69473a477a9ba2daee5d45a7e65c94981466
Reviewed-on: https://chromium-review.googlesource.com/1166193
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581654}

This reverts commit 46b03fcf.

Reason for revert:

Seems to break fast/events/middleClickAutoscroll-nested-divs.html on several platforms. Example here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34202


Original change's description:
> [animation-worklet] Rename layout tests
> 
> Remove "animation-worklet-' prefix from layout tests. The tests are inside AW
> directory so the prefix is just visual clutter. I kept it for tests that check
> something about the worklet itself.
> 
> Note: There was a legacy unused animationworklet/visual-update-expected.html
> file that this patch replaces now.
> 
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I67a36d7d5913b1394108b8a1731cc660d74f99ad
> Reviewed-on: https://chromium-review.googlesource.com/1165271
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Commit-Queue: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581552}

TBR=majidvp@chromium.org,yigu@chromium.org

Change-Id: If81712c7089784772b5a106159c70bdd7cbce9c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1167766Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581653}

Modified names for RecurrentSSLInterstitial experiments in
fieldtrial_testing_config.json, to match changes in cl/207890689

Change-Id: I405272b1366f1f2b74013d31a06d812b7a4326f2
Reviewed-on: https://chromium-review.googlesource.com/1167550
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581652}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/ce468a17c434..d5266326752f

$ git log ce468a17c..d52663267 --date=short --no-merges --format='%ad %ae %s'
2018-08-07 wez Fix typo breaking Fuchsia build
2018-08-07 misterg upsream additional printer test
2018-08-07 misterg Formatting changes,small cleanup,  no functionality changes
2018-08-07 misterg small cleanup, np functional changes
2018-08-06 misterg automatic code sync mgt, comment only
2018-08-03 wez No default exception handling
2018-07-19 p.paulweber Printers test: fixed compilation bug, due to unnecessary parentheses in declaration
2018-08-02 misterg one more fix
2018-08-02 misterg cmake fixes
2018-08-02 misterg more fixes
2018-08-02 misterg add --no_stacktrace_support for json-output-unittest
2018-08-02 misterg fixes tests
2018-08-02 misterg cmake test fixes
2018-08-02 misterg cmake fixes
2018-08-02 misterg cmake tests changes
2018-08-02 misterg cleaning up and adding test changes to CMake
2018-08-01 misterg Corresponding CMake Changes
2018-08-01 misterg various changes to tests
2018-08-01 misterg more test changes
2018-08-01 misterg adding googletest-json-output unitest
2018-08-01 misterg more test changes
2018-08-01 misterg more tests changes
2018-08-01 misterg googletest list tests unitest
2018-08-01 misterg gtest catch exceptions test and gtest shuffle test
2018-08-01 misterg changes to googletest break on failure and googletest filter unittests
2018-08-01 misterg changes for googletest env var test
2018-08-01 misterg googltest-color-test changes
2018-08-01 misterg googletest-output-test changes
2018-08-01 misterg Formatting changes and upstreaming one test
2018-07-30 misterg small tweaks, OSS merge cl 206357486
2018-07-27 misterg added missing comments
2018-07-27 misterg Formatting changes for automatic code management
2018-07-25 piotrkakol Updated broken and outdated URLs
2018-07-25 misterg Formatting changes, code sync
2018-07-21 stianvalle Update primer.md
2018-07-21 stianvalle Update primer.md
2018-07-21 stianvalle Update primer.md
2018-07-20 misterg code merge
2018-07-20 duxiuxing Replace "…" with "..."(three dots) to fix warning C4819 in Visual Studio
2018-07-19 misterg code sync
2018-07-18 misterg Code sync
2018-07-18 misterg Fix link
2018-07-18 misterg Code sync, mostly formatting and removing outdates
2018-07-18 misterg Formatting and a link
2018-07-17 misterg Docs sync
2018-07-17 syohex Ignore .DS_Store file
2018-07-17 duxiuxing Fix warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
2018-07-17 luke Fix broken links to FAQ in primer.md
2018-07-13 amoran Put ifdef guard after the includes.
2018-07-12 dmauro Adds the UniversalPrinter for absl::variant.
2018-07-12 amoran Avoid full test in no exceptions are enabled.
2018-07-11 misterg more formatting [skip ci]
2018-07-11 misterg formatting, [ci skip]
2018-07-11 amoran Fix issue #1654.
2018-07-10 misterg Fix heading
2018-07-10 misterg Docs sync
2018-07-10 dmauro Pass the --no_stacktrace_support argument to the CMake tests
2018-07-10 dmauro Adds stacktrace support from Abseil to Google Test
2018-05-23 m.tmatma This closes #1595: fix compiler error with Visual Studio 2017 on Win10 JP.
2018-06-29 duxiuxing VS2005 with SP1(_MSC_VER=1400) already supports __pragma
2018-06-07 rfj Eliminate GTEST_TEST_FILTER_ENV_VAR_.
2018-06-13 misterg ignore .md for appveyor builds

Created with:
  roll-dep src/third_party/googletest/src
R=dpranke,thakis

Change-Id: I440d22bf01c5db36933f10cbff5acf3c1ed60f09
Reviewed-on: https://chromium-review.googlesource.com/1167642Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581651}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0c298bd8..f43cb96e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0b7f443248a0a9b86f4708cf45e6ee08f7025e0e
Reviewed-on: https://chromium-review.googlesource.com/1167119Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581650}

https://skia.googlesource.com/skia.git/+log/f5402004c4a6..057c39025a93


git log f5402004c4a6..057c39025a93 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 timliang@google.com attached uniform and varying handlers to GrMtlPipelineStateBuilder
2018-08-08 reed@google.com migrating SkTDArray towards std::vector api
2018-08-08 herb@google.com Performance: Move GPU code to GlyphRun and inline
2018-08-08 jvanverth@google.com Reland "Intersection calc cleanup."
2018-08-08 reed@google.com Revert "migrating SkTDArray towards std::vector api"
2018-08-08 reed@google.com migrating SkTDArray towards std::vector api
2018-08-08 hcm@google.com add skia.org modules section, animation page
2018-08-08 benjaminwagner@google.com Add Win OpenCL Test job.
2018-08-08 caryclark@skia.org add simplify to json tests
2018-08-08 egdaniel@google.com Add support for Advanced blend extension to vulkan.
2018-08-08 egdaniel@google.com Update vulkan features (again) to support extension features.
2018-08-08 benjaminwagner@google.com Remove QuadroP400 TSAN job.
2018-08-08 djsollen@google.com Revert "Update ShouldUseAAA with our better complexity estimation"


Created with:
  gclient setdep -r src/third_party/skia@057c39025a93

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: Ia14a1efe7fa7d6adee9a4470901ecf48eb5927a9
Reviewed-on: https://chromium-review.googlesource.com/1167582Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581649}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/9dfdc2758f26..658ff786a213

$ git log 9dfdc2758..658ff786a --date=short --no-merges --format='%ad %ae %s'
2018-08-08 dor1s [libFuzzer] Optimize handle unstable checks by reducing iterations
2018-08-06 dor1s [libFuzzer] Add unstable function printing to print_unstable_stats flag

Created with:
  roll-dep src/third_party/libFuzzer/src

TBR=mbarbella@chromium.org

Bug: 854276
Change-Id: I3354344b7819757ac267df79446565316c0976ff
Reviewed-on: https://chromium-review.googlesource.com/1167643
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581648}

TBR=sky@chromium.org

Bug: 840957
Change-Id: I72b9675431e8d5ecb8992884869c93485b6b1742
Reviewed-on: https://chromium-review.googlesource.com/1166198Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581647}

This reverts commit 03914101.

Bug: 827599
Change-Id: I40ed04058540604fe58b30f666fdb87041e9cb29
Reviewed-on: https://chromium-review.googlesource.com/1166232Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581646}

This change replaces the PassGamepad interface usage with
SerializeAndDeserialize() which is the modern and simpler way of testing
struct traits. Also, gamepad_mojom_traits_unittest.cc is moved to
//device/gamepad/public/cpp.

Bug: 612330
Change-Id: I9e8ebe3e8d62a08503d1aa24fdec39f9af280134
Reviewed-on: https://chromium-review.googlesource.com/1164404Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581645}

This change fixes a regression where the icon is not visible on Mac
and Windows platforms.

Bug: 870652
Change-Id: Id1649a113e13b0168f197c8e53fc91e61655bab2
Reviewed-on: https://chromium-review.googlesource.com/1166450Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581644}

The implementation of DevToolsFileWatcher::RemoveWatch was calling
DevToolsFileWatcher::AddWatchOnImpl. Each call to
DevToolsFileWatcher::AddWatchOnImpl would create [potentially] hundreds of
thousands of file watchers, depending on the directory being watched.

This is likely the cause of an observed 40GB leak in the wild.

Bug: 810155
Change-Id: I61449ec232bba639bfeff2e1094c86d00e23665f
Reviewed-on: https://chromium-review.googlesource.com/1163930Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581643}

Bug: 871422
Change-Id: I76e5faebaa2f2f338bbb27bfaefe097f9006474a
Reviewed-on: https://chromium-review.googlesource.com/1165268
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581642}

The path was needed in SPv1 when we issued transforms as display items
for some layers. Now we can use the normal paint path for those layers
with paint properties.

This also fixes the crash on print bug.

Bug: 869917

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idc5d61c2703b778604c48b3fc74712b19f3632c3
Reviewed-on: https://chromium-review.googlesource.com/1164468
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581641}

When undoing a close all tabs action, the recently closed tabs would
continue to show all the tabs. This CL properly removes the restored
tabs by removing them from the TabRestoreService.

Bug: 846786
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3c02270cd8f4e9998f3e51032f5973fe0329bf6e
Reviewed-on: https://chromium-review.googlesource.com/1167118Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581640}

Change-Id: I8a6d9f3096c04667dc729b8754c4e5adb82b0b4e
Reviewed-on: https://chromium-review.googlesource.com/1167058Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581639}

The singleton/switch-to-tab browser tests, which happened to load
Maps and chrome://settings, were taking so much time, that on
Windows, they were timing out. By using simpler sites and loading
settings asynchronously, the time is cut in half.

Bug: 822071
Change-Id: I73e6de0e8a7c13e1670c8daa76d18c2acb9cc9d4
Reviewed-on: https://chromium-review.googlesource.com/1165797Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581638}

This CL fixes the issue when the view for ConsentBumpFragment was
displayed without the data related to the selected account. This was
caused by the following flow:
1. ConsentBumpFragment is displayed.
2. "More options" is clicked, opening ConsentBumpMoreOptionsFragment.
   ConsentBumpFragment is kept in FragmentManager back stack.
3. "Back" in ConsentBumpMoreOptionsFragment is clicked, popping the back
   stack entry.
4. To display ConsentBumpFragment again, FragmentManager recreates
   the view by calling ConsentBumpFragment.onCreateView.
5. The view is displayed without profile data.

Bug: 869426
Change-Id: Ia63c4df694cad921794ce8c9ab8e2e22b81f9c17
Reviewed-on: https://chromium-review.googlesource.com/1167520Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581637}

There are two bugs fixed here:
First, restoring a minimized window causes letterboxing in some cases:
GetClientAreaInsets as calculated by BrowserDesktopWindowTreeHostWin
is scaled by the DPI for the associated HWND.  That works great except
when restoring a window from a minimized state, during which the window
is in some weird off-screen no-man's-land and is not actually on any
display.  GetSystemMetricsForHWND() defaults to the closest display in
this case, and if that guess is wrong, you can get letterboxing.

This CL passes in the correct scale factor explicitly, so OnNCCalcSize
can pass in the scale for the display that the window is being restored
to.

Second, some setups always have (less noticeable) letterboxing.  This is
simply fixed by using the GetSystemMetricsForDpi API (if it's available)
instead of scaling the results of GetSystemMetrics ourselves and getting
letterboxing if Windows did not scale the same way.

Bug: 656730
Change-Id: I4eedce3fc3ef427e0986f086623094152940ba2b
Reviewed-on: https://chromium-review.googlesource.com/1149273Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581636}

It used to show when enter or exit tablet mode. But with new tablet mode
disambiguation the keyboard may be disabled when in clamshell mouse with
external mouse connected.

Users will still need a way to enter overview in flip or tablet form
factor with external mouse connected, so check if the keyboard is
disabled instead of tablet mode is on or off.

It seems shelf was waiting for status area widget to change bounds to
update to tablet mode shelf ui (back button visible and other items
shifted). Now that overview tray may not change visibility on enter/exit
tablet mode, status area widget bounds may remain the same. So shelf ui,
needs to be updated directly.

Also fix a bug with users being able to leave tablet mode with external
mouse when force-tablet-mode is set to tablet mode.

Test: Added tests
Bug: 870458
Change-Id: If8cd6e14d90238e87d1695b8f59ef167d9420479
Reviewed-on: https://chromium-review.googlesource.com/1163913
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581635}

On tablets the toolbar more or less stays consistent between the NTP and
regular web pages so it feels less jarring to leave the clear tab button
visible.

BUG=871905

Change-Id: I41689586facd855869852ecec8b044295bf15a12
Reviewed-on: https://chromium-review.googlesource.com/1165532Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581634}

The VideoDecodePerfHistory is used to make smoothness predictions for
the MediaCapabilities API. For normal profiles, the perf stats are to
a saved to small DB on disk. For incognito profiles we instead save the
stats "in memory" and they disappear when the session ends.

The lines removed in this change "seeded" the Incoginto profile with
the performance stats of the original profile. This has caused some
crashes because we appear to be using the seed DB after its freed (or
perhaps corrupted).

The root cause is not yet known, so the temporary fix is to simply
stop providing a seed DB for incognito. This is already the case for
Guest profiles (no notion of an originating profile) and for any
new on-the-record profile.

The impact will be fairly small, as it only takes ~30 seconds of
playback for enough new stats to accrue such that prediction quality
is unaffected.

In a follow up (after the release) I will revert this
and add some observer code to CHECK when seed_db_ is destroyed before
the InMemoryDB.

Bug: 865321
Change-Id: I103b4679bcfa99310d44f4bb810db0535f2d44f0
Reviewed-on: https://chromium-review.googlesource.com/1167514
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581633}

This CL removes the member var |previous_image_release_callback_|
and method DrawingBuffer::SwapPreviousFrameCallback(), because
they are not used in a meaningful way.

It's extracted from junov@'s crrev.com/c/1103011.

Bug: 839970
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0c410d5181ceb973843f74bc7e419e7e8305baf7
Reviewed-on: https://chromium-review.googlesource.com/1165833Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581632}

By an investigation inspired by crbug.com/870178, a few
problems were found in computing kMaxCharacterIndex.

1. Often the number of glyphs is compared with
   kMaxCharacterIndex. This is meaningful only when code
   point:glyph is 1:1.
2. Because limiting the number of glyphs is important to
   reduce reallocations, this patch adds kMaxGlyphs.
3. In RTL, the logic did not handle when character_index
   is in descending order.
4. Makes sure runs are split at cluster boundary.
5. Take the check out of the loop to ensure vectors
   allocated before the loop don't need reallocations.

A couple of notes:
1. By taking this logic out of the loop, we can probably
   do this before allocating RunInfo, and thus avoid all
   reallocations related to kMaxCharacterIndex and
   kMaxGlyphs. Haven't looked into it much yet.
2. The ordering maybe still incorrect, especially in RTL.
   May need more tests and a few more iterations.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8d70435c9f28287206b41831f68e7183d61fafcb
Reviewed-on: https://chromium-review.googlesource.com/1166768
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581631}