- 06 May, 2018 2 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Icd09aea13117af1c4bf03846d3a7d61556bafffe Reviewed-on: https://chromium-review.googlesource.com/1046129Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556349}
-
Max Moroz authored
Also write output of llvm-cov export program on the disk (needed for the bot). Plus some refactoring for logs from target programs: - redirect stderr from targets into stdout to be written into a .log - write logs into its own subdir for better output structure Not output folder structure look as follows: $ ls -l out/zreport15/ total 8 drwxr-x--- 5 mmoroz primarygroup 4096 May 4 10:53 linux -rw-r--r-- 1 mmoroz primarygroup 2519 May 4 10:53 style.css $ ls -l out/zreport15/linux/ total 48 drwxr-xr-x 2 mmoroz primarygroup 4096 May 4 10:53 components -rw-r--r-- 1 mmoroz primarygroup 1627 May 4 10:53 component_view_index.html -rw-r--r-- 1 mmoroz primarygroup 4672 May 4 10:53 coverage.profdata -rw-r--r-- 1 mmoroz primarygroup 241 May 4 10:53 directory_view_index.html -rw-r--r-- 1 mmoroz primarygroup 7416 May 4 10:53 file_view_index.html -rw-r--r-- 1 mmoroz primarygroup 200 May 4 10:53 index.html drwxr-xr-x 2 mmoroz primarygroup 4096 May 4 10:53 logs -rw-r--r-- 1 mmoroz primarygroup 7483 May 4 10:53 summary.json drwxr-x--- 3 mmoroz primarygroup 4096 May 4 10:53 usr Bug: 784464, 836663 Change-Id: I3283f16b62cfeb267bb2b3092fa469d5ff39ef14 Reviewed-on: https://chromium-review.googlesource.com/1044652 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#556348}
-
- 05 May, 2018 38 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9be6ec5e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16966 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I384b7df6d0e870e2fdfcaef877cc59f4cbfa93ea Reviewed-on: https://chromium-review.googlesource.com/1045803 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556347}
-
Wez authored
We already DCHECK that |ptr_| is valid in GetWeakPtr(), but this extra check ensures we catch mis-use earlier. Change-Id: Id62dc3cbe6c4e33f08bb1d5c5c2e304aa01c53a8 Reviewed-on: https://chromium-review.googlesource.com/1042485Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556346}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 690f3329. With Chromium commits locally applied on WPT: ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16965 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I00f8564beca7667e679bbf7124c8ef9b5205e289 Reviewed-on: https://chromium-review.googlesource.com/1045987 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 707f4d3e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 556340 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzcwN2Y0ZDNlNzgxZGIwZjUxZjQ5MzBjNTAxOTRkMmNkMWU3YWUyZDYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5528 Sample Failed Step: interactive_ui_tests Original change's description: > Fully integrate the Select-to-Speak tray button with the extension. > > This change lets taps to the tray button control changes in the Select-to-Speak > extension page. It also adds integration tests. > > A large part of this change is adding a mojom test API to allow the ChromeOS > integration test to find and tap the Select-to-Speak button in Ash. > > Bug: 753018 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I1593d4f8ac70c9bd321af843d6a71de6381f65f6 > Reviewed-on: https://chromium-review.googlesource.com/1041210 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556340} Change-Id: I7a62f01228147f07a681275916533cf53d339332 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 753018 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1046026 Cr-Commit-Position: refs/heads/master@{#556344}
-
Chris Harrelson authored
Based on CL 1033824 This patch adds three tests and test the following: - Filtered block establishes a container for fixed and abs pos. - Filtered inline establishes a container for fixed and abs pos. - Filtered <html> does not establish a container for fixed pos. Bug: 795549 Tbr: vmpstr@chromium.org Change-Id: I3fa13cc7f478503583a191bfb434cdab860862ef Reviewed-on: https://chromium-review.googlesource.com/1045727 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556343}
-
Christopher Cameron authored
RecyclableCompositorMac owns a ui::Compositor, but the surface id generation was owned by BrowserCompositorMac. A RecyclableCompositorMac will be recycled by many different BrowserCompositorMac, and as a result, it may have a non-monotonic- increasing surface id. Scope the surface id information to RecyclableCompositorMac, and throw some of the related logic into a helper function. Bug: 772576, 817827 Change-Id: Ic4299afa5670c96b51260917a3fafb2b692b3465 Reviewed-on: https://chromium-review.googlesource.com/1046045Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#556342}
-
Yuri Wiitala authored
This is a simple test utility that will be used in upcoming tests to act as a final consumer of audio in loopback unit tests. It records all the audio samples given to it, and then provides useful utility methods to analyze/interpret the signal. Bug: 824019 Change-Id: I0ef3476b2e8004c77265a85d51f5dd69a3b309b3 Reviewed-on: https://chromium-review.googlesource.com/1041653Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556341}
-
Katie D authored
This change lets taps to the tray button control changes in the Select-to-Speak extension page. It also adds integration tests. A large part of this change is adding a mojom test API to allow the ChromeOS integration test to find and tap the Select-to-Speak button in Ash. Bug: 753018 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1593d4f8ac70c9bd321af843d6a71de6381f65f6 Reviewed-on: https://chromium-review.googlesource.com/1041210 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556340}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f3313d8. With Chromium commits locally applied on WPT: ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16955 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I667e88e5e25093acc6314240ee38bbf574992c48 Reviewed-on: https://chromium-review.googlesource.com/1045802 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Scott Violet authored
This makes it so that if an app requests the WindowService it's launched in Ash. This is only enabled if --mash and --mus is not specified. BUG=837686 TEST=none Change-Id: Ic01879e0aff8828b17c0652bd74078daba628d40 Reviewed-on: https://chromium-review.googlesource.com/1045248 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 5157 5161 5163 5181 5182 5187 5195 5200 5206 5207 5208 5209 108 lines were removed and 21 lines were deflaked by consecutive results since 5129. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7fac4144cc97aaec933727bf2994edd7b0b37e81 Reviewed-on: https://chromium-review.googlesource.com/1042665 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556337}
-
Fady Samuel authored
LocalSurfaceId is plumbed to WebContents for auto-resize but never used. This CL deletes that plumbing. Bug: 672962 Change-Id: I851c17d856fc72405e5893ddbe80e36bc068af49 TBR: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1045911Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Idbbf9c9004ecaa158de95a9d496b84d1070dfd50 Reviewed-on: https://chromium-review.googlesource.com/1045914Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556335}
-
Yuri Wiitala authored
The DelayBuffer records and maintains a recent history of an audio signal, then allows read-back of any part of the recording. While this looks a lot like "yet another FIFO," it is not because the reads will typically be somewhere in the middle, not the end, of the circular queue. This will be used in a later change to support loopback functionality in the Audio Service. Bug: 824019 Change-Id: I5321724ac3a55929318d411a08d33344a39c2272 Reviewed-on: https://chromium-review.googlesource.com/1029617Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556334}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Bug: 832879 Change-Id: Idd49d49da49f09e8fb72c1143fbb27c485eb7a14 Reviewed-on: https://chromium-review.googlesource.com/1045228 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556333}
-
Christopher Cameron authored
There exists plumbing to send gfx::CALayerParams (the parameters for displaying content on macOS) from the viz::Display to the browser process via that viz::DisplayClient interface. In GPU compositing, this comes in via viz::Display's implementation of viz::OutputSurfaceClient::DidReceiveCALayerParams. Make viz::Display also implement a new interface, viz::SoftwareOutputDeviceClient, and add a method to this interface, SoftwareDeviceUpdatedCALayerParams, which the SoftwareOutputDeviceMac calls when a frame is drawn. Route this to the same paths that the GPU compositing path takes to send it to the browser process. Delete the now-unneeded gfx::AcceleratedWidgetMac interfaces in SoftwareOutputDeviceMac. Bug: 730660, 772576 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I03a21c5b1c1e5333aec94b5a0d1e88811fbbaf34 Reviewed-on: https://chromium-review.googlesource.com/1042312Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#556332}
-
erikchen authored
This CL is a refactor with no intended behavior change. Bug: 832879 Change-Id: I18a970240c9abcf38879c8b4d15aae848d2dd893 TBR: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1040471Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556331}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cdd10462. With Chromium commits locally applied on WPT: ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16954 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I9fbcd610b69ee5b2f6bbdaec29d2f9ba66284e46 Reviewed-on: https://chromium-review.googlesource.com/1045985 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Bo Liu authored
Kill the lowest ranked connection when there are no more service slots when trying to allocate a new connection. Remove the hack solution that passed down the number of service slots to RenderProcessHost::GetMaxRendererProcessCount. Remove releaseAllModerateBindings when the last service is allocated. Add a test in content that verifies intentional kill works. Refactored ChildConnectionAllocator to make the queuing of requests explicit. Then add a callback when Allocator runs out of slots for allocation which content layer handles by killing the lowest ranked connection. This implementation ensures there is only one connection being killed waiting to be noticed. Change-Id: I5f670dfcf6ce645ab2681ec97d095eca98b2b5a2 Reviewed-on: https://chromium-review.googlesource.com/1002193 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#556329}
-
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5522Erik Chen authored
Original change's description: > Fix hosted app crash when started in tablet mode > > The code was written with the expectation that > HostedAppButtonContainer::StartTitlebarAnimation() > is called before > HostedAppButtonContainer::OnImmersiveRevealStarted(). > > This is not the case when in tablet mode and results > in crashes. > > This CL updates HostedAppButtonContainer to allow these > methods to be called in either order. > > Bug: 836482 > Change-Id: I658578ca79599e21566fffd3986a6dc852cb6489 > Reviewed-on: https://chromium-review.googlesource.com/1029882 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556327} TBR=jamescook@chromium.org,sky@chromium.org,alancutter@chromium.org Change-Id: I8adc788a94cb297a86e2e8b6d04e733e8092e3ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836482 Reviewed-on: https://chromium-review.googlesource.com/1045872Reviewed-by:
-
Alan Cutter authored
The code was written with the expectation that HostedAppButtonContainer::StartTitlebarAnimation() is called before HostedAppButtonContainer::OnImmersiveRevealStarted(). This is not the case when in tablet mode and results in crashes. This CL updates HostedAppButtonContainer to allow these methods to be called in either order. Bug: 836482 Change-Id: I658578ca79599e21566fffd3986a6dc852cb6489 Reviewed-on: https://chromium-review.googlesource.com/1029882 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2c5e4b87. With Chromium commits locally applied on WPT: ca0aa292 "Support groupId constrainable properties in MediaDevices.getUserMedia()" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16945 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/x-frame-options yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I7403b2ee2fd7fe2bda44cc02e7085bac1e1fb92f Reviewed-on: https://chromium-review.googlesource.com/1045801 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
PhistucK authored
Added "Add property path to watch" for quickly adding an inspected object property expression to watch. This is not smart enough to infer the original expression that triggered the property list, but it works without a user intervention for the scope variables section. Also - - Removed a redundant . that is prepended to every property path. - Escaped the property name when it is a string. R=pfeldman@chromium.org Bug: none Change-Id: I984bad781786668bb708084dbb1a8537dabf02a3 Reviewed-on: https://chromium-review.googlesource.com/1001232Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: PhistucK <phistuck@gmail.com> Cr-Commit-Position: refs/heads/master@{#556325}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0fd27b6..70d24bb2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If8ce01913ad63ac5758596903ca0f2e429b9a4e0 Reviewed-on: https://chromium-review.googlesource.com/1045799Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556324}
-
yiyix authored
The current draw occlusion cannot handle 3d object yet. This patch allows DrawOcclusion to skip draw quads from a 3D objects. Bug: 833748 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I08d12c794d4acff0e1f584f4c74857bc5df83fee Reviewed-on: https://chromium-review.googlesource.com/1044781 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556323}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=rkc@chromium.org Change-Id: I223af27279136aa5971ec63760c6a37537b237fa Reviewed-on: https://chromium-review.googlesource.com/1045800Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556322}
-
Karan Bhatia authored
This CL introduces helpers for the page whitelisting API in the DeclarativeNetRequestBrowserTest test fixture. Existing test code is modified to use these helpers. BUG=811460, 696822 Change-Id: I7f9ec32d2ec8edc17dc6bd546bb3d804390efbd8 Reviewed-on: https://chromium-review.googlesource.com/1039007 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#556321}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2369c0c1..b0fd27b6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5c32a0643db3af6f214d475c9cc0a5fc4cf35487 Reviewed-on: https://chromium-review.googlesource.com/1045871Reviewed-by:
-
Karan Bhatia authored
This CL relands r555005 which was reverted since it introduced flakiness. The flakiness was most probably since we ended up creating the ExtensionTestMessageListener too late for the DeclarativeNetRequestBrowserTest_Packed.PageWhitelistingAPI test. The listener was created in SetUpOnMainThread override while the InstalledLoader ends up loading all extensions before this (during BrowserMainLoop::CreateStartupTasks()). Hence a subsequent ExtensionTestMessageListener::WaitUntilSatisfied() call would end up running indefinitely. To get around this, only wait for the background page to load if the background page isn't already ready. BUG= 696822, 838536 Change-Id: I2b288c6e6703e5be588d480403b362bf7c30db4e Reviewed-on: https://chromium-review.googlesource.com/1043271 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Joel Einbinder authored
I extracted out some improvements to inplace pretty print in SourceFrame from my sources auto pretty print patch. * Line numbers become blue when pretty print is active * Selection is properly scrolled into view when pretty print is toggled Change-Id: Ib1cf8f0a15b8495594ecf121cef8786d8cfd0f16 Reviewed-on: https://chromium-review.googlesource.com/1044878 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556318}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ie663240968da25682be04aee64595d5c988dc45d Reviewed-on: https://chromium-review.googlesource.com/1045901 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556317}
-
Erik Luo authored
Turns the console below-prompt UI experiment from hidden to visible. Clicking on the preview element will now focus the prompt editor, unless it has a selection. Bug: 810176 Change-Id: I28cb5fa9c375ab4ae5cbfdf5043d03c7d8c71057 Reviewed-on: https://chromium-review.googlesource.com/1043464 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d5b83bf9533..32d8f883bd4e $ git log 3d5b83bf9..32d8f883b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I08b02e7d153f25a8ad96f3f8ca2e48fb3d301386 Reviewed-on: https://chromium-review.googlesource.com/1045895Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556315}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/abd74feb3dc4..5c50bf92e6fb $ git log abd74feb3..5c50bf92e --date=short --no-merges --format='%ad %ae %s' 2018-04-30 gmeinke parallel_emerge: Save install plan use newlines Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I11f885e353a9950184acc3c1a452e120e26e2003 Reviewed-on: https://chromium-review.googlesource.com/1045897 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556314}
-
Fady Samuel authored
In the future (on Android), we'd like to be able to allocate LocalSurfaceIds on the compositor thread in order to synchronize top bar controls with web content scrolling or text selection handles with web content scrolling. Thus, changes in LocalSurfaceId need to be reported from the compositor thread, instead of the main thread. This CL takes us in this direction. If surface synchronization is enabled, the browser will respond to changes in LocalSurfaceId from the compositor thread instead of from the blink main thread. In the short term, this delays the "ACK" to unblock further resizes, but if this ends up being an issue we can perhaps inform the browser sooner. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I717304063cc16ea7c68462c18d4de165024d85be Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1011221 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556313}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/39e3bc6ed30a..3059fd7dba63 $ git log 39e3bc6ed..3059fd7db --date=short --no-merges --format='%ad %ae %s' 2018-05-04 harringtond Improve replay determinism Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ib90e53284fce7914887b59a19955de5046f06e5b Reviewed-on: https://chromium-review.googlesource.com/1045616Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556312}
-
dpapad authored
Bug: 832184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idf252a9e10a524e898e2de8fc540d890285ff01e Reviewed-on: https://chromium-review.googlesource.com/1038737Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556311}
-
sangwoo.ko authored
As we can convert plain strings into query url, We shouldn't block non-urls. Bug: 838794 Change-Id: Iaceaf0627a95c11382a4dee72d62a7af2a4e78bd Reviewed-on: https://chromium-review.googlesource.com/1041367 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#556310}
-
