- 03 Jan, 2018 13 commits
-
-
Tarun Bansal authored
Update test expectations for virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-recalculate-styles.js Bug: 798592 Change-Id: I9cfcf529b495a0c0d8a70ef4cdf40b6536c13540 TBR: jwd@chromium.org Reviewed-on: https://chromium-review.googlesource.com/848027 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#526565}
-
Bo Liu authored
Remove unused method signatures Fix a comment Change-Id: Idf191b76b3e2c2495a7ff3e31d16629c086d87e2 Reviewed-on: https://chromium-review.googlesource.com/847971Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526564}
-
Sergey Berezin authored
Use this builder as a canary for the new Xcode / CIPD flow. BUG=797051 TBR=justincohen@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I59173d9c8ca5ee37fff86cf7795600d84661be9a Reviewed-on: https://chromium-review.googlesource.com/848294 Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526563}
-
Will Chen authored
Rebaselined the test, once it lands, we can re-evaluate whether it's actually flaky. Bug: 747751 Change-Id: I5a447ed7b8cab1e586f96aec29b3ceb690019f85 Reviewed-on: https://chromium-review.googlesource.com/847895Reviewed-by:
Eugene Ostroukhov <eostroukhov@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526562}
-
Fady Samuel authored
A late arriving CompositorFrame should not activate if the dependent CF has been dropped. This can happen if a CompositorFrame is marked for destruction and then pulled out of the destruction queue ("surface resurrection"). This CL ensures that when a surface is reset, a SurfaceDiscarded notification is sent to the SurfaceDependencyTracker followed by SurfaceCreated to mimic creating a new surface. Bug: 796602 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I226b23bedbb1855c0da8fada8341c09a2f4fd318 Reviewed-on: https://chromium-review.googlesource.com/847427 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#526561}
-
Will Chen authored
I previously removed this test from SmokeTests (used to run a subset of tests on Android) in https://chromium-review.googlesource.com/688512. Bug: none Change-Id: I0658ee2e451d84a8f455979ca4ed7ab7aab68a22 Reviewed-on: https://chromium-review.googlesource.com/848021Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526560}
-
Quinten Yearsley authored
This reverts commit e71979ba. Reason for revert: mstensho@ reports that this flag is actually still useful and we still want to keep it. Original change's description: > Remove --fully-parallel from tests. > > Bug: 692866 > Change-Id: I0530db53a88da0eaf8c813f41047832ed6bbbc0d > Reviewed-on: https://chromium-review.googlesource.com/741106 > Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525379} TBR=qyearsley@chromium.org,mjkim610@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 692866 Change-Id: I1d694c1ef7437f784aa2cb2de47850fd68b4d3ab Reviewed-on: https://chromium-review.googlesource.com/847872Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#526559}
-
Tarun Bansal authored
Bug: 765378 Change-Id: I20e8e2fac148cfde6114ebf6a7af2a33d056b356 Reviewed-on: https://chromium-review.googlesource.com/846019Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#526558}
-
Tarun Bansal authored
Bug: 798563 Change-Id: Ie668c5e91689dd7c9128670257176bb3f0b5c378 TBR: tommi@chromium.org,sergeyu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/847962Reviewed-by:
-
Scott Violet authored
These tests used DeviceDataManager directly, which doesn't work for mus. The fix is to use InputDeviceClientTestApi. PreferTouchAsPrimary required an additional call because unit tests don't really bring up mus. BUG=776514 TEST=test only changes Change-Id: Ica853e72d97bada225004bda7d30b507cef4cab0 Reviewed-on: https://chromium-review.googlesource.com/847688 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#526556}
-
Renee Wright authored
This CL does the cases that return - ZoomAdjustedPixelValue - ZoomAdjustedPixelValueForLength - CSSIdentifierValue::Create - nullprt Bug: 775360 Change-Id: I92c1f2d8f302ebab37fb17ef54a152f154dceb9b Reviewed-on: https://chromium-review.googlesource.com/822017Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#526555}
-
Robert Hogan authored
If the descendants of an opportunity tree node have exclusions they will get lost when combining the node's current exclusions, so avoid doing that. Bug: 798436 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I90cde607c99fcfc808c1dafc531445bc25774cca Reviewed-on: https://chromium-review.googlesource.com/847595Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#526554}
-
Danyao Wang authored
Native error view is triggered when a pending item can't be loaded due to network error. It is handled by commiting the pending item and activating the native controller. With WKBasedNavigationManager, the commit step needs a WKBackForwardListItem in order to commit the pending item. Injecting a placeholder URL into WKWebView fixes this problem. Because any URL can trigger a native error view, I also removed the assertions checking that the URL encoded in a placeholder URL is always an app-specific URL. This fixes the following egtest failures: TabUsageRecorderTest/testOpenFromApp NavigationTestCase/testHistoryForwardToErrorPage NavigationTestCase/testHistoryBackNavigation NavigationTestCase/testWindowLocationReplaceAndChangeHash Bug: 784951 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie4f61087301774340981ba3661740b1f4e103a1e Reviewed-on: https://chromium-review.googlesource.com/847907Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#526553}
-
- 02 Jan, 2018 27 commits
-
-
Shenghua Zhang authored
Adding SDK update script to support: 1) downloading new version of SDK package(s) from sdkmanager 2) uploading a package instance and upload to CIPD. At the meanwhile update the package version in gn file to match what the uploading package about. Bug: 659808 Change-Id: I9b5f7c2a544ce8e799c0b1072d3c5462f59e2d21 Reviewed-on: https://chromium-review.googlesource.com/778083 Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#526552}
-
Vladimir Levin authored
On low end android, MaxDecodedImageBytes() might return a value that is smaller than the size we request. The reason we request a larger size is that only some of the codecs support decoding to a smaller size, and for things like PNGs we would still be requesting an intrinsic size even though the max bytes is smaller than that. This trips up a DCHECK. The fix, as suggested by the bug reporter, is to take the minimum of desired bytes and max bytes. R=chrishtr@chromium.org Bug: 798110 Change-Id: I092541359164f4e08af68bf0e7939f2a9f8c8237 Reviewed-on: https://chromium-review.googlesource.com/847632Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526551}
-
Morten Stenshorne authored
Just have legacy layout call the code in ng/. There were two identical definitions of FragmentainerBreakPrecedence(), which may cause trouble for Jumbo builds at some point. Also remove (static) LayoutBox::JoinFragmentainerBreakValues(), since NG already provides an identical function (with the same name). Change-Id: I1af407aa1fbde8411176ce23e8a99742f60f4fca Reviewed-on: https://chromium-review.googlesource.com/846996Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Jinsuk Kim authored
Upon destruction of a WebView instance, it was found that objects managed by WebContentUserData can be accessed after WebContentsInternal is already gc'ed, therefore can cause a UAF crash bug. This CL checks the condition in which WebContentsUserData is accessed, and appropriate null checkings are performed to prevent the crash. Bug: 796295 Change-Id: If64c1d42f4434052c45b5f6f72ff0394addf829f Reviewed-on: https://chromium-review.googlesource.com/844272Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#526549}
-
Etienne Pierre-Doray authored
This CL refactors following functions and unittest in zucchini_gen: - FindExtraTargets() - GenerateReferencesDelta() Implementation is changed, but implies no side effect (patch is identical). As a result, labelling and marking of targets is avoided, reducing usage of LabelManager. Bug: 760614 Change-Id: I7b8e59f938f3c3b5f8edaa6125649d4ae1c02a0d Reviewed-on: https://chromium-review.googlesource.com/845094 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#526548}
-
Sasha Bermeister authored
Bug: 781643 Change-Id: I4f518be0602252b06d931fa4c598c5e08b9c120a Reviewed-on: https://chromium-review.googlesource.com/826525 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#526547}
-
Christopher Grant authored
This allows the reticle to appear on the keyboard while typing. BUG=798561 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I647849e9556647bbbf25dc855761329926037edc Reviewed-on: https://chromium-review.googlesource.com/847932Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#526546}
-
Jesse Doherty authored
Bug: 798527 Change-Id: I0bff283c56b4e48a1a05eb6de8a707fbc63a3263 TBR: tbansal@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/847733 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Sasha Bermeister authored
Bug: 781643 Change-Id: Ic2c7118bc4d63404298b21ae0c85dd4512538881 Reviewed-on: https://chromium-review.googlesource.com/826524 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526544}
-
Daniel Bratell authored
In certain non-standard jumbo configurations (very large jumbo units) there were some symbol clashes that do not appear in normal jumbo builds. This resolves them by renaming one test class to better match the test, and by wrapping the other test in a custom namespace as done in other places in blink tests. Bug: 745732 Change-Id: Ic0388e9abd19b24366133c577059f59ef63a6b6b Reviewed-on: https://chromium-review.googlesource.com/847009Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#526543}
-
Mohamad Ahmadi authored
tests that depend on ChromeWebClient (for e.g., early script injection) to run. web: :WebTest uses an instance of web::TestWebClient by default. This allows Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8e36ac709f5c445392a817219cabc5c5152aa164 Reviewed-on: https://chromium-review.googlesource.com/840300Reviewed-by:
-
Tom Anderson authored
GTK windows have the .maximized class applied when they are maximized. Child widgets may be styled differently depending on this state, as the Breeze theme does with the unmaximize button. Unlike other themes, the Breeze theme uses a bitmap to render the titlebuttons, so it was the only theme so far affected by this issue. With this fix, the unmaximize button looks like a diamond instead of an up arrow. BUG=794358 R=thestig@chromium.org Change-Id: I462d78665e3d1e30d05535af632415c981f3f432 Reviewed-on: https://chromium-review.googlesource.com/842857Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526541}
-
Thanh Le authored
Bug: 796089 Change-Id: If98d74fdeac2892463f1353da778fb9973b07b86 Reviewed-on: https://chromium-review.googlesource.com/847694Reviewed-by:
-
Joy Ming authored
This is part of a series of changes to implement the functionality to change default download location on Android. This CL creates a simple toggle between internal and external storage locations as a temporary step while the layout of the final directory selector is being decided. Screenshot: https://drive.google.com/file/d/1axW_UAm8JWlAhrQvITsiHCKi1nNoF8Ym Bug: 792775 Change-Id: I3a5b11c84c3e4dcd79ab941351fdd20c310d569d Reviewed-on: https://chromium-review.googlesource.com/832822Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#526539}
-
Sheriff-o-matic authored
Change-Id: I3336d665aa4a14abdc1d6e60c9141f2bb9374918 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 798548 Reviewed-on: https://chromium-review.googlesource.com/846358 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Wez authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4b34ee3b25ff3820c03f3b8b2a1ec559a18650c3 Reviewed-on: https://chromium-review.googlesource.com/847644Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#526537}
-
Will Chen authored
This is a follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/846026. These tests were rebaselined and are now passing without flakes. Bug: 626703, 751952 Change-Id: I0497c373ae1b99e728b8f81cc52d11c9521e725e Reviewed-on: https://chromium-review.googlesource.com/847309Reviewed-by:
-
Will Chen authored
After marking the test from skip to pass / fail / timeout in https://chromium-review.googlesource.com/c/chromium/src/+/845979, we can see the test is only flaky on the Leak bot: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http/tests/devtools/console/console-search.js Bug: 667560 Change-Id: I0734ef74c65bd067ce7f933ed488b37ecd24fb23 Reviewed-on: https://chromium-review.googlesource.com/847306Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526535}
-
Abhishek Arya authored
R=glider@chromium.org Bug: 790784,797998 Change-Id: I112b606d8f34a616624d99201b6da8b5534148ea Reviewed-on: https://chromium-review.googlesource.com/846028Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#526534}
-
Yash Malik authored
Note that this CL doesn't add support for filling out the omnibox text field when the speech recognition result (in case we're not very confident in the speech). Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I660100011e7ccaaa8a9a85481829c09067f1859b Reviewed-on: https://chromium-review.googlesource.com/846222Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#526533}
-
Darren Shen authored
To match the spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly Bug: 785132 Change-Id: I0cdd6aa9e4ec1129d272e64cc53d12487e3fb256 Reviewed-on: https://chromium-review.googlesource.com/846159Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526532}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5edcf150. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/9456 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Iaa1bc72df228516e25226ee08436e55b9ca7eece Reviewed-on: https://chromium-review.googlesource.com/847281 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526531}
-
Elly Fong-Jones authored
This link is sometimes used as a free text field and can be quite long. Bug: 795226 Change-Id: I46e8f324f2467801dfa5a1ade8df45de8d0587de Reviewed-on: https://chromium-review.googlesource.com/829594Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#526530}
-
Simon authored
TBR=nednguyen@google.com NOTRY=true Bug: 798465 Change-Id: If3972194b9ccdbf677a6570c4bce34963eeb41e5 Reviewed-on: https://chromium-review.googlesource.com/846307Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#526529}
-
Denis Bessonov authored
The crash occurs in the following situation: - Navigation is performing which results in Frame detach from DOMWindow - PerformanceObserver::disconnect is called from PromiseReactionJob micro task In this case, this call graph is executed: blink::(anonymous namespace)::EndOfTaskRunner::DidProcessTask() v8::internal::Isolate::RunMicrotasks() v8::internal::Isolate::RunMicrotasksInternal() v8::internal::Isolate::PromiseReactionJob() ... some V8 magic to call browser API from JS ... blink::PerformanceObserver::disconnect() blink::PerformanceBase::UnregisterPerformanceObserver() blink::Performance::UpdateLongTaskInstrumentation() blink::LocalFrame::GetDocument() const and, given that Frame has been detached, GetDocument() is called with this equal to nullptr, which leads to segfault. Bug: 793720 Change-Id: Id3cd67e3ebb5a197024b8ac269eebfc241cf2fc7 Reviewed-on: https://chromium-review.googlesource.com/825022 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#526528}
-
Robert Sesek authored
Bug: 598854, 568664 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I65e453144c9d465579101269e0963cd4319abc33 Reviewed-on: https://chromium-review.googlesource.com/838281Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526527}
-
Brian White authored
Everything went well with the experiment so make it permanent. Bug: 782879 Change-Id: I340fc590d994bac2e50f17b25890558430136365 Reviewed-on: https://chromium-review.googlesource.com/847417Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#526526}
-
