- 01 Dec, 2016 40 commits
-
-
xiyuan authored
So that it can be used for mojo type mapping. BUG=648964 Review-Url: https://codereview.chromium.org/2538113005 Cr-Commit-Position: refs/heads/master@{#435709}
-
rajendrant authored
BUG=655749 Review-Url: https://codereview.chromium.org/2539063003 Cr-Commit-Position: refs/heads/master@{#435708}
-
sdefresne authored
When invoking build script from Xcode, many environment variables are exported by Xcode based on the project settings. Sanitize the environment as those variable interact poorly with the hermetic build (see linked bug for detail of failure more). BUG=634501 Review-Url: https://codereview.chromium.org/2544803002 Cr-Commit-Position: refs/heads/master@{#435707}
-
tnagel authored
To allow testing of Active Directory device policy with a fake D-Bus client, simulate the combined actions of authpolicyd and session manager by writing a minimal PolicyFetchResponse to stub_device_policy. BUG=667780 Review-Url: https://codereview.chromium.org/2531063002 Cr-Commit-Position: refs/heads/master@{#435706}
-
johnme authored
Reland of https://codereview.chromium.org/2540763002 which was reverted in https://codereview.chromium.org/2540423003. Test has been fixed. It'll be useful to compare timings and byte sizes for the different image types (content image, icon, badge, action icon). BUG=669621, 614456 TBR=isherman@chromium.org (histograms unchanged from reverted patch) Review-Url: https://codereview.chromium.org/2544613004 Cr-Commit-Position: refs/heads/master@{#435705}
-
kozyatinskiy authored
BUG=661497 TBR=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2542813004 Cr-Commit-Position: refs/heads/master@{#435704}
-
kylechar authored
Split //ui/display so that general display code stays in //ui/display and display management code is now in //ui/display/manager. This is necessary as //ui/base has a dependency on //ui/display and code that is being refactored out of ash has a dependency on //ui/base, forming a cycle. Create //ui/display/manager target. Move the files in src/ui/display/chromeos to src/ui/display/manager/chromeos since they are all related to display management. Update includes and targets for the moved files. BUG=667344 TBR=sadrul,reveman CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2540313002 Cr-Commit-Position: refs/heads/master@{#435703}
-
mthiesse authored
This CL introduces two virtual displays for VR Shell, one for the content window, and one for the background UI window (which is made as small as possible to save on memory). The UI now dynamically controls its size, and the content defaults to a reasonable size regular web browsing (in VR). BUG=643480 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2428383006 Cr-Commit-Position: refs/heads/master@{#435702}
-
kozyatinskiy authored
BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2545813003 Cr-Commit-Position: refs/heads/master@{#435701}
-
yucliu authored
1. DumpsateWriter.writeDumpValues prints a warning message if it's not created. 2. Move libcast_shell_android to shared_library in GN. 3. Other GN deps fix. BUG=None TEST=Build cast for Android and display web page Review-Url: https://codereview.chromium.org/2541513005 Cr-Commit-Position: refs/heads/master@{#435700}
-
mattreynolds authored
When the user disables Bluetooth, the Physical Web feature stops scanning for nearby URLs but retains information about URLs that have already been discovered. With this change, the retained information will not be returned when clients request the list of Physical Web URLs with Bluetooth disabled. BUG=663566 Review-Url: https://codereview.chromium.org/2507213003 Cr-Commit-Position: refs/heads/master@{#435699}
-
watk authored
This fixes a race condition where we previously asserted that both threads were stopped, but only after receiving a notification that the first had stopped. Now we don't assert that the second has stopped. It also includes some minor refactors: deleting TestInformation and injects the params directly, and splitting the failing test into two smaller tests. BUG=668291 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2540593005 Cr-Commit-Position: refs/heads/master@{#435698}
-
einbinder authored
_nestedUpdatesCounter and _fixWordMovement were unused, and FixWordMovement makes more sense as a static method. BUG=none Review-Url: https://codereview.chromium.org/2524583002 Cr-Commit-Position: refs/heads/master@{#435697}
-
sky authored
Makes DesktopWindowTreeHostMus update the client area on the server any time the bounds change. Makes DesktopNativeWidgetAura not update the transparency and fills-bounds-completely of the content_window_. This way DesktopNativeWidgetAura won't fill the client area and you can see the client decorations from the window manager. Also DesktopWindowTreeHostMus makes sure to mark the content_window_ layer as not fills bounds opaquely for same reason. Lastly makes it so the client that changes the client area isn't told about the change, and a bit of logging that fits in with other logging in the file. BUG=664625 663525 TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2535753009 Cr-Commit-Position: refs/heads/master@{#435696}
-
rch authored
BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2537993003 Cr-Commit-Position: refs/heads/master@{#435695}
-
lgrey authored
Fixing forward from https://codereview.chromium.org/2541583002 BUG=670181 Review-Url: https://codereview.chromium.org/2546753002 Cr-Commit-Position: refs/heads/master@{#435694}
-
jbriance authored
Remove useless class and struct forward declarations, and add missing ones in chromecast header files. BUG=662195 Review-Url: https://codereview.chromium.org/2545733002 Cr-Commit-Position: refs/heads/master@{#435693}
-
twellington authored
Destroy ContextualSearchQuickActionControl when ContextualSearchBarControl is destroyed. BUG=670153 Review-Url: https://codereview.chromium.org/2544873002 Cr-Commit-Position: refs/heads/master@{#435692}
-
ekaramad authored
When the value of requested range is invalid, the TextInputClientObserver will return the rect corresponding to the current cursor position instead. BUG=664679 Review-Url: https://codereview.chromium.org/2537363002 Cr-Commit-Position: refs/heads/master@{#435691}
-
jbroman authored
BUG=670415 TBR=battre@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2547643002 Cr-Commit-Position: refs/heads/master@{#435690}
-
einbinder authored
If a CSS value had the same name as a CSS property and was used in autocomplete, it would get a high priority. This doesn't happen often, if at all, in practice. But it's good to guard against. BUG=none Review-Url: https://codereview.chromium.org/2519193002 Cr-Commit-Position: refs/heads/master@{#435689}
-
fs authored
Make asCSSPrimitiveValue() return a reference to a CSSPrimitiveValue, rather than a pointer. The CSSPrimitiveValue contained in the SVGLength can/should never be null. Add a helper to SVGAnimatedLength to cut down on some boilerplate for accessing the current CSSValue. Review-Url: https://codereview.chromium.org/2549563002 Cr-Commit-Position: refs/heads/master@{#435688}
-
http://crrev.com/2538943002fmalita authored
Looks like rebaseline-cl picked up some .txt diffs for a handful of flaky Android tests. TBR=liyuqian@google.com,rockot@chromium.org Review-Url: https://codereview.chromium.org/2547613002 Cr-Commit-Position: refs/heads/master@{#435687}
-
fsamuel authored
resource_size_in_pixels was missed in TextureDrawQuad. This was missed because unit tests used SetNew instead of SetAll and only set all set the resource_size_in_pixels. This CL adds the missing field and updates the corresponding test. BUG=659601 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2541403002 Cr-Commit-Position: refs/heads/master@{#435686}
-
scottmg authored
[e57cdc4...]c:\src\cr\src\third_party\ced\src>git log --oneline 9012c0a..e57cdc4 e57cdc4 Merge pull request #3 from sgraham/master 3882135 Encode compact_enc_det.cc as utf-8 TBR=jinsukkim@chromium.org BUG=454858,637203 Review-Url: https://codereview.chromium.org/2547623002 Cr-Commit-Position: refs/heads/master@{#435685}
-
wkorman authored
Follow-up to renames performed in http://crrev.com/2536453002 Review-Url: https://codereview.chromium.org/2539713004 Cr-Commit-Position: refs/heads/master@{#435684}
-
rohitrao authored
BUG=None Review-Url: https://codereview.chromium.org/2545743002 Cr-Commit-Position: refs/heads/master@{#435683}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/02759102cf99..9be9c3486688 $ git log 02759102c..9be9c3486 --date=short --no-merges --format='%ad %ae %s' 2016-12-01 npm Improve early return in CGifLZWDecoder::Decode BUG=659417 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2544863002 Cr-Commit-Position: refs/heads/master@{#435682}
-
pdr authored
This patch stops the prepaint tree walk when no paint invalidation or paint property updates are needed. The three major changes are: 1) PaintPropertyTreeBuilder now detects when properties are added or removed and forces a paint property update for all descendants. This is needed because tree structure changes can cause descendant objects to reference new/different ancestors. 2) When stopping the prepaint tree walk due to throttled frames, paint invalidation and property update flags are no longer cleared. This allows subsequent prepaint tree walks to correctly invalidate subframes when they unthrottle. 3) PrePaintTreeWalk::walk(LayoutObject&...) exits early when possible. Design doc: https://docs.google.com/document/d/1_GkBfvameyhnLV7ODIRsOoTedQEG5liAcHwAxmwS-Vk/view Performance results on blink_perf.Paint[1]: color-changes.html: -3.4% large-table-background-change-with-invisible-collapsed-borders.html: -19.2% large-table-background-change-with-visible-collapsed-borders.html: -3.0% large-table-collapsed-border-change.html: -0.4% large-table-collapsed-border-change-with-backgrounds.html: -6.8% large-table-collapsed-border-change-with-text.html: -17.2% large-table-repaint.html: -6.0% paint-offset-changes.html: -4.7% transform-changes.html: -2.7% [1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release --pageset-repeat=5 --extra-browser-args=--enable-slimming-paint-v2 BUG=645667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2539693002 Cr-Commit-Position: refs/heads/master@{#435681}
-
katthomas authored
We want to be able to use --test-launcher-filter-file AND --gtest_filter. A test is run if and only if: A) positive_patterns_from_gtest_filter are empty, or the test matches at least one pattern from positive_patterns_from_gtest_filter AND B) positive_patterns_from_test_launcher_filter_file are empty, or the test matches at least one pattern from positive_patterns_from_test_launcher_filter_file AND C) the test doesn't match ANY negative_patterns_from_gtest_filter AND D) the test doesn't match ANY negative_patterns_from_test_launcher_filter_file R=dpranke@chromium.org BUG=587527 Review-Url: https://codereview.chromium.org/2515573003 Cr-Commit-Position: refs/heads/master@{#435680}
-
igorcov authored
To be used in Chrome OS when separating functionality based on board. Fixed the bad usage of GetLsbReleaseBoard(). BUG=653814,663857 Review-Url: https://codereview.chromium.org/2489853002 Cr-Commit-Position: refs/heads/master@{#435679}
-
dbeam authored
R=tommycli@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2541113003 Cr-Commit-Position: refs/heads/master@{#435678}
-
wangxianzhu authored
Revert of Don't expand empty rect during rect mapping (patchset #4 id:60001 of https://codereview.chromium.org/2416693002/ ) Reason for revert: It changed transform->mapRect(enclosingIntRect(rect)) to transform->mapRect(FloatRect(enclosingIntRect(rect))) causing missing enclosingIntRect() after the transform. We may also need enclosingIntRect for empty rects because even empty object can have visible filter depending on pixel snapping here. BUG=669774 TEST=paint/invalidation/rotated-subpixel.html Original issue's description: > Don't expand empty rect during rect mapping > > For example, enclosingIntRect(LayoutRect(0.5, 0.5, 0, 0)) results > IntRect(0, 0, 1, 1). This causes unnecessary non-empty visual rects > mapped from empty LayoutRects. > > This CL is mainly to reduce the difference between the old path and > slimmingPaintInvalidation with pixel snapping feature. > > Committed: https://crrev.com/67c516aaed2486295a98d7f0ff2235b921cd7933 > Cr-Commit-Position: refs/heads/master@{#424970} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2545573002 Cr-Commit-Position: refs/heads/master@{#435677}
-
hlundin authored
This change adds a new histogram factory method that provides a count histogram but with linearly spaced buckets. BUG=none Review-Url: https://codereview.chromium.org/2545703002 Cr-Commit-Position: refs/heads/master@{#435676}
-
takumif authored
When a new action is added to the incognito toolbar (which can happen with the Media Router component action), it should become visible regardless of the state of the non-incognito toolbar. This change ensures that and adds a unit test. BUG=668039 Review-Url: https://codereview.chromium.org/2539153003 Cr-Commit-Position: refs/heads/master@{#435675}
-
donnd authored
Just removing the assert. BUG=670158 Review-Url: https://codereview.chromium.org/2543903002 Cr-Commit-Position: refs/heads/master@{#435674}
-
vakh authored
Update: The server has started sending updates to Google Chrome builds for all supported lists. See: http://b/33182208 BUG=543161 Review-Url: https://codereview.chromium.org/2536913002 Cr-Commit-Position: refs/heads/master@{#435673}
-
ajuma authored
The map lookup was added by http://crrev.com/434349, but caused a 5-10% regression in CalcDrawPropsTests cc_perftests. This CL sets the effect tree index on the surface during the surface update step (when EffectNode::render_surface gets updated). BUG=670074 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2540333002 Cr-Commit-Position: refs/heads/master@{#435672}
-
jbroman authored
Remove bad Mac10.10 baseline for svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg. Originally landed in: https://codereview.chromium.org/2538943002 The platform/mac/ baseline is correct (matches the actual result on the bot), so deleting this file should suffice. TBR=liyuqian@google.com NOTRY=true Review-Url: https://codereview.chromium.org/2542843005 Cr-Commit-Position: refs/heads/master@{#435671}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/228237cf..d7fb769f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2540383004 Cr-Commit-Position: refs/heads/master@{#435670}
-