- 12 Nov, 2018 40 commits
-
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. Bug: 884159 Change-Id: I876c39d3f69f7d5e8ed3ead1f07660279e283eb0 Reviewed-on: https://chromium-review.googlesource.com/c/1286455Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607279}
-
Luke Halliwell authored
Change-Id: Ia56a9b605860cb8911bc3e94791760e1ad2b7664 Reviewed-on: https://chromium-review.googlesource.com/c/1303396Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#607278}
-
Aaron Krajeski authored
Also adapt them to run automatically with telemetry. Delete the old folder and its contents. Bug: 894043 Change-Id: I5aa4f9172de5ecba0cffd7187ba579b069ae216b Reviewed-on: https://chromium-review.googlesource.com/c/1315530 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607277}
-
Francois Doray authored
This will allow us to assess the impact of using thread priorities. The impact can be both positive (unimportant work gets out of the way) and negative (priority inversions when sharing locks across threads with different priorities). Note: This CL has extra complexity because we don't have guarantees that the FeatureList is initialized before threads are started in unit tests https://crbug.com/846380. Bug: 872820, 890978, 902441, 846380 Change-Id: I8887c7b9e0eb77f7c11aa6e2be8af1ea7150b491 Reviewed-on: https://chromium-review.googlesource.com/c/1318686 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#607276}
-
Tommy C. Li authored
pkasting@ is already in the omnibox component OWNERS file, so he will remain an OWNER of search_engines after this CL. chrome/browser/search_engines includes the below OWNERS file, so it doesn't directly need updating. I'm updating chrome/browser/ui/search_engines as well, as our team recently added code to the SearchEngineTabHelper to auto-update the default search provider favicons as the user browses. Bug: NONE Change-Id: Ib26716fb8ce00b3a166769611e87c4c80273ecba Reviewed-on: https://chromium-review.googlesource.com/c/1329892Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#607275}
-
John Budorick authored
Tbr: martiniss@chromium.org Bug: 877264 Change-Id: Icd73a35287a406a2fbe87669cbb5f472a0b4d413 Reviewed-on: https://chromium-review.googlesource.com/c/1331417Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607274}
-
Arthur Sonzogni authored
Some URLLoaders aren't always sending a response's body datapipe to their client after sending URLLoaderClient::OnReceiveResponse(response_head). It even happens to send URLLoaderClient::OnComplete(net::OK) after that. Most of the time, they do not send a datapipe, because the response's body is empty. The goal is to align URLLoaders so that they will always send a data pipe by using OnStartLoadingResponseBody(response_body). This CL is about ServiceWorker's URLLoaders. This CL is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 Bug: 826868, 831155 Change-Id: Ib28fc2067240d611ec149099b5365f70610a9369 Reviewed-on: https://chromium-review.googlesource.com/c/1323109 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#607273}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: Ia4d3093f9f70dd3aeeb0a49d87475bc3f4f2c58d Reviewed-on: https://chromium-review.googlesource.com/c/1330891Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#607272}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 899324 Test: none Change-Id: I764a9dc6f2d38f896a8d7ec41f15a834e5bbba85 Reviewed-on: https://chromium-review.googlesource.com/c/1330842Reviewed-by:
-
Peter Boström authored
This makes use of COLOR_TAB_THROBBER_SPINNING in both the loading and waiting states. Bug: chromium:903457 Change-Id: I3e6bed8392c956604649c42eb8fcef1d10a7a8c9 Reviewed-on: https://chromium-review.googlesource.com/c/1329349Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607270}
-
Francois Doray authored
Previously landed as https://chromium-review.googlesource.com/c/1318438. Reverted because PlatformThreadWinTest.SetBackgroundThreadModeFailsInIdlePriorityProcess failed on Windows 7. This reland adds more possible return values for ::GetThreadPriority() on Windows 7 (see diff between ps1 and ps7). Previously, SetCurrentThreadPriority(BACKGROUND) did not affect CPU priority on Windows in a IDLE process when the "WindowsThreadModeBackground" feature was enabled. It only affected I/O and memory priorities. With this CL, a second call to ::SetThreadPriority() is made to ensure that CPU priority is affected. TBR=gab@chromium.org Bug: 901483 Change-Id: I21ebc6465b3b8d10a956714d55ef88b28bf89fff Reviewed-on: https://chromium-review.googlesource.com/c/1326423Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This is a reland of aaeff5e6 which was a reland of 31bcf8aa which was a reland of 5528336d, which was a reland of dd9df78c, which was a reland of 7bd91635. Relanding with no changes, after disabling the flaky test in https://crbug.com/904389 Original change's description: > [blink] Control ScriptStreamer with ScriptResource > > Move the ScriptStreamer control logic from ClassicPendingScript to > ScriptResource. In the future, this will allow us to start streaming > a ScriptResource before the ClassicPendingScript is available, e.g on > preload. > > The ClassicPendingScript now only sends one "finished" callback, from > ScriptResource. This callback is either when the streaming completes, > or when there is no streaming and the ClassicPendingScript has told > the ScriptResource that it doesn't intend to start streaming. In the > long run, we want all scripts to go through the streaming interface, > and we want ScriptResource to control when streaming starts, so the > "no more streaming" call will disappear -- however it is necessary to > maintain the current behaviour, and be able to control it with a > runtime flag. > > Bug: chromium:865098 > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599148} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org Bug: chromium:865098 Change-Id: Ifa87904db32666517bfe1174fca51b7e552679b2 Reviewed-on: https://chromium-review.googlesource.com/c/1329800Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#607268}
-
Eric Roman authored
This fixes BasicAuthWSConnect.BasicAuthWSConnect. The ordering of proxy bypass rules only mattered until recently, with the addition of the <-loopback> bypass rule (Issue 413511). That rule gives a way to "subtract" the bypass of localhost, and can be used by tests need to proxy localhost (see Issue 901896). Because later rules have priority over earlier rules, we need to move <local> to the front, or it won't be possible for user-provided (explicit) rules to override it. Bug: 902418 Change-Id: I40fb6e23e7b79ba628595cd6724de627bedb5f73 Reviewed-on: https://chromium-review.googlesource.com/c/1321853 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607267}
-
Arthur Sonzogni authored
This is a sort of prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 The main goal is after sending: URLLoaderClient::OnReceiveResponse(response_header) to ALWAYS send: URLLoaderClient::OnStartLoadingResponseBody(response_body) Some URLLoader, when the response's body body is empty, don't even try to send the response_body data pipe. In the URLLoaderClient, not having to handle the case with no data pipe would be a nice simplification. What this CL does: 1) In BlobUrlLoader, create the data pipe at ::Start() time. 2) Pass the producer handle to the MojoBlobCreate at construction time. 3) Pass the consumer handle to OnStartLoadingResponseBody(), immediately after OnReceiveResponse(). Some code simplification was possible. There is no more need to implement PassDataPipe() in BlobURLLoader, ReaderDelegate and DataPipeReaderDelegate. There is no more need to give them the pipe at construction time neither. Bug: 826868, 831155 Change-Id: I827cb39bdd782624ff362874e98be90cab0d47f3 Reviewed-on: https://chromium-review.googlesource.com/c/1329741Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607266}
-
Max Moroz authored
Hopefully this won't break too many things. Libraries removed: - Linux: removed ~5.5MB from ~24.5MB of libs (excluding Android libs): 1.5M libclang_rt.asan-i386.so 4.0K libclang_rt.asan-preinit-i386.a 1.5M libclang_rt.asan-x86_64.so 4.0K libclang_rt.asan-preinit-x86_64.a 36K libclang_rt.hwasan_cxx-x86_64.a 4.0K libclang_rt.hwasan_cxx-x86_64.a.syms 1.4M libclang_rt.hwasan-x86_64.a 4.0K libclang_rt.hwasan-x86_64.a.syms 388K libclang_rt.hwasan-x86_64.so 352K libclang_rt.ubsan_standalone-i386.so 332K libclang_rt.ubsan_standalone-x86_64.so - Darwin: removed ~3MB from ~9MB of libs 1.5M libclang_rt.fuzzer_no_main_ios.a 1.6M libclang_rt.fuzzer_no_main_iossim.a - Windows: (insignificant) removed ~50KB from ~28MB of libs 48094 clang_rt.asan-preinit-i386.lib 892 clang_rt.asan-preinit-x86_64.lib Bug: 870331 Change-Id: I0ccf1310b2ab5bde6d514a31b2c5ba7eb2844401 Reviewed-on: https://chromium-review.googlesource.com/c/1315361Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607265}
-
Leszek Swirski authored
Mark the delaying_onload_link_preload_after_discovery layout test as flaky, due to flakiness under heavy load. Bug: 904389 Change-Id: I585fd5a02a7f94c98dbf10176f58069153c12b2c Reviewed-on: https://chromium-review.googlesource.com/c/1331392Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#607264}
-
James Hawkins authored
Change-Id: I46f7c22d556302df6a657742fcee5c253e14a437 Reviewed-on: https://chromium-review.googlesource.com/c/1330119Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e5366120355..59d560e4e67d Created with: gclient setdep -r src-internal@59d560e4e67d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I85cf5502cde03d3919ecad711c075dc60ef9c248 Reviewed-on: https://chromium-review.googlesource.com/c/1331221Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607262}
-
Benoît Lizé authored
Fix typo in https://chromium-review.googlesource.com/c/chromium/src/+/1323549 Bug: 877044 Change-Id: I377da8d819b3abbe27df8245e608e55c49759f05 Reviewed-on: https://chromium-review.googlesource.com/c/1329799Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607261}
-
Owen Min authored
Fix ProfileWindowBrowserTest.OpenBrowserWindowForProfileWithSigninRequired on Linux The test is flaky due to race conditionin the test body. Bug: 904397, 901430 Change-Id: I80b73f507e3826fc7a707379b89b39a3e7aa68c5 Reviewed-on: https://chromium-review.googlesource.com/c/1330032Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607260}
-
Michael Ludwig authored
Bug: 903289 Change-Id: I34dbf4c6b24c175941d95a3b8f3399d955af689d Reviewed-on: https://chromium-review.googlesource.com/c/1329901Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#607259}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: Ibf6c38d09ce7bfa49e60e049f5ff240e17eade8b Reviewed-on: https://chromium-review.googlesource.com/c/1329625Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607258}
-
Jesse McKenna authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1320650 Bug: 889029 Change-Id: I4dd60a56fcab509578cdfe08c999c1e34fd72375 Reviewed-on: https://chromium-review.googlesource.com/c/1331219 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
-
Xida Chen authored
Right now this class takes a WTF::String, which would be hard to make that pass cross thread. This CL changes WTF::String to a std::string. Bug: 902429 Change-Id: Iaa7377a02e299e99ac8178eaf59cd228724609d6 Reviewed-on: https://chromium-review.googlesource.com/c/1331032Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607256}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7cdd680b3802..d608c792b594 git log 7cdd680b3802..d608c792b594 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 lalitm@google.com Merge "trace_processor: track number of rss stat and mem counters without upids" Created with: gclient setdep -r src/third_party/perfetto@d608c792b594 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Icc4c3d0dd155cf3defb9158fa884b544fbfaebe4 Reviewed-on: https://chromium-review.googlesource.com/c/1331220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607255}
-
Alex Clarke authored
This is necessary for using SequenceManager inside ScopedTaskEnvironment. It also makes Virtual Time a bit cleaner from an interface PoV. Bug: 863341, 891670 Change-Id: Iaa8300b6c4b2f889b4cfe185959e3a280730636d Reviewed-on: https://chromium-review.googlesource.com/c/1329969 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607254}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=fdoray@chromium.org Bug: 766678 Change-Id: I49ce1451e0a57c832a2ef09d00364aba4b6a69e9 Reviewed-on: https://chromium-review.googlesource.com/c/1324397Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/50bf0429394d..48f63f90f6f3 git log 50bf0429394d..48f63f90f6f3 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 jiajia.qin@intel.com ES31: add row major matrix support (part 2) Created with: gclient setdep -r src/third_party/angle@48f63f90f6f3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9925fa75c8feb9418d8d453d4dd18a1a7825a761 Reviewed-on: https://chromium-review.googlesource.com/c/1331414Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ac7f8c6..85604c46 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6876c0b071b79ca6c6099456e9aadd263239e044 Reviewed-on: https://chromium-review.googlesource.com/c/1330027Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607251}
-
Majid Valipour authored
AnimationWorklet and ScrollTimeline heavily depend on WebAnimations API. For example to build the most basic example based on AnimationWorklet one needs to construct a KeyframeEffect. This CL will ensure that AnimationWorklet flag also enables WebAnimationsAPI runtime feature. Bug: 903953, 811922 Change-Id: Ie1f92ee2e579541675f88b762cbc30895bc66942 Reviewed-on: https://chromium-review.googlesource.com/c/1329891Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#607250}
-
jonross authored
Currently LocalSurfaceId allocation time is not always accurate. This is because ParentLocalSurfaceIdAllocator generates on at creation time. This change stops that, moving the generation to each of the times where we need to first allocate an ID. A few sites will need further investigation, as they seem to be accessing the allocator ID, out of their normal allocation flow. Which would lead to sending invalid LocalSurfaceIds. These will be addressed in follow-ups, and for now just fallback to generating an ID at creation time. BUG: 655231 Change-Id: I1e6c6b49f9b593896318814e50eea21b3671fb6b Reviewed-on: https://chromium-review.googlesource.com/c/1312118Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#607249}
-
edchin authored
A bug in WKWebView causes video playback to get gummed up for all future playbacks even on new WebStates until the app is killed. This fix runs the simple reduced motion animator for iOS 10 so users are able to playback video. Bug: 891851 Change-Id: I22e84f5a7e3b7aa453ba8fe4632ddc12619d86a7 Reviewed-on: https://chromium-review.googlesource.com/c/1330028Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607248}
-
Mathias Carlen authored
Before this patch, we stopped autofill assistant with an error message when the cvc step got cancelled. We are currently not able to distinguish between a bad cvc and cancel. This patch makes a first step towards a nicer flow where stop script becomes a graceful shutdown with a status message. Bug: 806868 Change-Id: I5d0e3f74d21f54df1276f994be2ae8c798fa2c0f Reviewed-on: https://chromium-review.googlesource.com/c/1331394 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607247}
-
Daniel Vogelheim authored
Change the client header announcing OP capability to use the value "0". This is meant to mitigate an apparently reasonably common bug where the header value is blindly copied into the request (as observed in the referenced bug). Bug: 751996, 901477 Change-Id: I85c67cfdad3d15fc8e76e62bf1f84323faa1f790 Reviewed-on: https://chromium-review.googlesource.com/c/1328982Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#607246}
-
Xida Chen authored
Right now at PassthroughTouchEventQueue::ProcessTouchAck, we fetch an event from outstanding_touches_ queue, modify its ack info and latency info, and put the event back in the queue again. Note that the outstanding_touches_ is a std::set sorted according to each event's unique_touch_id. Setting ack info and latency info won't change the unique_touch_id on the event, in order words, it won't affect the ordering of the event in that set. So it is un-necessary to remove the event and put it back in the queue again. This CL does clean up. It sets ack and latency info directly on the event in the outstanding_touches_. The only catch here is that the iter of a std::set is always const, so we have to do a const_cast. Bug: None Change-Id: I45cf1001ce82b3fd876b856618c99df25d5b9b4a Reviewed-on: https://chromium-review.googlesource.com/c/1297714Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607245}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: Ic159261bb0296e11d58bd7adb98b6a5a8fb5cece Reviewed-on: https://chromium-review.googlesource.com/c/1329747Reviewed-by:
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I753f512b660e613d8e6f622f81ef2aa3600d4310 Reviewed-on: https://chromium-review.googlesource.com/c/1329631Reviewed-by:
-
Nicolas Ouellet-Payeur authored
The test runs an 'echo' command to a temporary file when the user visits example.com, and then checks that the temporary file exists and contains the right string. Bug: 884211 Change-Id: Ifa8a129aa8e98583a6060274bb85a8bc4d235b8d Reviewed-on: https://chromium-review.googlesource.com/c/1318057Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#607242}
-
Owen Min authored
DeveloperToolsDisabled policy is marked as deprecated in policy_templates and DeveloperToolsPolicyHandler. Remove the one in handler so that the deprecation message only appears once. Bug: 902603 Change-Id: Ia9a78cd4667eb39b5ec3e82399fcd44ae1556de1 Reviewed-on: https://chromium-review.googlesource.com/c/1326843Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607241}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c7a34cae21d2..0243949545eb git log c7a34cae21d2..0243949545eb --date=short --no-merges --format='%ad %ae %s' 2018-11-12 reed@google.com Revert "route getFontMetrics to SkFont" 2018-11-12 reed@google.com add getwidths to SkFont 2018-11-11 reed@google.com impl SkFont::measureText 2018-11-11 reed@google.com route getFontMetrics to SkFont 2018-11-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2018-11-11 mtklein@google.com work around Flutter/Fuchsia GN problems 2018-11-11 mtklein@google.com Reland "Improve degenerate 2pt conical gradient cases" 2018-11-10 fmalita@chromium.org [skottie] Make animated image support generally available 2018-11-10 reed@google.com move GlyphCacheProc into fontpriv 2018-11-10 reed@google.com add fontmetrics to SkFont 2018-11-10 kjlubick@google.com Convert skottie's cloud build to use CanvasKit Created with: gclient setdep -r src/third_party/skia@0243949545eb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I12e66c7ffa4160419dbf559753c4758ac4b62fb5 Reviewed-on: https://chromium-review.googlesource.com/c/1331410Reviewed-by:
-
