- 16 Jan, 2020 21 commits
-
-
Miguel Casas authored
This CL replaces the DRM specific XB30 with AB30 where appropriate, and adds the necessary entries to support AB30 with SCANOUT usage. Test: forcing RGBA_1010102 as DisplaySnapshot::PrimaryFormat, and allowing for only an opaque FB (ToT wants both opaque and normal) the primary plane of the device is indeed XB30 as per /sys/kernel/debug/dri/0/state). and gl_unittests --gtest_also_run_disabled_tests and ozone_gl_unittests --gtest_also_run_disabled_tests AB30 test cases passing. Bug: 949260 Change-Id: Ie1841763b059971460597eded768a9a9827914b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960073Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#732211}
-
Weiliang Chen authored
Create OverlayProcessorOnGpu class which is an empty class on gpu thread. This uses the helper class created on previous CL. Following CLs will fill out its functionalities and make use of it. This is CL 2/? for sending the overlay candidates directly. R=rjkroege Bug: 979788 Change-Id: I50fb4e11bead2d990477cc056e807705340b39f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985301 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732210}
-
Kenneth Russell authored
This reverts commit cc0504e5. Reason for revert: speculative revert suspecting this CL as the cause of recently introduced test flakes Original change's description: > blink: Ensure correct shared image lifetime for static bitmap images. > > AcceleratedStaticBitmapImages created by WebGL rely on creating a > GL texture backing for a shared image to ensure the shared image > outlives the StaticBitmapImage. This in turn assumes that even if the > client explicitly destroys a shared image mailbox via > SharedImageInterface, they can continue to use this mailbox as long as > an associated representation is alive. This pattern is not something we > want to support. > > This pattern also means that when a mailbox is stored on > SharedImageInterface, we can not safely assume that the metadata > associated with it can be cached correctly. > > This change fixes this by transitioning WebGL to use the same factory > method for creating StaticBitmapImages as used by canvas2d. This in > turn also does the following: > > 1) Ensures that the correct texture target is plumbed through with the > StaticBitmapImage. > 2) Eliminates the needs to plumb an image and a release callback through > a bunch of code. Since the image now owns the release callback. > 3) Cleans up code in MailboxTextureHolder used to keep the mailbox's > texture backing alive. > 4) TransferToImageBitmap currently works by marking the resource as > lost, which means it can not be recycled. These redundant > reallocations are avoided with this change. > > R=kbr@chromium.org > > Bug: 1036142 > Change-Id: I8824aa8d03a48e35e39744cc30c9d0313dcbed08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996124 > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732100} TBR=kbr@chromium.org,khushalsagar@chromium.org,altimin@chromium.org,klausw@chromium.org Change-Id: Ic8c98f5f67d7c93c7e401846d1ff508e2b7159dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1036142, 1017162, 1042446, 1042481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003615Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732209}
-
Kunihiko Sakamoto authored
This extends all active SignedExchange histograms until 2020-10-01, and updates histogram owners appropriately. Bug: 1039320,1039319,1039318 Change-Id: Ieec4e5b07425aa881a395e44c748b8dce76800a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000405Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732208}
-
Vladimir Levin authored
This patch gathers the metrics for rendersubtree activation in UMA. R=chrishtr@chromium.org Change-Id: Id431799f9ff145ddb6413e37e43be6708ba626a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999319 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732207}
-
Nick Harper authored
Change-Id: Ia8eda5c1457b10d67c4f5b6a4caadefae4bde211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003351 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732206}
-
Yue Zhang authored
This CL introduces a new tab tile that always shows in the end of tab list in GTS. Clicking the new tab tile will create a new tab. New tab tile does not support any gesture and exists for both normal and incognito mode. Everything introduced in this CL is gated by field trail under the enable-tab-grid-layout flag. Light mode: https://drive.google.com/a/google.com/file/d/1B-8y4P3Pg-gyv9Z1eJ8wRP2PqEOHy-bV/view?usp=sharing Dark mode: https://drive.google.com/a/google.com/file/d/1DLwfIoDcfDfG2zyzLoiRigivYotauT87/view?usp=sharing NOTRY=true # Expediting. Only failed test is to be disabled. Bug: 1042304 Change-Id: Ia7bbb33ec8a93e0cd72e8d6e1c3663818c4ece8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999749 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#732205}
-
Noel Gordon authored
main.html <html dir="$i18n{textdirection}... suggests we should always read text direction from that element (document.documentElement). Test: browser_tests --gtest_filter="*ExpandHorizontalScroll*" Bug: 992819, 1025581 Change-Id: I890d9dc83568485f1b10096cc7ede61b8dc3085e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002548 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#732204}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ffdd58f5c0bf..a7b91502cd7f git log ffdd58f5c0bf..a7b91502cd7f --date=short --first-parent --format='%ad %ae %s' 2020-01-15 ianelliott@google.com Vulkan: Updated expectations after recent fixes Created with: gclient setdep -r src/third_party/angle@a7b91502cd7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: I379cd2aa1c9bd4ce44637fba15c49a7c1d510951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732203}
-
Anupam Snigdha authored
This patch removes the code where the input panel policy was set to notify TSF about the handling of the software input panel(SIP) as currently it is handled by calling TryShow/TryHide APIs. Bug: 1031786 Change-Id: I600f09b8e4d722d4586b51c67ac1078c5b35fe9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999547 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#732202}
-
Dan Beam authored
This reverts commit 87042ab6. Reason for revert: Clean up CLs have now landed and support for cr.exportPath() is being removed from Closure Compiler's --chrome_pass. It'll still have runtime effects, but the compiler wont understand that cr.exportPath('a.b.c') translates to window.a.b.c. Original change's description: > Revert "Add cr.exportPath() to ESLint banned properties" > > This reverts commit 6f69db7b. > > Reason for revert: > > The cleanup CLs haven't landed yet cuz the tree is borked > (ex: https://crrev.com/c/1995802) > > NOTREECHECKS=true > NOTRY=true > > Original change's description: > > Add cr.exportPath() to ESLint banned properties > > > > R=dpapad@chromium.org > > > > Bug: 1028829 > > Change-Id: I6ff5518a178bd86a5ab13b8ef7d8bce52b9588fd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995947 > > Commit-Queue: Dan Beam <dbeam@chromium.org> > > Auto-Submit: Dan Beam <dbeam@chromium.org> > > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#730348} > > TBR=dbeam@chromium.org,dpapad@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1028829 > Change-Id: I57cca1d4367794050cbd571382b30f11e650d429 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999549 > Reviewed-by: Dan Beam <dbeam@chromium.org> > Commit-Queue: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730990} TBR=dbeam@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1028829 Change-Id: I50af2fb35ab9ea9a7a73533499c5876f4a44d05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003920Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732201}
-
Sahel Sharify authored
coverage.py is hardcoded to generate coverage files in html format. This makes comparison of the two generated reports harder. While the text format allows users to use diff. This cl changes the script so that the user can specify either "html" or "text" output format via --format arg. The default value is html. Change-Id: I80da2701e332cb4bcda20bb187b928a307e907bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003790 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#732200}
-
Natalie Chouinard authored
Bug: 1035928 Change-Id: I2fba181a68566c535f83e1f4ad7d13491de1f1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003221Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#732199}
-
Andrew Xu authored
The current code fails to adapt gesture scroll on scrollable shelf under RTL. This CL fixes the issue by inverting the sign of the scroll offset under RTL. Bug: 1042119 Change-Id: I1db81df09b6f0b4d54097c7bd5e746e84e6e903f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931438Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d5e7c35c508..737bab4e36f5 Created with: gclient setdep -r src-internal@737bab4e36f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042278 Tbr: jbudorick@google.com Change-Id: Ie8f4a80144483aaafa5c713c86b29e03f09f0ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003748Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732197}
-
Robert Ma authored
In addition to console errors/warnings, we now accept alert/confirm/prompt as well. Also remove the temporary workaround added in crrev.com/c/1995474. Bug: 1041588 Change-Id: Ife40be2466db2b0d807d55252ca3c08b24889cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003608Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#732196}
-
Nick Harper authored
Change-Id: I293601adfc78aa56b52faa0dbed32ea5319256db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002942Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#732195}
-
Philip Rogers authored
This patch updates the CompositeCrossOriginIframes feature to promote (composite) cross-origin iframes. The original patch for this feature (https://crrev.com/708336) had a subtle bug because it did not change the self-painting status of the iframe's layer. To be composited, PaintLayers must be marked as self-painting (see: PaintLayerCompositor::CanBeComposited). This patch builds on the existing iframe compositing reason by adding a check for cross-origin frames in LayoutEmbeddedContent::RequiresAcceleratedCompositing. Because cross-origin changes now affect compositing, a call to Element::SetNeedsCompositingUpdate has been added when the cross-origin status changes in DocumentLoader::InstallNewDocument and LocalFrameView::CrossOriginStatusChanged. Bug: 1014273 Change-Id: I096fbad4921345df836b2a61c338cb4f4b5f79d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997639Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732194}
-
Klaus Weidner authored
Update the "source" link in samples to point to the Chromium modified versions. (The "View source on GitHub" link at the bottom still goes to the upstream immersive-web version.) For proposals/index.html, add a "variants" array that supports creating links to variants of the page with added query options, i.e. input source debugging for the AR samples. Change-Id: Iadba3107b18ebcb262ce10f46d708853ca119e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003396 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#732193}
-
Reid Kleckner authored
Clang recently disabled lax vector conversions by default, but Chromium relies on them. Add this flag until we can clean up the conversions. Skipping try bots because none of them should set llvm_force_head_revision, so this has no effect. TBR=thakis@chromium.org No-Try: True Bug: 1042470 Change-Id: Ibbb1c054f8bf72098e43694de2b22153bbc63fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003921Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732192}
-
James Vecore authored
The test OSSettingsBluetoothPageTest.AllJsTests started being flaky after https://crrev.com/c/1954273 landed. This CL re-enables the test suite while skipping the single flaky js test for now. There is a simple fix for the failing test of repeating the await waitForListUpdateTimeout() however it is not well understood why this is necessary so it needs further investigation. See bug https://crbug.com/1042352 for the followup. Fixed: 1035378 Change-Id: I161165c01650c58fb74c2710e2957ad83add0a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999065Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#732191}
-
- 15 Jan, 2020 19 commits
-
-
Peter Boström authored
Bug: chromium:1038731 Change-Id: I9762a30586a86b5bfef9ae4a234e952923f95cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002894 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732190}
-
Mike Dougherty authored
This reverts commit 534ab452. Reason for revert: Fails to compile on device. See https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/120373 Original change's description: > Disable testKeyboardHideState on iPhone > > Bug: 1041878 > Change-Id: Iae445f1161e1bd6d3de32de61921b70a9c1ffa7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001197 > Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732187} TBR=rohitrao@chromium.org,lindsayw@chromium.org,javierrobles@chromium.org Change-Id: Id2e2cab9737ba9d9bb3ff5bfedeb4c0595bb35a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003918Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#732189}
-
sangwoo authored
It seems .cc file was included by accident. Bug: NONE Change-Id: I09db820dcd46b6898b5da07ddb7baba0a20d1376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002270 Auto-Submit: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#732188}
-
Lindsay Pasricha authored
Bug: 1041878 Change-Id: Iae445f1161e1bd6d3de32de61921b70a9c1ffa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001197 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#732187}
-
Manu Cornet authored
Let the callers just get them from the nav widget. Change-Id: Ie872e82b893f762f65839dbe5daf2a7cd0c9d24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003392 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732186}
-
Tommy Li authored
In the omnibox, we've long had this niche feature, where if the user types "example" and presses Ctrl+Enter, we will navigate the user to "example.com". The way we implemented this was not sensitive to URL elision, so a side effect is that if the user was on "https://www.example.com", and the omnibox is displaying an elided "example.com", and the user presses Ctrl+Enter, the omnibox would downgrade the HTTPS to HTTP, navigating the user to "http://example.com". This isn't very exploitable, but kind of annoying, and not quite our intent. This CL makes it so that if the URL has not been edited, we will use the full unelided URL for Ctrl+Enter desired-TLD navigations. I don't anticipate merging this, as this is kind of a niche case. Bug: 1038746 Change-Id: Idf0c5295e09dc0c055333efaeba181949121fbdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001403 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#732185}
-
Becca Hughes authored
Add a playback sessions table to record media session data to media history. This also has a marker about whether this was complete or not and can return the most recent not complete playbacks. BUG=1041662 Change-Id: Icef42a4978b10ba9d9abd1a7bb2ea23e2f090b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999261Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#732184}
-
Jeevan Shikaram authored
This CL introduces a fix for tablet form factor devices. These devices have app list sync turned off, resulting in some sync code not running. This lead to an issue of default app ordering not being applied properly, specifically the default page breaks. Default page breaks are now installed when the model is built for app list, however this is only done so if the device is a tablet. Bug: 1031410 Change-Id: If4fb23b6f67a5de094e88bc478870f971ebf9a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997423Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#732183}
-
Henrique Nakashima authored
This is a part of FeatureUtilities that has no cohesion with the rest of its responsibilities. Bug: 1012975 Change-Id: Iaef2b7c7b2e57ec5a43eb8ff168e832bf567e8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999332Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#732182}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=ryansturm@chromium.org Bug: 1041419 Change-Id: I5c64a562b5a91207b51204fe58d679b1106d1425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994071 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#732181}
-
Alex Cooper authored
Flag definitions were removed in crrev.com/c/1988967; however, a few declarations were missed. This change removes those missed declarations. Bug: 1039499 Change-Id: Ide42e71ed35df98f3bb7aec5aeda5c196b7d97ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002939 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#732180}
-
Mounir Lamouri authored
Bug: 1032394 Change-Id: I1694d8bc289a98ca366d9fdfb06ea148fbd400b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959792 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732179}
-
Stephen Chenney authored
In the process of fixing test crashes with the original patch, the metric was disabled because the reporter was getting cleared before the code that reported. Reorder things to fix it. Bug: 1041453 Change-Id: Iadb12ae73e113930ea36c03e3cfc097736632495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001188 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732178}
-
rbpotter authored
This test was flaking by timing out, particularly on the Mac 10.13 dbg bot. This indicates it was likely taking too long to run, and the test contains a very large number of sub-tests, so it is likely that the test was working correctly but was too slow. Split out the sub-tests into their own TEST_F calls, so that each test is much shorter to run, and re-enable the tests. This will also allow us to discover if there are certain subtests that are particularly slow or that hang, so we can disable/fix them individually without disabling the entire suite. Bug: 1038991 Change-Id: Ic3d1419f2c8d6cdc10f97a7cb9eb75354f87d16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001756Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732177}
-
Alex Cooper authored
While previously purging WebVr from the repo, it seems like this file got missed. Change-Id: I2249874f65752ed3c143afa545ba5bb10cfbefbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003296 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#732176}
-
Fabrice de Gans-Riberi authored
Fuchsia build and tests have been run as part of Chromium CQ for some time now. This CL explicitly lists the platform as being supported. Bug: 10411459 Change-Id: I356835d344a1788eb300927d84ebbabdd5125ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995990Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#732175}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jrummell@chromium.org Bug: 1041419 Change-Id: I476454a428344042303d09daaa009e756f2dc4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995793 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732174}
-
Vasiliy Telezhnikov authored
This CL implements BeginFrameSourceWebView as a wrapper around parent BeginFrameSource and provide {Before/After}BeginFrame callbacks to support synchronous scrolling for WebView. It also implement subclass of it RootBeginFrameSourceWebView to replace WindowBeginFrameObserver. This essentially: * Finishes moving BeginFrame handling for WebView to WebView specific code as the all other code uses BeginFrames from viz. * Prepares BeginFrame code to be used with viz as it needs synchronous behaviour too. Bug: 805739 Change-Id: I189607907a323ee557337807fd1a835f033abf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997626Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#732173}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I96bf4e908fdf55a4dce471d3fb35469068326c68 Binary-Size: AR moving back into base apk crbug.com/1031623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002787 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#732172}
-