GitLab

The language code match in SVGTests::isValid() uses String::substring()
to limit the match to the primary language subtag. In the case where the
defaultLanguage() only contains the/a primary language subtag, this will
not require a copy, but otherwise it would.

Using startsWith() and a length-check guarantees that no copies will be
made. (A valid primary language subtag is always 2 letter long, so
checking only for length == 2 should be enough, although previously the
code could theoretically match a 1 letter, or even a zero-length tag.)

Review-Url: https://codereview.chromium.org/2284273002
Cr-Commit-Position: refs/heads/master@{#415255}

Schemas for gnome-keyring and libsecret are not 100% interchangeable. To
support gnome-keyring, we need to use equivalent schemas in both
libraries. This will allow a user to upgrade their machine from gnome-keyring
to libsecret, without chrome losing access to OSCrypt's encryption key.

We correct the unfortunate initial choice for a schema by copying entries
to the new schema.

As a bonus, this will correct the mislabeling of some entries (see crbug/640603)

BUG=639298

Review-Url: https://codereview.chromium.org/2273723002
Cr-Commit-Position: refs/heads/master@{#415254}

Fold the targetIsUsable(...) helper from SVGAnimateElement into said
method, and then replace the uses of the former with the corresponding
'should apply' predicate.

BUG=640676

Review-Url: https://codereview.chromium.org/2287983002
Cr-Commit-Position: refs/heads/master@{#415253}

BUG=551343

Review-Url: https://codereview.chromium.org/2282403003
Cr-Commit-Position: refs/heads/master@{#415252}

Pointed out by tkent in https://codereview.chromium.org/2242743002/

The original code could do 2 hash calculations for
adding a new key-value pair to ParentChildMap
(for find() and add()), and rehashing the map
may involve copying the HeapHashSet<Member<Node>>
objects.

Change the value part of ParentChildMap from a HeapHashMap
object to its pointer, to avoid redundant hash calculation
and object copy.

This does not change any functionality of the class.

BUG=594918

Review-Url: https://codereview.chromium.org/2290543002
Cr-Commit-Position: refs/heads/master@{#415251}

BUG=631966

Review-Url: https://codereview.chromium.org/2287473002
Cr-Commit-Position: refs/heads/master@{#415250}

This patch converts "editing/inserting/redo.html" to use w3c test
harness to simplify test script and renames to "redo_insert_text.html"
to provide to provide a hint what this test script verifies, for improving
readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2296583002
Cr-Commit-Position: refs/heads/master@{#415249}

Revert of Disable PasswordManagerBrowserTestBase.InternalsPage on Mac (patchset #1 id:1 of https://codereview.chromium.org/2287143003/ )

Reason for revert:
As leonhsl@ noted on https://codereview.chromium.org/2270333002/, the test failures only happened when the Mojo change https://codereview.chromium.org/2216463002 was on the trunk. Looking at the list of flakes [1], the revision numbers speak clearly:
413708 = Mojo change went in
413716 = first flake recorded
413923 = last flake recorded
413934 = Mojo change reverted

Therefore the revert is not needed, the Mojo change needs to be fixed before relanding.

[1] https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNwsSBUZsYWtlIixQYXNzd29yZE1hbmFnZXJCcm93c2VyVGVzdEJhc2UuSW50ZXJuYWxzUGFnZQw

Original issue's description:
> Disable PasswordManagerBrowserTestBase.InternalsPage on Mac
>
> The test flakes on Mac.
>
> BUG=640737
> TBR=vasilii@chromium.org
>
> Committed: https://crrev.com/2683579867440a6ead8e06329f00bd7d0b3a1ce2
> Cr-Commit-Position: refs/heads/master@{#414996}

TBR=vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640737

Review-Url: https://codereview.chromium.org/2292893002
Cr-Commit-Position: refs/heads/master@{#415248}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257113002
Cr-Commit-Position: refs/heads/master@{#415247}

This patch converts "editing/inserting/insert-paragraph-at-end-of-line.html" to
use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2284353002
Cr-Commit-Position: refs/heads/master@{#415246}

Review-Url: https://codereview.chromium.org/2290553004
Cr-Commit-Position: refs/heads/master@{#415245}

Network time is frequently unavailable when we hit certificate date
errors. This CL histograms additional information about why network time
is unavailable (specifically, whether no time query has been made or
whether the system clock lost sync since the last time query).

To do so, I deprecated the old network time histogram that shared an
enum with the build time histogram, and introduced a new network
time histogram with a network time enum (rather than adding more
network-specific values to the enum that is shared with the build time
histogram).

BUG=

Review-Url: https://codereview.chromium.org/2254433003
Cr-Commit-Position: refs/heads/master@{#415244}

The order of the CORS error messages for the link elements is not
stable. Stop logging them and compare only output from the test cases.

R=yhirano
BUG=633834

Review-Url: https://codereview.chromium.org/2277693002
Cr-Commit-Position: refs/heads/master@{#415243}

It seems a wrong baseline was checked in. This CL removes one in platform/win7/,
and Windows 7 refers one in platform/win/.

BUG=636258
TBR=keishi@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2289083002
Cr-Commit-Position: refs/heads/master@{#415242}

Since we're going to make ExceptionStates scope-like objects at
http://crrev.com/2272613003 , ExceptionState should be
STACK_ALLOCATED().

BUG=

Review-Url: https://codereview.chromium.org/2272313003
Cr-Commit-Position: refs/heads/master@{#415241}

This patch is a preparation for hoisting the call sites of
Document::updateStyleAndLayouIgnorePendingStylesheets from
TextIterator and PlainText.

BUG=590369

Review-Url: https://codereview.chromium.org/2291943002
Cr-Commit-Position: refs/heads/master@{#415240}

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord

Review-Url: https://codereview.chromium.org/2288823003
Cr-Commit-Position: refs/heads/master@{#415239}

This patch converts "editing/inserting/insert-div-025.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2287263002
Cr-Commit-Position: refs/heads/master@{#415238}

This patch converts "editing/inserting/insert-div-021.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2288113002
Cr-Commit-Position: refs/heads/master@{#415237}

SpellChecker::markMisspellingsAndBadGrammar() is simutaneously called
from outside as a public function and used by other member functions of
SpellChecker as an internal procedure.

This patch cleans up the relations by making the function private and
introducing a public wrapper.

BUG=n/a
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2289593007
Cr-Commit-Position: refs/heads/master@{#415236}

Parent style not used for HTML element adjustment.

Review-Url: https://codereview.chromium.org/2290623002
Cr-Commit-Position: refs/heads/master@{#415235}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/14f70933ab02..be813143dbae

$ git log 14f70933a..be813143d --date=short --no-merges --format='%ad %ae %s'
2016-08-29 toyoshim Add a workaround to work with dalvik running on x86

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2292823002
Cr-Commit-Position: refs/heads/master@{#415234}

And made {fukino,oka,yamaguchi}+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using ~/depot_tools/watchlists.py.

Review-Url: https://codereview.chromium.org/2294603003
Cr-Commit-Position: refs/heads/master@{#415233}

"if (testRunner)" throws if testRunner is undefined.

BUG=none

Review-Url: https://codereview.chromium.org/2295653002
Cr-Commit-Position: refs/heads/master@{#415232}

Revert of Add OfflinePageSuggestionsProviderTest (patchset #10 id:180001 of https://codereview.chromium.org/2279223002/ )

Reason for revert:
Fails on Chrome os.
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/25426

Original issue's description:
> Add OfflinePageSuggestionsProviderTest
>
> BUG=628198
>
> Committed: https://crrev.com/5fe00b8dfc81a113eb3d02641cf71daff59b5fa0
> Cr-Commit-Position: refs/heads/master@{#415211}

TBR=treib@chromium.org,tschumann@chromium.org,dsansome@chromium.org,pke@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=628198

Review-Url: https://codereview.chromium.org/2297493002
Cr-Commit-Position: refs/heads/master@{#415231}

This patch moves the CSSVariableResolver::isValidVariableName call that
usually exists alongside calling cssPropertyId into the cssPropertyId
call (and similarly for unresolvedCSSPropertyId). Pretty much every
place which parses property names should be handling custom properties,
so it's easier to just return CSSPropertyVariable instead of needing to
manually check for a valid custom property name.

Review-Url: https://codereview.chromium.org/2288633002
Cr-Commit-Position: refs/heads/master@{#415230}

Cr-Commit-Position: refs/heads/master@{#415229}

I'm now making toV8() never return an empty handle.
This CL makes Dictionary::toV8Impl return v8::Undefined() instead of an empty handle.
This shouldn't change any web-exposed behavior, since V8 interprets
a returned empty handle as v8::Undefined().

BUG=625512

Review-Url: https://codereview.chromium.org/2287433002
Cr-Commit-Position: refs/heads/master@{#415228}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/446b8bf..f80f5b3

$ git log 446b8bf..f80f5b3 --date=short --no-merges --format=%ad %ae %s
2016-08-29 ehmaldonado@webrtc.org Remove Chromium Clang warnings only on Windows.
2016-08-29 sakal@webrtc.org Remove the old AndroidVideoCapturer stack code.
2016-08-29 nisse@webrtc.org Reland of Delete method cricket::VideoFrame::Copy. (patchset #1 id:1 of https://codereview.webrtc.org/2275313003/ )
2016-08-29 nisse@webrtc.org Delete deprecated and unused method VideoFrame::SetTimeStamp.
2016-08-28 kjellander@webrtc.org MB: Flip Windows bots to GN by default
2016-08-26 deadbeef@webrtc.org Combining "SetTransportChannel" and "SetRtcpTransportChannel".
2016-08-26 deadbeef@webrtc.org Add parameter to TransportController to not change ICE role on restart.
2016-08-26 kwiberg@webrtc.org Fix Chromium clang plugin warnings
2016-08-26 ehmaldonado@webrtc.org GN: Fix windows clang errors. Attempt 2.
2016-08-26 kjellander@webrtc.org Adding GYP/GN owners to stats/ aligning with all other dirs.
2016-08-26 zhihuang@webrtc.org Log how often DTLS negotiation failed because of incompatible ciphersuites.
2016-08-26 peah@webrtc.org Added logging of the level controller metrics.
2016-08-26 danilchap@webrtc.org Change RtpSender::OnReceiveNACK name and signature Name changed to follow style. list replaced with vector to decrease number of included headers.
2016-08-26 peah@webrtc.org Deactivated the intelligibility enhancement functionality by default
2016-08-26 peah@webrtc.org Revert of Added functionality for specifying the initial signal level to use for the gain estimation in the l… (patchset #8 id:160001 of https://codereview.webrtc.org/2254973003/ )
2016-08-26 kjellander@webrtc.org MB: Flip Linux bots to GN by default.
2016-08-26 danilchap@webrtc.org AbsoluteSendTime rtp header extension publish MsTo24Bit conversion Since this conversion is used in multiple place and extension seems right place to keep it in.
2016-08-26 ossu@webrtc.org Removed virtual from several methods in DecoderDatabase to minimize the number of points that need to be mocked for testing.
2016-08-26 peah@webrtc.org This CL adds functionality in the level controller to receive a signal level to use initially, instead of the default initial signal level.
2016-08-26 kwiberg@webrtc.org Replace calls to assert() with RTC_DCHECK_*() in .c code
2016-08-26 johan@webrtc.org Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.
2016-08-25 henrik.lundin@webrtc.org NetEq: Update CNG code to accommodate 48 kHz sample rate
2016-08-25 peah@webrtc.org Adding AecDump functionality to AppRTCDemo for iOS
2016-08-25 deadbeef@webrtc.org Renaming BaseChannel methods and adding comments for added clarity.
2016-08-25 philipel@webrtc.org Revert of Delete method cricket::VideoFrame::Copy. (patchset #3 id:210001 of https://codereview.webrtc.org/2275243002/ )
2016-08-25 nisse@webrtc.org Reland of Delete method cricket::VideoFrame::Copy. (patchset #1 id:1 of https://codereview.webrtc.org/2087923004/ )
2016-08-25 henrika@webrtc.org Avoids java.lang.NullPointerException in WebRtcAudioRecord
2016-08-25 ivoc@webrtc.org Moved format_macros.h from rtc_base to rtc_base_approved.
2016-08-25 ehmaldonado@webrtc.org GN: Fix Windows Clang errors
2016-08-25 maxmorin@webrtc.org Fix error when accumulating floats in an int.
2016-08-25 hbos@webrtc.org Refactor certificate stats collection, added SSLCertificateStats.
2016-08-25 magjed@webrtc.org Implement CVO for iOS capturer
2016-08-25 ehmaldonado@webrtc.org Add missing "//build/config/sanitizers:deps" to executable targets.
2016-08-25 brandtr@webrtc.org Move InsertZeroColumns and CopyColumn to ::internal.
2016-08-25 kwiberg@webrtc.org GN build rules for four audio processing test executables
2016-08-25 henrik.lundin@webrtc.org Make neteq_rtpplay parse RTP header extensions
2016-08-25 aleloi@webrtc.org Removed inline definitions and added destructors to fix chromium-style.
2016-08-25 henrik.lundin@webrtc.org NetEq: only update current_rtp_payload_type_ when validated
2016-08-24 deadbeef@webrtc.org Fix setting the MTU for SCTP.
2016-08-24 deadbeef@webrtc.org Fixing inconsistency with behavior of `ClearGettingPorts`.
2016-08-24 deadbeef@webrtc.org Fixing segfault caused by TurnServer.
2016-08-24 deadbeef@webrtc.org Fixing off-by-one error with max SCTP id.
2016-08-24 deadbeef@webrtc.org Fixing timestamp comparison assert.
2016-08-24 glaznev@webrtc.org Increase QP threshold for H.264 encoder QP based scaling.
2016-08-24 tkchin@webrtc.org Restart capture session if needed on active.
2016-08-24 henrik.lundin@webrtc.org NetEq: Don't check sample rate and frame size upon error
2016-08-24 henrik.lundin@webrtc.org Make FakeDecodeFromFile handle codec-internal CNG
2016-08-24 kjellander@webrtc.org MB: Flip Mac bots to GN by default.
2016-08-24 ehmaldonado@webrtc.org Roll chromium_revision e3860bd2..938114be (412289:414059)
2016-08-24 kjellander@webrtc.org GN: Synchronize resources between Android and iOS.
2016-08-24 maxmorin@webrtc.org Make dependency of audio_device of ApplicationServices explicit. Tested in https://codereview.webrtc.org/2276903002.
2016-08-24 philipel@webrtc.org Now probe for x3 and x6 of the initial start bitrate and allow for faster receive bitrates when calculating probing estimates.
2016-08-24 ivoc@webrtc.org Added GN target for webrtc_opus_fec_test.
2016-08-24 ehmaldonado@webrtc.org Disable examples for GYP Android bots.
2016-08-24 sakal@webrtc.org Revert of GN build rules for four audio processing test executables (patchset #3 id:40001 of https://codereview.webrtc.org/2267403003/ )
2016-08-24 kwiberg@webrtc.org GN build rules for four audio processing test executables
2016-08-24 philipel@webrtc.org Only use payload size within the know send/receive interval for probing calculations.
2016-08-24 kwiberg@webrtc.org iLBC: Handle a case of bad input data
2016-08-24 philipel@webrtc.org Set send side bitrate estimate on successful probing attempt.
2016-08-24 kjellander@webrtc.org GN: Add resources for webrtc_perf_tests on Android
2016-08-24 ivoc@webrtc.org Added GN target for isac_test.
2016-08-24 aleloi@webrtc.org Removals and renamings in the new audio mixer.
2016-08-24 nisse@webrtc.org Add ThreadChecker to the TimestampAligner class.
2016-08-24 aleloi@webrtc.org Increased column width for python tool rtp_analyzer.py.
2016-08-24 aleloi@webrtc.org Updated mixer unittests and fixed a related bug in the new mixer.
2016-08-24 hbos@webrtc.org RTCStats and RTCStatsReport added (webrtc/stats).
2016-08-24 aleloi@webrtc.org Added a level indicator to new mixer.
2016-08-24 kthelgason@webrtc.org Remove outdated symlink
2016-08-24 sakal@webrtc.org Fix AppRTC Android Demo GN build when is_component_build=true.
2016-08-24 kjellander@webrtc.org MB: Flip Android bots to GN by default.
2016-08-23 terelius@webrtc.org Define a protobuf format for representing plots. Add code to convert the C-representation generated by the RtcEventLog analysis tool, to the new protobuf format.
2016-08-23 terelius@webrtc.org Adds function for computing moving average to visualization tool.
2016-08-23 honghaiz@webrtc.org Add logs and small change in BasicPortAllocator.
2016-08-23 isheriff@google.com ProbingEstimator: Erase history based on time threshold

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review URL: https://codereview.chromium.org/2293433002 .

Cr-Commit-Position: refs/heads/master@{#415227}

These are unused and no longer needed. We can revive them from git history if
we need them again.

BUG=641996
TEST=compiles

Review-Url: https://codereview.chromium.org/2295433002
Cr-Commit-Position: refs/heads/master@{#415226}

The preedit view of the candidate window should be hidden correctly when the text input client doesn't support inline composing.

BUG=612642

Review-Url: https://codereview.chromium.org/2290083002
Cr-Commit-Position: refs/heads/master@{#415225}

On ozone platforms, the message GpuHostMsg_VideoMemoryUsageStats used to be
skipped and not handled. Hence the task manager never received those stats.

BUG=629873
TEST=manually open the task manager and show the GPU memory column. Data should be there

Review-Url: https://codereview.chromium.org/2285983002
Cr-Commit-Position: refs/heads/master@{#415224}

BUG=390254

Review-Url: https://codereview.chromium.org/2292723002
Cr-Commit-Position: refs/heads/master@{#415223}

BUG=637407
R=rch@chromium.org

Review-Url: https://codereview.chromium.org/2286373002
Cr-Commit-Position: refs/heads/master@{#415222}

Linked with CL: https://codereview.chromium.org/2269303002/

BUG=640368

Review-Url: https://codereview.chromium.org/2283083002
Cr-Commit-Position: refs/heads/master@{#415221}

In the delayed activation of input connection, we call requestFocus()
on proxy view, and this triggers HwSecImmHelper.isPasswordInputType()
on Huawei phone, which in turn calls View#onCreateInputConnection() so
there is an infinite loop, which eventually causes stackoverflow.

Presumably isPasswordInputType() is only concerned about whether
onCreateInputConnection()'s outAttrs.inputType is password type or not,
so we fill out outAttrs.inputType and early out when there is a reentrance.

BUG=636197

Review-Url: https://codereview.chromium.org/2246833002
Cr-Commit-Position: refs/heads/master@{#415220}

Review-Url: https://codereview.chromium.org/2285143003
Cr-Commit-Position: refs/heads/master@{#415219}

This allows playback to be blocked based on certain conditions
including video resolution (see linked bug + internal CL).

BUG=internal b/31055542

Review-Url: https://codereview.chromium.org/2277853002
Cr-Commit-Position: refs/heads/master@{#415218}

Originally generated Wed Aug 24.

Import wpt@526656f814ac1acfdb8e3f93592ea36eced6a278

Using update-w3c-deps in Chromium 44ce3017.

Review-Url: https://codereview.chromium.org/2273143002
Cr-Commit-Position: refs/heads/master@{#415217}

The recently removed client edge on Windows 10 made the status bubble
overlap the window edge. This patch clips out the bubble border when the
bubble is docked, and leaves it unchanged when it's floating. Also made
the border always 1 pixel even at hidpi to make it look more consistent
with the material UI.

BUG=636479

Review-Url: https://codereview.chromium.org/2247563002
Cr-Commit-Position: refs/heads/master@{#415216}