GitLab

BUG=376549
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/299023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272355 0039d316-1c4b-4281-b951-d872f2087c98

Handling HTERROR WM_SETCURSOR messages apparently causes a regression.
Modals don't pulse, beep, and come foreground when the parent is clicked.
This originally regressed with my http://crrev.com/188817.

BUG=375181
TEST=Clicking a browser with a window-modal dialog causes the dialog to pulse, beep, and the window pair to come foreground.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/284313016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272353 0039d316-1c4b-4281-b951-d872f2087c98

Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering.

Update tests that were originally missed.

Original review: https://codereview.chromium.org/240163006/
Revert review: https://codereview.chromium.org/276173002/
Revert "Revert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/)"

This reverts commit 9031ef57.

TEST=CustomFrameViewTest
BUG=351917

Review URL: https://codereview.chromium.org/281353009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272352 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/280483002/

BUG=314704

Review URL: https://codereview.chromium.org/295933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272351 0039d316-1c4b-4281-b951-d872f2087c98

In order to move SandboxIPCProcess into a thread, we need a mechanism
to make that thread exit.

BUG=322185
TEST=content_shell loads webpages, browser shuts down correctly.

Review URL: https://codereview.chromium.org/291173009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272350 0039d316-1c4b-4281-b951-d872f2087c98

This flag defaults to true for official builds and false for unofficial builds. If the flag is false, Chromium will connect to sandbox wallet servers.

Net effect: instead of being controller by Chrome vs. Chromium, the default is controlled by Official vs. Unofficial buildtype.

BUG=334088

Review URL: https://codereview.chromium.org/288003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272348 0039d316-1c4b-4281-b951-d872f2087c98

"tools/safely-roll-deps /src blink"
is the replacemnt syntax.  No need to keep dead code around.

BUG=242461

Review URL: https://codereview.chromium.org/291333007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272347 0039d316-1c4b-4281-b951-d872f2087c98

This also adds unittests for ServerLogEntry client code, with common code
pulled out to a separate file.

This doesn't affect LogToServer classes - they will be refactored in a
separate CL. Also fix some IWYU issues uncovered by the refactor.

TEST=unittests

Review URL: https://codereview.chromium.org/282063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272346 0039d316-1c4b-4281-b951-d872f2087c98

1) Use TOOLCHAIN_OS rather than OS for package names
2) gpu_nacl.gyp shouldn't include trusted code test dependencies.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
R=bbudge@chromium.org, bradnelson@google.com, piman@chromium.org, sievers@chromium.org

Review URL: https://codereview.chromium.org/295933013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141, 330264

Review URL: https://codereview.chromium.org/293043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272344 0039d316-1c4b-4281-b951-d872f2087c98

They were added after we had to add some local patches for a tricky clang roll
two months ago.  We've done several rolls without local patches since then.

BUG=341352
NOTRY=true

Review URL: https://codereview.chromium.org/292333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272342 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, if .landmines exists, and isn't clobbered by the clobber in
compile.py, every build will cause a clobber until .landmines is removed.

Trying to fix http://crbug.com/375459 brought this up. In that case
compile.py wasn't removing .landmines, which is necessary in the case
of a landmines change on two subsequent builds. If .landmines isn't
maintained, then there's nothing to diff against on the second build
and so a clobber won't be correctly triggered.

R=iannucci@chromium.org,kbr@chromium.org
BUG=376359

Review URL: https://codereview.chromium.org/293983017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272341 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272340 0039d316-1c4b-4281-b951-d872f2087c98

R= dschuff@chromium.org
TEST= none
BUG= https://code.google.com/p/nativeclient/issues/detail?id=2205
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/293093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272339 0039d316-1c4b-4281-b951-d872f2087c98

This picks up a single change:
6fc0e1a090 Fix gyp targets
http://git.chromium.org/gitweb/?p=android_tools.git;a=commit;h=6fc0e1a090e97805a70f0e65377a9db4db3db8f5

Review URL: https://codereview.chromium.org/298653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: https://codereview.chromium.org/292123011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373318
TEST=GestureProviderTest.PinchZoomWithThreshold

Review URL: https://codereview.chromium.org/298823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272336 0039d316-1c4b-4281-b951-d872f2087c98

It is not needed anymore now that we do not support hybrid rasterization. Gpu-rasterization flag is per page instead of per layer.

BUG=367200

Review URL: https://codereview.chromium.org/296453009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272335 0039d316-1c4b-4281-b951-d872f2087c98

One of the tests replays recorded events from a real swipe.  The others
simulate realistic conditions and test edge cases. The tests discovered two
bugs:
- History swiping cannot be triggered if the very first touch event consists of
only vertical motion.
- History swiping blocks vertical part of diagonal swipes.

BUG=375514, 375512

Review URL: https://codereview.chromium.org/282143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272334 0039d316-1c4b-4281-b951-d872f2087c98

While I was investigating http://crbug.com/355650 I noticed that
ChromeVox doesn't work not only in cloud print dialog but in every dialog that
was created by ShowWebDialog. This problem can be fixed by creating extension
web contents observer for contents of dialog.

BUG=355650
TEST=manually

Review URL: https://codereview.chromium.org/256783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272333 0039d316-1c4b-4281-b951-d872f2087c98

This way when creating the Compositor we can supply the ContextFactory
from the thread local Env to it. This is part of making aura thread
safe.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/296053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272332 0039d316-1c4b-4281-b951-d872f2087c98

> Enable Bluetooth Chrome APIs for M-36 beta.
> 
> BUG=376064
> 
> 

TBR=tengs@chromium.org

Review URL: https://codereview.chromium.org/296983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376070

Review URL: https://codereview.chromium.org/296943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272330 0039d316-1c4b-4281-b951-d872f2087c98

Introduces the NonBlockingTypeProcessor's sync logic.  When combined
with the NonBlockingTypeProcessorCore's sync logic (which will be
introduced in a follow-up commit), this will be an alternative to the
existing sync engine implemented with DirectoryUpdateHandler and
DirectoryCommitContributor.

Adds non_blocking_sync_common.h, which defines structs to be used to
pass messages between the processor and processor core.

Adds DataTypeState as a parameter to the processor to processor core
connection methods.  Eventually this will be used to initialize the
processor core with state that the processor loaded from disk.

Adds a lot of unit tests and unit test framework intrastructure.  The
NonBlockingTypeProcessor and NonBlockingTypeProcessorCore's
communications with each other will be very racy.  These tests are
intended to help manage the complexity this will cause by allowing us to
test all the possible race conditions individually.

BUG=351005

Review URL: https://codereview.chromium.org/280983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272329 0039d316-1c4b-4281-b951-d872f2087c98

While 'gestureSourceTypeSupported' has not rolled into stable,
IsGestureSourceTypeSupported returns false for touch input when on Mac.

BUG=372714

Review URL: https://codereview.chromium.org/296113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272328 0039d316-1c4b-4281-b951-d872f2087c98

Starting in r266097, we always used the insets provided by Gtk2Border. We had previously had a hacky solution where we tried to determine whether the button was a toolbar button by digging in its style, but that hack was removed because it overreached. We had this hack to deal with slightly larger icon assets that GTK handed us.

In r269180, there was a subtle timing change, which then meant  that buttons outside the toolbar started using the GTK insets, such as buttons in the extension removal dialog, the javascript alert dialog, etc.

Now, Gtk2Border always uses the insets provided by the views::LabelButtonBorder (and we no longer have a concept of "GTK insets"), and we explicitly set smaller insets that don't cause the clipping issues only in ToolbarButton. This lets both bugs be fixed at the same time.

BUG=372305
TEST=Using GTK+ theme mode, the left edge of the back button shouldn't be visually chopped off.
TEST=Using GTK+ theme mode, The OK button on a javascript alert shouldn't be vertically squashed.
TEST=Using the default theme, both of the above should look normal.
R=msw@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/292153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272326 0039d316-1c4b-4281-b951-d872f2087c98

This makes it possible to add candidate configurations at either the
back (least-preferred) or front (most-preferred) of each channel's
candidate list.

This CL also disables VP9, by default, in candidate session
configurations, replaces DisableVideoCodec with 
EnableVideoCodec, and makes the Enable/Disable<foo>Codec
helpers members of CandidateSessionConfig..

Review URL: https://codereview.chromium.org/292093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272324 0039d316-1c4b-4281-b951-d872f2087c98

Updating AppMenu back, forward, and star assets to the latest spec.

BUG=375379
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/296693010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272323 0039d316-1c4b-4281-b951-d872f2087c98

Reland "Only dispatch menu events if they have a valid target. (https://codereview.chromium.org/284903002/)"

Clean up MenuController at end of tests and on subsequent RunMenu calls.

BUG=370162
TEST=MenuControllerTest.EventTargeter
TEST=In touchview, open wrench menu and press a key (i.e. 'T'), nothing should
happen.

Review URL: https://codereview.chromium.org/286933007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272322 0039d316-1c4b-4281-b951-d872f2087c98

Implements reflection blocking for the in-process fake sync server.

The notifications delivery system used in the real world will not
deliver notifications of new or modified items to the client that
originated that change.  This feature is known by the names
"reflection blocking" or "squelching".

Most of out integration tests expect reflection blocking to be
disabled, so we can't turn this on in all tests.  The default
is to leave it off.  Tests that want to enable reflection blocking
must override "TestUsesSelfNotifications" in their test framework
class.

BUG=323265

Review URL: https://codereview.chromium.org/296743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272321 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/295103009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272320 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove override of View::HitTestRect() from BookmarkBarView (https://chromiumcodereview.appspot.com/286313003/)

Reason for revert:
Items on the bookmark bar can still be highlighted and tooltips are shown when the omnibox popup is open. tdanderson@ will investigate.

Original issue's description:
> Remove override of View::HitTestRect() from BookmarkBarView
> 
> The override of View::HitTestRect() in BookmarkBarView checks
> for the state of the omnibox popup to determine whether or not the
> bookmark bar can accept events. Since this is unrelated to location,
> it is better to move this logic into an override of
> EventTarget::CanAcceptEvent() instead.
> 
> BUG=374340
> TEST=none
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272133

TBR=sadrul@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374340

Review URL: https://codereview.chromium.org/298653007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376064



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272317 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272316 0039d316-1c4b-4281-b951-d872f2087c98

This patch reverts r272117, which broke the prelight state on toolbar
buttons.

BUG=376478,374325
TBR=sadrul@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/296703012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272315 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, edits font size and padding, and makes calculation of the close
button's origin clearer.

BUG=None

Review URL: https://codereview.chromium.org/294123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272313 0039d316-1c4b-4281-b951-d872f2087c98

Right now we set the surface view background color everytime we create a new
surface and this causes a white flash everytime the activity is resumed

BUG=365589

Review URL: https://codereview.chromium.org/293983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272312 0039d316-1c4b-4281-b951-d872f2087c98

Don't allow octal in default (and constant) values. (Or any other values
that may pop up.)

R=sky@chromium.org

Review URL: https://codereview.chromium.org/291173010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357270
TEST=GestureProviderTest.AuraTripleTap

Review URL: https://codereview.chromium.org/289373009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272310 0039d316-1c4b-4281-b951-d872f2087c98

MediaStreamManager::SendMessageToNativeLog posts a task to the UI thread, which will attach the audio thread to the Android java VM. Unlike chrome created threads, the audio thread is owned by the OS and does not detach itself from the VM on exit, causing a crash.

The fix is to not call SendMessageToNativeLog on Android because webrtc logging is never enabled on Android due to the lack of extension.

BUG=365915

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271764

Review URL: https://codereview.chromium.org/294803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272309 0039d316-1c4b-4281-b951-d872f2087c98