- 08 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d6841487eb8e..e59d40e0bcab git log d6841487eb8e..e59d40e0bcab --date=short --no-merges --format='%ad %ae %s' 2019-02-08 herb@google.com Simplify mask handling in SkRemoteGlyphCache 2019-02-08 herb@google.com Split getOrCreateCache into a SkFont and descriptor based calles 2019-02-08 brianosman@google.com Remove support for GPU bone transformations 2019-02-08 mtklein@google.com add more test cases to DAA gm Created with: gclient setdep -r src/third_party/skia@e59d40e0bcab The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I25926e7855bb75b01fb9710227ca3a8498f6a438 Reviewed-on: https://chromium-review.googlesource.com/c/1461147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630472}
-
John Lee authored
Bug: 927717 Change-Id: Ieeb9789977b83587a1dd7869721ba43aea616929 Reviewed-on: https://chromium-review.googlesource.com/c/1455516Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#630471}
-
Aidan Wolter authored
It is unsafe to observe WebContents in any thread other than the browser main thread. Depends-On: chromium/1437623 Bug: None Test: cast_shell_unittests Change-Id: I9f824043afe33bfb97797ac886c99677c1e858ba Reviewed-on: https://chromium-review.googlesource.com/c/1437624 Auto-Submit: Aidan Wolter <awolter@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#630470}
-
John Lee authored
Bug: 923259 Change-Id: I9ef936ad47e49f9e67fc9fa49386de9366597888 Reviewed-on: https://chromium-review.googlesource.com/c/1455521Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#630469}
-
Klaus Weidner authored
This creates a new destination directory based on the Cr-Commit-Position of the top local commit, and updates the index.html file to cover all found commit positions. Run with "-h" to see command line options. Bug: 923149 Change-Id: I6bbef88f6472ae78ee67f153d62acd0874ed1297 Reviewed-on: https://chromium-review.googlesource.com/c/1459928 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630468}
-
Vlad Tsyrklevich authored
Currently headless_browsertests manually copies the crashpad handler's dependencies to Helpers/, instead set an an appropriate rpath. Bug: 929873 Change-Id: I6011b833084762a1b07132a9cb1e0642f04deca1 Reviewed-on: https://chromium-review.googlesource.com/c/1460068Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#630467}
-
Becky Zhou authored
+ Add night- variant for some semantic color references + Change themes to inherit DayNight theme + Unify some themes to share the base set of style and color attributes + Add naming convention for themes NOPRESUBMIT=true (Bypass AlertDialog.Builder error since I'm not adding new ones) Bug: 925564 Change-Id: Ice5066812027ae791522ca0cdc5a21110b597b11 Reviewed-on: https://chromium-review.googlesource.com/c/1437201 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#630466}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a0ff7c51200a..12b3d7e9d661 git log a0ff7c51200a..12b3d7e9d661 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 zoddicus@users.noreply.github.com Add strip-debug to webgpu-mode passes (#2368) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@12b3d7e9d661 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I08e4c0248c31027e7a20ba37eeb1c1b216ade3ac Reviewed-on: https://chromium-review.googlesource.com/c/1461195Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4103ceacac3e..f256339a1959 git log 4103ceacac3e..f256339a1959 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 geofflang@chromium.org Vulkan: Implement eglBindTexImage 2019-02-08 jmadill@chromium.org Use github link to SVG example image in docs. Created with: gclient setdep -r src/third_party/angle@f256339a1959 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I43913af29aceabbeec989bfdedc8e2020c582c8d Reviewed-on: https://chromium-review.googlesource.com/c/1461149Reviewed-by:
-
Oksana Zhuravlova authored
This page copies the content from an old documentation site page to //docs/mojo_ipc_conversion.md Bug: 929385 Change-Id: I08a1856e0c7acca3d30e876abeefd71cff386c22 Reviewed-on: https://chromium-review.googlesource.com/c/1456200 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#630463}
-
Zhongyi Shi authored
Remove various memeber variables to config QuicStreamFactoryTest and move the configuration to HttpNetworkSession::Params. To configure a new QuicStreamFactoryTest, set the configuration via |test_params_| and call Initialize(). Change-Id: I05789db7fa10a3001d4aa2421e1fdaefff693984 Reviewed-on: https://chromium-review.googlesource.com/c/1461088 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#630462}
-
Nick Diego Yamane authored
Currently, WaylandPointer is not emitting MOUSE_ENTERED events. This has been causing a couple of issues, among them: - When you open a new window using keyboard shortcut for example, the mouse cursor is invisible until you start moving the pointer around. - When a window looses focus with no movement events fired and one tries to open a new window (e.g: using keyboard shortcut), the browser crashes (in builds with dchecks enabled) when it tries to reset cursor for that window. This happens because cursor is not set in this case for the first window (holding a CursorType::kNull in this case), because WaylandWindow::SetCursor is only being triggered when WaylandPointer::Motion events are fired (what doesn't happen in this case). This patch fixes these issues by dispatching a MOUSE_ENTERED platform event in WaylandPointer::Entered() function. Bug: 928272 Change-Id: I13e01f28116fd6ce3a47ce8dc14cedcd51ed72ed Reviewed-on: https://chromium-review.googlesource.com/c/1460357Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#630461}
-
Mihai Sardarescu authored
Consent for Google service is no longer unified. This CL is removing the client of the UnifiedConsentService as it is now obsolete. Bug: 929372 TBR=asvitkine Change-Id: I4cacda2c65e97e13dd79304a337468897a1a0414 Reviewed-on: https://chromium-review.googlesource.com/c/1460918 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#630460}
-
Karan Bhatia authored
The test times out on multiple bots. BUG=923226 TBR=kenrb@chromium.org Change-Id: Ief2710141129c4a2e5fddfa358f7a874a5075f63 Reviewed-on: https://chromium-review.googlesource.com/c/1461299Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630459}
-
Gabriel Charette authored
Modernizes state and makes it easier to perform queries without modifying state (Interlock*() methods can only inspect the current value by replacing it..). Uses the default std::memory_order_seq_cst. We could potentially be slightly less strict but there probably isn't a reason to given this isn't the most expensive operation in PostTask() or DoWork() already. Clarifies things for https://crrev.com/c/1455266/9/base/message_loop/message_pump_win.cc#470 It's fairly weird that the whole algorithm depends on ScopedNestableTaskAllower invoking ScheduleWork() when it's not even a concept known to MessagePump... but this has long been the case... R=fdoray@chromium.org Bug: 885371 Change-Id: Id98fb6e72793cff0485ed916906a313a96f95332 Reviewed-on: https://chromium-review.googlesource.com/c/1460598 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#630458}
-
Scott Violet authored
There were a couple of problems here: . EmbedRoot was Showing() the WindowTreeHost. Instead the visibility should be initially set from WindowTreeClient when it gets information about the root. . The server needs to send IsVisible() for non-top-levels roots. This way, the correct visibility is set in the client. Without this, windows in a hidden container think they are visible. I'm mildly worried this should apply to top-levels too, and it's trickier to get right. I'm postponing that for now. BUG=929454 TEST=covered by tests Change-Id: Icf287c00b866dcaf62f7eb34377f9e950967eb94 Reviewed-on: https://chromium-review.googlesource.com/c/1460489 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630457}
-
Luciano Pacheco authored
Manual edit: - change to reset onMergeItems_ inside FileTabledecorate because that replaces the class constructor. - remove closure markup @struct and @extends because they aren't needed with ES6 class (they're implicit). CL 3 of 4. Bug: 778674 Change-Id: Iddbc2278b700f55588b85567aa9fbbe25a595b3f Reviewed-on: https://chromium-review.googlesource.com/c/1460200 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630456}
-
Anastasia Helfinstein authored
Specifically adds support for standard actions. Bug: 920659 Change-Id: I69e93a695092028f3583695c56b70bc35f71f144 Reviewed-on: https://chromium-review.googlesource.com/c/1460067Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#630455}
-
Ryan Hansberry authored
Also mark the corresponding metric as deprecated. See crbug.com/929518 for plans to improve metrics here. I thouroughly manually tested this change by setting |kConnectionLatencyTimeoutSeconds| to 0. This allowed me to verify that even right after attempting to set connection latency, the Bluetooth API can handle an immediate subsequent attempt to create a GATT connection. This also allowed me to catch a potential new bug in OnSetConnectionLatencySuccess() (see comments there for explanation). Bug: 905724 Change-Id: I26a1ac3111a99212cd73f67507dcc8a19e62c566 Reviewed-on: https://chromium-review.googlesource.com/c/1457729Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#630454}
-
Natalie Chouinard authored
Connect Java and native sides of JNI bridge for all functions on WebsiteEvents. Also cleanup some unused imports. Bug: 923581 Change-Id: I57a5258d3734f55acb52c247ef5fd83c9196f0be Reviewed-on: https://chromium-review.googlesource.com/c/1459583 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Piotr Bialecki authored
InstallActivity entry needs to be placed in base module's manifest as we do not refresh application context after successful AR module installation. Bug fix for incorrect callback being called on successful AR module installation. Bug: 926225 Change-Id: I45c448d89d3b5aa15b81c38ef9ffc60d5a0a6308 Reviewed-on: https://chromium-review.googlesource.com/c/1459797 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#630452}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/22b1689dde6c..d77957d206cc git log 22b1689dde6c..d77957d206cc --date=short --no-merges --format='%ad %ae %s' 2019-02-08 kbr@chromium.org Crash GPU process if renderer hangs. Created with: gclient setdep -r src/third_party/catapult@d77957d206cc The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:911772 TBR=sullivan@chromium.org Change-Id: Ia8a407a6e0a147fc41231db4898fdc2edc46cb87 Reviewed-on: https://chromium-review.googlesource.com/c/1461145Reviewed-by:
-
Aidan Wolter authored
Because CastSessionIdMap never gets destroyed, it does not make sense to use WeakPtrs. We are replacing them with base::Unretained(this), and adding comments why this is safe. Bug: None Test: cast_shell_unittests Change-Id: I5970f7204cf3ac10f4403811dfb52e1f5d93ce62 Reviewed-on: https://chromium-review.googlesource.com/c/1437623Reviewed-by:
-
Istiaque Ahmed authored
There's a contradictory comment about the copy constructor being implicit, where, in reality, this was explicit. Since we don't require Items to be copied, this CL makes Item non-copyable instead, and provides move constructs. Bug: None Test: Internal only change, no visible changes expected. Change-Id: I051a972181a3210d55745052c87bb58b8db7ef04 Reviewed-on: https://chromium-review.googlesource.com/c/1460124 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#630449}
-
Martin Kreichgauer authored
r1428879 changed AuthenticatorImpl to not immediately resolve the request promise after an error occurs but wait for the UI to be dismissed first. As a side-effect, the FidoRequestHandler for the request handler for the request lives on while the UI is shown. I.e., external authenticators continue to accept inputs (and users can still complete the request successfully); and the Windows WebAuthn UI continues to be shown. This changes AuthenticatorImpl to cancel all pending authenticators immediately after an error has occurred. Also implements cancelling of U2F HID authenticators. Bug: 897757 Change-Id: Ibd4800a3dcc5ac49b92bec0bfe13e6ca506122ba Reviewed-on: https://chromium-review.googlesource.com/c/1460480Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630448}
-
Jenny Zhang authored
Bug: 924771 Change-Id: Ic864c914614f269ff01df4e22ba0d5f5a1d02be6 Reviewed-on: https://chromium-review.googlesource.com/c/1461186Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#630447}
-
inglorion authored
gcp_unittests makes a call across DLL boundaries to register fake implementations for testing. This is not visible to link-time optimization, so the classes involved need to be marked lto_visibility_public to prevent the optimizer from generating invalid code. See https://clang.llvm.org/docs/LTOVisibility.html BUG=928396 Change-Id: Ie02e72503b3da8f9c35074bb7c2291d860baba42 Reviewed-on: https://chromium-review.googlesource.com/c/1455095Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Auto-Submit: Bob Haarman <inglorion@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#630446}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/311f25ab..37a08a2a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4501b5a68bad9d4a1ae92462ba5931ac5be1c0ea Reviewed-on: https://chromium-review.googlesource.com/c/1460983Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630445}
-
Bailey Berro authored
- Adds any preconfigured shares that do not match an explicitly known mode to the dropdown. - If new policies are added to later milestones that are unknown in older versions of Chrome, the preconfigured shares will fallback to being added in the dropdown. This ensures that we can gracefully handle adding new enterprise policies in the future. Bug: chromium:929322 Change-Id: I693ad6d102e0cfe3129ee349b86df84851038eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1456945Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#630444}
-
Ayu Ishii authored
Change-Id: I9fcd596e475063646d93ef894ab8105c8461fe0a Bug: 867008 Reviewed-on: https://chromium-review.googlesource.com/c/1448322Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#630443}
-
David Black authored
Previously notification views were hardcoded with placeholders. Now they are actually tied to Assistant notifications. Still TODO: - Handle button click events. - Animate entry/exit. - Add type to notifications so we can differentiate between in-Assistant and system notifications. Bug: b:1453547 Change-Id: I3ccf3067f388b3e87eb4a0159c7ed404ee54ae5c Reviewed-on: https://chromium-review.googlesource.com/c/1459586 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#630442}
-
Nicolas Pena authored
The OriginalTimingAllowOrigin attribute was added in https://codereview.chromium.org/271083002 to ensure TAO headers are preserved on cached resources (304 responses). This CL removes it because it seems that it is no longer needed. It also moves the corresponding test to WPT. Bug: 929453 Change-Id: I41e0c84b04a94acc27c22e375f55398d9fc411e5 Reviewed-on: https://chromium-review.googlesource.com/c/1459333 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#630441}
-
Wez authored
Cancel the FileDescriptorWatcher watch on the ClipboardX11's display connection before closing the connection, during teardown. Bug: 930007 Change-Id: I020962f522a3eb8017992d5dc430d8ce31a87049 Reviewed-on: https://chromium-review.googlesource.com/c/1460600 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#630440}
-
Mikel Astiz authored
The notion of active devices, as surfaced by Sync.DeviceCount and exposed internally via DeviceInfoTracker, can very easily run into duplicates if users disable and reenable sync on the same device, because the cache GUID gets reset and a new DeviceInfo entity is created. This is particularly relevant in a world where sync-the-transport gets enabled when the user signs in, since there will be a new DeviceInfo instance every time. In order to improve such notion, we leverage the sync timestamps to instead count devices that are known to overlap in time. Bug: 910390 Change-Id: I2866d98d53813b64a821de764d632748b15b72dd Reviewed-on: https://chromium-review.googlesource.com/c/1436366Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#630439}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78f6491898f6..de578cdd6b58 Created with: gclient setdep -r src-internal@de578cdd6b58 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0ce31f79b026ca6da919ccdbe611717a58880276 Reviewed-on: https://chromium-review.googlesource.com/c/1461144Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630438}
-
Karan Bhatia authored
This reverts commit 48f72caa. Reason for revert: Introduced tests fail on Android CFI bot. See crbug.com/930262. Original change's description: > android: Experiment setup for the reached code profiler. > > This CL prepares the reached code profiler for the finch experiment. It adds: > - base::Feature "ReachedCodeProfiler", which state is cached in > - Android shared preference "reached_code_profiler_enabled", that determines > whether to set > - command line switch "enable-reached-code-profiler", that eventually enables > the profiler > > We cannot simply use a base::Feature for the reached code profiler because > we have to know the feature state very early in the startup, before the > FeatureList is initialized. > > To work around this limitation we cache the feature state in Android shared > preferences that are available in Java before native is initialized. > > Since only the browser process has a right to read the shared preferences we > pass the value of the cached feature state as a command line flag to all > processes. > > Bug: 916263 > Change-Id: I730b98c5484ca595bdfda46592572f5853784aa8 > Reviewed-on: https://chromium-review.googlesource.com/c/1393328 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630298} TBR=pasko@chromium.org,gab@chromium.org,yfriedman@chromium.org,boliu@chromium.org,agrieve@chromium.org,alexilin@chromium.org Change-Id: I2e9b1f35b4bb4cfce38b820d41140a0014bd6437 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 916263, 930262 Reviewed-on: https://chromium-review.googlesource.com/c/1460431Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I1cae4a6fbf4bd94fc0ec704ea998c1ab9d727834 Reviewed-on: https://chromium-review.googlesource.com/c/1460604Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#630436}
-
Roger Tawa authored
This reverts commit c0cf050d. Reason for revert: crbug.com/930250 Original change's description: > Add remoting FTL API key > > Add API key for remoting to use during the signaling process. Note that > this key is only used by Chrome Remote Desktop and will not be used in > the Chrome browser. > > Internal CL: https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/831973 > > Bug: 927962 > Change-Id: Iecfa48aebe1078a4a0c747f42711000d9155fc3f > Reviewed-on: https://chromium-review.googlesource.com/c/1450409 > Reviewed-by: Joe Downing <joedow@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Auto-Submit: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630352} TBR=rogerta@chromium.org,joedow@chromium.org,yuweih@chromium.org Change-Id: I466452e9f2680b478ac5c3cf4b9600cba6d7cb8c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927962 Reviewed-on: https://chromium-review.googlesource.com/c/1461092Reviewed-by:
-
Tomasz Wiszkowski authored
Last patchset for change Ia7465d5e1cde0d4cd3c3d9ef9363f7679fded8bb that was rejected by transient gerrit error. Bug: 920396 Change-Id: I550414fe65aa34d843ad372caf54a0778de84939 Reviewed-on: https://chromium-review.googlesource.com/c/1456290 Commit-Queue: Ender <ender@google.com> Reviewed-by:
-
Xiaocheng Hu authored
This patch fixes the presubmit error: third_party/blink/web_tests/NeverFixTests:2202 Duplicate or ambiguous entry lines third_party/blink/web_tests/NeverFixTests:2022 and third_party/blink/web_tests/NeverFixTests:2202. external/wpt/payment-request/payment-request-multiple-show-manual.https.html third_party/blink/web_tests/NeverFixTests:2203 Duplicate or ambiguous entry lines third_party/blink/web_tests/NeverFixTests:2023 and third_party/blink/web_tests/NeverFixTests:2203. external/wpt/payment-request/payment-request-show-method-manual.https.html third_party/blink/web_tests/NeverFixTests:2204 Duplicate or ambiguous entry lines third_party/blink/web_tests/NeverFixTests:2020 and third_party/blink/web_tests/NeverFixTests:2204. external/wpt/payment-request/payment-request-abort-method-manual.https.html Change-Id: I5458bb3b3b3c23e5f9c2b2a186c61799feae24c9 NoTry: True Tbr: rouslan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1461150Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630433}
-
