GitLab

Change-Id: Idf8027acd402ce8faf8095370688ea8f33f46fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551513Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829653}

This changes the signature of |WebController::SelectOption|
to take a regular expression (string) and a value source
instead of the previous strategy.

The regular expression is matched in JS (similar to how
|TextFilter| works in |ElementFinder|), which makes it a
"contains" by default. The matching is done case insensitive
as was done so far.

The |RequiredFieldsFallbackHandler| still operates on the
strategy and builds the regexp on the client. This is done
to reduce complexity in that action. Currently the script
does not know whether or not a field is a dropdown, this is
evaluated on the client. Setting a regular expression as a
value would be possible but potentially confusing.

Bug: b/171281545
Change-Id: I00ab0bcf518d16063ceeae60da4b854707cfeff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542983
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829652}

VulkanContextProvider is created before GrShaderCache and so cache
wasn't pass to Skia via GrContextOptions.

This CL defers init of GrContext in VulkanInProcessContextProvider to
SharedContextState::InitializeGrContext to mitigate this.

Use of cache itself is under feature flag for metrics comparison and
a kill switch purpose.

Bug: 1151031
Change-Id: Idc410b9b557f7ca67164eb80d6a37a27ceb0f6d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551245Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829651}

Bug: 1104336
Change-Id: I7669ebd551e003c0199a3274af38ab0287fcc0fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547441Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#829650}

Prior this change, at the bottom of the dialog there was always a label
with text "* Field is required". Now this text is only shown when there
is at least one required field.

For now it only affects the AddressEditor usage opened from Autofill
Settings.

Bug: 1149568
Change-Id: I581c7ca6e89f1aaacb3e698dd3fb21981f2aa087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536438
Commit-Queue: Elizabeth Popova <lizapopova@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#829649}

Roll Chrome Linux PGO profile from chrome-linux-master-1605851942-6f480177b4524c7e895c150a8dd7d9195900edb6.profdata to chrome-linux-master-1605873573-9397db153d32d8ff4c4f46949924e1cd67fa6977.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I9fc090440237088088fcb09c2a5ea40eee028f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552467Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829648}

Bug: chromium:1011811
Change-Id: Ia1473a40ff26070f87ef8ff5bcbcba0286fb9976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550828
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829647}

Re-structure write barrier to allow delegating to the Oilpan library.

Bug: 1056170
Change-Id: I872fdb902a51d16d985f4e88ffd7e9368bf46623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551115
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829646}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aaaa5b96c66b..68553be73643

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC mmoskvitin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: mmoskvitin@google.com
Change-Id: If8b50089b7fbfe935c6664647e67417b899ccf2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552464Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829645}

Adds View::GetMirroredContentsBounds() which takes view insets into
account.

Bug: 1150725
Change-Id: I2d07b90f6388790fdb442f172b72452a5401ea03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551082Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829644}

This CL adds a mechanism to report file errors, as reported by
base::File::Error, though DOMExceptions. Due to security and privacy
considerations, not all errors are exposed to the user. For those
operations performed by the browser process (open, rename), the exact
error type is not exposed to the renderer.

Errors that are not reported by base::File::Error are left unchanged and
will be addressed in a followup CL.

The design document for this change is
https://docs.google.com/document/d/1rvs615AU2s8kVsmUlukbmtQNvUWFny0yzAS_gsnYZEs/

Bug: 1095537
Change-Id: If047ddccb6464dd6efb2b06a5da262d049f1e9a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436344
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829643}

This CL replaces all uses of net::EffectiveConnectionType with
blink::mojom::EffectiveConnectionType to reduce type conversion
between them in blink.

Bug: 919392, 1097943
Change-Id: I42db0329e9a0e436391e30779d69cf8d7f8040cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550321Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#829642}

Move the self keep alive member into the base class.
Remove Close overrides.
Remove Compositor() dead code.
Remove web_view_ member and use View().

This leaves one method left in the subclasses.

BUG=1097816

Change-Id: I7fd2c6fd87c8990070f329a6ade53cbe4f94cf1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548500
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829641}

Document the minimum Chrome version for the new enum values in the
chrome.certificateProvider API that were introduced in r828892 (the
new PSS-related entries in the Algorithm enum).

Without this change, the documentation at developer.chrome.com doesn't
contain information that these enums were added later than the other
ones. Apparently, the documentation only autogenerates these notices for
types and methods, but not for enum items.

Bug: 792204
Change-Id: Ia81a11691d9db5e1ba75cacd0d6dda53e679d0d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550545
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829640}

This CL changes the current variable name accountId to accountEmail so
that we can have a consistent name for account email.

Bug: 1131344
Change-Id: I652755e7485673d6611622f5bd60aceda5d849ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550827Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829639}

Start.

Bug: 1150937
Change-Id: Ief46f56a25ec90a35a84aa15c0c2a04f4d67d203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551795Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829638}

CORS support code for non network service code path existed
in the network::cors::legacy namespace, and mistakenly is left
even after the network service full launch.

This patch removes the network::cors::legacy,
//services/network/public/cpp/cors/cors_legacy.{cc|h}.

Bug: 1053866
Change-Id: Id03f49751d63dbe8fc1cac48161aa9c579d3ebe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552322
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829637}

Reland "Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.""

This reverts commit f01c0ad1.

Reason for revert:
1. Fixed `CaptureScreenshotBeyondViewport_OutOfView` by proper rounding.
2. Fixed `CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown` on some platform by relaxing color tolerance.

Original change's description:
> Revert "Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.""
>
> This reverts commit b8a64dcd.
>
> Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_OutOfView is failing consistently on "Android FYI SkiaRenderer Vulkan (Pixel 2)"
>
> https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/b8863213321775995088
>
> Original change's description:
> > Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."
> >
> > This reverts commit 85d844e3.
> >
> > Reason for revert: reland initial commit with disabled flaky test.
> >
> > Original change's description:
> > > Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."
> > >
> > > This reverts commit 114bc6ab.
> > >
> > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel:
> > >
> > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849
> > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850
> > >
> > > Original change's description:
> > > > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
> > > >
> > > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
> > > > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered.
> > > > 3. Set `hide_scrollbars` to avoid artificial scrollbars.
> > > > 4. Set `record_whole_document` to force the whole page to be rendered.
> > > > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight".
> > > >
> > > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37
> > > >
> > > > Screenshots:
> > > >
> > > > - Before: https://i.imgur.com/yt6WZRx.png
> > > > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars.
> > > > - Patchset #3:
> > > >   * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view.
> > > >   * https://imgur.com/MXpgHOl
> > > >   * https://imgur.com/haxemcr - not aligned with the node.
> > > >   * https://imgur.com/RbdlYVT
> > > > - Patchset #18:
> > > >   * https://imgur.com/EWUmn0O
> > > >   * https://imgur.com/DUrQ1yF
> > > >   * https://imgur.com/cT5oBSi - perfectly aligned.
> > > >   * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended).
> > > >
> > > > Bug: 1003629
> > > > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876
> > > > Commit-Queue: Maksim Sadym <sadym@chromium.org>
> > > > Auto-Submit: Maksim Sadym <sadym@chromium.org>
> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#827440}
> > >
> > > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sigurds@chromium.org,sadym@chromium.org
> > >
> > > Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1003629
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543
> > > Reviewed-by: Scott Little <sclittle@chromium.org>
> > > Commit-Queue: Scott Little <sclittle@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#827505}
> >
> > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sclittle@chromium.org,sigurds@chromium.org,sadym@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1003629
> > Change-Id: I2d394d77d0235762c61449ff8e90573de4c0c5d5
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545524
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Commit-Queue: Maksim Sadym <sadym@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#829147}
>
> TBR=wangxianzhu@chromium.org,caseq@chromium.org,sadym@chromium.org
>
> Change-Id: I2422b2560d10910cd90290c5647eb068743ac682
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1003629
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550242
> Reviewed-by: Mingjing Zhang <mjzhang@chromium.org>
> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#829230}

TBR=wangxianzhu@chromium.org,caseq@chromium.org,mjzhang@chromium.org,sadym@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1003629
Change-Id: Ib6e44df890e6707d811fccf2c6a8817983123c9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551114
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829636}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2477097c7892..cc8c82e4bcb7

2020-11-20 tvanderlippe@chromium.org Typecheck javascript_metadata/JavaScriptMetadata.js with TypeScript
2020-11-20 jacktfranklin@chromium.org TypeScriptify ui/SoftContextMenu.js

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I6f85861aa29f7d36acb199b351e9a46b3a5b9373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552441Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829635}

1. Remove diacritic symbol above cyrillic letters (е́ -> е, а́ -> а). It
is only used to show which syllable should be stressed when the word is
pronounced and never used in writing.
2. Allow using "е" instead of "ё", both spellings are used.
3. Add nominative grammatical case for email address keyword. Before in
Russian "адрес электронной почты" (email address) was matched, but
"электронная почта" (email) not.

Change-Id: Ibbb88d263eb8fde52bc0cd11e47e66fed780c227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550784Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Elizabeth Popova <lizapopova@google.com>
Cr-Commit-Position: refs/heads/master@{#829634}

MainFrame scroll focused editable element takes place in two phases.
1) To call scroll into view on the layout object.
2) Scheduling a page animation for zoom.

1) is common for local child roots just the calculation is a bit different.

BUG=1097816

Change-Id: I28dc389b21098e90376ea7bb3fade37313d244b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548420
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829633}

If the caspian files are missing, the upload script will now download
them from the current latest deployment before uploading the new
version. This allows a chrome dev to upload a new version without
worrying about caspian if their changes are unrelated.

Change-Id: Ib0f79f760845b239215e2c8f8be3c964060fbeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551775Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829632}

Test is failing due to a change unrelated to autofill.

We could edit the test expectation file, but try to batch cipd
changes, so disabled for now as we determine if we have some more
tests to fix at the same time.

Bug: 1151204
Change-Id: Ie9dd2053dbe89e063a828c78df0591d09e5be53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552261
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#829631}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f300a38617e..aaaa5b96c66b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC mmoskvitin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: mmoskvitin@google.com
Change-Id: If371b8ca8ac8bd4dd2e6b692831127e39f3f29f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551659Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829630}

This is preferred by the style guide:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#initialize-members-in-the-declaration-where-possible

Bug: None
Change-Id: I51d527f6db042e2b3e4efa3bbe8e06af336b5773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549861Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829629}

The self-destruction timer is not necessary because the RegionDataLoader
is guaranteed to be destructed once the query to libaddressinput
terminates.

Change-Id: Iac364183aa9d456b91ddc4d5f6f29b4c0ffe816d
Bug: 1148749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544945Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#829628}

And remove the meaningless screenshot expectations.

Change-Id: I3ecdde35d8d1c9acd8a18a24813a25271e5245f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549944Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829627}

The NDEFReader onerror event handler is renamed to onreadingerror to
make it clear to web developers that only NFC read errors will be fired
in this event as NDEFReader and NDEFWriter will soon been merged. Note
that an error message is now displayed in the devtools JS console to
help web developers to diagnose issues while it was part of the error
event before.

This CL also removes onreadingerror event fired on MojoConnectionError
as this is called if either the NFC service is unavailable in which case
NDEFReader.scan() will return a rejected promise, or when NFC permission
is revoked in which case the Permission API can be used to detect
changes.

Spec: https://github.com/w3c/web-nfc/pull/601
Bug: 520391
Change-Id: I451083fb5382149e9a1e45da31e575709f190448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546011Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#829626}

A fuzzer case caused a crash in
LayoutBoxModelObject::BackgroundTransfersToView because the body style
was null, but the body still had a layout object since
ViewportDefiningElementChanged is called after style recalc but before
layout tree re-attachment. We had a guard for NeedsReattachLayoutTree on
body for this, but not for the root element.

I am not sure how the body can get a null ComputedStyle during recalc
without the NeedsReattachLayoutTree being set, but checking the root
element as well does fix the fuzzer crash.

Bug: 1150916
Change-Id: Icd1368717a9bd97dbd5ef541733eeab4187ccf93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550549Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829625}

This CL solves the "first frame problem" [1], where ScrollTimelines
created by style recalc end up as inactive, because layout hasn't
run yet at the time that style recalc takes place.

When a new timeline is created, it goes into a list of "unvalidated"
timelines. During the lifecycle update, right after the style and
layout steps, we go through all such timelines and check if the current
timeline state (snapshot) is "stale" compared to a freshly computed
snapshot. If it is, it means that layout had some effect on the
timeline(s) that we would like to include in the next frame. We then
mark the associated effect targets for style recalc, which in turn
triggers a re-run of the style/layout steps in the lifecycle.

After all timelines have been validated, the list of unvalidated
timelines is cleared. This guarantees that we don't accidentally
trigger style/layout more than twice.

[1] https://github.com/w3c/csswg-drafts/issues/5261

Fixed: 1145933
Bug: 1074052
Change-Id: Ic915bb71b204c93cbde1c5f485d26a4b1c2bd09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517448
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829624}

The Content Security Policies code under services/network and the
relative mojo types still misses support for a few CSP directives. We
need to support all CSP directives in order to use it as a replacement
to the Blink types, and also if we want to add Content Security
Policies to the Policy Container (see attached bugs).

This CL implements support for the directive 'block-all-mixed-content'.

Bug: 1021462,1149272
Change-Id: Id90438e8c3f335041a1351aea174df5b671ee253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539914
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829623}

We need behavior triggered by the presence of a "--force-fieldtrials"
but we also want to remove the deprecated flag connected to
AutofillFieldMetadata.

Putting in a stub to unblock that deprecation work while keeping the
tests up and running.

Bug: 1151207
Change-Id: I790cef05abd7d8a436627a438d665bffaa8158d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552281
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#829622}

Change-Id: Ia2a06b75e46b6cd295d647c19d2965e0468a2e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550673
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829621}

Bug: 1143567
Change-Id: I37f738d40c7a424440bf892405a0cca1ca2742cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551867Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Ye Kuang <yekuang@google.com>
Auto-Submit: Ye Kuang <yekuang@google.com>
Cr-Commit-Position: refs/heads/master@{#829620}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a3b434580dbf..2477097c7892

2020-11-20 aerotwist@chromium.org TypeScriptify main.ts
2020-11-20 alexrudenko@chromium.org Display flex containers in the Layout panel
2020-11-20 bmeurer@chromium.org [sources] Remove CallFrame.sourceScopeChain.
2020-11-20 szuend@chromium.org TypeScript-ify ui/Tooltip.js
2020-11-20 bmeurer@chromium.org [sources] Remove redundant evaluate logic in popover.
2020-11-20 aerotwist@chromium.org TypeScriptify TimelineUIUtils.js (Part 2)
2020-11-20 petermarshall@chromium.org [typescript] TypeScript-ify source_frame/SourcesTextEditor.js 1/N
2020-11-20 bmeurer@chromium.org [sdk][bindings] Introduce DebuggerModel._evaluateOnCallFrameCallback.
2020-11-20 janscheffler@chromium.org Fix "Inspect Element" not working

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1042636,chromium:1127915,chromium:1150029,chromium:1150294
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I382ab33be975fcc69f8f9319430afc548ae59218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552148Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829619}

This CL adds the functionality to the add-new-tab-button to add the
new tab via Mediator.

Bug: 1128249,1134132
Change-Id: I4a33befc0bf5c81c2726a7183120d489b7115d9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542904
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829618}

The SafetyCheck::PasswordStatus |FEATURE_UNAVAILABLE| value was listed
in the C++ enum, but was missing in the corresponding enum in enums.xml.
This CL fixes that.

Bug: 1015841
Change-Id: Ib1f67b876f5252f98f2ce5994b04635b775a0cbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547703Reviewed-by: Andrey Zaytsev <andzaytsev@google.com>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829617}

This reverts commit 6e751ac6.

Reason for revert: likely the culprit for test flakiness.
Almost certainly (great timing match and touched by this CL):
crbug.com/1151237, crbug.com/1151190

Maybe (great timing match, but not directly touched by this CL):
crbug.com/1151160

There seems to be no other suspicious CLs in the matching time range.

Original change's description:
> Introduce BaseActivityTestRule to handle Activity starting/finishing
>
> Introduces a BaseActivityTestRule that allows tests to control whether
> or not the Activity is finished after the test runs.
>
> Also fixes some issues with Android's ActivityTestRule, like it not
> handling LauncherActivities, and unnecessarily inheriting
> UiThreadTestRule.
>
> Bug: 1146574
> Change-Id: I40ab917effb9d2fb53f58733f8dc75e292016aa4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523418
> Reviewed-by: Sahel Sharify <sahel@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#829386}

TBR=yfriedman@chromium.org,mthiesse@chromium.org,sahel@chromium.org

Change-Id: I03f1fc15026740ea01631b019a73738e706f9ac7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1146574, 1151237, 1151190, 1151160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550810Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#829616}

This reverts commit 433d1a41.

Reason for revert: new test is failing on linux-chromeos-chrome builder.

Original change's description:
> BackForwardCache: Allow WebFilesystem with a flag
>
> WebFilesystem doesn't have notions of handlers or connections, then it
> should be safe to allow pages with WebFilesystem to be put into the
> BFcache. Let's allow WebFilesystem for BFcache in order to improve the
> BFcache hit rate.
>
> This is implemented behind a flag and the feature is disabled by
> default. This means that this CL doesn't change the behavior by default.
> We might enable the feature later.
>
> Bug: 1144133
> Change-Id: Idf5d9cfb8a4365ae65743c2becc7a4ef8ec66999
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531155
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#829149}

TBR=kinuko@chromium.org,mek@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1144133, 1151235
Change-Id: I37344a9763d5b592fc1c2a60c1b480a5cc18e177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551117Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#829615}

TBR=bling-team@google.com

Change-Id: If4b88bb68972bc6707ad02654df02d1be16a1823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552164Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829614}