GitLab

Bug: 1005618
Change-Id: I379360ea93312f7d6a3b0d9005b2b6895ac22b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816717Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698575}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b762286def9..e0aac4191fbd

git log 8b762286def9..e0aac4191fbd --date=short --no-merges --format='%ad %ae %s'
2019-09-20 lamontjones@chromium.org OWNERS.ci: add lamontjones@

Created with:
  gclient setdep -r src/third_party/chromite@e0aac4191fbd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I1f3b93ca838456aa2d9ee477e14484cee79e6375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815692Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698574}

This reverts commit b5af1d8d.

Reason for revert: instrumentation registry isn't working on other builders. https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Android/19484

Original change's description:
> Update test filters to androidx.
> 
> Bug: 1005891
> Change-Id: If459301ac9a4b419cdbd487222754d19767f24ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814691
> Reviewed-by: Yuwei Huang <yuweih@chromium.org>
> Commit-Queue: benjamin joyce <bjoyce@google.com>
> Cr-Commit-Position: refs/heads/master@{#698246}

TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,garykac@chromium.org,joedow@chromium.org,yuweih@chromium.org,bjoyce@google.com

Change-Id: Ib8b6bdb9e1b98973ab1e7f2cc2f5b34336097cbb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1005891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816361Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@google.com>
Cr-Commit-Position: refs/heads/master@{#698573}

Add aria labels for the dialog and the prompt
https://imgur.com/a/UsQs5lG

Bug: 963183
Change-Id: I4bcdf4e1c9fb6fc853fe345ecd77ba2adc255f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718606
Commit-Queue: Anubha Mathur <anubmat@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698572}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: If61a2791abc8654628acb5ed45185394256db72d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808170Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698571}

https://chromium.googlesource.com/angle/angle.git/+log/d7f28aae3d89..dd4a00a06d01

git log d7f28aae3d89..dd4a00a06d01 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 jmadill@chromium.org Vulkan: Track resource usage via counter.

Created with:
  gclient setdep -r src/third_party/angle@dd4a00a06d01

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Bug: None
Change-Id: I641dfb982da51d2fc8f50cd97e2568d22ae3a341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815691Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698570}

WS_EX_TRANSPARENT only seems to mean "pass events to the underlying window" when
the windows in question is also WS_EX_LAYERED.

Bug: 1004721
Change-Id: Ia2618ddfa9c16a49fd8eb156ab0c7793736bce0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816745
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698569}

  * Original CL was missing a single and critical line.
  * This CL also adds unit tests to verify.

Bug: internal b/138446155
Bug: internal b/141369532
Test: manual and unit test
Change-Id: I99707882c716fc371aa28aa29700f85eecb26638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816534Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698568}

Tablet mode has a performance feature which takes a screenshot to fully
occlude all windows while the top window is animating. This CL adds a
test suite to test the feature, including a regression test for a
recently found regression.

Test: added tests
Bug: 1002735
Change-Id: I712ecdb3778f720fa55b6cbcf34773caca0c1f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815229Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698567}

This CL restricts //media/gpu:image_processor and :video_frame_mapper
to ChromeOS and ChromeCast, since they are only implemented for these
platforms.  Same for image_processor_test.

video_frame_file_writer.cc sandwiched some uses of |video_frame_mapper_|
in an OS_LINUX and left others unprotected, which confused OS_WIN
builds. This CL changes those to if defined(OS_CHROMEOS), since I
don't think this file is meant to be compiled nor run on OS_LINUX.

Change-Id: I8098d55859c50a752b40a63955684e558db3582a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787467
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698566}

Bug: 82078
Change-Id: Iede861b1cf4680d52f3dc1f298ca5f6ec8f398f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815574
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698565}

This reverts commit 749dcc3b.

Reason for revert: Inexplicable Fuchsia failures https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8901777180770604000/+/steps/content_unittests/0/logs/Deterministic_failure:_SessionStorageContextMojoTest.Scavenging__status_FAILURE_/0

Original change's description:
> Move File Service off Service Manager
> 
> This is a first step towards eliminating the File Service and migrating
> DOM Storage code into the Storage Service.
> 
> File Service and its only clients (DOM storage objects) are moved off of
> Service Manager APIs. LocalStorageContextMojo and
> SessionStorageContextMojo are changed to own their own FileService
> instance, now constructed directly over a directory path.
> 
> No functional changes intended in this CL.
> 
> Bug: 994911,977637
> Change-Id: I2ffd0bef670304a0dc3c103981139603521a14ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778801
> Commit-Queue: Ken Rockot <rockot@google.com>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#698487}

TBR=avi@chromium.org,rockot@google.com,mek@chromium.org,rsesek@chromium.org

Change-Id: I62995f899ebb399f929b1a95d415a79d675480e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 994911, 977637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815727Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#698564}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: I30a06cf2cfc7c4a835c1d4094be4a598ab354714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808458
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698563}

We want to move AFDO bits from Chrome OS into Chromium. Chrome OS
currently chooses default AFDO profile from different profiles for
different architectures, so we need to add a new GN arg to support it.

By default, Chrome OS is not using AFDO.

Bug: chromium:1001227
Test: Chrome builds without AFDO, without new flags
Test: Chrome builds with silvermont AFDO with clang_use_default_sample_profile=True
Test: Chrome builds with broadwell AFDO with clang_use_default_sample_profile=True and chromeos_select_default_profile_from_platforms="broadwell"

Change-Id: I08d1fa88e5737453b320093dd410e3a6488e17ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814319Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tiancong Wang <tcwang@google.com>
Cr-Commit-Position: refs/heads/master@{#698562}

Creating an experiment to allow sending sample pings of
allowlist domains to Safe Browsing. Also updating the
request proto to specify if it's a full or sample ping.

Bug: 953106
Change-Id: Iedf4ec390fca9697c2d57c001e7f46a5e8fa4b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814957
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698561}

TBR=govind@chromium.org

Change-Id: Ib9f751d6eea63492d15b317c9c4551da8c3fb78f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816531Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698560}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: Ic8de8a1fa2a2b84d09b0eb96590bf59cd475c3f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808408
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698559}

First eliminate the |equals_minimum_ok| variable, and always pass true
when searching the 'begin' instance list. Since currently the only way
to set this to false is for the first interval, and for that interval we
always start searching for the first instance time greater than
Earliest(), we can make it always be true without problem.

We also recognize zero-length intervals are not of any interest, as
indicated by the:

  first && temp_begin == temp_end... and
  !first && temp_end == interval_.end

clauses (note that |begin_after| == |interval_.end| when !first, and
thus if |temp_begin| ends up being equal to |interval_.end| this is
essentially checking that the interval isn't zero-length). Thus we can
always look for an 'end' instance that is greater than |temp_begin|
directly rather than checking for one that is potentially equal. This
should also mean that any newly found end time (as we loop) will never
equal the previous end that we got - allowing us to drop the
|last_interval_temp_end| construct.

Because we should no longer get zero-length intervals, we can drop the
special case for temp_begin == 0 and temp_end == 0 (zero-length first
interval that starts [and ends] at t=0).

Bug: 998526
Change-Id: I4d27372b50d24879af91bd35d7156c5bf9a1271d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816547Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#698558}

Was originally a bunch of per-file but I've written half the folder at
this point, so...

Change-Id: I0b2c5e4315a93133ca4294d831503ab1a1bb3e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815666Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698557}

This CL was partially generated by
//base/android/jni_generator/jni_refactorer.py.

Two classes converted in this CL:
  * UrlUtilities.java
  * DevUiModuleProvider.java

The tests were manually refactored to not use robolectric shadows
for UrlUtilities native methods.

Bug: 929661
Change-Id: Id3fbe2f7e53f3c0aa454aa51e1e94a2a6f0f1cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815344Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698556}

 * Get rid of MixerServiceConnectionFactory
 * Factor out code common to all (future) types of connections into
   MixerConnection, and rename MixerServiceConnection to OutputStreamConnection
   (which is based on MixerConnection).
 * Move common message-handling code out of OutputStreamConnection into
   MixerSocket.
 * Move type conversion code into a common file.

Bug: internal b/127963522
Test: on device
Merge-With: eureka-internal/313198
Change-Id: I7fa02b1d077a4eb7347728b4673cdea83e4597fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804681
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698555}

This change adds a hard timeout to the class that performs the update
check. This is done to keep the logic running in case update engine dies
or is stuck waiting for network or any other event.

BUG=924762
TEST=Unit tests.

Change-Id: I673dee89fbfef46568741fe82bda76ed9e1c1543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759518Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698554}

This CL:
* Makes |type| a required member of ConfigProperties and fixes the
  existing calls to SetProperties.
* Fixes SetProperties to support setting of EAP properties. Includes
  calling CreateConfiguration instead of SetProperties when necessary.
  This will fix issue 983890.
* Introduces ConfigureNetwork to cros_network_config.mojom using the
  same ConfigProperties dictionary as SetProperties.

Migrating the network configuration WebUI to use ConfigureNetwork will
be done in a follow-up.

For chromeos/user_manager deps addition (indirect dependencies exist):
TBR=xiyuan@chromium.org

Bug: 1001598, 983890
Change-Id: Ib02f6a40dd01ae90db57574d7bbf83e21666541f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808085Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698553}

Now that BlinkGenPropertyTrees has launched, there is no need to track
is_root_for_isolated_group on cc::Layer as it is now tracked using
render surface reasons.

Bug: 993936
Change-Id: Ifa5b0b497392d8cb4020826139a6270c2faaf20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815610
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698552}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: I6f7f0c0de66cb32990d0e3b4e985142d65a5cc14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808070
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#698551}

UserCloudPolicyManagerTest uses a lot of login functionality that's
centralized within LoggedInUserMixin. Avoid code duplication by
refactoring UserCloudPolicyManagerTest to use LoggedInUserMixin for
logging in.

Bug: 990909
Change-Id: I929c7182e8fc178191b8cc722ea6bbd6987b3411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796562Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698550}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: Ia350e71825604e5554f74e38f1223e49db2082b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808100
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698549}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5271b8e5167..a4592ef724c8


Created with:
  gclient setdep -r src-internal@a4592ef724c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I116895024f18306d96dc3b82fdd39f7eb9531d9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816861Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698548}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: I1d633f24dbc8d146cdcb0991bc15d6fc0dd472da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808073
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698547}

TraceEventHandles (on the stack) contain an ID we use to validate
that the handle is referring to an event in the event stack of the
current ThreadLocalEventSink in TLS. This was previously set by
session_id_ which is increment each time tracing is started but
there are potential race conditions where two sinks are created
with the same session_id_ which causes crashes. Changing this to
be its own explicit id for each created sink.

R=ssid@chromium.org

Bug: 983307
Change-Id: Ibd08c8203f31b394bc6c3d2cb0a5346501d2b049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814669Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698546}

Bug: 1003813
Change-Id: I250c4becaec287ba3e317d69e5afb61e754832a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807701
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698545}

This field isn't used outside of tests and a debug line in an
unmaintained example QUIC proxy.

Bug: 89321, 934009
Change-Id: I579df4e9c7ec5f90d9b3878be6e0828047714819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814663
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698544}

Bug: 82078
Change-Id: Id055fb1600ada645c1782cddd48348e687aa9245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815573
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698543}

See https://docs.google.com/document/d/1tfRRv-kaGUiburkhRp1xCKnM8t6jqauacp8YIqMiZmk/preview for context.

Bug: 977050
Change-Id: I8b3ba1653908e10d1ee2c8698b35d16f4729d6bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808196
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698542}

It used to have its special logic. But now it doesn't. Remove it.

Bug: None
Change-Id: I3bd3a35bd1da5fc7b30035dc821a7cb9338b36d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816246Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698541}

See https://tinyurl.com/yxau5sc4 for context.

Bug: 977050
Change-Id: If87e32552f4ffb9fbfb9eb5b4fec918a4d4e694b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808302Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698540}

Rename to AssistantStateClient, and move to c/b/ui/ash/assistant.

Remove obsolete logics and update the unit test.

Bug: b/138679823
Test: Run AssistantStateClientTest.* in unit_tests
Change-Id: I6da13ec34fa8a7e2741f659662456ed145197cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802634
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698539}

TBR=benwells@chromium.org (Mechanical changes)
TBR=estade@chromium.org (Mechanical changes)
TBR=rdevlin.cronin@chromium.org (Mechanical changes)
TBR=sky@chromium.org (Mechanical changes)
TBR=stevenjb@chromium.org (Mechanical changes)

Bug: 489687
Change-Id: I74db7b3463706dda1a61c060bcc5243f8c8dc56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784939
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698538}

Fix for AXPlatformNodeWin::get_IsSelected (ISelectionItemProvider::
get_IsSelected) to return false by default if the node supports
ISelectionItemProvider. Previously, we threw UIA_E_INVALIDOPERATION
for node that supports ISelectionItemProvider but not explicitly
marked as selected.

The motivation behind this change is due to Windows Narrator announcing
"No Item in View" for list items because their ISelectionItemProvider::
get_IsSelected by default returns UIA_E_INVALIDOPERATION and confuses
Narrator.

Bug: 844149
Change-Id: Iafc1c083dd0feb98b8d1a2d3b18c38284105e2e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810060
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698537}

Before this change, autofill had its own logic for determining a page
was secure. This CL changes the behavior to match the security state
shown in the omnibox.

Bug: 701018
Change-Id: Idd38fc77f93155412961c29a85f237c42ad21563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808226
Commit-Queue: Aidan Beggs <beggs@google.com>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698536}