GitLab

The top shadow drawable for bottom sheet consists of 3 parts
vertically - round-cornered view, shadow, and an empty space at the
top. In order to remove the gap between bottom sheet and infobar (or
any other view bottom container), the infobar needs to be lowered down
by the height of shadow plus that of the empty space. This CL defines
a new constant |bottom_sheet_shadow_top_offset| for the space, and
applies it to bottom container.

Bug: 1025098, 1030251
Change-Id: Ic145e861fcc5f1639196f6b96d3bfe3208fc0581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948367
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721775}

Adds a TODO to the issue to fix dependencies.

TBR=takumif@chromium.org

Change-Id: I7b75ae3d4925e3f99cc62335a353cabd8bd89c8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951488Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721774}

Bug: b:143715504
Change-Id: I8f362488e8d79a90a2c294c3978e3c56e8ca5391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948810Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Cr-Commit-Position: refs/heads/master@{#721773}

Presentation helper only picks up changes to the use of EGL timestamps
when we make current (GLSurfacePresentationHelper::OnMakeCurrent).
With virtual contexts we very rarely call MakeCurrent.

This CL adds a MakeCurrent on initialization to pick it up.

Change-Id: I2cc5429004e6f2d84782091464d0a90aa5d25ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951581
Commit-Queue: Jonathan Backer <backer@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Auto-Submit: Jonathan Backer <backer@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721772}

The DNS fuzzer dictionaries contain some preconstructed record fields
for A, AAAA, and CNAME records. This patch adds corresponding values
for ESNI (draft 4) records to hopefully increase the fuzzer's coverage
of the ESNI parsing code.

R=ericorth

Bug: 1003494
Change-Id: Id3ef0f0cb77bf3eb5721e4aacf55d87b6ae6707d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924548
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721771}

This CL sets up the scroll container to the the TabListElement itself,
allowing the TabListElement to directly control its own scroll
position without having to modify anything outside of itself. This
also allows for various optimizations so that layout does not need
to be re-calculated multiple times.

Other optimizations include using a cache of CSS variables to
determine the relatively static dimensions of tabs and viewport.

Bug: 1023492
Change-Id: I00874f36ab022aed15477c98652f8014b6098ce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948059Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721770}

TBR=alexclarke@chromium.org

Bug: 1030735
Change-Id: Ica41739148816215876d6da58bef0acaa548fada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951776Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721769}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=lpy@chromium.org

Bug: 1023677
Change-Id: Ib862853982d5623ee977d4ae21104b10937a4f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926827
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721768}

If a source file in a target #includes, transitively, a header
generated by e.g. a buildflag_header, mojom, or grit target, the
compiler may attempt to compile that translation unit before the
header is generated unless gn properly declares the dependency
on the action that generates the header.

This patch adds some missing deps that at least allows the
test_support target to be compiled from scratch without first
compiling some other target, which was blocking some builds in
the chromecast internal project.

Bug: 800764
Test: build the following target in a clean out directory:
      third_party/blink/renderer/modules/peerconnection:test_support

Change-Id: I1c469a37585f142df5c97e6a0ba21c76a889759f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947558Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721767}

This is the first in a series of changes that introduce a manifest
scope in AppCache.

Prior to these changes, a manifest can specify CHROMIUM-INTERCEPT
and FALLBACK sections with resources that exist outside of the scope
of the manifest's URL.

After these changes, a manifest by default will have a scope that
is the URL of the manifest stripped to the right-most forward-slash.
Any resources specified in the CHROMIUM-INTERCEPT or FALLBACK
sections will need to reside within this scope.

This CL adds a manifest_parser_version which is currently 0 and
plumbs that through AppCache, AppCacheUpdateJob, and
AppCacheManifestParser.  manifest_parser_version is kept in 2
members: cached_manifest_parser_version_ (a const) and
fetched_manifest_parser_version_.  The manifest parser currently
gets cached_manifest_parser_version_ from the group which
initializes to 0 and always results in a
fetched_manifest_parser_version_ of 0, so this change is effectively a
no-op.

This CL also adds a manifest_scope which is currently set to the
manifest URL's root path.  The manifest_scope is retrieved in 3
stages, and there's a member for each stage: cached_manifest_scope_
and fetched_manifest_scope_.  Initially, all of these are set to the
manifest URL's empty path to make this a no-op change.  Eventually,
this will be tightened down to a stricter default of the manifest
URL without a filename.

Bug: 999001
Change-Id: I723c594e9e5abec6608c4a9eb0cd77c8434fd46e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934316Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721766}

This patch adds the check to ensure that in WebGPU command buffer
decoder deviceTick() is called only when wgpu_device_ is not nullptr.
In current implementation wgpu_device_ will not be created until
RequestAdapter() is called, so wgpu_device_ may not be always valid
after the creation of WebGPU command buffer.

BUG=chromium:996713, chromium:1028241

Change-Id: I868e178dbad69ece0618d3d7b72112b1a129827e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949774Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Cr-Commit-Position: refs/heads/master@{#721765}

Change-Id: I1ab3e2c1b18dbd3614e4bf0cc9f29a3b91d632f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946056
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721764}

This change add a check to ensure frame is available, and to return
and error if not before proceeding with the call.

Bug: 1027394
Change-Id: Ib839321b7a9eef193b4285523ac60344d4a3a049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947192
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721763}

Follow-up to commit 470bf888 ("heap: Resolve data race in addition to
HashTable"), which started using std::atomic outside the
DUMP_HASHTABLE_STATS ifdef.

This fixes the build with libstdc++ (it looks like <atomic> was being
implicitly included by libc++):

../../third_party/blink/renderer/platform/wtf/hash_table.h:1796:31: error: implicit instantiation of undefined template 'std::atomic<std::pair<blink::OffererState, blink::OffererState> *>'
  AsAtomic<ValueType*>(table_).store(new_table, std::memory_order_relaxed);
                              ^
../../third_party/blink/renderer/platform/wtf/hash_table.h:1863:22: note: in instantiation of member function 'WTF::HashTable<std::pair<blink::OffererState, blink::OffererState>, std::pair<blink::OffererState, blink::OffererState>, WTF::IdentityExtractor, WTF::PairHash<blink::OffererState, blink::OffererState>, WTF::HashTraits<std::pair<blink::OffererState
, blink::OffererState> >, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::PartitionAllocator>::RehashTo' requested here
  Value* new_entry = RehashTo(new_table, new_table_size, entry);
                     ^
../../third_party/blink/renderer/platform/wtf/hash_table.h:1068:5: note: in instantiation of member function 'WTF::HashTable<std::pair<blink::OffererState, blink::OffererState>, std::pair<blink::OffererState, blink::OffererState>, WTF::IdentityExtractor, WTF::PairHash<blink::OffererState, blink::OffererState>, WTF::HashTraits<std::pair<blink::OffererState,
 blink::OffererState> >, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::PartitionAllocator>::Rehash' requested here
    Rehash(new_capacity, nullptr);
    ^
../../third_party/blink/renderer/platform/wtf/hash_set.h:180:11: note: in instantiation of member function 'WTF::HashTable<std::pair<blink::OffererState, blink::OffererState>, std::pair<blink::OffererState, blink::OffererState>, WTF::IdentityExtractor, WTF::PairHash<blink::OffererState, blink::OffererState>, WTF::HashTraits<std::pair<blink::OffererState, b
link::OffererState> >, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::PartitionAllocator>::ReserveCapacityForSize' requested here
    impl_.ReserveCapacityForSize(SafeCast<wtf_size_t>(elements.size()));
          ^
../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker.cc:26:7: note: in instantiation of member function 'WTF::HashSet<std::pair<blink::OffererState, blink::OffererState>, WTF::PairHash<blink::OffererState, blink::OffererState>, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::PartitionAllocator>::HashS
et' requested here
    : valid_offerer_transitions_(
      ^
/usr/lib/gcc/x86_64-redhat-linux/9/../../../../include/c++/9/bits/atomic_base.h:148:12: note: template is declared here
    struct atomic<_Tp*>;
           ^

Bug: 957519
Change-Id: I0694785f6f5191b82773ea5144dfba20b113afb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951024
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721762}

This reverts commit 7fb4c506.

Reason for revert: Won't remove chromium.webkit.json

Original change's description:
> Revert "Remove exparchive from testing configs"
>
> This reverts commit 23dd050b.
>
> Reason for revert: Broke rebaseline-cl, https://crbug.com/1018936
>
> Original change's description:
> > Remove exparchive from testing configs
> >
> > Bug: 840252
> > Change-Id: I7181f1adde1d2b11b4ca5da6535210112f031317
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877229
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#709666}
>
> TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> # Skipping CQ because the failure is unrelated, other tests pass, and
> # this is breaking rebaseline-cl.
>
> No-Try: true
> Bug: 840252
> Change-Id: If30dac52b2e23aff12dd8144d517e7a504a9c1bd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885251
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710102}

Bug: 840252
Change-Id: I23d620370b1dad7f6eee777ad9aaa7b751923775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949455
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721761}

CI builders:
- Win x64 Builder (dbg)
- win-archive-rel
- win-archive-dbg

Try builders:
- win10_chromium_x64_dbg_ng
- win_x64_archive

Migration schedule:
https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0

Bug: 950413
Change-Id: If71323e8cfbfc243971cd1954ddd138ec2d3f1b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924179
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721760}

This reverts commit d4a087be.

Reason for revert: broken between window drag

Original change's description:
> [Tab Groups] Add animation for tab group headers.
> 
> Bug: 1021689
> 
> Change-Id: Ida4f922471b9e53684acfc683623150b82e2a7cf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906873
> Commit-Queue: Charlene Yan <cyan@chromium.org>
> Reviewed-by: Connie Wan <connily@chromium.org>
> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721269}

TBR=tbergquist@chromium.org,cyan@chromium.org,connily@chromium.org

Change-Id: Iaa871c53373c42e5f55092c97d90e179b6f3862f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1021689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952094Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721759}

This adds the file as an EG2 target, updates #includes, and uses a longer
timeout for some instances of waiting for a web state that take longer
in EG2 mode.

Bug: 987646
Change-Id: I350d0f9f9e2b6e653345f25b70dc1f5b21ab4d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951563
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721758}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e60ecd30efa..a0b8c5dcf189

git log 0e60ecd30efa..a0b8c5dcf189 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 danakj@chromium.org Don't fetch tags in presubmit

Created with:
  gclient setdep -r src/third_party/depot_tools@a0b8c5dcf189

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1019824
Tbr: agable@chromium.org
Change-Id: I53e871e8ef4a4e49b3d3d305c9569aa3dea66cfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951408Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721757}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I959fd21da32222eb66727cb487a8554243e9db97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951887Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721756}

Current traces have shown that the compositor is seeing more scroll
delta than is sent to the main thread but it's not clear where the
missing deltas are going.

This CL adds some detailed tracing in various places to help narrow down
the search space.

Bug: 1018084
Change-Id: I463a6d8420bbe45397ad2ca67894d11f85002a65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949860
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721755}

The overlays for SkiaRenderer has been supported with
https://crrev.com/c/1949270, so turn on SkiaRenderer with SurfaceControl.

Bug: 1012401
Change-Id: I7e59f2e7f85c452ba5b66ebec3f732176e49e75f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950746Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721754}

Simply move the SetFocusedFrame APIs into blink's LocalFrame/RemoteFrame
implementations.

BUG=1008432

Change-Id: If8e29ef03253af352ba9a98236f379135c331725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927212Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721753}

Goes with spec CL https://github.com/w3c/csswg-drafts/pull/4437 (merged)
Follows up on https://crrev.com/c/1894477

Change-Id: I9f50739cb4dac68d3c9002c0f3ed509f6b379380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949405Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721752}

In tablet mode, the app list is expected to remain visible when
the cycler is shown, so it shouldn't be dismissed.

BUG: 1024494
TEST: Home screen isn't blank after using alt-tab in tablet mode
Change-Id: Iade57ac11528d11501e8b319f2d5dbdbc6716b6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927791Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Kazuki Takise <takise@chromium.org>
Auto-Submit: Kazuki Takise <takise@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721751}

This CL adds e2e test to verify behavior of adaptive toolbar in grid
tab switcher. Situations that are tested are:
* Portrait and landscape +GTS +Duet
* Portrait and landscape +GTS -Duet
* Portrait and landscape -GTS +Duet

Bug: 1012014
Change-Id: Ib82f38a60f8f8649d6961a59463e743dbbe0d7b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938464
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721750}

The Debug*Api family does exclusively logging, and does not add any DCHECK()s
etc, so s/Debug/Log/g to make this more clear.

R=kbr
TBR=rjkroege
BUG=None

Change-Id: I0b31609880c2ce0b9266cc7263ae8edf1510fcc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951724Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721749}

ContextualNotificationPermissionUiSelector determines if the quiet prompt UI
should be used to display a notification permission request on a given site.

This is the case when:
  1) the quiet UI is enabled in prefs for all sites, either directly by the
     user in settings, or by the AdaptiveQuietNotificationPermissionUiEnabler.
  2) the quiet UI is triggered by crowd deny, either through:
     a) CrowdDenyPreloadData, that is, the component updater, or
     b) CrowdDenySafeBrowsingRequest, that is, on-demand Safe Browsing pings.

The ContextualNotificationPermissionUiSelector is also wired up to the
PermissionRequestManager instead NotificationPermissionUiSelectorBasedOnPrefs.

Bug: 1028642
Change-Id: Ibb44ec1e0f0fe95d4fb350e9c2211199719df103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944395
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721748}

This adds minimal initialization needed for CrashReporterController, as
well as delaying the call to processNewMinidumps() until after native
initialization has happened. Also cleans up the creation of
CrashReporterController to use AIDL instead of reflection.

Bug: 1027076
Change-Id: Ib1969c82eb93b88965de8ee793fa3d6eb46c7bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951551
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721747}

This changes makes it possible for one ConnectionGroup to retain a
reference to another "parent" group.

The result allows multiple endpoints within a group to set their own
idle handler without becoming detached from the original group:
if an an idle handler is set on an endpoint which already belongs
to a group, a new group is created with the original group as its
parent and the endpoint references the new group instead. Thus this
interface and any interfaces bound transitively through it will now
reference the new group, but the new group will in turn keep the
original group alive as if all those interface endpoints were
referencing it directly.

This change is useful to support the migration of the Audio Service
off of Service Manager, as its client library currently uses an idle
handler on an interface which will already belong to the main service
interface's connection group under the new service model.

Bug: 977637
Change-Id: I43443ca96a260c9860785eb30450896a95d7ffe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940654
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721746}

Bug: b/141898654
Test: updated the test to catch this type of regression
Change-Id: Icee3d5aeb825748333bbe7094f10124d0e61f59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951152
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721745}

This reverts commit a8ebb5e6.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Implement TabGroupHighlight
> 
> See attached bug for screencast. Confirmed with UX that the highlight should only appear on drag, not hover.
> 
> Bug: 1017822
> Change-Id: I0921f5cf425d82c25344adb4801de6de8746f771
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929490
> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
> Commit-Queue: Connie Wan <connily@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721705}

TBR=tbergquist@chromium.org,cyan@chromium.org,connily@chromium.org

Change-Id: Ifd307f56a9c7db57e928a310f60f1a01e770a800
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1017822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951556Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721744}

Bug: none
Change-Id: Id308c2dd2b429542e5b79fd58b4643a8c23b0a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951804
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721743}

https://android.googlesource.com/platform/external/perfetto.git/+log/77e5e0540b54..d90f59573de9

git log 77e5e0540b54..d90f59573de9 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 hjd@google.com Merge "perfetto-cmd: Pass IsUser as arg"
2019-12-04 hjd@google.com Merge "Revert "Reland: Add statsd logging to perfetto_cmd""

Created with:
  gclient setdep -r src/third_party/perfetto@d90f59573de9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I836602d24ad6cda88ea23a5d6cd04f3eed07963d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721742}

Implements browser tests to verify that startup profiles taken in the
browser and child processes are received by the metrics provider.

To work within the test timeouts and to avoid non-determinism this
requires a couple adaptations to be made to the code when run under
these tests. The profiling period is reduced from 30 seconds to one
second, and profiles are taken in all renderer processes. The behavior
is enabled by providing a 'browser-test' argument to the existing
'start-stack-profiler' switch.

The main thread profiler for browser tests is moved later, after the
command line is set up, to be able to observe the added switch
argument. StackSamplingConfiguration is made responsible for the
sampling parameters, reusing the GetSamplingParamsForCurrentProcess()
function which was previously unused.

This reland of https://crrev.com/716372 gates the tests on channel
since the profiler is enabled only on trunk, canary, and dev, but
the official continuous builders build as stable channel.

Bug: 1011877, 1026575
Change-Id: I1cce130ff035007a2935dfccb2f7e2dca56880ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938077
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721741}

This change makes the trace strings consistent with the class name. Previously,
trace names would always show as TraceGLAPI, even for the other implementations
like EGL, GLX, and WGL.

R=kbr
BUG=none

Change-Id: Id4708c0b10c300d5c8da007ef693927a46da7fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951548
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721740}

https://pinpoint-dot-chromeperf.appspot.com/job/13f52f23220000 shows -1.8%
improvement for thread_total_rendering_cpu_time_per_frame. (Though another perf try job shows only -0.4%,
guess the improvment is not big enough compared to noise)

Anyway theoretically this patch should bring improvement by moving branching ahead to compile time.
Wrote a small c++ program. Compile with clang and it is verified by objdump that
the template non-type variable with if style result with no if test assembly code generated,
without use of "if constexpr" statement.

Bug: 1026774
Change-Id: I21f36924aca06f9f0a286be06e268cb8a3f4e03a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949679Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#721739}

Adds WebTimeLimitsInterface to start and stop web time limits UI for
Chrome and PWAs. It will be called by AppService.
Implements the new interface in ChildUserService.

Additional maintenance:
* Move some classes into app_time namespace.
* Create test API to expose internal details of ChildUserService.

Bug: 1015661
Test: PerAppTimeLimitsTest
Change-Id: I33c9f2fca3dcc5fb4364f086e9b606c642dba6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947543Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721738}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=mohsen@chromium.org

Bug: 1023677
Change-Id: Ibc5d9625d2e2c08177b4fed8e03fe06370910ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925463
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721737}

In base::File, |file_| is a ScopedPlatformFile. So add constructors that
can take a ScopedPlatformFile directly, instead of having the caller
release the PlatformFile, and then rewrapping it.

Change-Id: Ie70cacc0a47263ff9ec5ce38f84032f1e469faa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948195Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721736}