- 25 May, 2018 40 commits
-
-
James Cook authored
WindowSizerAsh needs synchronous access to the target display for each new browser window. * Create ash::ShellState and move root_window_for_new_windows_ there * Introduce mojom::ShellState interface in ash * Create a ShellStateClient in chrome to cache the target display id for new windows The interface is not implemented by ash::Shell because ash::Shell is already massive (1500 lines). Also, shell.h is included in 900 places in the code base and I don't want to add mojo generated headers to shell.h. Windows still don't appear on the secondary display with --enable-features=Mash, but chrome is getting the correct display id and setting the window bounds properly. I think ash needs to be fixed to support top-level bounds on the secondary display, but that will need to be a follow-up CL. Bug: 764009, 768908 Test: ash_unittests, unit_tests for WindowSizer Change-Id: Ib77834f8ed5dc4e65f02ff83ab81acbf3331db61 Reviewed-on: https://chromium-review.googlesource.com/1067591Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561950}
-
Daniel Nicoara authored
This is a reland of ce767464 Original change's description: > [Ozone-DRM] Refactor plane management and add tests > > * We use plane properties on legacy DRM to get some details (plane > type, in_formats). Read the properties in HardwareDisplayPlane and > check that the required properties are available in DRM atomic. > * Split dummy plane into its own class to clean up code. > * Remove test plane since we can now create the real objects via > injected state in DrmDevice. > * Cleanup plane initialization. > * Remove MockHardwareDisplayPlaneManager and rely on MockDrmDevice to > inject the necessary state. > > BUG=839487 > TEST=Ran unittests > > Change-Id: I03c91620557dcf7426629cf97bb989d8d7e83c68 > Reviewed-on: https://chromium-review.googlesource.com/1048585 > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561616} Bug: 839487 Change-Id: Ifb74647dfe1f05ef3339261dd1f7c51c0c371622 Reviewed-on: https://chromium-review.googlesource.com/1073487Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#561949}
-
Shenghua Zhang authored
TBR=jbudorick@chromium.org Bug: 731559 Change-Id: I6ed4bfa7b6c22f41a9fd65732cabc22064eb8162 Reviewed-on: https://chromium-review.googlesource.com/1073620Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#561948}
-
Dominic Mazzoni authored
Use a switch so that if a new enum value is added, a compile error will force us to update this code. Bug: 817124 Change-Id: I4183b735c913532c47df97c0518853b7d26aa91d Reviewed-on: https://chromium-review.googlesource.com/994414 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#561947}
-
Emily Hanley authored
from each shard. Updating bot map format to include an optional begin and end value to indicate a subset of stories to run. Bug: 713357 Change-Id: Id3188cc350e9df2c82177057e032301ddc8b851d Reviewed-on: https://chromium-review.googlesource.com/1070310Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#561946}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f9482f4c52b..d0a7d10f397d $ git log 5f9482f4c..d0a7d10f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-07 jiawei.shao ES3.1: Set unordered access view related resource limits on D3D11 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I2d5dcd77f664b58d6e7fdadd5cdad8606656ea63 Reviewed-on: https://chromium-review.googlesource.com/1073102 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561945}
-
Sebastien Marchand authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1072787 with fixes. ps1 is the original CL, the fix is in ps2 the problem is that I'm casting a LocalSiteCharacteristicsNonRecordingDataStore* to a LocalSiteCharacteristicsDataStore* instead of a SiteCharacteristicsDataStore* (the common interface between the 2 classes) Bug: 773382, 846492 Change-Id: I6cad02e8ca771debc3b4b2028616dec8fbcaf521 Reviewed-on: https://chromium-review.googlesource.com/1073050Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#561944}
-
Mike Dougherty authored
Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9177b7841982999299f31084ce3b042aefd59fdc Reviewed-on: https://chromium-review.googlesource.com/942027Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561943}
-
Amy Qiu authored
The top_25_pages page set is not used in any benchmarks or inherited by any other classes, therefore remove it. Bug: 760553 Change-Id: I37849b76f92aab88e124ac2086b596782a3b0546 Reviewed-on: https://chromium-review.googlesource.com/1072447Reviewed-by:
-
Jun Choi authored
Refactor repeated code to construct Authenticator with timer into a function. Bug: 798573 Change-Id: I5b3ecedb4cc56a30f5b32ed3872a709e18545cee Reviewed-on: https://chromium-review.googlesource.com/1034096 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#561941}
-
Scott Chen authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7efd3b2fa74cc89768964271b5261ea1593faaab Reviewed-on: https://chromium-review.googlesource.com/1070767Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#561940}
-
Francois Doray authored
Instantiating a ResourceCoordinatorTabHelper is useful to support TabLoadTracker, even when the service manager and GRC are not enabled. Bug: 775644 Change-Id: I5a47aa711f4759172a73a5bc8c75685513995e27 Reviewed-on: https://chromium-review.googlesource.com/1071718 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#561939}
-
rbpotter authored
Bug: 846493 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6d7634edabe8e756ac7ea62fc88d223902f9a46f Reviewed-on: https://chromium-review.googlesource.com/1072696Reviewed-by:
-
Tarun Bansal authored
Bug: 836552 Change-Id: I1a2fa3efe8b4e5818f8dcb54b49004039e52053d Reviewed-on: https://chromium-review.googlesource.com/1069705Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#561937}
-
Hans Wennborg authored
This should be fixed after crrev.com/561824 Bug: 845816 Change-Id: I1f12642c2ab8bea9f56e1c15d23046074ccbe62e Reviewed-on: https://chromium-review.googlesource.com/1073368 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561936}
-
stkhapugin@chromium.org authored
Now that we have offline pages on iOS with reading list, it makes sense to implement IsOfflinePage() and use it to determine the offline status of the page. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I062ae21b5f995574a65d5b3a4a64bae56ef4c4c0 Reviewed-on: https://chromium-review.googlesource.com/1071655 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#561935}
-
Chromium WPT Sync authored
Using wpt-import in Chromium adb006d2. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." 036419b1 "Fix errors in wpt/css/css-masking/* tests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18565 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I1879eb89c8685abb13c27c634c2658e2f5d00692 Reviewed-on: https://chromium-review.googlesource.com/1073403 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561934}
-
Luna Lu authored
This reverts commit 69141da0. Reason for revert: core.stacktrace_unittest.TabStackTraceTest.testValidDump is failing on Win 7, disabling this test for now. Original change's description: > Revert "Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win" > > This reverts commit 216e6d16. > > Reason for revert: culrpit CL was reverted > > BUG:chromium:846313 > > Original change's description: > > Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win > > > > TBR=kbr@chromium.org > > NOTRY=true # net_unittests flake > > > > Bug: 846289 > > Change-Id: I7fa42786ebdb448fd424e37a7c777e60df6b3c36 > > Reviewed-on: https://chromium-review.googlesource.com/1071868 > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > Cr-Commit-Position: refs/heads/master@{#561594} > > TBR=nednguyen@google.com > > Change-Id: Ibf328d3ea480b094e47c5037a7498f198ef94e62 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846289 > Reviewed-on: https://chromium-review.googlesource.com/1073091 > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#561881} TBR=nednguyen@google.com Change-Id: I039a5ffa03afbd50d79c57529d1b561def58ccdf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846289 Reviewed-on: https://chromium-review.googlesource.com/1073492Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#561933}
-
James Hawkins authored
This change also animates the ellipses while the operation is executing. R=jdufault@chromium.org Bug: 845313 Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf Reviewed-on: https://chromium-review.googlesource.com/1072804Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#561932}
-
Koji Ishii authored
Following bot results are included. 5862 5867 5874 5880 125 lines were removed and 5 lines were deflaked by consecutive results since 5829. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I84d7148e920796f0b2ec0a41b7908cbb5e94904c Reviewed-on: https://chromium-review.googlesource.com/1073174 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#561931}
-
Dominic Mazzoni authored
As a follow-up to http://crrev.com/c/1015291, this change makes it so that all bubbles with an anchor view are now part of the focus order of their anchor view. Bug: 764918 Change-Id: I76fd7b5d8c8c5c10d5f7ff9c0278f6207f4db4d6 Reviewed-on: https://chromium-review.googlesource.com/1025372 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Yusuf Ozuysal authored
After creating the intent for OpenInChrome, this resolves it to see whether Chrome can handle it. If not, falls back to a VIEW intent instead. BUG=834427 Change-Id: If39dc930521f78c0bdcd2818b9996694cff57b1c Reviewed-on: https://chromium-review.googlesource.com/1072166Reviewed-by:
-
Wez authored
This reverts commit c348474f. Reason for revert: Filter was added to the wrong test suite, so had no effect. Original change's description: > Fuchsia: Filter PipelineIntegrationTest.TrackStatusChangesWhileSuspended. > > PipelineIntegrationTest.TrackStatusChangesWhileSuspended times out > frequently on the FYI bots, so filter it out for now. > > Bug: 836785 > Change-Id: Id209d83a72e16a52cd7cc8b9281bf167a63cf636 > Reviewed-on: https://chromium-review.googlesource.com/1068617 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561561} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: I057d4db914418cfd2a65a03a827c36a72c9439b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836785 Reviewed-on: https://chromium-review.googlesource.com/1073491Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#561928}
-
Daniel Nicoara authored
All callers have been updated to use VideoPlaneController::SetGeometry, so remove the deprecated call. Bug: None Test: Compiled Change-Id: I6c0a57c10ea8dd8282205359864854a9e36a0e73 Reviewed-on: https://chromium-review.googlesource.com/1067684Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#561927}
-
John Z Wu authored
Tests all public methods. Bug: 778764 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I10d254c9c70761c780024a4711493889fedd4cb7 Reviewed-on: https://chromium-review.googlesource.com/1070598 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
Luna Lu authored
Bug: 846747 Change-Id: I917e61d4db2a30a3a537892aa972cdf505cbaf43 Reviewed-on: https://chromium-review.googlesource.com/1073406Reviewed-by:
-
Luna Lu authored
Bug: 846753 Change-Id: I917f1efaab85b2ddf10c64c17f5f763d8256e2c8 Reviewed-on: https://chromium-review.googlesource.com/1073570Reviewed-by:
-
Mike Wasserman authored
Have ws2::WindowService own a ClipboardImpl, like ws::Service. Enables copy/paste within the ksv app, but not to/from ash/chrome. (run ksv app via --keyboard-shortcut-viewer-app, press Ctrl+Alt+/). TODO: Support copy-paste between mojo apps and Chrome/Ash. Bug: 839591 Change-Id: I02b05cb9f830b0053dc0f1ad9e8e702505ad10a4 Reviewed-on: https://chromium-review.googlesource.com/1073572 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#561923}
-
Xi Cheng authored
The notification_platform_bridge_win* files are not moved for now for consistency reasons. There are no functionality changes at all. This makes the files in notifications/ more organized and eliminates the need of various per-file rules in the OWNERS file. Bug: 734095 Change-Id: I6d792a92d343841da4585edd1938295183b344be Reviewed-on: https://chromium-review.googlesource.com/1072698Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#561922}
-
Patrick Noland authored
Bug: 830919 Change-Id: I1fd9bdbd5f15003d1006518b6883111b5c6e6a5e Reviewed-on: https://chromium-review.googlesource.com/1043095 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#561921}
-
Aaron Leventhal authored
In HTML via <ins>/<del>, and planned for ARIA 1.2, it is possible to mark insertions and deletions in a document. These need to be exposed to screen readers so that they can read revision changes or change suggestions from document reviewers. For now, ins/del are now mapped to internal roles, automation roles and OS X subroles. We are waiting for roles from IA2 for the new roles there. Here is the github issue: https://github.com/LinuxA11y/IAccessible2/issues/4 TBR=spang@chromium.org Bug: 843744 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I90e6d3140f6136a71e0d2f49b0b8d615485536bb Reviewed-on: https://chromium-review.googlesource.com/1067362 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561920}
-
Findit authored
This reverts commit 80bae8d5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 561872 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vODBiYWU4ZDVlYjNiOTc4YjQ4ZGU5YWFmNjM1OTI2YTkwMzU3NjMzZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/26622 Sample Failed Step: sync_integration_tests on Mac-10.11 Sample Flaky Test: TwoClientPreferencesSyncTest.LateRegisteredPrefsShouldSync_E2ETest Original change's description: > Support late registration of syncable preferences. > > Today, there's already a race when registering a preference > through the mojo preference service: the asynchronous > registration call might be slower than starting sync. As > more services are being implemented, those scenarios are > getting more likely -- especially as services could be > started at arbitrary times. > > Before this path, the synced preferences implementation did > not support this scenario. This patch changes the synced > preference implementation to receive and persist remote > data for preferences before they get registered. Currently, > this only applies for a whitelisted set of preferences. > More details about the approach can be found in the design > doc linked from the crbug/840332. > > Bug: 840332 > Change-Id: I90f046d7b59098a303e7b92350cc29e5de9cc244 > Reviewed-on: https://chromium-review.googlesource.com/1064750 > Commit-Queue: Tim Schumann <tschumann@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561872} Change-Id: I50c2cc6742cf32ea96af4c30e9d857e6dac56144 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840332, 846791 Reviewed-on: https://chromium-review.googlesource.com/1073104 Cr-Commit-Position: refs/heads/master@{#561919}
-
John Z Wu authored
Adds a unit test for every method in public API. Bug: 778764 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0db0ef7f9d7dee1e6486bcc49953edb5a0b76f2a Reviewed-on: https://chromium-review.googlesource.com/1065127 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
Mathieu Perreault authored
Removing support for various experiments, except the feature code for |isIconAtStart| on Android, which may be useful in the future and used by other features reusing the dropdown. Bug: 841772 Test: visual Change-Id: I5a73b706ec30652348957a84ea6e095e493f006a Reviewed-on: https://chromium-review.googlesource.com/1061582Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#561917}
-
https://crbug.com/843523arthursonzogni authored
Test that document.querySelector(":target") works when called in the window.load event. This test is a subset of dom/nodes/Element-matches.html, the difference is that this test is more lightweight. It causes the window.load event to be sent earlier. There is a race condition. Currently, it will only work when FrameLoader::ProcessFragment is called before Document::ImplicitClose(). Probable fix: https://chromium-review.googlesource.com/c/chromium/src/+/1057507 Bug: 843523 Change-Id: Ibf7b0d7621b18c3dfefaaa323bbd335d86ce0652 Reviewed-on: https://chromium-review.googlesource.com/1061456 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#561916}
-
Sky Malice authored
Monochrome.apk_Dex +2 entries fields +15 entries methods +4 entries types +7 entries strings Monochrome.apk_Breakdown (+16,364 bytes) -173 bytes Zip Overhead +657 bytes Non-compiled Android resources size +12,528 bytes Native code size +132 bytes Package metadata size +432 bytes Java code size +2,788 bytes Compiled Android resources size Monochrome.apk_Specifics +17,492 bytes normalized apk size +2 zip entries file count +12,528 bytes main lib size +1,128 bytes main dex size Bug: 844007 Change-Id: Id753ce08cebbee9d56679eee3452f6215d1f9907 Reviewed-on: https://chromium-review.googlesource.com/1073402Reviewed-by: -
Steven Bennetts authored
Bug: 846488 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib5e5fcc8b6eb51016c0a9a0f682a4afc4c657210 Reviewed-on: https://chromium-review.googlesource.com/1072923 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
Originally landed: r560165, crrev.com/c/1063007 Reverted: r561246, crrev.com/c/1069891 TBR=dtseng@chromium.org Bug: 651614, 845778 Change-Id: I77b54de28cb0c4a231b5b0758ba4708100d27fff Reviewed-on: https://chromium-review.googlesource.com/1072875Reviewed-by:
-
Parastoo Geranmayeh authored
Logs the skipping decision for hidden or representational fields. Generally, we need to skip the hidden/representational fields, but to support reflected synthetic fields, we don't skip them if they are of 'select' form control type. Test added. See go/1038546-ukm-review for UKM collection review. Bug: 836949 Change-Id: I68c284d39a25176a008f2ad5305f5844a7b4c697 Reviewed-on: https://chromium-review.googlesource.com/1038546 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#561912}
-
Philip Rogers authored
This patch removes: LocalFrameView::IsEnclosedInCompositingLayer LocalFrameView::UpdateLayersAndCompositingAfterScrollIfNeeded Incidentally, this removes the last DisableCompositingQueryAsserts from LocalFrameView. Bug: 823365 Change-Id: I2cc8ef49252be320b994578570919ff5b2a34586 Reviewed-on: https://chromium-review.googlesource.com/1072908 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561911}
-
