GitLab

The linker by defaults writes the absolute path to the corresponding pdb
into executables it creates (if /DEBUG is passed).

/pdbaltpath:%_PDB% tells it to instead just write the basename of the pdb
into the executable, which makes the build more reproducible:

1. Different build directories no longer cause the part of the exe that contains
   the pdb path to be different.

2. More subtly, the pdb file contains offsets into the executable, and if the
   pdb path has different lengths on different systems, the pdb file will be
   different due to the absolute pdb path in the executable.  lld-link sets the
   UUID of the pdb to the hash of the pdb file contents, and the UUID of the
   pdb is also stored in the executable.  So this is also one of the parts
   needed to make the pdb output deterministic.

(Note that while link.exe has supported /pdbaltpath:%_PDB% for a long time,
lld-link learned about %_PDB% only very recently, and this CL depends on the
clang roll https://chromium-review.googlesource.com/c/1271718.)

Bug: 330260
Change-Id: If4c505ababa46ed4f51330521ff09f12f6840a47
Reviewed-on: https://chromium-review.googlesource.com/c/1273475Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598940}

The original CL got reverted in crrev.com/c/1277245 because of a
window-specific bug:
../../third_party/blink/renderer/platform/testing/image_decode_bench.cc(43,26):  error: no matching conversion for functional-style cast from 'const char *' to 'base::FilePath'
    const auto file_path = base::FilePath(name);

which is solved in this CL: crrev.com/c/1277547/1..2
TBR=noel@chromium.org, scroggo@chromium.org, since the delta is trivial

Original CL description ------------------------------------------------
This CL refactors image_decode_bench:
- Rewrites function ReadFile() to use base::FilePath etc.
- Configures the Logging and changes fprintf/stderr to LOG()
 statements, and exit()s into LOG_ASSERT().
- Names the constant kDefaultDecodeTimes.
- s/DecodeError/PrintErrorAndExit/ to clarify what it does.
- Changes uses of CurrentTimeTicks() with base::ElapsedTimer,
 and uses TimeDelta ISO double to count the elapsed time.
- Uses perf_test::PrintResult to add info about the image
 (size and #pixels), when a new parameter (-v / -verbose)
 is specified after the current two parameters, file and
 #iterations; output is e.g.:
*RESULT decode_time /usr/local/google/home/mcasas/Pictures/4.webp: 100 times 790528 pixels (1024x772)= 66.27827 ms/sample

Bug: 889898
Change-Id: I5f553a8e1f661776c747e0433df0ac794680706d
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1225653
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1277547Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598939}

It will allow fine grained control of which parts of the UI changes
are enabled/disabled.

Bug: 894601
Change-Id: I4ec747b43272c8a2b5d2c838d12294095bd5ba89
Reviewed-on: https://chromium-review.googlesource.com/c/1264739
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598938}

- Creates InfobarCoordinator, which for now will be used as the public interface of
infobarContainer, and will serve the function of InfoBarContainerDelegateIOS.

- Creates an Infobar positioner protocol that will help the delegate position the infobarContainer,
this will use LayoutGuides in followup CL's

- Moves current infobars files from the infobars source_set to a new infobars_ui source_set.

Bug: 892376
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I825c1ff2ce18930b4dc7a642f067d0d77b64302a
Reviewed-on: https://chromium-review.googlesource.com/c/1263278Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598937}

Migrate components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc to using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates Android's WarmupURLFetcher and the
respective unittests away from URLFetcher.

When migrating the unittests, it was opted to implement a
queue of mocked responses mechanism, to mimic the current behavior
(using net::MockClientSocketFactory and net::MockRead objects).

The CL also removed the helper method GetURLFetcherForConfig,
merging it into RetrieveRemoteConfig. Basically, although it made
sense with URLFetcher's set up and flow of method calls, it is
not the case with SimpleURLLoader.

BUG=879784

Change-Id: I0c38042fcd37f5848dca49ff8322e514f818cdba
Reviewed-on: https://chromium-review.googlesource.com/c/1274405Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#598936}

Launch bug: http://crbug.com/754101
The plan is to launch the feature in M71.

Change-Id: Idde08df84304ad6f2668603579fdc7e619072892
Reviewed-on: https://chromium-review.googlesource.com/c/1262656Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598935}

Previously style for invisible elements are still computed but changed
to have the value display:none at the end of computation through
StyleAdjuster. This CL moves the check for invisible attribute to
near the start of Element::StyleForLayoutObject so that we won't waste
time computing style for invisible elements.

Bug: 873057
Change-Id: I21a9f3fe4b8ddacf781d0e5e3de54f3bb0b04b17
Reviewed-on: https://chromium-review.googlesource.com/c/1276066
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598934}

Tbr: ellyjones@chromium.org
Bug: 828031
Change-Id: Idf9b3f7140b468acdfa5b7694caf3ac55e5cd245
Reviewed-on: https://chromium-review.googlesource.com/c/1277551Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598933}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fddb9569821..47faa068e8ff


git log 2fddb9569821..47faa068e8ff --date=short --no-merges --format='%ad %ae %s'
2018-10-11 ehmaldonado@chromium.org git-cl: Make request to upload logs more visible.


Created with:
  gclient setdep -r src/third_party/depot_tools@47faa068e8ff

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:881860
TBR=agable@chromium.org

Change-Id: I0fb982270df976414397ca374704f9971c5c3a1e
Reviewed-on: https://chromium-review.googlesource.com/c/1277748Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598932}

Previously get_build_defs.py was producing BUILD.gn that's hard to
read. Now the lists in the output are split into multiple lines with
proper indentation, which makes them more readable.

Change-Id: I6015b99710c0ec450205a0045d2a43dbf73c47e9
Reviewed-on: https://chromium-review.googlesource.com/c/1277832Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598931}

It should match the opacity of the password text.

Bug: 881578
Change-Id: Ifdc4a607aed92cf98ffa86b20c8be595de6a607a
Reviewed-on: https://chromium-review.googlesource.com/c/1271103Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598930}

This change updates PasswordPrivateDelegate to use sort keys when
communicating with the PasswordManagerPresenter. Communication with the
JavaScript continues to be done via indices, which is why a utility
class to map between strings and integers is introduced. Furthermore,
PasswordManagerPresenter's API is updated with sort key based overloads.
This fixes the linked bug, which assumed the tuple (index, website,
username) will be a stable identifier for each entry present in the list
of passwords. This assumption can break, when there are multiple entries
with the same website and username. Replacing index with an identifier
that is derived from more information solves this issue.

TBR=tedchoc@chromium.org

Bug: 892260
Change-Id: I4df39a8c7ebe33c1e56bb64c8a3a96262e246584
Reviewed-on: https://chromium-review.googlesource.com/c/1273717
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598929}

When a double-tap is dropped through a touch-action (e.g.  "none" or
"manipulation"), we replace the double-tap event with a single-tap which
is the second single-tap in the gesture sequence.  Blink dispatches
compat "click" events for both these taps.  Without a correct tap-count
(==2) in the second tap, a follow-up "dblclick" event is not dispatched,
which is wrong.  This CL fixes the problem.

Bug: 874474
Change-Id: I25f9806e5ec9f211f9f83d59e8949052a816aaf3
Reviewed-on: https://chromium-review.googlesource.com/c/1276846Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598928}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d75c465bc3db..9a77fdecd091


Created with:
  gclient setdep -r src-internal@9a77fdecd091

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None.
TBR=mmoss@chromium.org

Change-Id: Ib70361fd42c5788747a0e92bdcbee5b478b24715
Reviewed-on: https://chromium-review.googlesource.com/c/1277745Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598927}

- Adds NetworkFileSharesPreconfiguredShares policy, which allows shares to
be preconfigured by a user. Initially the only supported fields are share_url
and mode. The only supported mode is drop_down, which adds share_url to the
discovery drop down.
- In the future, additional modes will be implemented such as a mode that
automatically mounts the shares. This will also require adding credential
fields to the object.

Bug: chromium:878502
Change-Id: I7494e5f9680f313680add379ac3833610d1213a9
Reviewed-on: https://chromium-review.googlesource.com/c/1265903
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598926}

Records two new metrics situations (local and server for both):
1) How many strikes a card had when it was successfully saved
2) When save is not offered due to being a 3-striked card

Bug: 884817
Change-Id: I225994e6ad210cc6f0d768f209ff17a5cea23532
Reviewed-on: https://chromium-review.googlesource.com/c/1275026
Commit-Queue: Jared Saul <jsaul@google.com>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598925}

Update the incognito NTP header color to 100% white.

BUG=850138

Change-Id: Ieb13f4dafeb3af67048904cb80798dff9505bbeb
Reviewed-on: https://chromium-review.googlesource.com/c/1277787Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598924}

https://pdfium.googlesource.com/pdfium.git/+log/265886b2befa..c345065e7aff


git log 265886b2befa..c345065e7aff --date=short --no-merges --format='%ad %ae %s'
2018-10-11 thestig@chromium.org Rename interform files to interactiveform.


Created with:
  gclient setdep -r src/third_party/pdfium@c345065e7aff

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I20b28616b56df643f55d3bb3a4c3aeabc89b060b
Reviewed-on: https://chromium-review.googlesource.com/c/1276811Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598923}

Bug: 891888
Change-Id: I2922c7b24cf688387af8c15d58523fd0f45b1f7a
Reviewed-on: https://chromium-review.googlesource.com/c/1259546Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598922}

This CL adds a new entry to the blacklist as per new report from
https://bugs.chromium.org/p/chromium/issues/detail?id=849636#c61

TBR=emircan@chromium.org

Bug: 792640, 849636, 862395
Change-Id: I47a36dce54993f93059fd833f0ca5ea074037339
Reviewed-on: https://chromium-review.googlesource.com/c/1277589
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598921}

- Change the notification behavior/expectations of
OfflineContentProvider.  On Android we will no longer throttle
OnItemAdded calls to the notification layer depending on state.  This
really only impacts downloads and offline pages, where we don't want to
then trigger OnItemAdded for every item on startup, as that will dump
the whole contents to the notification layer.

This is how both systems currently work, but making that assumption
explicit means we can be more loose on what we let through the
OnItemAdded call to the notification layer.

Change-Id: Iad8a778035d50fa8dab6222d2e53e7132efd1766
Reviewed-on: https://chromium-review.googlesource.com/c/1265556
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598920}

R=jhawkins@chromium.org

TBR=jhawkins@chromium.org

Bug: 873310
Change-Id: Ie0e9a8ef43c890666b39e4f188d9ba156295c7e8
Reviewed-on: https://chromium-review.googlesource.com/c/1277866
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598919}

This CL reverts CL https://codereview.chromium.org/2697563002/.

Reason for revert: Channel ID is no longer supported on Chromium,
so this debug information no longer needs to be passed to Gaia.

Bug: 633256
Change-Id: I89b96af036e80fd9d685bc3df351468cb54aa676
Reviewed-on: https://chromium-review.googlesource.com/c/1276768Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598918}

Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1226099

Only change is a fix for the xdefine macro issue in hit_test_query.cc.

Bug: 891320

R=riajiang@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ief766fbd9a9bc5c41a0a7b087c318af5e09e8d81
Reviewed-on: https://chromium-review.googlesource.com/c/1269760Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Alexander Shah <zandershah@google.com>
Cr-Commit-Position: refs/heads/master@{#598917}

      +722,123 bytes normalized apk size
            +5 zip entries file count
       +54,016 bytes main lib size
      +451,168 bytes main dex size
      +273,295 bytes APK size
 +2,096,013.72 bytes Estimated installed size
InstallBreakdown (+2,092,986.72 bytes):
        +2,340 bytes unwind_cfi (dev and canary only) size
        +1,930 bytes Non-compiled Android resources size
       +54,016 bytes Native code size
          +348 bytes Package metadata size
 +2,018,752.72 bytes Java code size
       +15,600 bytes Compiled Android resources size
        +2,299 entries fields
        +3,201 entries methods
          +759 entries types
        +1,601 entries strings

Specifics: 
InstallSize: 
Dex: 
Change-Id: I9d6d7f4ade5063c4eaa868fec73b53cf1bf5fae8
Reviewed-on: https://chromium-review.googlesource.com/c/1277366Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598916}

When this test was written it was assumed safe to use exact comparisons
for scale because it was expected that all the page scale factors would
be a power of 2. But Android test bots use arbitrary values that mean we
should use EXPECT_NEAR instead.

TBR=kenrb@chromium.org

Bug: 894561
Change-Id: Ia6f70f62ef993ef5bd2a7699a7fbb30c492c651d
Reviewed-on: https://chromium-review.googlesource.com/c/1277651Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598915}

Bug: 867488
Change-Id: Idb8c9aa2ce120f6d8c4d3feb4789b0f81d636818
Reviewed-on: https://chromium-review.googlesource.com/c/1275139Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598914}

This patch fixes FontOrientation in ComputedStyle when
StyleAdjuster changes WritingMode.

FontOrientation is computed from WritingMode and
TextOrientation when constructing style through FontBuilder,
but it can be out-of-sync when WritingMode is changed without
using FontBuilder.

This patch re-synchronize FontOrientation in such cases.

Bug: 869882
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie1eedcec9c96e381fc508871a8b714ab0f086081
Reviewed-on: https://chromium-review.googlesource.com/c/1275986
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598913}

Add a Sync integration test which exercises custom passphrase flows, including
the handling and proper functioning of the newly added key derivation method
(scrypt).

Add an integration test helper file for encryption-related tasks and modify
FakeServer and LoopbackServer to allow easier modification of persistent
entities such as Nigori. Add passphrase-related functionality to
ProfileSyncServiceHarness to give tests better control over how and when
passphrase-based encryption is enabled.

The test uses a gray-box approach, where it tests the client at the
ProfileSyncService granularity, but injects and inspects entities on the (fake)
server to ensure that encryption is performed properly. This is necessary
because, when it comes to encryption, we are not interested merely in that it
does not hinder existing functionality (e.g. two clients are syncing data
properly in the presence of a custom passphrase), but also that it provides the
expected security to the user. For this reason, we use our knowledge of the
encryption architecture internals to ensure that the data committed to the
server is encrypted in the expected way.

Bug: 894148
Change-Id: I728f7f18cc0db7b1da50f747a87a640877d0b023
Reviewed-on: https://chromium-review.googlesource.com/c/1274205
Commit-Queue: David Davidović <davidovic@google.com>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598912}

Bug: 894546
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2dc2757f678bc0c2e8f7a575989b6bbaf1d2d592
Reviewed-on: https://chromium-review.googlesource.com/c/1277593Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598911}

The associated unit test is also moved.

Change-Id: Ia35c2873d8c40071f204fbecc064285ee3ed0ecf
Reviewed-on: https://chromium-review.googlesource.com/c/1277373
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598910}

The translation Pedal prompts user for page translation when executed.
This is an action Pedal that does not result in navigation, so now
the omnibox is also reset/reverted when any Pedal executes.

Bug: 893183
Change-Id: Ib9d3e31489ab740045e823e57786ef05b61d0916
Reviewed-on: https://chromium-review.googlesource.com/c/1274458Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598909}

This refactoring is needed to access Profile
within ExtensionManagemnt class in
https://crrev.com/c/1268938

Bug: none
Test: update unittests
Change-Id: Icdd53213a270d68e535d9846c5cc60dc19a1fb9e
Reviewed-on: https://chromium-review.googlesource.com/c/1275889Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598908}

Note that the default policy value used to be only "PIN", so fingerprint may
be disabled for users until their prefs are reset to default values (for
example, they can remove and re-add their account).

To avoid this issue in the future, the default policy value is changed to "ALL".

Bug: 884266
Change-Id: I8809a2fcd571149df60cd2ef2013ac6d73971397
Reviewed-on: https://chromium-review.googlesource.com/c/1271586
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598907}

This will partly fix the problem of Settings and Discover internal apps.
Both of their kAppType are set to BROWSER, which is not what we want for
window drag. For real browser window, its frame will only be hidden when
it is full-screened. Add the restriction here to avoid the problem of
Settings and Discover when they are only maximized.

Bug: 877723
Change-Id: Ib6b6708b8065940a1a94be89cdde6b317093cdb2
Reviewed-on: https://chromium-review.googlesource.com/c/1274839Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598906}

This flag is now true and the feature is guarded by an actual
FeatureFlag.

Bug: 61248
Change-Id: I10633a52d5b4fc94fea882d495e8bd02d17a8c70
Reviewed-on: https://chromium-review.googlesource.com/c/1277185Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598905}

This change speeds up reaction time by:
 - adding a retry mechanism to ScriptTracker::CheckScripts when finding
 elements on the page.
 - merging conditions that look for the same elements into one call to
 WebController::ElementExists

This change also introduces a helper for running multiple ElementExists
or GetFields at the same time. The helper makes things simpler and also
hides the fact that we temporarily have to run these in sequence,
instead of in parallel.

This changes reproduces the behavior of the Java implementation, which
would retry looking for elements to satisfy unmet precondition checks
every 100ms for up to 2s. The approach taken is quite different, since
in Java, this happenened on separate threads.

The idea is to have the helper keep track of everything the
preconditions want to check and reporting the result incrementally to
the preconditions, and eventually to the controller.

CheckScripts now:

1. applies all the static checks on preconditions, such as URL or
   parameters
2. looks for all elements mentioned in preconditions
3. reports the resulting set of scripts to the controller
4. waits 100ms
5. looks for all elements mentioned in preconditions that were
   not found in the previous run
6. reports the new set of scripts to the controller, if there's
   been any change
7. go back to 4 until all elements were found or the 2s deadline
   is reached

Bug: 806868
Change-Id: I796c83f156531bd3999fc464ca162be0d70ad4b0
Reviewed-on: https://chromium-review.googlesource.com/c/1273299
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598904}

Change-Id: I597847a123db38e2fe648a87ef19e920c7ebec06
Reviewed-on: https://chromium-review.googlesource.com/c/1274047Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598903}

Adds bool parameter for enabling/disabling NTLM on Remount.

Bug: chromium:888096
Change-Id: I072362ef347f57831db518ebe10dcaa11327ea8b
Reviewed-on: https://chromium-review.googlesource.com/c/1269175Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598902}

When the user is signed in and syncing, the signin-allowed
toggle is now disabled.

Note: This CL is adapted from crrev.com/c/1273517 and
removes the hint, i.e. there are no string changes here.

Bug: 892745
Change-Id: I1778115390518860fca4b4f11588d5ca7c7b9210
Reviewed-on: https://chromium-review.googlesource.com/c/1275849Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598901}