- 12 Jul, 2019 40 commits
-
-
Mike Frysinger authored
Python 3 doesn't support the ur string prefix, and it's not needed: a plain r prefix works in both versions everywhere. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I5628fd57ac59906bd27c94f61aa5ea7e07807b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699353 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676837}
-
Sylvain Defresne authored
As discussed offline, remove the custom TestIdentityManagerObserver that is used to check behaviour instead of public API. Instead test that sign-in adds the accounts from faked system to IdentityManager. Use shared TestIdentityManagerObserver to check that the errors are cleared when the application goes back into foreground (since this test behaviour of AuthenticationService, not IdentityManager). Remove unnecessary FakeSigninClient since it does not override any methods from IOSChromeSigninClient. Instead use the default factory. Bug: none Change-Id: I59f43e83c5caa3aad595361c8144ba4f1ca83895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697014 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676836}
-
Matthias Körber authored
Change-Id: I44ad30be9d24df7de18a2627417a6a34886927c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660662 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676835}
-
Sylvain Defresne authored
This method is unnecessary for two reasons. 1. as IdentityManagerFactory constructor declares dependencies on other KeyedService's factories, this ensures they are built 2. IdentityManagerFactory now only depends on SigninClientFactory that is created from EnsureBrowserStateKeyedServiceFactoriesBuilt Bug: none Change-Id: Icaa1b443519afbab90752d7869957458f5149d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696966 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#676834}
-
Tarun Bansal authored
They seem to be obsoleted in either M-68 or M-69. I did not dig up too deep to get the exact milestone. Change-Id: Ifb72d7e95bdfefcf33bccc39ef1132ae055c2960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699725 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676833}
-
Henrique Ferreiro authored
After all usage of Profile and dependencies on //chrome/browser code have been moved out of ProfileOAuth2TokenServiceBuilder, profile_oauth2_token_service_builder.* can be moved to //components/signin/internal/identity_manager. In this CL, the profile path is added to IdentityManagerBuildParams and the code to build the AccountTrackerService is moved into IdentityManagerBuilder. This CL finishes internalizing the creation of IdentityManager in Linux, Chrome OS and Android platforms. Bug: 974198 Change-Id: I41edeef9a73d7f624ee646052c3814e883e81bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690579 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
The primary goal of this CL is to convert usage of MediaControllerImageObserver interface and port dependent files to adopt new implementation. Bug: 955171 Change-Id: I15e76a25eee48513594c223128b83846c7061f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686710 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#676831}
-
Sylvain Defresne authored
Downstream usage has been removed, the overload can now be deleted safely without breaking the autoroller. Bug: 982681 Change-Id: Ibee48b9071cd8c3ae7b473a3e5bef7a4d1a90399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695308 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
WebGL uses GPU resources. If a page in the back forward cache uses WebGL, the page would keep the resources on GPU and this might be problematic for other pages as GPU resources are limited. Another option would be to cause context lost, but this is still controversial. Most websites don't prepare for context lost and increasing possibility of context lost might break websites. Bug: 981740 Change-Id: Ib04680d9be76258c220d2f0e385eb10a17de567d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697189Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#676829}
-
Fergal Daly authored
This describes the implementation of the current prototype and the various other approaches we are considering. Change-Id: I1538d0fe6f5668fa1e05f05c9ed7b161f6559aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698361Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676828}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. AccountInfoFetcher and AccessTokenFetcher take PO2TS instead of O2TS as they have used PO2TS instances and O2TS is supposed to be folded into PO2TS. Bug: 967598 Change-Id: I8cdad9a435a62253665babac1e5188f92818eb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699262Reviewed-by:
-
Fergal Daly authored
Change-Id: Ia5da0520e1d4aa444ba6f04a37fc9771eb0b4d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698023Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676826}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/05439f5cc69e..12e4307dc7b4 git log 05439f5cc69e..12e4307dc7b4 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 bungeman@google.com Properly handle phantom points for variation fonts (#56601). Created with: gclient setdep -r src/third_party/freetype/src@12e4307dc7b4 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: 981443 Change-Id: I9c9de723d302a9e42ec5ed3fd5354233fab76c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699550Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676825}
-
Yutaka Hirano authored
To make StrongAlias<Tag, bool> more attractive for replacing enum used for boolean params, introduce explicit conversion to the underlying type to StrongAlias. Bug: 983022 Change-Id: I14599f05c558dbce9d0d86256079eddc6cea0a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697401 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#676824}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that the latter is only one subclass of O2TS. It moves oauth2_token_service_unittest.cc to profile_oauth2_token_service_unittest.cc since O2TS works only with PO2TS. Bug: 967598 Change-Id: I37aaa7ac759b24dacf4b8dd48b20d47b5305abb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697066 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
arthursonzogni authored
Pages in the BackForwardCache and the current one need to use a different set of RenderView. The RenderView manages a WebView object from blink, which hosts a blink frame tree. Two differents pages can't be in the same frame tree. They need to use a different set of blink::Page. This CL requires the old page to live in a different BrowsingInstance than any other page in order to enter the BackForwardCache. Bug: 977562 Change-Id: I2ec5c4d39f7f546991f4a890e81cc2968e045e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683521 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/268589b895db..7938579ef96f Created with: gclient setdep -r src-internal@7938579ef96f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: I07bf60a0b6bcfa32933f7ea89b6f683fba33a900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699547Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676821}
-
Hirokazu Honda authored
ARC++ allocates video frame buffer using gralloc. The requested frame size is specified by ProvidePictureBuffers(). Gralloc possibility adjusts the requested frame size. Chrome has to be informed the adjusted frame size and work with the frame size. Bug: 979115 Test: CtsMediaTestCases on kevin Test: CtsMediaTestCases on atlas Change-Id: I91c8aa3f64e8a8dba0b6c62ab18918fc0c7d5a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694962 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#676820}
-
arthursonzogni authored
The feature name doesn't match the one in the Finch config file, because there was an added 'k' letter. Bug: 977562 Change-Id: I9dfcb4d9191669c4aa27514996c12cce8d8c7f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699803Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#676819}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e896a0da6678..06ab6e5b1330 git log e896a0da6678..06ab6e5b1330 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 jiawei.shao@intel.com Metal: Code clean up in copy commands 2019-07-12 cwallez@chromium.org Add rendering tests for all color formats Created with: gclient setdep -r src/third_party/dawn@06ab6e5b1330 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I6fa6f0f982f5d4b500222f15f8323d06c621dc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699549Reviewed-by:
-
Anna Malova authored
Move Safe Browsing objects from AwBrowserContext to AwBrowserProcess. AwSafeBrowsingUIManager, TriggerManager, DatabaseManager and AwSafeBrowsingWhitelistManager are supposed to be global and not tied to any profile. Bug: 963875 Change-Id: Id353809e069a619223d396fa29b217534c680432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690854Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#676817}
-
Yuki Shiino authored
- Added all the APIs into IdlType - Simplified function docstring - Made the order of API listing consistent with class definitions This is a preparation to implement ReferenceType's proxy. Bug: 839389 Change-Id: I43ecdbdab9b84fbcc2503b64adb470b74fa1c0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698121Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#676816}
-
Javier Ernesto Flores Robles authored
Bug: 976640 Change-Id: I13b8e7ad638b7540724a65392ff8466414846420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697626 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#676815}
-
Juan Antonio Navarro Perez authored
With the removal of some legacy memory benchmarks, vr_benchmarks are the sole remaining client of the top 10 URL_LIST and their WPR recordings. To make this more explicit we move both the list and the recordings to contrib/vr_benchmarks Bug: 761014 Change-Id: I8c1023655391484b245479ccb296ce0beee1972e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687242Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#676814}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4e8154e696f40eb807be1c161da1961f26b7a54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699556Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22df64cc..b411a379 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I471f853acb0da0e8aa9e50ba3a1c067c93f8bbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698171Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676812}
-
Jordan Demeulenaere authored
Bug: 978295 Change-Id: I00cd32b667e8c7e210ec649ffc11e3a565c20802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698528Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#676811}
-
Michael Ershov authored
Add a new error code to enterprise.platformKeys.[challengeUserKey|challengeMachineKey] so it's possible to distinguish between devices that doesn't support the operation and a real failure. Bug: 974018 Test: EPKPChallengeMachineKeyTest.AttestationUnsupported Change-Id: I77b21958007b92a061522cedffd59f40a8b39284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695544Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#676810}
-
Daniel Vogelheim authored
Bug: 739170 Change-Id: Ie6d9dec721660c33b108fde2da226abfc9d746ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698522Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#676809}
-
Sylvain Defresne authored
All the tests that were making use of that feature have been converted to use the real production workflow as IdentityTestEnvironment is not designed to allow testing sign-in or sign-out workflow since they are different on each platform. Remove the feature as it has no use, thus all the platform behave the same way when using IdentityTestEnvironment. Bug: 982259 Change-Id: I3809280d769863b80f12dcea5ac04f83ce855ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695344 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Bug: None Change-Id: I7a1cde140753c16d8a7a6b76d7a15d305b7b9626 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699058 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#676807}
-
Sylvain Defresne authored
CWVSyncController wants to test the interaction with the production workflow of the sign-in which IdentityTestEnvironment cannot properly model. This is because IdentityTestEnvironment is generic code that put the IdentityManager in a known state for code that do not care how the list of accounts is updated. The only method from IdentityTestEnvironment that is used by the test is UpdatePersistentErrorOfRefreshTokenForAccount() and it does not depends on having fake backing the IdentityManager. So change the test to create a real instance and to invoke the test util method directly. This removes one usage of IdentityTestEnvironment::ExtraParams (which will eventually be removed and will allow to ensure IdentityManager is always backed by fake when using IdentityTestEnvironment). Also do some cleanup of the test: - use getter to fetch the different KeyedServices instead of storing pointer to the services as CWVSyncControllerTest member field - move initialisation and cleanup to constructor and destructor as this is preferred to overloading SetUp() and TearDown() - introduce a separate class TestIdentityManagerObserver to count the number of times OnRefreshTokenUpdatedForAccount() is called - remove unnecessary member field and duplicate initialisation This also required changing IOSWebViewSigninClient constructor to take a WebViewBrowserState* instead of the shared url loader factory and the cookie manager as the getter are creating the objects lazily which require properly initializing the network stack which is unnecessary for tests. Bug: 982259 Change-Id: Ia99bef652386d89f683db82a09c6d23cfe037ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695285Reviewed-by:John Wu <jzw@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0cb36be6f6d3..80bb3116391c git log 0cb36be6f6d3..80bb3116391c --date=short --no-merges --format='%ad %ae %s' 2019-07-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src c538b5d796fb..71892a5eda90 (1 commits) Created with: gclient setdep -r src/third_party/angle@80bb3116391c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:None Change-Id: I9e7dab8ef9c8308dcd1062d63b5ea91401b9f078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699902Reviewed-by:
-
rajendrant authored
This CL includes tests for: - Testing that images and iframes with the attribute loading="lazy" are deferred until they come into view - Testing that images and iframes with the attribute loading="eager" are loaded immediately Bug: 916260 Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#676804}
-
Matthew Cary authored
The linux sandbox creates shared memory segments in SandboxIPCHandler::HandleMakeSharedMemorySegment. The wrinkle is that these segments may be created executable, which is done nowhere else in chrome. NaCl appears to be the only consumer of this feature, via NaClAppLoadModule / NaClAppLoadFile. The platform file descriptor backing the shared memory is extracted and shared via sendmsg() manually, rather than via a mojo or legacy IPC mechanism. This CL introduces a linux-only executable create for base::subtle::PlatformSharedMemoryRegion to be used for this purpose. The new create method has a stern comment, and is only exposed through the base::subtle API, in order to discourage wide usage. Bug: 795291 Change-Id: I9753c74b74c30d9873eb13415f4084ccf9b3fa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695405 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
Bug: 975976, 945557 Change-Id: I41d8da642d12d18e8a22206384a534389c35b53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697483Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676802}
-
Omer Katz authored
This CL optimizes pre-finalizer invocation. Previously, we would maintain pre-finalizers in a LinkedHashSet and invoke as follows: 1. Create a reversed copy of pre-finalizers in a Vector 2. Iterate the vector 2.a Invoke pre-finalizers on dead objects 2.b Remove dead objects from HashSet Instead, we now maintain pre-finalizers in a Deque and invoke as follows: 1. Iterate the deque backwards 2. Store non-pre-finalized (live) objects in a new Deque 3. Move the new Deque over. This improves performance on selected microbenchmarks by at least 25% (and up to 65%). Bug: 981043 Change-Id: I0f3e3bbbc9c75ca017b11c6d60f991b1a68b44be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698465Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id12206148676581f9d8db65a8c5dea99261da53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699322Reviewed-by:
-
Antonio Gomes authored
This is (likely) the last of the set of precursor CLs to pave the way to Onion souping webmediaplayer_ms{compositor}.cc. It is part of section 4.4.1 in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY Note that as part of the move to blink, the CL also updates the signature of two methods, previously using GURL, banned in Blink: GetMediaURLScheme() and ReportMetrics(). BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I5f95c7749978f71781b0eb3b9c33a1ac80338054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698165Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#676799}
-
Benoît Lizé authored
The foreground variant is enabled by default, and the background one unused. Simplify the code and the tests. As a side-effect, also remove the following histograms: - Memory.ParkableString.CompressionRatio - Memory.ParkableString.SavingsKb - Memory.ParkableString.TotalSizeKb Bug: 951773, 967546 Change-Id: Ia4c8a1753f59974a394d6fdb11e1ac5bfe65cac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697649Reviewed-by:
-
