GitLab

This is a follow-up CL for
https://codereview.chromium.org/2577183002/

This CL fixes the logic of counting the number of devices. Previously, the
|device_ids_| is cleared in function StartDeviceDiscovery(), and since
StartDeviceDiscovery() is called after PopulateConnectedDevices(),
and PopulateConnectedDevices() may add cached devices. So those added devices
are removed from |device_ids_|. This CL fixes this by clearing the |device_ids_|
before the PopulateConnectedDevices() function is called.

TBR=scheib@chromium.org

BUG=674195

Review-Url: https://codereview.chromium.org/2601773003
Cr-Commit-Position: refs/heads/master@{#440781}

https://skia.googlesource.com/skia.git/+log/878df6dd03d1..29437eb5c782

$ git log 878df6dd0..29437eb5c --date=short --no-merges --format='%ad %ae %s'
2016-12-27 brianosman Add color space fallback for matrix convolution filter

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=liyuqian@google.com

Review-Url: https://codereview.chromium.org/2600953002
Cr-Commit-Position: refs/heads/master@{#440780}

This patch will now show bars for nodes that are collapsed and contain
nodes that have bars inside them.

See: http://imgur.com/a/egUwg

R=dgozman
BUG=664704

Review-Url: https://codereview.chromium.org/2591043003
Cr-Commit-Position: refs/heads/master@{#440779}

BUG=676488

Review-Url: https://codereview.chromium.org/2592273002
Cr-Commit-Position: refs/heads/master@{#440778}

Ensure the warning dialog on leaving Chrome is shown in the case where
the intent URL is redirected to Play Store.

BUG=648530

Review-Url: https://codereview.chromium.org/2597283002
Cr-Commit-Position: refs/heads/master@{#440777}

This reverts commit feb10cb7.

BUG=676188,392620
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2602543002
Cr-Commit-Position: refs/heads/master@{#440776}

Currently, the PaintArtifactCompositor naively puts every PaintChunk
into its own composited layer. This patch improves on that by merging
a PaintChunk into the same layer as the PaintChunk which precedes it,
if the new PaintChunk has a compatible PropertyTreeState (no directly
composited property tree nodes between the state of the new PaintChunk
and the old one).

This algorithm is spelled out in a design doc, see crbug.com/668342.

A large amount of this patch is additional tests and testing machinery
to support the change in behavior.

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2581843002
Cr-Commit-Position: refs/heads/master@{#440775}

ChromeServiceWorkerTest.FallbackMainResourceRequestWhenJSDisabled was already fixed but it snuck back in from a bad merge. Camille fixed the PageLoadMetricsBrowserTest failures in r440646.

BUG=504347

Review-Url: https://codereview.chromium.org/2600233002
Cr-Commit-Position: refs/heads/master@{#440774}

NavigationManager's GoBack() and GoForward() crash if navigation is not
possible. This mirrors NavigationController's behavior so
NavigationManager should only be changed along with
NavigationController.

KeyCommandsProvider sends IDC_FORWARD and IDC_BACK commands without
checking that navigation is possible and app crashes.

There are 2 fully correct options to fix this bug:
1.) Change NavigationManager and NavigationController, so they don't
    crash (which has both pros and cons).
2.) Change KeyCommandsProvider, so it does not send IDC_FORWARD,
    IDC_BACK commands if navigation is not possible.

Correct fix will be tracked in a separate bug (crbug.com/677160), and
this CL simply fixes a crash in the most simplest way w/o touching
Tab class (which will be removed).

BUG=676727

Review-Url: https://codereview.chromium.org/2605713002
Cr-Commit-Position: refs/heads/master@{#440773}

In particular, interstitials "mask" the underlying webcontents
and we need to handle them specially.  We do this by capturing
the correct content::RenderViewHost from the interstitial
instead of the webcontents it sits on top of.

BUG=675283

Review-Url: https://codereview.chromium.org/2581413002
Cr-Commit-Position: refs/heads/master@{#440772}

https://skia.googlesource.com/skia.git/+log/210e8551a30f..878df6dd03d1

$ git log 210e8551a..878df6dd0 --date=short --no-merges --format='%ad %ae %s'
2016-12-27 brianosman Modify matrix convolution GM for sRGB testing

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=liyuqian@google.com

Review-Url: https://codereview.chromium.org/2601803002
Cr-Commit-Position: refs/heads/master@{#440771}

See bug for details.

BUG=536858

Review-Url: https://codereview.chromium.org/2594193002
Cr-Commit-Position: refs/heads/master@{#440770}

Revert of Disable UndoTabModelTest#testUndoNotSupported (patchset #1 id:1 of https://codereview.chromium.org/2575323004/ )

Reason for revert:
The root cause has been fixed, so this can be re-enabled.

Original issue's description:
> Disable UndoTabModelTest#testUndoNotSupported
>
> BUG=674654
> TBR=dfalcantara@chromium.org
>
> Committed: https://crrev.com/722592581993a0a4171b92a9e604d6ac24f6615c
> Cr-Commit-Position: refs/heads/master@{#438947}

TBR=dfalcantara@chromium.org,twellington@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=674654

Review-Url: https://codereview.chromium.org/2604823002
Cr-Commit-Position: refs/heads/master@{#440769}

Also sort per-file delegations alphabetically.

BUG=none

Review-Url: https://codereview.chromium.org/2600923002
Cr-Commit-Position: refs/heads/master@{#440768}

Ananta fixed NavigationControllerBrowserTest. EnsureSamePageNavigationUpdatesFrameNavigationEntry in r440443 and NavigationControllerBrowserTest.RaceCrossOriginNavigationAndSamePageHistoryNavigation is no longer triggering DCHECKs.

BUG=475027

Review-Url: https://codereview.chromium.org/2606793002
Cr-Commit-Position: refs/heads/master@{#440767}

Since the state keys are not generated as long as the time sync didn't
happen, the callback containing the state key might end up not being
invoked at all. This information has been included in the code comments.

BUG=649422

Review-Url: https://codereview.chromium.org/2532163002
Cr-Commit-Position: refs/heads/master@{#440766}

The idea of this patch is to start using html_diff for -pretty-diff.html
files; once these files are always available then the wdiff-related code
can be removed and there will still be some kind of HTML diff on Windows.

In order to keep this change minimal, the files are still called
-pretty-diff.html and "has_pretty_patch" is still set in the results JSON,
but after this, the "has_pretty_patch" and "has_wdiff" keys in the results
JSON should be removed.

BUG=672651

Review-Url: https://codereview.chromium.org/2580343003
Cr-Commit-Position: refs/heads/master@{#440765}

This script relies on having the recently added ShowGlobals.exe built
and in your path.

R=stanisc@chromium.org
BUG=630755

Review-Url: https://codereview.chromium.org/2592323002
Cr-Commit-Position: refs/heads/master@{#440764}

Previously the adjustment of previous visual rects on scroll was not
complete: it ignored non-layered objects, and didn't adjust location
in backing.

Now set paint invalidation flag on scroll if needed, and all required
adjustments will be done during paint invalidation.

BUG=673197
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2605543002
Cr-Commit-Position: refs/heads/master@{#440763}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/df882a1d..b8939070

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2607583002
Cr-Commit-Position: refs/heads/master@{#440762}

CSS position change may not affect paint properties of the object
itself, but may affect paint properties of descendants.

BUG=674623
TEST=All/ScrollAnchorTest.ExcludeAbsolutePositionThatSticksToViewport/0
TEST=All/PaintPropertyTreeBuilderTest.PositionChangeUpdateDescendantProperties/*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2604743002
Cr-Commit-Position: refs/heads/master@{#440761}

1. Added test support classes that allow running the smoke tests in
   different environments against different servers. There is one
   support class for Java-only tests and one that requires H2 & QUIC.
   The concrete implementation of support classes is determined at
   runtime by reading the value of |TestSupportImplClass| from the
   Android string resource file.
2. Added two test APKs one for Java only deployment and one to test
   behavior when the native “.so” file is absent.
3. Enabled proguarding for the existing unit tests. The new APKS also
   run proguard in order to check the correctness of proguard configs
   for different deployments.
4. Added new HttpServer for Java-only scenario that does not depend on
   Chromium “base” and “net” modules.
5. Added two additional smoke QUIC & H2 tests to the existing test APK.

To run all smoke tests, execute:

ninja -C out/Debug cronet_smoketests_platform_only_instrumentation_apk \
cronet_smoketests_missing_native_library_instrumentation_apk \
cronet_test_instrumentation_apk -j 240 && \
./out/Debug/bin/run_cronet_smoketests_platform_only_instrumentation_apk && \
./out/Debug/bin/run_cronet_smoketests_missing_native_library_instrumentation_apk && \
./out/Debug/bin/run_cronet_test_instrumentation_apk \
--test-filter=org.chromium.net.smoke.*

The output jars that contain the smoke tests:
./out/Debug/lib.java/components/cronet/android/cronet_smoketests_missing_native_library_java.jar
./out/Debug/lib.java/components/cronet/android/cronet_smoketests_native_java.jar
./out/Debug/lib.java/components/cronet/android/cronet_smoketests_platform_only_java.jar

BUG=669264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2561803002
Cr-Commit-Position: refs/heads/master@{#440760}

The PersistentHistograms feature is currently enabled through field trials, so
it is not yet used on offical builders, where the fieldtrial_testing_config is
not applied. Whether or not this feature is enabled affects how browser tests
need to force-synchronize renderer-side histograms before samples can be
verified on the browser-side.

This CL makes Safe Browsing subresource filter browser tests support both
methods.

BUG=677020,637415

Review-Url: https://codereview.chromium.org/2603773002
Cr-Commit-Position: refs/heads/master@{#440759}

BUG=659732
TEST=manual

Review-Url: https://codereview.chromium.org/2605703002
Cr-Commit-Position: refs/heads/master@{#440758}

[Sheriffing] Mark (virtual/threaded/)inspector/tracing/timeline-js/timeline-script-tag-1.html as flaky on Win7 Dbg

BUG=677145
TBR=pfeldman
NOTRY=true

Review-Url: https://codereview.chromium.org/2598413002
Cr-Commit-Position: refs/heads/master@{#440757}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7b1dc4fe..df882a1d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2605693002
Cr-Commit-Position: refs/heads/master@{#440756}

This is the last patch of the items placement data refactoring. By using
a different Grid instance in computeIntrinsicLogicalWidths we effectively
isolate the intrinsic size computation from the layout. They are now using
different data structures so they don't interfere each other.

This also means that we no longer reuse the placement of items done in the
intrinsic size computation. That shouldn't be a big issue because we do save
the position of items between layouts.

Last but not least, this patch finally removes the ugly const_cast's we had
in computeIntrinsicLogicalWidths() as we no longer modify the internal state
of LayoutGrid.

BUG=627812,666688

Review-Url: https://codereview.chromium.org/2589143002
Cr-Commit-Position: refs/heads/master@{#440755}

Disables this test because it fails on ios-canary. Filed a bug to
track this disabled test (see BUG=).

BUG=677121

Review-Url: https://codereview.chromium.org/2602743002
Cr-Commit-Position: refs/heads/master@{#440754}

This test is flaky on ios phone devices on dowstream bots.

BUG=677129

Review-Url: https://codereview.chromium.org/2602753002
Cr-Commit-Position: refs/heads/master@{#440753}

If there is no network connection, the read next gesture should open the
first distilled article if some exists.
This is case A1 of attached bug.

BUG=669897

Review-Url: https://codereview.chromium.org/2607523002
Cr-Commit-Position: refs/heads/master@{#440752}

This CL includes
1.Making ChromePasswordManagerClient to be InputEventObserver
2.ChromePasswordManagerClient subscribes itself on InputEvents on navigation of main frame.
3.Implementing class PasswordReuseDetectionManager, that will manage all password reuse relate stuff. Currently it saves only keystrokes in string.
4.Client propagates keystrokes to PasswordReuseDetectionManager

Calling PasswordStore for verification of password reuse will be done in later CLs.

BUG=657041

Review-Url: https://codereview.chromium.org/2472133004
Cr-Commit-Position: refs/heads/master@{#440751}

Currently AGSA only uses ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR. The experiment
will not take effect on these origins. Other 1st party apps are not using this
prerender::Origin, as far as we know, and the use of it is restricted to 1st
party, hence this change should not affect the experiment for other Android
apps.

BUG=640592

Review-Url: https://codereview.chromium.org/2600893002
Cr-Commit-Position: refs/heads/master@{#440750}

Just a clean-up. Spotted an unused data member when looking at
PasswordFormManager, so this CL removes it.

BUG=621355

Review-Url: https://codereview.chromium.org/2606703003
Cr-Commit-Position: refs/heads/master@{#440749}

The state keys are not generated as long as the time hasn't been
synchronized. These changes fix the case when the state keys generation
is late, possibly for the network missing reason, and the controller
hits the timeout.

The timeout can happen at establishing the ownership, or later at
state keys check. Without state keys check we cannot assume we can
skip FRE. If the ownership is established and FRE can be skipped
(OWNERSHIP_TAKEN or OWNERSHIP_UNKNOWN), the new state is set
immediately, so the timeout cannot trigger.

TEST=Manually tested on a falco chromebook.

BUG=673270, 645464

Review-Url: https://codereview.chromium.org/2587033002
Cr-Commit-Position: refs/heads/master@{#440748}

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2598833002
Cr-Commit-Position: refs/heads/master@{#440747}

This change connects the ServiceWorkerPaymentAppBridge to the service
worker payment app code in content/browser/payments. This allows
installed service worker payment apps to show up in the Payment Request
dialog.

I also replace "String scopeUrl" with "long registrationId" as the
identifier for service worker payment apps.

This code is protected by the kServiceWorkerPaymentApps feature flag.

BUG=661608

Review-Url: https://codereview.chromium.org/2586213002
Cr-Commit-Position: refs/heads/master@{#440746}

isfinite() check is unnecessary here because -Infinity and +Infinity will be
converted to NaN in i::JSDate::New(), which is called by v8::Date::New.

This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2602723002
Cr-Commit-Position: refs/heads/master@{#440745}

Modify the list based on the latest Mali GPU
https://www.arm.com/products/graphics-and-multimedia/mali-gpu

BUG=NA
Signed-off-by: sujiths.s <sujiths.s@samsung.com>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2593013002
Cr-Commit-Position: refs/heads/master@{#440744}

This CL records if the Reading List entry is displayed as the online or
offline version.

BUG=651041

Review-Url: https://codereview.chromium.org/2570463006
Cr-Commit-Position: refs/heads/master@{#440743}

This crash occurred when a ServiceWorkerControlleeRequestHandler was
created to handle a subresource request for a provider host with a
controller, but by the time MaybeCreateJob() was created the controller
and active version was removed due to
ServiceWorkerRegistration::DeleteVersion().

In this case, we just tell the URLRequestJob to abort with error rather
than handle the error (e.g., by fall back to network). We don't want to
silently hide the exceptional case in case some bug makes this happen
often.

Also add some general comments and DCHECKs in ServiceWorkerProviderHost
to clarify controller vs active version.

BUG=655910

Review-Url: https://codereview.chromium.org/2604763002
Cr-Commit-Position: refs/heads/master@{#440742}