- 04 Dec, 2017 40 commits
-
-
Theresa Wellington authored
This reverts commit 48a0f056 and re-enables the #testSearchBookmarks_Delete. In order for this test to pass on tablets, special handling of the search state while updating the native page's URL was added. BUG=791485,789910 Change-Id: I43133858518754fa321e563a81982432eec98b93 Reviewed-on: https://chromium-review.googlesource.com/806932Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521527}
-
Yves Arrouye authored
https://chromium.googlesource.com/chromiumos/platform/system_api/+/5c4b603461a79a731cfcb4554f244a42f7e8679d 2017-11-29 drcrash Constant for the new DBUS API TpmAttestationSignEnterpriseVaChallenge BUG=b:69687094 TEST=Sync with this Change-Id: I3128234598e306d06d2e709b75d9719d983cb9e0 Reviewed-on: https://chromium-review.googlesource.com/806764Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#521526}
-
Stephen Martinis authored
This clarifies the meaning of forward slashes in artifact file paths, and also clarifies the directory these paths are relative to, when no artifact permanent location is set. Bug: 775619 Change-Id: I1f41d86273455123823350a39b239cc04b6a0216 Reviewed-on: https://chromium-review.googlesource.com/802092 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521525}
-
kylechar authored
Add calls in VizProcessTransportFactory to register HWNDs. This code is the same as in GpuProcessTransportFactory. The registration of child HWND can happen later with viz and the display compositor in the GPU process. As a result, VizProcessTransportFactory can request calling SetParent() too early. Remember that the browser requested calling SetParent() and when the child is registered call it then. InProcessCommandBuffer assumed it was in the browser process and directly called ::SetParent(), which isn't allowed by the GPU sandbox. Use the same mechanism used by GpuCommandBufferStub to forward the SetParent() request to the browser. This requires providing the GpuChannelManager to InProcessCommandBuffer. Bug: 787099 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2ff351bc90a3f0871149608ad5b6457a1a6cebbc Reviewed-on: https://chromium-review.googlesource.com/779244Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#521524}
-
Mitsuru Oshima authored
BUG=773461 TEST=None Change-Id: I2dd813cd873e7b437606085784543b1a3d72dc95 Reviewed-on: https://chromium-review.googlesource.com/801090Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521523}
-
Eric Caruso authored
This component will be used to serve modem helper programs and firmware blobs. BUG=b:37953355 Change-Id: I91e23b96448f7e6c472ab58777ef284b091c0886 Reviewed-on: https://chromium-review.googlesource.com/801980Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Eric Caruso <ejcaruso@chromium.org> Cr-Commit-Position: refs/heads/master@{#521522}
-
Renjie Liu authored
original owner: amoylan@chromium.org original cl: https://chromium-review.googlesource.com/c/chromium/src/+/754255 This CL is part of the implementation of public-IP-only geolocation as described in the design doc: https://docs.google.com/document/d/1oSQM3GEMTL1raWLYv8S6_Yyt93FF2zQbANI4bKJ6LDs This part is a new Mojo interface PublicIpAddressGeolocationProvider that provides mojom::Geolocation implementations using the PublicIpAddressGeolocator (from the upstream dependent CL). In a subsequent CL, DeviceService will provide this implementation of PublicIpAddressGeolocationProvider via ServiceManager. Change-Id: I2458c816b5a861a409ab2b3a5defa8d80444c59e Reviewed-on: https://chromium-review.googlesource.com/784533Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Renjie Liu <renjieliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521521}
-
bsheedy authored
Switches WebVrTransitionTEst#testControlsVisibleAfterExitingVr to use enterPresentationOrFail, as before it was waiting for a non-existent JavaScript step to finish, which added ~10 seconds onto each test run. Bug: Change-Id: I2170941f78ac900b9dde57ac9fa5d70cdd43c8c0 Reviewed-on: https://chromium-review.googlesource.com/806247Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521520}
-
Yutaka Hirano authored
This CL sets the outstanding limits for ResourceLoadScheduler for the experiment, and disables the body detection logic from ResourceScheduler. Bug: 785770 Change-Id: I178d65da2681a1790dc1fc67c1318d9c809007a7 Reviewed-on: https://chromium-review.googlesource.com/799612 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#521519}
-
Marti Wong authored
Fix the incorrect bottom inset of bookmarkTableView which is set when keyboard appears for editing new folder name. (This causes the new folder being "pushed" to the top of the screen on iPad.) Screenshot: https://drive.google.com/file/d/1q_w8bRICkEQmOgApFM1wG79UBLJ_EReS Bug: 790046 Change-Id: Ic331244b9f49d77ef0b01edf20252ae4cec2e88d Reviewed-on: https://chromium-review.googlesource.com/805179Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521518}
-
Roger McFarlane authored
The data driven tests in form_structure_browsertes.cc were navigating to test pages using data URLs. These have no way to generate relative URLs for form actions, so the output was being generated incorrectly for forms that would be evaluated as !ShouldBeParsed due to having "search" actions. This CL uses the embedded test server to serve the test pages instead. Bug: 789944 Change-Id: I9bdb6fa376dba070195d125807fb5e4b5443a203 Reviewed-on: https://chromium-review.googlesource.com/804054 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#521517}
-
Yuzhu Shen authored
This significantly reduces non-Android chrome size. With an official build on Linux, before the change - resources.pak 12230694 after the change - resources.pak 12069587 The difference is about 160KB. Bug: 699569, 718047 Change-Id: I2d2f6985cb10c27637a8a7d478001b18ac1b8111 Reviewed-on: https://chromium-review.googlesource.com/804974Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521516}
-
Vladimir Levin authored
This patch adds glUniformLocation function to be passed to Skia, since it creates it when used on windows. Running cc_unittests with --use-gpu-in-tests triggers an assert without this patch, and passes with. I've also verified that the similar behavior happens on poster circle. R=piman@chromium.org, enne@chromium.org, bsalomon@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie015bdf751e00ef9aa1f15ae6274fc26ae329249 Reviewed-on: https://chromium-review.googlesource.com/804951Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521515}
-
Matt Menke authored
Adds an API to the NetworkService so that it can take in a mojom::ProxyResolverFactory, and makes Chrome's CreateDefaultNetworkContextParams method add an InterfracePtr that points at ChromeMojoProxyResolverFactory. Also moves ChromeMojoProxyResolverFactories from the IO to the UI thread, and removes the old code to create them from the legacy IOThread and ProfileIOData classes. Bug: 754007 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I89f77ddfb9511494f1f32a596f3a67509cd5b1e3 Reviewed-on: https://chromium-review.googlesource.com/768216 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521514}
-
Lei Zhang authored
Change-Id: I5dba826a1ff92c0032e1de442c206497a318b91c Reviewed-on: https://chromium-review.googlesource.com/805154 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521513}
-
Alexey Kozyatinskiy authored
WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization. This test is passing locally. TBR=dgozman@chromium.org Bug: chromium:432444 Change-Id: I854aa9d72932d788f71724e84720a6529a6b5f4a Reviewed-on: https://chromium-review.googlesource.com/806924Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521512}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a0aa5fd..05bcbe6 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I139cafc18b4884582b160f347c330329d1a42448 Reviewed-on: https://chromium-review.googlesource.com/806725Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521511}
-
Bret Sepulveda authored
The methods appear to have been added long ago to support an old design of the Task Manager. Bug: Change-Id: Ief7019d0017ae187040542a580dfb7e99abf5cf8 Reviewed-on: https://chromium-review.googlesource.com/803746Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#521510}
-
Dmitry Gozman authored
This is a reland of b42d3973 Original change's description: > [DevTools] Move DevToolsFrontend implementation from content/renderer to blink > > Bug: 776009 > Change-Id: I949313b261ae074844d1da349570e1e0a8e23744 > Reviewed-on: https://chromium-review.googlesource.com/739746 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516193} TBR=pfeldman Bug: 776009 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If426bbed212bc3a2f11af9fa0e019ef1dc53742d Reviewed-on: https://chromium-review.googlesource.com/768433Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521509}
-
Simon Que authored
Instead of each log source having to handle anonymization, just let the feedbackPrivate API handle it. Bug: 787554 Change-Id: I8e25235fe2aa2f01aeed4e32c4f23aa925712367 Reviewed-on: https://chromium-review.googlesource.com/806681 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#521508}
-
Scott Violet authored
Setting --viz in AuraTestHelper means we can't run tests as they would run when --mus is specified on the command line. If this is necessary, it's better to push to the testsuite. BUG=786453 TEST=none Change-Id: I4b6f6b9685f16abdcf4c8e69347239368ad9a6b3 Reviewed-on: https://chromium-review.googlesource.com/806797Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521507}
-
Albert J. Wong authored
Previous refactors focused on moving the public free functions in the headers to methods. This CL focuses on the private functions including renaming a number of the functions so they have clearer semantics. There was some splatter into PartitionPage and PartitionFreelistEntry, but the majority of changes in those classes are reserved for a followup CL. No functionality change should be introduced here. See related bug for more details on methodology. Bug: 787153 Change-Id: I4e7c8c8364ba1257d1f42c83954565dfacbd57e3 Reviewed-on: https://chromium-review.googlesource.com/791514 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#521506}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/7ffbcf909d36..60b1b6e76e98 $ git log 7ffbcf909..60b1b6e76 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 angle-deps-roller Roll skia/third_party/externals/angle2/ d5f44c986..f5be5bafa (1 commit) 2017-12-04 reed helper api to force a raster image 2017-12-04 csmartdalton turn on extended Clang warnings on Windows too 2017-12-04 mtklein Only look at gamut_transform if we wrote to it. 2017-12-04 robertphillips Add resource cache limits to SkSurfaceCharacterization 2017-12-04 benjaminwagner Fix recipe comments for ASAN. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Id5869fc7a46e8ab849f2ccc9d427fcfd55979b43 Reviewed-on: https://chromium-review.googlesource.com/806324Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521505}
-
Derek Cheng authored
This reverts commit 1d862dda. Reason for revert: broke WinMSVC64 (dbg) compile: histogram_percentile_counter.obj : error LNK2019: unresolved external symbol "struct rtc::nullopt_t const rtc::nullopt" (?nullopt@rtc@@3Unullopt_t@1@B) referenced in function "public: class rtc::Optional<unsigned int> __cdecl rtc::HistogramPercentileCounter::GetPercentile(float)" (?GetPercentile@HistogramPercentileCounter@rtc@@QEAA?AV?$Optional@I@2@M@Z) rate_statistics.obj : error LNK2001: unresolved external symbol "struct rtc::nullopt_t const rtc::nullopt" (?nullopt@rtc@@3Unullopt_t@1@B) string_to_number.obj : error LNK2001: unresolved external symbol "struct rtc::nullopt_t const rtc::nullopt" (?nullopt@rtc@@3Unullopt_t@1@B) Original change's description: > Roll src/third_party/webrtc/ 83d27683a..31cee3a0d (7 commits) > > https://webrtc.googlesource.com/src.git/+log/83d27683a83d..31cee3a0d51e > > $ git log 83d27683a..31cee3a0d --date=short --no-merges --format='%ad %ae %s' > > Created with: > roll-dep src/third_party/webrtc > BUG=None,None > > > The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: Idbcb75f5fe9f49ddb5b3f8718dbfe8b2dfb698a3 > Reviewed-on: https://chromium-review.googlesource.com/806321 > Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org> > Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521486} TBR=webrtc-autoroll@chromium.org,webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe6c064ed64c8563c6e86b07ac655c3dcee159ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/807208Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521504}
-
Nate Fischer authored
No change to behavior. This adds missing @Override Java annotations in AndroidNetworkLibrary. This resolves an errorprone compiler warning. Test: ninja net_java (fewer compiler warnings) Change-Id: I9b621aec75690ecaba422363796d038d73fc0ca1 Reviewed-on: https://chromium-review.googlesource.com/806749Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521503}
-
John Abd-El-Malek authored
This helps with debugging. Bug: 598073 Change-Id: I72d92c5b4870e4b1e985ae1a2442980b08dbe34c Reviewed-on: https://chromium-review.googlesource.com/806800Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521502}
-
Xiaohan Wang authored
Prefer UmaHistogram* function to using the histogram directly. Change-Id: I9eb38bf856c76fe50ff094a7728ef1f7aebe239a Reviewed-on: https://chromium-review.googlesource.com/804697Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521501}
-
Sergei Datsenko authored
Test setting and getting cookies. Test window location access from fragments. Bug: chromium:787197 Change-Id: I8dd9b16ebdfe5680a4977ec1e416b6447a70d44a Reviewed-on: https://chromium-review.googlesource.com/805182Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#521500}
-
xlai authored
The original metric Blink.Canvas.ToBlob.IdleEncodeDuration is only computing the total time on encoding on idle task EXCLUDING the time when system is waiting for idle task to start. But this information is very crucial in determining the threshold for kIdleTaskCompleteTimeoutDelay. Bug: 787972 Change-Id: I2855e4ea054c1eaeb73742662e98116ade8d3c62 Reviewed-on: https://chromium-review.googlesource.com/789431 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521499}
-
John Abd-El-Malek authored
BUG=776589 Change-Id: I51507a0dee08bcaa6531dee4dcf9b03d264de103 Reviewed-on: https://chromium-review.googlesource.com/806928 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521498}
-
Christopher Grant authored
This change does the following: - Splits the input field into text, hint and cursor elements. - Removes the need to re-render text when the cursor blinks. - Supports a text hint, shown when the field is empty. BUG= Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifbf32560cb7003f4d8951bea871680facd5c0a81 Reviewed-on: https://chromium-review.googlesource.com/804114Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#521497}
-
Kurt Horimoto authored
Bug: 778014 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id8f56f26497bd89c25494a2ae6a210c2e0445d0f Reviewed-on: https://chromium-review.googlesource.com/802997 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#521496}
-
Robert Sesek authored
- {"firstexception","lastexception"}{,"_bt"} - "toolbar-nib_info" - "sendaction" - "nsevent" Bug: 598854 Change-Id: Id5ea8c7dbdd328452234763c065f946908fcea15 Reviewed-on: https://chromium-review.googlesource.com/804214 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521495}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 557e241c. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6908 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/FileAPI TBR=qyearsley No-Export: true Change-Id: I7c7d93d652cff833679583d11c0fa6155d7f2574 Reviewed-on: https://chromium-review.googlesource.com/806680 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521494}
-
Evan Stade authored
Bug: 783018 Change-Id: Ic1340627bacde0109e92afd45b2cb3c164dd9594 Reviewed-on: https://chromium-review.googlesource.com/783661Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#521493}
-
Devlin Cronin authored
s/const char/constexpr const char Bug: None Change-Id: I78e88bcaa3319f61cfbd0a096ff37d8947d23833 Reviewed-on: https://chromium-review.googlesource.com/804862Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521492}
-
jkereliuk authored
This is intended as a temporary fix since the current commit position for version 62 points to a revision that is actually listed as 63. Bug: Change-Id: I9aa73ac1e9f9712b84893c08e7d8c07d333df3ab Reviewed-on: https://chromium-review.googlesource.com/806762Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521491}
-
Nate Chapin authored
It had a custom implementation to support use of RawResourceClientStateChecker. Separate these. The original version (https://chromium.googlesource.com/chromium/src/+/ae15c13530084329ac2509ccded45428d7d7d2c8) failed to update DocumentThreadableLoader::Trace(). It introduced an intermediate subclass, ResourceOwner<RawResource>, between DocumentThreadableLoader and RawResourceClient, but because Trace() wasn't updated, ResourceOwner::resource_ was left untraced. The GC clang plugin would normally catch a mistake like this, but the plugin ignores ResourceOwner due to https://crbug.com/652966, so it wasn't detected at compile time. Bug: 790778, 640291 Change-Id: I114df7eaa97139fbb6aa70b22b2f41019988631f Reviewed-on: https://chromium-review.googlesource.com/806753 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#521490}
-
Wez authored
These tests flake under Fuchsia, suggesting that the ordering of NetLog events assumed by the tests may not always be valid, e.g. due to concurrency in resource delivery over QUIC. The additional EXPECTations will cause more detail to be reported about what was actually NetLog'd. The tests are also renamed to better express their purpose. Bug: 775122 Change-Id: Ia1c8aa898d27db2faafd2e79d705b724a7704843 Reviewed-on: https://chromium-review.googlesource.com/806760Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521489}
-
Yuwei Huang authored
According to the mock, separators should go between sections, not items. This CL fixes the style according to the mock. Given that this changes the UI of the app, it might be better to check in this after the M64 branch point. Before: https://drive.google.com/a/google.com/file/d/1cosHV0dLNdIraqZCQhE0M0La9b6fDn6B/view?usp=sharing After: https://drive.google.com/a/google.com/file/d/1s_ZtlUMztnkr-QdU1-04ssxw-m2iLXHH/view?usp=sharing Bug: 786616 Change-Id: If4975398b7fd0da0a0884ee4b009c3098f05de42 Reviewed-on: https://chromium-review.googlesource.com/783817 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#521488}
-