GitLab

If a downloads ends with content length mismatch errors, Chrome will
try to resume it automatically.
However, less than half of the downloads actually completes with more
data received.
This CL adds some UMA for us to understand why the remaining download
fail.

BUG=968833

Change-Id: Iaf3bec605a96880316ced34437a99e0527978b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637645
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666130}

https://chromium.googlesource.com/catapult.git/+log/dd7a2ceeb49e..3344e16e55cf


git log dd7a2ceeb49e..3344e16e55cf --date=short --no-merges --format='%ad %ae %s'
2019-06-04 dalecurtis@chromium.org Fix media video playback metrics.


Created with:
  gclient setdep -r src/third_party/catapult@3344e16e55cf

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:965682
TBR=charliea@google.com

Change-Id: Ie6d668d9c61d8e627c58192166d98aeddbcedb00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643157Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666129}

Bug: 953376
Change-Id: I7c2bf8a54481bb31ead4eeb86c15510228a10988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575818Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666128}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/71c6bc07e67f..d2f31cc65dea


git log 71c6bc07e67f..d2f31cc65dea --date=short --no-merges --format='%ad %ae %s'
2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@d2f31cc65dea

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I8e3766af34f528ab9e283f085b4a50e3c4db0153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644235Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666127}

Bug: 960079
Change-Id: I89a941438cb05163f99dd5b773602e37c2c4ae4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642270Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666126}

This is a reland of a9d56928

Original change's description:
> [omnibox] Rename the ZeroSuggestProvider::ResultType values
> 
> This CL renames the ZeroSuggestProvider::ResultType values to be
> more descriptive, and adds more commentary.
> 
> They used to imply that we asked the default search provider for
> zero-suggestions, which was sometimes misleading, since that's not
> always true.
> 
> Bug: 963173
> Change-Id: I85a55cb57749441d2adfdb53642247fd055b7d9a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631903
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665330}

Bug: 963173
Change-Id: I206a4fd36189e2400bfd754ac4f0fba4ab076075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640160
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666125}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I93c43042ae115a7ae363e7c681710bdc51a426d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644234Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666124}

This CL drives Favicon visibility with fade-in/out animator. Also
keeps the size of favicons consistent.

|EphemeralTabLayer::GetLocalFaviconImageForURL| is replaced with the
notification via |FaviconDriverObserver|. |GetLocalFaviconImageForURL|
provides favicons that are already available in local history db
only. Relying soly on it caused a bug not updating favicon for
newly visited pages. FaviconDriverObserver addressed the problem.

If navigated to a page from a domain different from the current one,

1) reset to a default favicon
2) show the new one as soon as we're notified of the new favicon.

Note that these operations do not happen if navigated to a page within
a same domain. This is checked by the host name of URL being visited.

Bug: 929727
Change-Id: I716f9c03b31c513a7eb00dd286018a7a200cbde3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605381
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666123}

Enforce CSP checks for fetch in isolated worlds. Also add tests for fetch usage
in isolated worlds and its interaction with CSP. This also exposes a bug with
the current handling of redirects as far as bypassing the main world CSP is
concerned.

Since the IsolatedWorldCSP feature is disabled by default, this CL will cause
the CSP check to use an empty CSP instead of just bypassing the CSP checks for
isolated worlds. In practice, this should cause no behavior change.

BUG=896041

Change-Id: I4778112e3c5e7f6fcb2f2849eca6ed7ef384f65e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633531
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666122}

Hide Quick Settings feature pods and some top-row shortcuts in Kiosk
Next sessions.

This also moves the SignOutButton's visibility logic to
TopShortcutsView, simplifying the button itself. This is in line with
how the other top-row shortcut buttons work.

Depending on user feedback, follow-up work might add some feature
pods back in, or remove the collapse/expand option. If we start
diverging more substantially from the normal Quick Settings, we can
create KioskNext versions of these classes instead.

Bug: 966890
Change-Id: I4c84e39021f213ca24fe8fcc39dd9b53a3119491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638880
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666121}

This is the first CL for upstreaming TabSelectionEditor. This CL
refactors TabGridViewHolder to support creating different ViewHolders
for a RecyclerView based on the provided item view type.

Change-Id: I94aa3c92875b31b0f9f79d4ce0e0c56b43ef9392
Bug: 970087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642140Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666120}

Disables SplitView when KioskNextShell is enabled.

Also disables snapping and the drag/snap indicators when
split view is disabled.

Bug: 966889
Test: run ash_unittests; manually by dragging windows in Overview Mode
      in a KioskNext session

Change-Id: Idb7a6c57ac89144af726ca3480fba5eaae12c3a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636907
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666119}

Updates NativeFileSystemDirectoryHandleImpl::GetChildURL() to return a
base::File::Error for invalid |name| input.  |name| must specify a
direct child of the current directory.  Invalid |name| inputs include:

 1. Empty string: ''
 2. Current directory: '.'
 3. Parent directory: '..'
 4. Strings containing path separators like '/'

Updates the callers of GetChildURL() to handle errors by immediately
running callbacks with the base::File::Error returned by GetChildURL().

Extends existing NativeFileSystem API webtests by adding invalid 'name'
input tests for each JavaScript API with a 'name' parameter, including
getFile(), getDirectory(), moveTo(), and copyTo().

Bug: 960411
Change-Id: Ida6ebf1cb2d1017e2cafe386c30d5cb65430055c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643984
Commit-Queue: Steve Becker <stevebe@microsoft.com>
Auto-Submit: Steve Becker <stevebe@microsoft.com>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666118}

Now that dictionary can be used as a member of a union type, so this
CL changed NDEFRecordData type from "any" to the Spec defined union.

Bug: 935912, 520391
Change-Id: Ib6ab361fa6a4087a2e14f4e9eb20b4a949155c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628587Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Donna Wu <donna.wu@intel.com>
Cr-Commit-Position: refs/heads/master@{#666117}

Bug: 969600
Change-Id: I3e181e886c2acdb5bc0ffd2cd6ab18d7282bb28f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642610
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666116}

The current understat histogram includes reloads (and forward/back nav)
but reloads aren't actually candidates for previews now. This adds an
understat histogram limited to new navigations that are user initiated
so that it will be easier to compare just the new nav impact to the
current overall understat.

Bug: 965969
Change-Id: Ia3fb766335a9bdf3b4c22eafa08467d5a05c9d8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637671Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666115}

Bug: 970122
Change-Id: I68ac5251950a3c218fbc4edfe9aa1c7a05e061f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642947Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666114}

MESA_framebuffer_flip_y needs the allocated framebuffer
to be setup to the same orientation.

BUG=964010
TEST=https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html?webglVersion=2

Change-Id: If7b7aaec176387e47c46c4f7337d686536375e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641666Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666113}

This CL uses the BackgroundTaskCoordinator to scedule background task
with platform API.

Bug: 963283,930968
Change-Id: I9d6af682cdc456f66dcab88997eee08acab11320
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639560
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666112}

- Fix two OWNERS files that pointed to //ui/keyboard instead of
  //ash/keyboard.
- Moved ash/keyboard/ui/OWNERS to ash/keyboard/OWNERS as they just
  pointed to the same thing.
- Added OWNERS to c/b/ui/ash/keyboard that points to ash/keyboard/.

Bug: 961568
No-Presubmit: true
Change-Id: Iebb1d3bde2e3e22a02fb3216d1967a1abb49abb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638077
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666111}

This is a reland of 53dfd8ca

An unrelated 32-bit build break in openscreen caused this patch to be reverted, since we added additional dependencies on openscreen and its platform code. That break has been fixed andthe openscreen dependency has been rolled, so this patch should be good to land.
Original change's description:
> Add plumbing for mDNS Open Screen support
>
> This patch adds classes to implement the mDNS interfaces
> that Open Screen expects, using the discovery system inside of
> Chromium.
>
> Change-Id: I450b757241ff99a59ec59f5352a0b604f729b9db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590536
> Commit-Queue: Jordan Bayles <jophba@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664404}

Change-Id: Ib915525a2e07da28997ee04bf534e7e4ae2de415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639366
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666110}

This will be submitted after
https://chrome-internal-review.googlesource.com/c/infradata/config/+/1358391

Bug: 954450
Change-Id: I15bbf07503fa8bead3661dc69c8249796bce6c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642494Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666109}

Change-Id: I196e6dbc5fcd878d8867d52c1a3b60e04b26a046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641995
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666108}

NGMappingUnitsRange does nothing but a base::span<>. So this patch
replaces it with base::span<> to reduce unnecessary code.

Change-Id: I5bafa4b26cb7539876096cd89e31d10f00f393c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642160
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666107}

- Made the "Settings" menu text a level 1 heading for screen readers
  to meet WCAG 1.3.1 Info and Relationships success criteria.
  See: https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships

- Added an axe-core accessibility test for the settings menu.

Screenshot: https://i.imgur.com/yhUG2D7.png

Bug: 963183
Change-Id: I0063aa33e99dedfdefb94e14905ed833cfc5fcb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618279Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: John Emau <johnemau@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#666106}

Cleans up all remaining TODOs pointing to 926048, which covers adding
WMR support to the XR browser tests. Specifically, this properly
implements controller and pointer poses using the data provided by
the test instead of using hard coded values.

Bug: 926048
Change-Id: I014781127e8d7e5151a1766ad2a8d28761140ecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642960Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666105}

We are not supposed to call FrozenNativePage.getView().
This is no-op in Release build.

Bug: 952331
Change-Id: I10fe58f1daaaa4f5b42c913a8c0cbd6685441ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643071Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666104}

In order to move off of the browser IO thread this CL replaces a number
of thread API usage with sequence APIs instead.

Bug: 960012
Change-Id: I8f66c05c53dad55fcbe3347b4fbb1f49b8f0e6d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643668Reviewed-by: Staphany Park <staphany@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666103}

And don't pool QUIC requests with different NetworkIsolationKeys when
kPartitionConnectionsByNetworkIsolationKey is enabled.

BUG=963480

Change-Id: I41a3bf3f4f0a24a5bfc264de46fc28e1f880d46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629227
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666102}

Add addVirtualAuthenticator and removeVirtualAuthenticator to the
WebAuthn Devtools Domain. Patch VirtualFidoDevice so that it no longer
hardcodes the transport declared on attestation, this makes testing
different authenticators easier.

This is one in a series of patches intended to create a Testing API for
WebAuthn, for use in Web Platform Tests and by external webauthn tests.

For an overview of overall design, please see
https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing

Bug: 922572
Change-Id: Ib606a265576b8059d3a347c63b26a30574136538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636828
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666101}

- Updates label of the PPD file selection for advanced printer dialog
  and for edit printer dialog.
- Learn More link will be updated to point to correct URL.

Bug: 939899
Test: End to End manual
Change-Id: Ie759ae625263ce5f758d3a045b72e1565efeec6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636396Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666100}

TBR=meacer@chromium.org

Change-Id: I8107a1e11daa2b939386c5dc92e2c20ff383b029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644302Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666099}

TBR=mlamouri@chromium.org

Bug: 970866
Change-Id: Ib8911bc25d886d5771ee7b80c9fbc91202a05b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644164Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666098}

TBR=ahemery@chromium.org

Bug: 970841
Change-Id: Ib51b648e2fd09251b058b943d49b8458727c4800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644015Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666097}

The Abort operation is triggered by the RP, and returns the AbortError.
The current error massage for AbortError is "The user aborted a
request.". The change makes the AbortError massage as
"The Rely Party aborted a request."

Bug: n/a
Change-Id: Iea3991f930ba039d05ec7279aa4b3191303c836f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642685Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Suzy Li <suzyli@google.com>
Cr-Commit-Position: refs/heads/master@{#666096}

I'm planning to remove protocol::Serializable::serialize(bool),
removing the ability there to make a ProtocolMessage
that carries JSON. This is the last usage of such messages
in both Chromium and V8; so I've put a bit of conversion
boilerplate code which is borrowed from
content/browser/devtools/devtools_protocol_encoding.cc.
Sadly it's longer, but it is a price to pay for simplifying
the API. Thanks much for considering.

Change-Id: I24a01e1ed6134f58fa65f03d29506afa33a7ff01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641551
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666095}

Sets event policy to None on all transient ancestors to match behaviour
of main window.

TBR=afakhry@chromium.org

Test: ash_unittests ScopedOverviewTransformWindowTest.EventTargetingPolicy
Bug: 963394
Change-Id: Ic4b2f67648a2582d677d989aeda1e83b235e9d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643349Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666094}

This CL moves part of the code from registerPaint into a new API
in PaintWorklet. The reason is that these code are working on a
member that is in the PaintWorklet class, so it really should belong
to the PaintWorklet class.

Bug: None
Change-Id: If8c0eb0390d8c64d2fedb48a1a337e6981c11f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644007Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666093}

This flag specifies whether to target the platform's copy of the HWASan
runtime, rather than one bundled with the application.

I decided to make this a build flag rather than change the default because
there are use cases for both settings.

- Builds with hwasan_platform=true may only be used on HWASANified builds of
  the platform.
- Builds with hwasan_platform=false are only expected to work on
  non-HWSANified builds of the platform. They may work in HWASANified builds,
  but this is not guaranteed because the compiler is allowed to target the
  bundled runtime library which may have a different ABI to the platform's
  copy.

Moreover, hwasan_platform=false requires the compiler to emit additional
code into each function which can hurt performance and binary size.

Bug: 916828
Change-Id: I45c9ccdc0a5cf1b3c6a729263204a023b40ba15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642787
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666092}

This also adds extra scenarios.
* Resizing with overview on the other side.
* touch event

I also found the scenario that splitview controller can be
called recursively during shutdown, which is fixed by the change
in SplitViewController

Bug: None
Change-Id: I293ed17bba4961d338ac0f9a389f42f8f233d4ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637244
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666091}