GitLab

Add metrics for the new Clear Browsing Data dialog on Android.
A histogram and actions are used to record which tab was used for a
deletion.
Time period changes are recorded as actions.
A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded
twice because the new dialog creates two instances of
ClearBrowsingDataPreferences.

BUG=731120

Review-Url: https://codereview.chromium.org/2927063002
Cr-Commit-Position: refs/heads/master@{#478602}

An experimental class is now generated as well as the regular one, and is linked within 
the main class.  Just like in the C++ bindings the experimental class contains everything.
The class methods generated now start with a lowercase letter (same as in the protocol).
Some stray white space has been removed from the template.

Bug: 
Change-Id: I4e0d8e0f04990e9f635cab71fea18c1f21111754
Reviewed-on: https://chromium-review.googlesource.com/529070
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478601}

BUG=729633
TEST=VoiceOver

Review-Url: https://codereview.chromium.org/2931503002
Cr-Commit-Position: refs/heads/master@{#478600}

BUG=622743

Review-Url: https://codereview.chromium.org/2924013005
Cr-Commit-Position: refs/heads/master@{#478599}

BUG=722374

Review-Url: https://codereview.chromium.org/2891933002
Cr-Commit-Position: refs/heads/master@{#478598}

Prior to this CL, removing an Android resource wouldn't actually remove
it from the final APK.

This CL adds each resource to depfile_deps so that building after
removing an Android resource will work as expected (after a gn gen -
which is required when adding a resource as well).

Bug: 730099
Change-Id: I9429b61fa19c2c8e3d21df3e30119ba7c6bdec01
Reviewed-on: https://chromium-review.googlesource.com/527492Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478597}

This CL changes layouts of account rows to confrom to Material spec and bring
consistensy to the account lists.

Bug: 701221, 722910
Change-Id: Ie70304cb9c9254335bbe7aaa94ac5e7d9c2ff519
Reviewed-on: https://chromium-review.googlesource.com/527098Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478596}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/113a309a..3a15e30f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2934753002
Cr-Commit-Position: refs/heads/master@{#478595}

Revert of Align `clear-site-data` syntax with the spec. (patchset #2 id:20001 of https://codereview.chromium.org/2929593002/ )

Reason for revert:
Despite passing all the bots, this apparently breaks `content_browsertests`: https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=57936. So, let's go fix that.

Original issue's description:
> Align `clear-site-data` syntax with the spec.
>
> We've shifted from an explicit JSON dictionary to a list of quoted
> strings (that can be parsed as JSON for forward-compatibility). That is,
> rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
> we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.
>
> Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27.
>
> BUG=607897
>
> Review-Url: https://codereview.chromium.org/2929593002
> Cr-Commit-Position: refs/heads/master@{#478585}
> Committed: https://chromium.googlesource.com/chromium/src/+/085b57ffe70b6cb90cd77b61585babcf59df3a95

TBR=msramek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607897

Review-Url: https://codereview.chromium.org/2933083002
Cr-Commit-Position: refs/heads/master@{#478594}

Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my
team currently takes ownership of running WebKit performance tests on the perf
waterfall (including sheriffing their perf regressions & breakages).

In term of code familiarity, I have made sizable
feature changes to the test framework in this directory (crbug.com/701059) & authored documentation for writing blink perf tests  (https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/PerformanceTests/README.md)

To ensure that the perf tests in this directory have consistent quality, I
would want to become the owner of the directory.

In term of process, this means that I will be responsible for reviewing all the
commits in this folder. In longer term, I plan to grow other member of speed
benchmarking team to also become maintainers of this directory.

Review-Url: https://codereview.chromium.org/2928083002
Cr-Commit-Position: refs/heads/master@{#478593}

Make the WebRtcMediaStreamAdapter, which represent local streams,
use the WebRtcMediaStreamTrackMap and AdapterRef classes for the
handling of initializing, getting and uninitializing local tracks.

WebRtcMediaStreamTrackAdapter is updated to allow local tracks from
non-local sources (removed DCHECKs) which happens when redirecting
remote sources as local streams.

This is one step closer to decoupling streams and tracks.

The same thing will be done in a follow-up CL for the remote streams
case, RemoteMediaStreamImpl.

BUG=705901, 700916

Review-Url: https://codereview.chromium.org/2897603004
Cr-Commit-Position: refs/heads/master@{#478592}

It seems java isn't necesarially present on mac which is causing pain
for those trying to build all.

Bug: 
Change-Id: I9fb58ec63b3c0e06b4882473b1b116b947810a3e
Reviewed-on: https://chromium-review.googlesource.com/530944Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478591}

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wu_fMIYkyaQ/85j16Cg6BAAJ

Bug: 731752, 680419
Change-Id: I250e03b2fb614a21a2b7eb1a27b7a11a746e6fc8
Reviewed-on: https://chromium-review.googlesource.com/529249
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478590}

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393

Review-Url: https://codereview.chromium.org/2927233003
Cr-Commit-Position: refs/heads/master@{#478589}

Network traffic annotation is added to network request of:
content/network/url_loader_impl.cc

BUG=656607
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2893233002
Cr-Commit-Position: refs/heads/master@{#478588}

The new-style notification should have two states: Collapsed(default) and Expanded.
To implement the feature, this CL does:
* Create NotificationHeaderView which is responsible to keeps app_icon, app_name, expand_button, settings_button, and close_button.
* When the expand_button is clicked, some view's visibility and message_view's line limit is modified to have "expanded" view.

For simplicity, I avoided dynamic creation/deletion of views on expanded state change. The expanded state only changes the existing view's property.
If it hit noticeable performance regression, I'll update the way to change the view.

BUG=728500,726242
TEST=manually tested expand/collapse function on following notifications using --enabled-new-style-notification
* A basic notification with one-line message (This doesn't have expand icon.)
* A basic notificatoin with two-line message
* A basic notification with two buttons
* A image notification

Review-Url: https://codereview.chromium.org/2925263003
Cr-Commit-Position: refs/heads/master@{#478587}

More code cleanup while reading the code.
Deja-vu?!

R=primiano@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2929673005
Cr-Commit-Position: refs/heads/master@{#478586}

We've shifted from an explicit JSON dictionary to a list of quoted
strings (that can be parsed as JSON for forward-compatibility). That is,
rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`,
we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing.

Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27.

BUG=607897

Review-Url: https://codereview.chromium.org/2929593002
Cr-Commit-Position: refs/heads/master@{#478585}

BUG=730029

Review-Url: https://codereview.chromium.org/2923733003
Cr-Commit-Position: refs/heads/master@{#478584}

We just want to set a data property on the global object, without
triggering user-defined setters.

R=jochen@chromium.org
BUG=chromium:729993

Change-Id: Idd12d95282916c60f84cc0cbed9117be8d18bee4
Reviewed-on: https://chromium-review.googlesource.com/529125Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478583}

This CL removes a TODO that asked to use a proper value for
|pending_history_list_offset|. This TODO is 2 years old. According to
the DCHECK and the comments at the top of this function, no
history-navigation is expected to happens here. So the current value
(-1) is correct and the TODO can be removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2927023004
Cr-Commit-Position: refs/heads/master@{#478582}

Currently "less than X MB" and "less than 1 MB" are inserted into "Frees
up $1" this might not work correctly when being translated so this CL
adds three separate sentences with only a placeholder for "X MB".

BUG=725401

Review-Url: https://codereview.chromium.org/2935443003
Cr-Commit-Position: refs/heads/master@{#478581}

This maps id <-> WebRtcMediaStreamTrackAdapter and handles creating
track adapters if they don't already exist. Reference counting
ensures adapters exists for as long as they are referenced, and that
they are disposed and removed from the map when no longer needed.

This can in a follow-up be used by WebRtcMediaStreamAdapter ("local
streams") and RemoteMediaStreamImpl ("remote streams") to get
references to track adapters "owned" by the map instead of directly
creating and owning the sinks/adapters that a
WebRtcMediaStreamTrackAdapter consists of.

This would allow local and remote streams to reference tracks that
already exist. The map can also be used to create and own tracks that
are not associated with any streams.

BUG=705901, 700916

Review-Url: https://codereview.chromium.org/2887403003
Cr-Commit-Position: refs/heads/master@{#478580}

The important sites dialog on desktop is only triggered when cookies
are selected for deletion but cache is also protected, so the string
needs to be different in case cookies and cache are supposed to be
deleted.

BUG=698692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2934453003
Cr-Commit-Position: refs/heads/master@{#478579}

Currently tests which have their mock dispatcher hosts remove the dispatcher
host only from SWContextCore but not from the test helper. This patch is to fix
that so that tests will have only one appropriate dispatcher host at the same
time.

This is split off from https://crrev.com/2779763004/ .

BUG=629701, 676983, 668633

Review-Url: https://codereview.chromium.org/2933793002
Cr-Commit-Position: refs/heads/master@{#478578}

This is inspired by (aka basically copied from) the search widget. The
few bits of existing implementation are those that could be reused from
the search widget (the app opening code). In order to add unit tests I
had to move resources from being a dependency of the code to being a
dependency of the full appex (see build.gn files) as both widgets are
in the same unit test target and caused resource file name collisions.

BUG=622743

Review-Url: https://codereview.chromium.org/2927803002
Cr-Commit-Position: refs/heads/master@{#478577}

In the current impl, it rejects w/ NetworkError. That should be AbortError
according to the spec.

Spec: https://drafts.css-houdini.org/worklets/#fetch-and-invoke-a-worklet-script

3. If script is null, then queue a task on outsideSettings’s responsible event
   loop to run these steps:
 3.1. If pendingTaskStruct’s counter is not -1, then run these steps:
  3.1.1. Set pendingTaskStruct’s counter to -1.
  3.1.2. Reject promise with an "AbortError" DOMException.

There are no wpt tests yet (see issue 724907)

Bug: 732212
Change-Id: Idc352dd6555de8ef49108662deeb24202f76d667
Reviewed-on: https://chromium-review.googlesource.com/530447
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478576}

Follow up from comment on
https://chromium-review.googlesource.com/c/507468/

Bug: 637460
Change-Id: Ic478edd7c0d5e40a7b8d9236003f44e25a39fea6
Reviewed-on: https://chromium-review.googlesource.com/530445
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478575}

This is a preparation to fix crbug.com/732217. Range.insertNode() will use
EnsurePreInsertionValidity().

Bug: 732217
Change-Id: I3a348c8b9ea60d1b39b5a1d3b708a092abccbaab
Reviewed-on: https://chromium-review.googlesource.com/530868
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478574}

Before this CL, installing runtime enabled features was done as
 Config foo_config[] = { {...} };
 for (auto conf : foo_conf) Install(conf);
 Config bar_config[] = { {...}, {...} };
 for (auto conf : bar_conf) Install(conf);
and it was messy both in templates and in geneated code.
This CL changes it to be simple as
 Config configs[] = { {/*for foo*/}, {/*for bar*/}, {/*for bar*/} };
 Install(configs);



Bug: 617892
Change-Id: I68b44b9aded795fa22de007da78e8397e104ed06
Reviewed-on: https://chromium-review.googlesource.com/527725
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478573}

This reverts commit 1fd2f73e.

Reason for revert:
This CL causes a compile failure.
The failure log is:
https://build.chromium.org/p/chromium/builders/Win/builds/56026

c:\b\c\b\win_archive\src\ui\keyboard\keyboard_test_util.cc(54): warning C4373: '`anonymous-namespace'::ControllerStateChangeWaiter::OnStateChanged': virtual function overrides 'keyboard::KeyboardControllerObserver::OnStateChanged', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers
c:\b\c\b\win_archive\src\ui\keyboard\keyboard_controller_observer.h(34): note: see declaration of 'keyboard::KeyboardControllerObserver::OnStateChanged'

Original change's description:
> Introduce explicit state to keyboard_controller.
> 
> Bug: 719905
> Change-Id: I14a1ee6b8e66c4f4c98ea4957dde7a7e0d75aad3
> Reviewed-on: https://chromium-review.googlesource.com/516866
> Commit-Queue: Keigo Oka <oka@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478568}

TBR=oshima@chromium.org,bshe@chromium.org,oka@chromium.org,yhanada@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 719905

Change-Id: I14143cde82fa85757be72ee9aed622577fd40dd7
Reviewed-on: https://chromium-review.googlesource.com/530732Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478572}

The test is fixed after https://codereview.chromium.org/2924873007/ landed

BUG=407998

Review-Url: https://codereview.chromium.org/2932863002
Cr-Commit-Position: refs/heads/master@{#478571}

These were left over from some previous cleanup.

BUG = None

Change-Id: I6588e2b7606d34a032d1ec892ec272f98ca3abb5
Reviewed-on: https://chromium-review.googlesource.com/529184Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478570}

The test was using a ThreadChecker to check that OnChanged is invoked
on the webrtc signaling thread. The problem is it is attached to
whatever thread first calls OnChanged, which in several tests was the
main thread.

The DCHECK is changed to "not on main thread", which should imply its
invoked on the webrtc signaling thread. This is good enough, and
avoids refactoring and changing initialization order that would be
necessary to pass the webrtc signaling thread for the sake of a single
DCHECK.

The DCHECK showed that RTCPeerConnectionHandlerTest and
MediaStreamRemoteVideoSourceTest was using the TrackObserver on the
wrong thread - tests are updated.

BUG=705901

Review-Url: https://codereview.chromium.org/2924033002
Cr-Commit-Position: refs/heads/master@{#478569}

Bug: 719905
Change-Id: I14a1ee6b8e66c4f4c98ea4957dde7a7e0d75aad3
Reviewed-on: https://chromium-review.googlesource.com/516866
Commit-Queue: Keigo Oka <oka@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478568}

It must be Null SelectionPaintRange w/o calculating VSinFlatTree.

BUG=708453

Review-Url: https://codereview.chromium.org/2932293002
Cr-Commit-Position: refs/heads/master@{#478567}

Toggling the Google Payments switch toggles the
autofill::prefs::kAutofillWalletImportEnabled which is watched by the
autofill::PersonalDataManager. If as a result of this, there is any change
to the list of autofill profiles and credit cards, PersonalDataManager
notifies its observers via -onPersonalDataChanged where
AutofillCollectionViewController reloads the model. Therefore no item or
section needs to be added/removed when the swtich is toggled.

BUG=671552

Review-Url: https://codereview.chromium.org/2934453004
Cr-Commit-Position: refs/heads/master@{#478566}

The DOM specification [1] doesn't ask any special handling for ShadowRoot in
Range.insertNode.  So we should treat a ShadowRoot same as DocumentFragment.

[1] https://dom.spec.whatwg.org/#concept-range-insert

Bug: 732220
Change-Id: Id907833514abcd447d5458a973a7a077cc3297c4
Reviewed-on: https://chromium-review.googlesource.com/530607Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478565}

We are always sending these images to sRGB canvases, so do the
conversion ahead of time.

This fixes a bug wherein, when a WebGLRenderingContext reads a
BitmapImage it wants the image to be in sRGB (if not-none was
requested). We will eventually need to decide how a color-canvas-using
WebGLRenderingContext should handle non-sRGB images.

BUG=730983

Review-Url: https://codereview.chromium.org/2924373002
Cr-Commit-Position: refs/heads/master@{#478564}

so that it matches to the DOM specification more.
This CL has no behavior changes.

Bug: 730412
Change-Id: I8881f2286e098238e255553bea8d2e1ab8b13ca4
Reviewed-on: https://chromium-review.googlesource.com/530924Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478563}