GitLab

Otherwise chrome:// are not recognized as the search result.

This CL also modifies the logic of URLSearchProvider's result
aggregation, because the SearchProvider doesn't emit result change
for URL-ish results.

BUG=416083
R=oshima@chromium.org
TBR=mpearson@chromium.org, agl@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/584263002

Cr-Commit-Position: refs/heads/master@{#295803}

BUG=415656

Review URL: https://codereview.chromium.org/583583005

Cr-Commit-Position: refs/heads/master@{#295802}

Revert of Make mojo/services pass in "gn check" (patchset #3 id:40001 of https://codereview.chromium.org/581273003/)

Reason for revert:
Broke component build

Original issue's description:
> Make mojo/services pass in "gn check"
>
> This mostly just adds the missing dependency identified by the checker.
>
> In some cases I looked at the target and added public_deps that I thought were appropriate given the nature of the target.
>
> This renames the generated mojo action names to be foo__generator instead of foo_generator since it is not clear from the current name that it is an internally-generated target and I kept trying to use it. The double-underscore matches the Android generated targets.
>
> In a few cases I changed ordering (sources come before deps in GN style) but I didn't want to make the changes difficult to diff so didn't do it for most cases.
>
> R=darin@chromium.org
>
> Committed: https://crrev.com/e2311613971cf63c66b60ebea38b4592b8520b8f
> Cr-Commit-Position: refs/heads/master@{#295797}

TBR=davemoore@chromium.org,darin@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/583423002

Cr-Commit-Position: refs/heads/master@{#295801}

If the user cancels their sign-in, or if some other error occurs, we
currently display "An unknown error occurred", which is not very helpful.

Review URL: https://codereview.chromium.org/585913003

Cr-Commit-Position: refs/heads/master@{#295800}

This reverts commit bd0aa4dc.

TBR=darin@chromium.org
BUG=415059

Review URL: https://codereview.chromium.org/584173002

Cr-Commit-Position: refs/heads/master@{#295799}

This should fix the iOS builder include errors as the previous Mac package failed
to include the include/ dir.

BUG=400088
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/586923002

Cr-Commit-Position: refs/heads/master@{#295798}

This mostly just adds the missing dependency identified by the checker.

In some cases I looked at the target and added public_deps that I thought were appropriate given the nature of the target.

This renames the generated mojo action names to be foo__generator instead of foo_generator since it is not clear from the current name that it is an internally-generated target and I kept trying to use it. The double-underscore matches the Android generated targets.

In a few cases I changed ordering (sources come before deps in GN style) but I didn't want to make the changes difficult to diff so didn't do it for most cases.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/581273003

Cr-Commit-Position: refs/heads/master@{#295797}

<include src="..."/>
<include src="..." />

R=tbreisacher@chromium.org
BUG=393873
NOTRY=true

Review URL: https://codereview.chromium.org/585053003

Cr-Commit-Position: refs/heads/master@{#295796}

BUG=388885
NOTRY=True

Review URL: https://codereview.chromium.org/575313003

Cr-Commit-Position: refs/heads/master@{#295795}

Update ui::GuessWindowManager() to detect popular
EWMH-supporting tiling window managers. Include these in the
Linux.WindowManager UMA histogram.

Detect Enlightenment 0.17 and later (enabling the custom
frame by default for it); previously only 0.16 was
detected.

Remove support for detecting chromeos-wm, the old Chrome OS
window manager that went away after Chrome OS switched to
Aura.

BUG=345482

Review URL: https://codereview.chromium.org/585553003

Cr-Commit-Position: refs/heads/master@{#295794}

BUG=400088
TBR=hans

Review URL: https://codereview.chromium.org/589773002

Cr-Commit-Position: refs/heads/master@{#295793}

Try failures are unrelated to this CL.
NOTRY=True

Review URL: https://codereview.chromium.org/575693002

Cr-Commit-Position: refs/heads/master@{#295792}

Revert of Removing browser.Start() and instead starts the browser at the point of creation. (patchset #5 id:80001 of https://codereview.chromium.org/565803002/)

Reason for revert:
missed changing constructor for CrOS browser

Original issue's description:
> Removing browser.Start() and instead starts the browser at the point of creation.
>
> BUG=412126
>
> Committed: https://crrev.com/01c68e8765254d9971296b291ff718b4f6af3004
> Cr-Commit-Position: refs/heads/master@{#295591}

TBR=nednguyen@google.com,slamm@chromium.org,slamm@google.com
NOTREECHECKS=true
NOTRY=true
BUG=412126

Review URL: https://codereview.chromium.org/587853003

Cr-Commit-Position: refs/heads/master@{#295791}

Folders should only have their id set by the server, and the clients
should only set the remote id on clips they created themselves.

Additionally, EnhancedBookmarkModel now monitors the remote id field for bookmarks, and initiates a de-duping protocol whenever two (or more) nodes with the same id are detected.
BUG=413876

Review URL: https://codereview.chromium.org/563363002

Cr-Commit-Position: refs/heads/master@{#295790}

Also remove an unused header and add it where actually used.

Review URL: https://codereview.chromium.org/587453005

Cr-Commit-Position: refs/heads/master@{#295789}

(Convert all uses to AttachEndpoint(). This means that Channel will no
longer create ChannelEndpoints.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/591573002

Cr-Commit-Position: refs/heads/master@{#295788}

BUG=416124
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/586813003

Cr-Commit-Position: refs/heads/master@{#295787}

Timings on z620:

Without:

GYP_DEFINES=component=static_library chromium_win_pch=0 incremental_chrome_dll=0

touch content\app\main.cc (causes chrome.dll, chrome_child.dll, and unit_tests.exe to relink)
tim ninja -C out\Release unit_tests
[19/19] LINK_EMBED unit_tests.exe

real: 4m46.828s

With:

GYP_DEFINES=component=static_library branding=Chrome chromium_win_pch=0 incremental_chrome_dll=1

touch content\app\content_main.cc && tim ninja -C out\Release unit_tests
ninja: Entering directory `out\Release'
[19/19] LINK_EMBED unit_tests.exe

real: 0m43.625s

This is basically best case, and the actual performance on bots will differ based on
their config and the number of files that change from run-to-run, but it seems worth
enabling to see what happens, at least.

R=jam@chromium.org
BUG=404809,402270

Review URL: https://codereview.chromium.org/502993005

Cr-Commit-Position: refs/heads/master@{#295786}

R=hclam@chromium.org
TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/587823002

Cr-Commit-Position: refs/heads/master@{#295785}

With some changes in libvpx and webrtc, plus this change, we should be able to enable webrtc in the GN build.

R=hclam@chromium.org

Review URL: https://codereview.chromium.org/583353002

Cr-Commit-Position: refs/heads/master@{#295784}

I went through and made "gn check //ui/*" pass, and did a lot of enhancements for the bugs I found.

Fixes a big bug in the header checker where it did not consider direct private dependencies to be OK from a header include perspective. However, private deps only change things when there are intermediate targets. This patch marks direct deps OK, and changes the variable names from is_public to is_permitted (since it may not actually be public).

Allow includes to be permitted if any target allows the include, rather than all of them. This happens if multiple targets have the same file as sources.

Strip the generated file directory from the beginning of sources. Previously, this was only for outputs (since typically they're included assuming the root gen dir is on the path). This comes up when an action generates a file, and then it's put into a source set (which we do a lot). This change allows a public dependency on the source set to count for header include purposes.

Track public/private deps in the dependency path finder so the error message can show which deps are private that break the chain. This was really helpful when tracking down errors.

Add deps and public deps to the build to make check pass.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/584683002

Cr-Commit-Position: refs/heads/master@{#295783}

From python optparse docs for action='append':

"It also means that if the default value is non-empty, the default
elements will be present in the parsed value for the option, with any
values from the command line appended after those default values:"

So, to actually create a default, we have to set it later in
CreateResults. Unfortunate, but true. Thanks vogelheim@ for catching
this.

BUG=

Review URL: https://codereview.chromium.org/585023002

Cr-Commit-Position: refs/heads/master@{#295782}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/34469ea..686c9e7

TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/587803002

Cr-Commit-Position: refs/heads/master@{#295781}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/87e2437..45725db

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/586023003

Cr-Commit-Position: refs/heads/master@{#295780}

Modify Menu.jr to also respond to touch events. Provide visual touch feedback based on mouse hover.

TEST=Manual testing of Bookmark Manager
BUG=398404

Review URL: https://codereview.chromium.org/584553005

Cr-Commit-Position: refs/heads/master@{#295779}

BUG=
R=sky@chromium.org

Review URL: https://codereview.chromium.org/589493003

Cr-Commit-Position: refs/heads/master@{#295778}

BUG=none

Review URL: https://codereview.chromium.org/589653002

Cr-Commit-Position: refs/heads/master@{#295777}

This was only added to work around crbug.com/416124 and is no longer needed,
and apparenty it's causing issues on the gpu bots.

BUG=none
TBR=hans

Review URL: https://codereview.chromium.org/586163002

Cr-Commit-Position: refs/heads/master@{#295776}

xref https://code.google.com/p/drmemory/issues/detail?id=1058

R=bruening@chromium.org
BUG=413215
NOTRY=true

Review URL: https://codereview.chromium.org/574643006

Cr-Commit-Position: refs/heads/master@{#295775}

This is a follow up CL for 414417 that includes the ONC translation
necessary for the Wimax UI and fixes the JS to use the new WiMAX
capitalization. It also adds a WiMAX entry to the HTML doc.

BUG=414417

Review URL: https://codereview.chromium.org/581213003

Cr-Commit-Position: refs/heads/master@{#295774}

Screenshots:
Ubuntu:
http://i.imgur.com/FuzZfcr.jpg

OSX:
http://i.imgur.com/ylHBVCx.png

BUG=407453

Review URL: https://codereview.chromium.org/501273002

Cr-Commit-Position: refs/heads/master@{#295773}

Scroll events are mouse events as well. On debug builds this DCHECK
would otherwise get triggered.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/590523004

Cr-Commit-Position: refs/heads/master@{#295772}

The test MediaGalleriesPlatformAppBrowserTest.MediaGalleriesRead is
flaky on MacOSX bots.

BUG=416128
NOTRY=true
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/588663003

Cr-Commit-Position: refs/heads/master@{#295771}

The linker is coalescing sections incorrectly (x64-only,
incremental-only), so disable these tests for now in that
configuration. See crbug.com/251251 for more details.

Upstream toolchain bug at https://connect.microsoft.com/VisualStudio/feedbackdetail/view/967992

R=wfh@chromium.org
BUG=251251

Review URL: https://codereview.chromium.org/580213002

Cr-Commit-Position: refs/heads/master@{#295770}

R=dsinclair

Review URL: https://codereview.chromium.org/587733002

Cr-Commit-Position: refs/heads/master@{#295769}

When 216630 was rolled in, there was one roll that got reverted,
and then we re-built packages for the next one. However, some devs
and maybe bots who didn't sync to the revert got stuck with the old
binaries which would now mismatch against goma's checksum.

No behavior change.

BUG=415883
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/583233004

Cr-Commit-Position: refs/heads/master@{#295768}

R=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/583343002

Cr-Commit-Position: refs/heads/master@{#295767}

IsIdentityOrTranslation, IsScaleOrTranslation, and HasPerspective
are now provided by SkMatrix44 so use those.

R=vollick
BUG=408710

Review URL: https://codereview.chromium.org/590553002

Cr-Commit-Position: refs/heads/master@{#295766}

Revert of Telemetry: Use the leftmost argument to find the test to parse flags. (patchset #2 id:20001 of https://codereview.chromium.org/582793002/)

Reason for revert:
Broke Android debug gpu bot:
http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/12692

This bot relies on being able to supply some flags before the test name; it runs:
content/test/gpu/run_gpu_test.py --browser=android-content-shell webgl_conformance --webgl-conformance-version=1.0.1

Original issue's description:
> Telemetry: Use the leftmost argument to find the test to parse flags.
>
> Previously it would check all of the arguments, and use the last test found.
> This is causes problems as different tests can be used to create the parser and
> accepts the parsed flags.
>
> SHERIFFS: If errors related to parsing flags for run_measurement, run_benchmark
> or run_gpu_test.py appear, this is likely the cause. It is safe to revert.
>
> BUG=413334
>
> Committed: https://crrev.com/5afe5a61f03743bd523dae66f662ad773f8befb9
> Cr-Commit-Position: refs/heads/master@{#295738}

TBR=nednguyen@google.com,kbr@chromium.org,tonyg@chromium.org,dtu@chromium.org,ariblue@google.com
NOTREECHECKS=true
NOTRY=true
BUG=413334

Review URL: https://codereview.chromium.org/584023003

Cr-Commit-Position: refs/heads/master@{#295765}

Align with SSLClientSocketNSS's behavior around the PeerCertificate object.
Within the sandbox for Chromoting, the platform certificate may be unavailable
while the SSL-layer certificate is. Match NSS in using the SSL-layer
certificate for many operations. Also check appropriately for the platform
certificate being NULL in DoVerifyCert rather than simply crashing.

BUG=414315
TEST=Install Chromoting app. Connecting to another computer works.

Review URL: https://codereview.chromium.org/576233002

Cr-Commit-Position: refs/heads/master@{#295764}