GitLab

The LogBuffer distinguishes between two types of node in a tree that is
ultimately converted to a DOM: Elements (think of this as HTML tags) and Text
Nodes. Before this CL it was possible to do the following:

Log() << "Foo" << "Bar";

This would create a text node with content "Foo" and give it a child "Bar". As
HTML does not allow a text node to have children, "Bar" would never appear
in chrome://autofill-internals.

The correct code in this case would be:

Log() << Tag{"div"} << "Foo" << "Bar";

To make the code clearer, the term "node" in the code has been replaced with
"element": In HTML, Nodes are the super set of Element (tags) and Text Nodes.

At some point, we could support HTML Fragments, which would enable use to
support the Log() << "Foo" << "Bar" syntax without requiring to explicitly add
a Tag{"div"} before the "Foo".

Bug: 928595
Change-Id: I778a025c853dc0a39f41675d57a381ba11c13975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722534Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681832}

https://swiftshader.googlesource.com/SwiftShader.git/+log/3575550a711b..8d269bac7c4a


git log 3575550a711b..8d269bac7c4a --date=short --no-merges --format='%ad %ae %s'
2019-07-29 bclayton@google.com Fix build of tests/fuzzers.
2019-07-29 bclayton@google.com Reactor: Use std::shared_ptr to ref-count rr::Routines


Created with:
  gclient setdep -r src/third_party/swiftshader@8d269bac7c4a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/137524292,chromium:b/137649247,chromium:b/137524292,chromium:b/137649247
Change-Id: I3366f9da6034ab7416c1cda411f24c5921fcda38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724116Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681831}

http://crrev/c/1715273 introduced fields with tag numbers that conflict
with the server's. This change fixes that on the client side.

Bug: b/138276952
Change-Id: I7e38f18715ad5fafe5271949495c50156e38562f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722542Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681830}

PlatformFontWin is enforcing a minimal font size.
see: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_win.cc?l=292

The PlatformFontSkiaOnWindows experiment is using the PlatformFontSkia
on Windows. But this implementation doesn't enfore the minimal font size.
This CL is adding the call to win::AdjustFontSize(...) which is responsible
to ensure the minimal size is respected.


This CL is fixing the unittest |FontTest.DeriveResizesIfSizeTooSmall| when
running with the PlatformFontSkiaOnWindows experiment.

  [ RUN      ] FontTest.DeriveResizesIfSizeTooSmall
  ../../ui/gfx/font_unittest.cc(152): error: Expected equality of these values:
    5
    derived_font.GetFontSize()
      Which is: 4


R=robliao@chromium.org, asvitkine@chromium.org

Bug: 944227
Change-Id: I99ad1ce651183cd488719b48791f9f056e6471e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710013Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681829}

https://dawn.googlesource.com/dawn.git/+log/b98f0faa4d0b..10fe83305a04


git log b98f0faa4d0b..10fe83305a04 --date=short --no-merges --format='%ad %ae %s'
2019-07-29 cwallez@chromium.org Metal: Pack vertex buffers just after the pipeline layout


Created with:
  gclient setdep -r src/third_party/dawn@10fe83305a04

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel

TBR=cwallez@google.com

Bug: None
Change-Id: I0285f4c8ca9921ca3f1d104a0768eb4b2d1c798c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724115Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681828}

Without Unified Consent, the advanced sign-in settings is opened by
the main controller. Before opening the view, -[SigninInteractionCoordinator
signinDoneWithSuccess:] is called and then the main controller is called.
The issue is the presenting view controller has been removed by
|signinDoneWithSuccess:|, and the main controller was called with nil.

This bug has been introduced with crrev.com/c/1702264.

Bug: 987374
Change-Id: Ibd1c754d92b3676db1a013e6c9c1d4a9c35d265d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724670
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681827}

https://skia.googlesource.com/skia.git/+log/33f77d35ca2c..96827b125f3a


git log 33f77d35ca2c..96827b125f3a --date=short --no-merges --format='%ad %ae %s'
2019-07-29 jvanverth@google.com Use raw MTLBuffer for texture uploads.
2019-07-29 brianosman@google.com Finish and document particle public API
2019-07-29 robertphillips@google.com Switch BackendAllocationTests from GrPixelConfig to GrColorType


Created with:
  gclient setdep -r src/third_party/skia@96827b125f3a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=benjaminwagner@google.com

Bug: None
Change-Id: I185dd357fd6e4588f832db43ba86f48ed46d788d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681826}

This initial proof-of-concept is setting number of temporal layers only.

Intent to implement thread link (not containing intent to ship):
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/--ZpYlTo6LE

Bug: 986069
Change-Id: I6bd094d6166637a6899b7d2a63a2905accb7857c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710555Reviewed-by: Florent Castelli <orphis@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681825}

Shave some bits off the android chrome APK by making sure we don't
include the browser side webauthn stack. It isn't used in android.

Bug: 987449
Change-Id: I139b28b935816e50ef89b79e2aedd461828b0afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717913
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#681824}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3fea07b44639..90836d9a6e45


Created with:
  gclient setdep -r src-internal@90836d9a6e45

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ia47cc3c77c47e286994550ec0f8bd617407867d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724113Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681823}

Bug: 985024
Change-Id: Iace7bcf664ca59cadd903a49b181f0e718f7df27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717998
Auto-Submit: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681822}

This rolls SPIRV-Cross to a newer version that implements OpArrayLength
for the MSL output.

BUG=dawn:195

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/f07a4e16a60e..ffca8735ff42

$ git log f07a4e16a..ffca8735f --date=short --no-merges --format='%ad %ae %s'
2019-07-26 cdavis MSL: Unify the get_*_address_space() methods.
2019-07-26 post MSL: Cleanup temporary use with emit_uninitialized_temporary.
2019-07-26 post MSL: Deal with Modf/Frexp where output is access chain to scalar.
2019-07-26 post Do not force temporary unless continue-only for loop dominates.
2019-07-25 post Missed case where DoWhile continue block deals with Phi.
2019-07-25 post Vulkan GLSL: Support disabling samplerless texture function EXT.
2019-07-25 post Workaround MSVC 2013 compiler issues.
2019-07-22 cdavis MSL: Adjust BuiltInWorkgroupId for vkCmdDispatchBase().
2019-07-24 post Fix some typos in comments.
2019-07-24 post Do not attempt to pack types which are already scalar.
2019-07-24 post HLSL query lod cleanups.
2019-07-24 post Do not eagerly invalidate all active variables on a branch.
2019-07-23 post Do not disable temporary forwarding when we suppress usage tracking.
2019-07-23 post Add another test for unpacking without load forwarding.
2019-07-23 post Look at pointee type when unpacking expressions.
2019-07-23 post Fix some warnings when building in MoltenVK.
2019-07-23 post Deal correctly with non-forwarded packed loads.
2019-07-23 post Test CompositeInsert/Extract/VectorShuffle on packed vectors.
2019-07-23 post Add test for array of scalar struct.
2019-07-23 post Recursively pack struct types when we find scalar packed structs.
2019-07-23 post Run format_all.sh.
2019-07-23 post Unpack vector expression in Matrix-Vector multiplies.
2019-07-23 post Test matrix multiplies in more complex scenarios.
2019-07-23 post Test implicit packing of struct members.
2019-07-23 post GLSL/HLSL: Verify member alignment for explicit offset as well.
2019-07-23 post Add tests for struct padding and self-alignment.
2019-07-23 post Use to_unpacked_row_major_expression to unify row-major in MSL/GLSL.
2019-07-23 post Simplify row-major matrix/vector multiplies.
2019-07-23 post Test array of std140 vectors.
2019-07-23 post Add struct size padding tests.
2019-07-22 post Add test for CompositeExtract from row-major loaded vector.
2019-07-22 post Add test for split access chain into row-major matrix.
2019-07-22 post Remove obsolete matrix workaround code.
2019-07-22 post Only transpose unpacked expressions.
2019-07-22 post Deal correctly with complete stores to row_major matrices.
2019-07-22 post Declare correct matrix type when unpacking.
2019-07-22 post Don't forget to register a write to LHS expression in certain case.
2019-07-22 post Deal with swizzled stores to std140 matrices.
2019-07-22 post Fix some row-major column store cases.
2019-07-22 post Fix more stray parens.
2019-07-22 post Fixup stray parent in output.
2019-07-22 post Correctly unpack row-major matrices when storing to LHS.
2019-07-22 post MSL: Add std140 and scalar matrix layouts.
2019-07-22 post MSL: Add std430 matrix access test.
2019-07-22 post MSL: Support storing to row-major column.
2019-07-22 post Tests run clean.
2019-07-19 post Fix unpacking of packed but not remapped types on load.
2019-07-19 post Traverse correct types when checking scalar layout.
2019-07-19 post Deal with scalar layout of entire structs.
2019-07-19 post Pass down row-major state to unpacking functions.
(...)
2019-05-28 post Fixup OpLine parsing comments.
2019-05-28 post Support emitting OpLine directive.
2019-05-28 post GLSL: Support std430 in UBOs with scalar layout.
2019-05-27 post Run format_all.sh.
2019-05-27 post MSL: Use correct address space when passing array-of-buffers.
2019-05-27 post OpArrayLength must trigger active variables.
2019-05-27 post MSL: Implement OpArrayLength.
2019-05-24 post Add Git/timestamp --revision support.
2019-05-23 post MSL: Add test case for complex type alias.
2019-05-23 post MSL: Fix struct declaration order with complex type aliases.
2019-05-18 post Fix formatting, update C ABI version.
2019-05-09 post MSL: Support argument buffers and image swizzling.
2019-05-08 stuart.carnie Add get_member_name and active_buffer_ranges to C APIs
2019-05-17 amerkoleci Fix spvc_type_get_vector_size C function.
2019-05-16 cdavis Remove fallback for OpGroupNonUniformElect.
2019-05-15 cdavis MSL: Add support for subgroup operations.
2019-05-14 post Only deploy on new tags.
2019-05-14 post Add setup for Github releases via Travis.
2019-05-14 post Validate that C ABI in CMakeLists.txt matches code.
2019-05-14 post Run format_all.sh.
2019-05-11 laszlo.agocs GLSL: Add option to disable buffer blocks regardless of version
2019-05-13 post Fix nonuniform test for MSL.
2019-05-13 post HLSL/MSL: Deal correctly with nonuniformEXT qualifier.
2019-05-09 post MSL: Add test for passing single swizzled texture arg from array.
2019-05-09 post Fix GCC 4.x warning.
2019-05-09 post MSL: Deal with texture swizzle on arrays of images.
2019-05-09 post GLSL: Support OpBitcast for buffer references.
2019-05-08 rharrison Set env to vulkan1.1 for spirv-as in test_shaders.py
2019-05-07 post GLSL: Return correct sign for OpArrayLength.
2019-05-07 post HLSL: Support OpArrayLength.
2019-05-07 post Accept SPIR-V 1.4 version.
2019-05-02 post GLSL: Support GL_EXT_nonuniform_qualifier.
2019-04-26 cdavis Fix a copy-pasto.
2019-04-26 post GLSL: Support GL_EXT_scalar_block_layout.
2019-04-26 post Fix GCC 4.x warning.
2019-04-24 post GLSL: Implement GL_EXT_buffer_reference.
2019-04-24 post Fix infinite loop when OpAtomic* temporaries are used in other blocks.
2019-04-24 post Work around false positive warning on GCC 8.3.
2019-04-23 post MSL: Cast texture_buffer index to uint.
2019-04-23 post Add texture_buffer_native option to C API.
2019-04-23 post Run format_all.sh.
2019-04-23 post MSL: Support native texture_buffer type, throw error on atomics.
2019-04-16 mikebarriault Correct formatting.
2019-04-16 mikebarriault Only use MSL constant address space for tessellation control shader.
2019-04-12 post Support running {,update_}test_shader.sh with CMake builds.
2019-04-12 ashley.harris Don't apply vertex attribute remapping other non-vertex or non-input interface blocks
2019-04-11 mikebarriault Remove accidentally committed test patch.
2019-04-10 mikebarriault Fix tests for device->constant address space change in MSL tessellation control shader generation.
2019-04-10 post Force complex loop in certain rare access chain scenarios.
2019-04-09 mikebarriault Use constant address space for SPIR-V parameters when generating tessellation control shader.

TBR=rharrison@google.com

Created with:
  roll-dep src/third_party/spirv-cross/spirv-cross

Change-Id: I5e2929a9b381c1471bccad153d6c412afe3e89fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724081Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681821}

The screenshot:
https://drive.google.com/file/d/1hFwKWKo8fVp9BvxX6i7FClsguEidiXZs/view?usp=sharing

Bug: 982018
Change-Id: I4901d1e5dc34540c0d445ec5f73fc1017a1abef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724652
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681820}

Works around users have random other versions in their PATH.

Bug: 988100
Change-Id: I48111e378b5186e4373fda3927b9cec0922cb391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724437Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681819}

https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getthreadpriority

Change-Id: If2d50f6c0ee4e8da8bbf81cca8cfa37d2272d3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720641Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Boris Yusupov <boriay@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#681818}

This CL implements prompting the client to show the onboarding when
a new credential is saved and the right kPasswordManagerOnboardingState
is set.

Bug: 983445
Change-Id: Idbbd00690ff12a6dd250fc782a0de13bd9b5abbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706507
Commit-Queue: Andrei Chulkov <achulkov@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681817}

Showcase's protocol_alerter.mm is conflicting with OCMock.  Prefixing with
crsc_ instead.

Bug: 988423
Change-Id: I542b7df1374a285b3a8ecf293b682fa922d10fde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724654
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681816}

https://chromium.googlesource.com/chromium/src/+/f898f31efa9b13b56985d60b30eddeb068598891
asserted that sandbox flags weren't changing. Doing a document.open across
same origin iframes caused this CHECK to fire.

BUG=987452

Change-Id: I81a255fd9b6de4af375abab523148349e3108ae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720995Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681815}

ash::KeyboardController is converted from mojo interface. As
a mojo interface, it does not need RemoveObserver since closing
underlying connection automatically stops observing. As C++
interface, we should have an explicit RemoveObserver to avoid
having a dangling pointer in the observer list.

Bug: 958203
Change-Id: Ia61a43ff2d6d95b7c3d5264c27632aae277b6a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721230Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681814}

This allows observers to access page load info from the metrics
observer delegate directly, instead of being passed the
PageLoadExtraInfo struct by the delegate. Previously the entire
PageLoadExtraInfo struct was created and passed independent of the
data needed by the observers. This also removes the duplication of
delegate and PageLoadExtraInfo fields (navigation_start, did commit).

Each API function returns the same data as used to populate the
PageLoadExtraInfo struct.

This API will be followed up with the following sets of CLs:
1. Replace common observer utility functions to use the delegate
   returned values instead of the PageLoadExtraInfo struct.
2. Group page_load_metrics_observer On* functions that use
   PageLoadExtraInfo structs and replace them with delegate returned
   values.

This also adds first_background_time and first_foreground_time as
members of the page_load_tracker, so as to not compute these with
each call to their respective getter function.

BUG=939403

Change-Id: I84af9f19fc2d14a727318ea2eb0668229f795cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713153
Commit-Queue: Justin Miron <justinmiron@google.com>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681813}

This CL adds the new UI to incorporate Google Translate branding
into the new Button_GM2 and Tab translate bubble UI. Bug 987962 is filed
to track this new feature request.

Bug: 963148, 987962
Change-Id: Ia648f322cea5dae55bd9e21a537775bf74c772a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708843Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681812}

https://android.googlesource.com/platform/external/perfetto.git/+log/da370c8e520b..ecd71dad4bd5


git log da370c8e520b..ecd71dad4bd5 --date=short --no-merges --format='%ad %ae %s'
2019-07-29 treehugger-gerrit@google.com Merge "protozero: Fix moving a protozero decoder"
2019-07-29 rsavitski@google.com Merge "tmux script: tee to log files; add -s (skip converters) -l (tmux layout) options"


Created with:
  gclient setdep -r src/third_party/perfetto@ecd71dad4bd5

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I5816df2f06854c1e1afa78ac4a22e86035592eed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724112Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681811}

Also remove some dead code in BrowserContext.

Bug: 934009
Change-Id: I015a1b65086f28304a6f0b0ff36f4341b709b9db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723930
Auto-Submit: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681810}

This keeps the navigation controller and the presented view controller
in sync with the same style.

Bug: 985461
Change-Id: I49af9e8a7eacdcccbb4b67ca3e5925454081b58a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722838
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681809}

Previously, HttpServerPropertiesManager would watch for any changes to
prefs, and then it would update the prefs stored in
HttpServerPropertiesImpl. Since it also sets preferences in response to
changes in HttpServerPropertiesImpl's state, it also kept around a bool
to avoid reentrancy.

This seems like a fair bit more effort than necessary - nothing writes
to the HttpServerPropertiesManager's prefs field except for
HttpServerPropertiesManager itself. When running in the network service,
there's even a dedicated pref file just for the network service, which
almost nothing else uses.

This CL simplifies HttpServerPropertiesManager to only read the
preference once, when it starts, and only write prefs once the initial
prefs have been loaded, on shutdown, after Clear(), and when the prefs
have been modified. This CL is intended to simplify the state machine,
to make it easier to invert the relationship between
HttpServerPropertiesManager and HttpServerPropertiesImpl (see bug).

Bug: 984996
Change-Id: I71c303bdac23424dc268d21b8be72f87043dad7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707401Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681808}

doesn't trigger translate

This CL address issue 983510. Currently under TAB UI, if the "Always
translate {source language} option is de-selected and selected again,
it doesn't trigger translation as it should. This CL fixes this issue.

Bug:983510

Change-Id: I8ed90119a25f959ab52410cc2c7fbc930097f082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702766Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681807}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Ia4011889cd8075236bf80a4bda1e1f19c8c6b608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700853Reviewed-by: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681806}

Adding filter files to exclude the known broken tests from running by
default. This will get the bot back to green, which is key for us
understanding when outside changes result in breakage in
BackForwardCache code.

It also gives us a clear burndown list to work through and fix, which
can be easily understood and measured.

Bug: 511340
Change-Id: I8da2149acf09fbcb13384285150817ec4e1dae70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718029Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681805}

Change-Id: I93f84a3eac89cc584bdb6414522b0adc71f3d66b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722846Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681804}

Fix TaskId translation logic for Background Sync one-off tasks.

Bug: 988406
Change-Id: I91aa4d1fde9e6b372d99fba6644e6c3f1dd748ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722960Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681803}

This reverts commit 21505f63.

Reason for revert: Broke all webview perf bots

Original change's description:
> Reland "heap: Enable concurrent sweeping"
> 
> This relands 51bb0bd3 as flaky failures in webgl tests were caused by
> aecfa837.
> 
> Bug: 967258
> Change-Id: Icf2e5d050e763e112471f5ac1897a3e24f6c9006
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713525
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Anton Bikineev <bikineev@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679918}

TBR=haraken@chromium.org,mlippautz@chromium.org,bikineev@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 967258
Change-Id: Iff6d2058bbe0370f4cd8cae676919572f946e47e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724509Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681802}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6d7e1dd2..bac9d6cd

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie2db9b5b381db8e630355ae5cf62b844b8250ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723853Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681801}

Bug:973603

R=caraitto@chromium.org, pauljensen@chromium.org

Change-Id: Ia1d3309579ee45b222375b12cd655ee1d985a07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652540
Auto-Submit: Michelle Roxas <michelleroxas@google.com>
Commit-Queue: Michelle Roxas <michelleroxas@google.com>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681800}

To use color values, the compositor must have a CrossThreadStyleValue
specific to color values so it can use the proper functionality for
color values.  The new class CrossThreadColorValue was created for this
purpose.  CrossThreadColorValue is intiended to be used alongside
CSSUnsupportedColorValue.

Follow up to:
https://chromium-review.googlesource.com/c/chromium/src/+/1713747

Bug: 883721
Change-Id: If296bf492ceb20380f82bcc80225094cd3d72a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716962Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Adam Raine <asraine@google.com>
Cr-Commit-Position: refs/heads/master@{#681799}

This is a reland of 6811de35

It was reverted due to crbug.com/988010
The underlying issue was unrelated to that patch and has been fixed in
https://chromium-review.googlesource.com/c/chromium/src/+/1722841

No changes are introduced and hence TBR'ing original reviewers.

Original change's description:
> [PasswordManager] Stop Using Native Backends on Linux systems
>
> Recent migrations moved all users who have been using the keying to the
> LoginDatabase. This CL forces all users to using LoginDatabase
> instead of native backends on Linux.
>
> TBR=pcc@chromium.org
>
> Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60
> Bug: 950269, 950267
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560
> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681042}

TBR=cfroussios@chromium.org,vasilii@chromium.org,pcc@chromium.org

Bug: 950269, 950267
Change-Id: I1f091e18f6e23da8a2c8588c9a00bdb08fbda2f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722964Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681798}

Bug: 986737
Change-Id: I7a96cbc5668adfb8c9922e2adca03bc7cfa5ab7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719127
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681797}

Bug: 977804
Change-Id: Ib6d2a783bd053ef1554cb5a133b03d6fb894ace5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722272
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681796}

Modal sheets use "NSTitleWindowStyleMask" for Reasons (looks like mostly
input handling). This means that when we ask for their content rect, they
account for the title bar, though we don't actually display one!

In practice this means:
1. We've been undersizing modals for a while.
2. If it so happens that if we roundtrip back through NativeWidgetNSWindowBridge::SetBounds
(motivating example: when the window is moved to a screen with different DPI), we lose
*another* title bar's worth of height.

This change modifies the style mask so that the title bar isn't accounted for when
calculating the content rect.

Bug: 982477
Change-Id: I79da0297a1d79eaae3f7eaef85a5986c12b74436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721269
Auto-Submit: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681795}

The (somewhat flakey)
correct-events-for-short-animations-with-syncbases.html
has been reworked and made more stable. This might affect it's coverage
but it was too flakey to work reliably.

rapid-syncbases.html
has been created to hopefully catch what correct-events-for-short-animations-with-syncbases.html used to catch.

Together these tests should have some redundancy which will
improve the test stability and hopefully make them less flakey.

Bug: 981522
Change-Id: I217903f66dc5a1a1739a258b32da39338a44bb3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722966
Commit-Queue: Edvard Thörnros <edvardt@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Edvard Thörnros <edvardt@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681794}

https://skia.googlesource.com/skia.git/+log/d188f3a9613d..33f77d35ca2c


git log d188f3a9613d..33f77d35ca2c --date=short --no-merges --format='%ad %ae %s'
2019-07-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@33f77d35ca2c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=benjaminwagner@google.com

Bug: None
Change-Id: I06a360cd7cfc82bbd0f676ec4699bfec04d749ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722203Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681793}