- 18 Jun, 2019 40 commits
-
-
Dan Beam authored
This reverts commit 0bd3cb69. Reason for revert: Broke closure compiler bot https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8910374524264371136/+/steps/run_tests/0/stdout Original change's description: > Convert PromiseResolver and FocusOutlineManager to ES6 class syntax. > > Also replace a few usages of bind(this) with arrow functions. > > Bug: 747596 > Change-Id: Icbbe4425e5ddd7b8861fb01fe4b7f9fa093d08be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658638 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669792} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I399c066ee883da844bcd8af7dbef37e770243802 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 747596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663742Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#669947}
-
Matthew Mourgos authored
Bug: 973713 Change-Id: I650acdec495b079f826d115d97bddab9357499cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659022 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#669946}
-
David Staessens authored
This CL changes the video_decode_accelerator(_perf)_tests to use the correct visible rectangle. The checksums for the switch_1080p_720p_240frames.h264 video have been updated as these were incorrect. TEST=ran new VDA tests on eve BUG=974075 Change-Id: I81d584c66b3aebd02ee193c6e068748e65dc96ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659651Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#669945}
-
David Staessens authored
This CL introduces the VaapiVideoDecoder, based on the media::VideoDecoder interface. This decoder is a complete rewrite of the VaapiVideoDecodeAccelerator which is based on the deprecated media::VideoDecodeAccelerator interface. TEST=ran new VDA tests on eve BUG=920058 Cq-Depend: chromium:1535514 Change-Id: Ib11f22afbd06c9469275aa26a3cebd04e0a4e03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634030 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#669944}
-
Matt Mueller authored
The flag is only available on Linux and macOS, as those are currently the platforms where trust store integration is completed. Bug: 973650 Change-Id: Id7273acedc88deebe1aaa80d2dcaed0f6e4fbb96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660797Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#669943}
-
Ben Pastene authored
Bug: 932269 Change-Id: I4bb696dd9caa2004b8108cd56e4a7d9f73248563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663023 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#669942}
-
Antonio Gomes authored
BUG=704136 R=haraken@chromium.org Change-Id: I5aa59e43448703eb743e40a9fc0bad2b5666140d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659106 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#669941}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/468585d96747..1d05fadfb4fa Created with: gclient setdep -r src-internal@1d05fadfb4fa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I8dc821c86f2e05477391a6a9edc3bb6234ab986c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663575Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669940}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 29e350f6. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." 3d4f72a8 "Worker: Add service worker interception tests for shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ie291f2cc64ba01de1b9586c08321c6fe0108e1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663326Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669939}
-
Antonio Gomes authored
This CL is part of the phase 3 on the document [1]. It includes moving to Blink files and content/renderer/media/stream dependencies from media/audio or media/webrtc that block Onion souping more entangled files. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/edit# As a follow up to the CL, this class will be renamed to WebAudioMediaStreamAudioSink. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Id86386441212d7909e20cb2be90b2ca8c4c1f409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659474 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#669938}
-
Dan Beam authored
Instead, the code has been updated to use: * @media (prefers-color-scheme: light/dark) {...} in CSS * window.matchMedia(...).matches in JS for querying and * window.matchMedia(...).{addListener,removeListener} in JS for notifications. \o/ Bug: 965811 Change-Id: I6bbb1b548bdb3919977f9f18f414bd193dffd129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654279 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#669937}
-
Yoichi Osato authored
Reason for reland: the culprit was not this patch. This patch was reverted because of compile failure on android: https://chromium-review.googlesource.com/c/chromium/src/+/1660391 However, relanding this don't cause compile failure. Bug: 865001 Change-Id: Ia64a440525791fe67fb9d8a3882b91bc41af262c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661316Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#669936}
-
Matthew Webb authored
Just cleaning up some bio enrollment-related code and reducing copying. Bug: 974046 Change-Id: If0f30989ee06097717abd0f62887ed7ba00d4ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659851 Commit-Queue: Matthew Webb <noviv@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#669935}
-
Charlene Yan authored
This reverts commit 2af55fab. Reason for revert: Still flaky Original change's description: > Reland "Add ability to drag tabs between pinned and unpinned tabs to modify the" > > This reverts commit 1158f5ef. > > Reason for revert: This is an experimental reland since this broke older > mac waterfall bots. This was fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1649313 > > Original change's description: > > Revert "Add ability to drag tabs between pinned and unpinned tabs to modify the" > > > > This reverts commit 91948560. > > > > Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/38757, consistent failures on mac of the following tests: > > TabDragging/DetachToBrowserTabDragControllerTest.DragToPinEnabled_DragToUnpinInNewWindow/0 > > TabDragging/DetachToBrowserTabDragControllerTest.DragToPinInNewWindow/0 > > > > Original change's description: > > > Add ability to drag tabs between pinned and unpinned tabs to modify the > > > pinned state. > > > > > > Bug: 965681 > > > Change-Id: I4cebf850839a1fdbee702ab2cd3c2fccbdba811e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637045 > > > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > > > Commit-Queue: Charlene Yan <cyan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#666796} > > > > TBR=bsep@chromium.org,cyan@chromium.org > > > > Change-Id: I0a68811b31c718fcdccba6058ab6bdf664a1547a > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 965681 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649316 > > Reviewed-by: Armando Miraglia <armax@chromium.org> > > Commit-Queue: Armando Miraglia <armax@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#667042} > > TBR=bsep@chromium.org,armax@chromium.org,cyan@chromium.org > > Change-Id: Ia1521f2c2443c40a3b2ac55be079c6e1be91dea2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 965681 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648899 > Commit-Queue: Charlene Yan <cyan@chromium.org> > Reviewed-by: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669906} TBR=bsep@chromium.org,armax@chromium.org,cyan@chromium.org Change-Id: I8ab3f943b2aed204f318c329fca88a0459f2255b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 965681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663582Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#669934}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8f4046b0b667..872c1d7fe98a git log 8f4046b0b667..872c1d7fe98a --date=short --no-merges --format='%ad %ae %s' 2019-06-18 jiawei.shao@intel.com Add validations to the texture copies with BC formats Created with: gclient setdep -r src/third_party/dawn@872c1d7fe98a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Ib620e34aee94df1ef4a3556f6de3541da5b56bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669933}
-
Carlos Knippschild authored
Bug: 975917, 975554, 969994, 967482, 967480, 967475, 967473 Change-Id: Ibffc2a210357fd74cc81bc9ec9f7708caa2d98d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663015 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#669932}
-
Ahmed Mehfooz authored
Collapse Animation has been changed. Buttons below the second row now move downwards and fade out. Similarly, buttons on the second page or later also move downwards and fade out. If the tray is collapsed when not on the first page, there is a smooth back and forth transition between the selected page and the first page while collapsing or expanding back from a partially collapsed state. Add transition durations for page switching. Animation Example Video: https://screencast.googleplex.com/cast/NTg4NTIyMDQ3OTgyNzk2OHw2NWUxZDkwMy05NQ Bug: 914077 Change-Id: I81cdd01f61b5a902f530829a3488db3723271f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610641 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#669931}
-
Becca Hughes authored
Extend preload histograms to M82 because these are important when updating the preload list. BUG=975372 Change-Id: Id88067c761b79c59d2b89cf1bc564b1683bd3b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663073Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#669930}
-
Matthew Mourgos authored
Bug: 877567 Change-Id: Ieabdd88c52daf2bdea0f07dd419f72d193e48832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652690 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#669929}
-
Shakti Sahu authored
This CL fixes the renames to be reflected on the download home UI correctly without triggering notifications. 1 - Added an observer method OnDownloadRenamed to DownloadItem::Observer 2 - DownloadOfflineContentProvider observes the renames through an AllDownloadEventNotifier::Observer 3 - Fixed the ignore update logic at OfflineContentAggregatorNotificationBridgeUi Change-Id: I82f3415f8e70814c00037890c400165eedbf23b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661353Reviewed-by:Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#669928}
-
Robert Ogden authored
This PostTask should be using the UI thread, see bug. Bug: 974829 Change-Id: Ic437d92ab542969a50bbcfc08b83171ad4bf6f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661401Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#669927}
-
Leo Zhang authored
Implement platform support for loading shared library in decoder. This feature will be disabled by default and only compiled when flag enable_cros_ime_decoder in chromeos/services/ime/public/features.gni is turned on. Bug: 837156 Change-Id: Iaec701361f50061ded08a1998975a521701b0387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659553Reviewed-by:
Marti Wong <martiw@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669926}
-
Rohit Rao authored
Xcode11 now requires this plist key to be present for all apps. BUG=None Change-Id: I9d88f9da68e096d5f852a6f644a23ac3db1bd132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663358 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#669925}
-
Matt Menke authored
The restricted headers potentially give Chrome and the server its talking different views of what's going on for the rest of a transaction, so it isn't a great idea to allow setting them. Proxy headers are also restricted. Bug: 973103 Change-Id: Id014181a332252d908c6255cc7c2593a4be781f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659194Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#669924}
-
Giovanni Ortuño Urquidi authored
Overscrolling for app windows was disabled in [1] because it was making the Files video player slow. (old overscroll code used to take a screenshot after each navigation and the video player was navigating every 5 seconds). The code was later optimized to reduce the number of screenshots taken, and eventually the code to take screenshots was removed[2]. There is no reason why the feature has to remain disabled now that we don't take screenshots. [1] https://codereview.chromium.org/12082083 [2] https://chromium.googlesource.com/chromium/src/+/6e6c40b4697e889533a480fa04ffb2eb96dcda1d Bug: 747587 Change-Id: I24b499b7f4c2f412d5efa2f687c9d96dd4cdd5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659650 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#669923}
-
Ben Pastene authored
This reverts commit dc15ca61. Reason for revert: suspected to be causing link failures on android "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408 Original change's description: > [DevTools] Roll inspector_protocol and migrate to std::vector. > > New revision: 83b1154a9661d22bba9a368d368214cc20880419 > > This updates the usages of the protocol types to the new > definitions, using std::vector-based implementations > of protocol::Array. > - In many places we can now use the C++11 style for( : ) loops. > - We use std::make_unique for creation. > - We use emplace_back to insert elements, which sometimes > allows us to create strings etc. in place. > - Accessing strings in arrays is cheaper, since vector[i] > returns a reference (protocol::Array::get made a copy!). > - One can assert equivalence of vectors with strings > in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); > - Overall the code is shorter, as the vector API is > more concise. > > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669857} TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#669922}
-
John Z Wu authored
Convert to member variable. Change-Id: I0985910a2730b3668796d706ab52cb12a7a8ba11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659630 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#669921}
-
jorgegil@google.com authored
PointerTest.IgnorePointerEventDuringModal was passing when it shouldn't have been. These change fixes it with correct assertions and splits it into three separate and more clear test scenarios. Bug: 973693 Test: exo_unittests Change-Id: Icd9b95a8634ff47cb12ae55208229d9a15c69fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658840 Auto-Submit: Jorge Gil <jorgegil@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#669920}
-
Malay Keshav authored
This patch performs multiple tasks: - Removes redundant license information from js file. - Fixes unicode characters to be ascii when minifying. - Updates the README to give the correct minification parameters. - Add BUILD.gn file Bug: 958684 Change-Id: I7f39cd22f081fcdae6f463ba7da2364e425986b2 TESTED: Build chrome os locally with lottie Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663379Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#669919}
-
Nicholas Hollingum authored
This cl adds the templating engine which is used to generate the proto and the harness used by the fuzzer. The templater uses Jinja2 and has a .gni wrapper for ease of use in our build system. I have confirmed that the fuzzer has more coverage than the prototype in crrev.com/c/1640526, however it requires further work to improve the coverage to the desired levels. Bug: 961564 Change-Id: Ie27d7ff0b97cf3ed88dadfebf4d977682054c699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645134Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#669918}
-
Sergey Ulanov authored
Without format ClientNativePixmap cannot verify that the handle it received is valid. Bug: 957314 Change-Id: I387c6d7e43feb9e129a6e84313494c175bf6ed71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661059Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#669917}
-
tby authored
This is the V2 model for query-based mixed-types ranking. For experimentation purposes V1 has been kept also, and the instantiation of one, the other, or neither, is controlled by finch parameters. Bug: 931149 Change-Id: I4ecdbfc98dfed330a6e7406b33e89171838170c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661317Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#669916}
-
Alex Danilo authored
Fix stale comments that referred to PanelEntry objects, which are now called PanelItem. Fix/update Closure annotations. Bug: 947388 Change-Id: Ic9945e0c160723c9d38867fd22a47d9cff521d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657517Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669915}
-
Sergey Ulanov authored
Two fixes for AudioOutputStreamFuchsia: - Don't call Play() until after the first SendPacket() call as is required by the AudioRenderer interface. - Add padding to min_lead_time_ for the first packet, to reduce the chance that samples at the beginning of the stream are dropped. Bug: 974029 Change-Id: If2dc43a3df7d671a42f7983dea130fa3b10ad1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659230 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#669914}
-
Peng Huang authored
Without those two extensions, vulkan validation layers will report errors Bug: None Change-Id: I1117fc03c3d322b3e51955591fea13b4db247a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662836Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#669913}
-
Andrew Lee authored
This is a small bug which is caused by this CL merged yesterday (https://chromium-review.googlesource.com/c/chromium/src/+/1636889). This error occurs because DCHECK(!property_trees->needs_rebuild) fails. While we try to drag elements on the dom tree UI, the property trees need to be updated again, hence property_trees->needs_rebuild = true. We can easily avoid this error by only calling GetRenderSurfaceReason() when rebuild is NOT required. Bug: 973092 Change-Id: Ifdb49d7e81d32f6bcff73662ef34f0118d4abf50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650640 Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#669912}
-
Jon Mann authored
This field is now only shown under the "Network" details pane. Bug: 924246 Change-Id: Ibdd6d722d26792a2ab108392721ae88a0abb2fb6 Screenshot: https://screenshot.googleplex.com/24ayhPiZrWw.png Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663076 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#669911}
-
Noel Gordon authored
DriveFs shipped and it reports Team Drive modification time: show that time in the file list. Bug: 867153 Change-Id: I8569e90687ef22f6d67ef8ae032aa80d21acb09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660302Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669910}
-
Min Chen authored
Bug: 937907 Change-Id: I33f0fab2b6c2147994c8ec64c9bdd142bea71d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662988 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#669909}
-
sczs authored
Previously we were simply updating the BadgeUI, but the backing variable for the badge state wasn't being updated. Updating the badgeState also triggers an Update of the UI per line 171. Bug: 972113, 911864 Change-Id: Iaff8d95bde53df319ef957d8ad27040610b8f89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648664Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#669908}
-