- 16 Oct, 2018 40 commits
-
-
Mugdha Lakhani authored
JobDetails into one JobState enum. as promised in a previous review comment: https://chromium-review.googlesource.com/c/chromium/src/+/1249075/3/chrome/browser/background_fetch/background_fetch_delegate_impl.h#133 Change-Id: I442acd04f01b7e5e75a6db3977ff373f3bb620aa Reviewed-on: https://chromium-review.googlesource.com/c/1280842 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600062}
-
Kenneth Russell authored
This reverts commit 9780253f. Reason for revert: test failure was real, and caused by https://chromium-review.googlesource.com/1267235 , which has since been reverted. Original change's description: > Disable ContextLost_WebGLUnblockedAfterUserInitiatedReload > > gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLUnblockedAfterUserInitiatedReload in context_lost_tests > is flaky on Win10 Debug > > TBR=kbr@chromium.org > > Bug: 895765, 879423 > Change-Id: Ic36400494df68f257329e040be2c72f1ad2ec3a6 > Reviewed-on: https://chromium-review.googlesource.com/c/1283049 > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599973} TBR=kbr@chromium.org,cfroussios@chromium.org Change-Id: I33951694d070e6eb183eba9a05d9ea517f81ce65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 895765, 879423 Reviewed-on: https://chromium-review.googlesource.com/c/1283945Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600061}
-
Hans Wennborg authored
Recent versions of Clang started taking enumerations into account for the -Wshadow warning, e.g. ../../third_party/blink/renderer/core/html/forms/html_select_element.h:237:5: warning: declaration shadows a variable in namespace 'blink' [-Wshadow] kDispatchInputAndChangeEvent = 1 << 1, ^ ../../third_party/blink/renderer/core/html/forms/text_control_element.h:48:3: note: previous declaration is here kDispatchInputAndChangeEvent ^ Fix this by adding a Flag suffix to the enumerations, which is good for clarity too. Bug: 895475 Change-Id: Ie9225dc711fc3985a46c2f56040bc56c8a451495 Reviewed-on: https://chromium-review.googlesource.com/c/1283749Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#600060}
-
timidger authored
This is to remain consistent in how the Chrome Cleanup Tool removes other force installed extensions. They interact badly with administrator permissions and so removing them entirely is cleaner than simply disabling like we do with normally installed extensions when the cleanup tool detects UwS. Change-Id: I1b6b814d521e78edccd7c603f1eae3ef7a9a6c5f Reviewed-on: https://chromium-review.googlesource.com/c/1278852Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Preston Carpenter <timidger@google.com> Cr-Commit-Position: refs/heads/master@{#600059}
-
Sergio Villar Senin authored
It was using SigninManagerBase API to get the primary (authenticated) account id. It's now using the IdentityManager API. Bug: 890806 Change-Id: I2902cd16c4040301f84d238dc46ca2b8f9e10793 Reviewed-on: https://chromium-review.googlesource.com/c/1276609 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#600058}
-
Oksana Zhuravlova authored
Change-Id: I7c6d15d75fd6ea4a936729bc2b07445778fae165 Reviewed-on: https://chromium-review.googlesource.com/c/1281867Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#600057}
-
Tien Mai authored
- Make sure all registry entries created by GCP is not hardcoded to chrome - Make sure we can install different versions of the GCP for Chrome/Chromium Bug: 883943 Change-Id: I72aa14545ad7b0ab4320b14baf210b3b80979ffe Reviewed-on: https://chromium-review.googlesource.com/c/1278503Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#600056}
-
Mike Wasserman authored
ClosingView is destroyed during its call to Widget::CloseNow(). ClosingView::widget_ should not be accesses after calling CloseNow(). Bug: 895882 Test: No flaky crashes Change-Id: I40bb3306e969332191fc7118a905eee5900f0f2e Reviewed-on: https://chromium-review.googlesource.com/c/1283690Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600055}
-
Weidong Guo authored
The original change fixed the bounds for app list window, but not for its parent, so the issue is not fixed entirely. Fix it for the parent window in this CL. Bug: 884889 Change-Id: I6a48bae85fd3d89957d58a4aabf270c7df288d5d Reviewed-on: https://chromium-review.googlesource.com/c/1282386 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#600054}
-
Sky Malice authored
Specifics: +731,605 bytes normalized apk size +5 zip entries file count +58,328 bytes main lib size +452,576 bytes main dex size InstallSize: +281,657 bytes APK size +2,110,064.04 bytes Estimated installed size InstallBreakdown (+2,105,796.04 bytes): +2,628 bytes unwind_cfi (dev and canary only) size +1,883 bytes Non-compiled Android resources size +58,328 bytes Native code size +344 bytes Package metadata size +2,027,013.04 bytes Java code size +15,600 bytes Compiled Android resources size Dex: +2,305 entries fields +3,207 entries methods +757 entries types +1,604 entries strings Change-Id: Ic9266a66c247d20fa0872235b2b0d2b4a46afd7e Reviewed-on: https://chromium-review.googlesource.com/c/1282029Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#600053}
-
Johannes Henkel authored
This is in preparation of referencing this type from the code generated by third_party/inspector_protocol/code_generator.py. My overall WIP change is in here, and happy to explain more: https://chromium-review.googlesource.com/c/chromium/src/+/1244719 Bug: chromium:891377 Change-Id: I2e59d49bbe333bb132ea8e16fcac2dace589f163 Reviewed-on: https://chromium-review.googlesource.com/c/1282224 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600052}
-
Johannes Henkel authored
This is in preparation of referencing this type from the code generated by third_party/inspector_protocol/code_generator.py. My overall WIP change is in here, and happy to explain more: https://chromium-review.googlesource.com/c/chromium/src/+/1244719 Bug: chromium:891377 Change-Id: I9fbb8b980e522c0063f96a8a2a42498903d445a8 Reviewed-on: https://chromium-review.googlesource.com/c/1282208 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Peter Boström authored
Before this change, a square focus ring was recently added to make sure that text set using chrome.browserAction.setBadgeText was not clipped by the focus ring. This new focus-ring style unfortunately looks very out of place, so this change just removes the FocusRing::SetPath call so that it matches the ink-drop style (and focus-ring style) of all toolbar buttons. Obscuring the badge text is not too bad here since the text is clearly visible when the view is not in focus and only partially occluded with the focus ring present. Bug: chromium:895263 Change-Id: I210893c84c138944f12923a1b844c833134ff7bb Reviewed-on: https://chromium-review.googlesource.com/c/1281904Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#600050}
-
Dan Harrington authored
Previously, prefetch articles were showing notification on download, and showing up in the wrong place in Downloads. I verified the fix locally. Bug: 895906 Change-Id: I893ec8232f40d1f4a27ee7b89e860c39ca9b3cfe Reviewed-on: https://chromium-review.googlesource.com/c/1283849Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#600049}
-
Sergio Villar Senin authored
It's currently using the SigninManager API to retrieve the currently authenticated account's email. Replaced by the IdentityManager equivalent API so it could eventually use the identity service. Bug: 890776 Change-Id: I2ed33724ec940d955fbe10bfbc1eaaea29ea473a Reviewed-on: https://chromium-review.googlesource.com/c/1280276Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#600048}
-
Wez authored
We don't implemented Mojo named channels under Fuchsia, so remove those test cases. Bug: 754038 Change-Id: Iac1d282d69fd972e3efa26db412f0ffcb4afe993 Reviewed-on: https://chromium-review.googlesource.com/c/1282723 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55fbadac66fe..ffad1c5fd295 Created with: gclient setdep -r src-internal@ffad1c5fd295 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1764f2769107934b30d4c4881c113e54c4ae2c6d Reviewed-on: https://chromium-review.googlesource.com/c/1283513Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600046}
-
Adam Rice authored
This will permit Windows authentication to work with WebSockets. See Intent to Ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/kEtUcy7W0fU/dTyvzUy0BgAJ Turn on the WebSocketHandshakeReuseConnection feature by default. Test coverage for the old behaviour has been removed; since the flag itself will be removed in the next version, this seems acceptable. BUG=423609 Change-Id: I1373b7b4adcfe695f56a174a7fed2a3bd67ad56b Reviewed-on: https://chromium-review.googlesource.com/c/1283349Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#600045}
-
Chase Phillips authored
Previously, defines in Blink variants would be set to both the Chromium and the Blink variants export_define* values. This isn't correct since Blink variants must export their own defines. This CL causes Blink variants to only define what's set with export_define_blink. Bug: 717812 Change-Id: Ie554cef3044eba6e4ee093098b9c4afedaecd89e Reviewed-on: https://chromium-review.googlesource.com/c/1282209Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c0c9df23b38c..f7eaeb14ee78 git log c0c9df23b38c..f7eaeb14ee78 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 treehugger-gerrit@google.com Merge "profiling: Properly align register_data." Created with: gclient setdep -r src/third_party/perfetto@f7eaeb14ee78 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8adc047f533d90779608cc87d652212b113ddb0d Reviewed-on: https://chromium-review.googlesource.com/c/1283512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600043}
-
Ben Pastene authored
This reverts commit 7f0c13c7. Reason for revert: we don't have the capacity :( https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel Original change's description: > Move telemetry_unittests from cros VM fyi bot to CQ bot. > > Bug: 876494 > Change-Id: Icfa8631e1278745a50e439d78b4373fb1f0f1f3a > Reviewed-on: https://chromium-review.googlesource.com/c/1281230 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599851} TBR=achuith@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I8b9981920ec5078da9147e0ef36d2c96028501b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876494 Reviewed-on: https://chromium-review.googlesource.com/c/1283932Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#600042}
-
zork@chromium.org authored
Bug: 894790 Change-Id: I67d67ee8849e97195fe8e5bf82f83b8f809145a6 Reviewed-on: https://chromium-review.googlesource.com/c/1281236Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Zachary Kuznia <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#600041}
-
Katie D authored
In the newer shelf UI, the node classname might not be the tray classname, but one of its ancestors is instead. Bug: 894663 Change-Id: I90f5c09d186b7d1d0cb278c310b3ad42e6c1c62d Reviewed-on: https://chromium-review.googlesource.com/c/1278268Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#600040}
-
Johannes Henkel authored
This means it's up to the client of the protocol layer to decode the base64, just like before the introduction of 'binary'. My overall WIP change is in here, and happy to explain more: https://chromium-review.googlesource.com/c/chromium/src/+/1244719 Bug: chromium:891377 Change-Id: I60762ff2a815afe2bb0b69480340f1904a1d9909 Reviewed-on: https://chromium-review.googlesource.com/c/1281877 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/70bac6b6f68d..b708a096f473 git log 70bac6b6f68d..b708a096f473 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 dgarrett@google.com chromeos_config: Move external CQ to swarming. Created with: gclient setdep -r src/third_party/chromite@b708a096f473 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I90518efd9a553f47022375d86d93b43bca6445c0 Reviewed-on: https://chromium-review.googlesource.com/c/1283511Reviewed-by:
-
Pete Williamson authored
Some sites were being added to the blacklist properly, but not filtered out when doing the join against the blacklist table. This happened because the sites in our database did not consistently end with "/", but sometimes a "/" got added before we put the site into the blacklist. The fix here is to pass all sites through GURL and get the spec after parsing, so they will be consistent. Bug: 893845 Change-Id: Id705aab833da546c57950fad115c694b96c5fd24 Reviewed-on: https://chromium-review.googlesource.com/c/1281176Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#600037}
-
Vladimir Levin authored
This patch introduces a flag for layout view isolation nodes, since it seems to have caused a memory regression. The flag would allow to easily test the memory usage and other perf benefits. I'll remove the flag and enable by default when the problems are resolved. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Bug: 895270 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaa74c997dc3d211d0a870fdff303a9c94b5312e9 Reviewed-on: https://chromium-review.googlesource.com/c/1282204Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600036}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1ac3fe80647..6eba3c6104f2 git log a1ac3fe80647..6eba3c6104f2 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 syoussefi@chromium.org Vulkan: Distinguish query operations in GraphViz output Created with: gclient setdep -r src/third_party/angle@6eba3c6104f2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie710a582403e0e672abf09b13428b0fbfbfdf7db Reviewed-on: https://chromium-review.googlesource.com/c/1282347Reviewed-by:
-
Xida Chen authored
These 3 tests seem flaky. It appears that GetEffectiveTouchActionForChild fails to update the |whitelisted_touch_action| sometimes and hence it remains the old value. This CL tries to deflake these tests, but resetting the |whitelisted_touch_action| before it is used. Bug: 888155 Change-Id: I49a6c32adcaf1d61d314125493ccf56473f8fa30 Reviewed-on: https://chromium-review.googlesource.com/c/1278846 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#600034}
-
Xiaohan Wang authored
Instead of stripping the codec string and table look-up by stripped codec string, use MimeUtil ParseAudioCodecString() and ParseVideoCodecString() to convert the codec string to media AudioCodec/VideoCodec, then have dedicated functions to convert media codecs to EmeCodecs. Bug: 707127 Test: All existing tests pass. Change-Id: I9a69a76bd8acc6ef7cb23ef6630c258df3f5347f Reviewed-on: https://chromium-review.googlesource.com/c/1277613 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#600033}
-
Leonard Grey authored
Bug: 846796 Change-Id: If5ba4f29ace1dce12e13a9bfdae3ee9154811187 Reviewed-on: https://chromium-review.googlesource.com/c/1283549Reviewed-by:
-
Paul Jensen authored
Response may be broken into multple reads. Adjust test to handle this appropriately. Bug: 895621 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I41ed850f8d39b7c48bc209669afa0cb06ab23d20 Reviewed-on: https://chromium-review.googlesource.com/c/1283409Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600031}
-
Fady Samuel authored
SurfaceAggregator had a bunch of not-so-useful UMA like ManhattanDistanceToPrimary, UsingFallbackSurface and ValidSurfaces. These metrics don't really provide anything actionable. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Icf095d2cc307ef90ec9bc5f826bf972775961788 Reviewed-on: https://chromium-review.googlesource.com/c/1283472Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600030}
-
sczs authored
- Makes InfobarCoordinator conform to the UpgradeCenterClient protocol. - Adds a isInfobarPresentingForTab method to InfobarCoordinator. Bug: 892376 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I11e8d15a05c196765caff39885aa14053870817f Reviewed-on: https://chromium-review.googlesource.com/c/1281862 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600029}
-
Yuichiro Hanada authored
We disable Chrome OS VK while ARC++ IME by observing OnActivate/OnDeactivate event, but it's not called when the IME is removed. This CL moves the logic to disable/re-enable Chrome OS VK to InputMethodChanged which is called always when the active IME is changed. Bug: 895728 Test: manual & unit_tests Change-Id: If57a725de23ae3315046bc4f511ac9d343bfbf8d Reviewed-on: https://chromium-review.googlesource.com/c/1282690 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600028}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/renderer_context_menu. This CL was uploaded by git cl split. R=avi@chromium.org Bug: 809610 Change-Id: Ib7d5220acd85a864cea773ed2a6ca66611beaf66 Reviewed-on: https://chromium-review.googlesource.com/c/1259031Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600027}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api/lock_screen_data. This CL was uploaded by git cl split. R=rkc@chromium.org Bug: 809610 Change-Id: Id88e7e119165588735fe1032a95af99b71caf706 Reviewed-on: https://chromium-review.googlesource.com/c/1259029Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/apps/platform_apps/api/easy_unlock_private. This CL was uploaded by git cl split. R=jhawkins@chromium.org Bug: 809610 Change-Id: I491e41bd7735ed3a940594eb11f88542dcc0e3e5 Reviewed-on: https://chromium-review.googlesource.com/c/1258906Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600025}
-
Jan Wilken Doerrie authored
This change is a follow-up to r599728 that renamed index to id in passwords_private.idl. That change missed to update password_manager_proxy.js, which is fixed by this change. Bug: 892260, 895785 Change-Id: Id1ae5e6e46f8dd66c51bb01988b537ec99a1975c Reviewed-on: https://chromium-review.googlesource.com/c/1283129Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#600024}
-
Scott Violet authored
The trace event macro in LayerTreeHostImpl::DidPresentCompositorFrame() moves to ui::Compositor::DidPresentCompositorFrame(), and Compositor/WindowTreeHost get the ability to provide an additional value that is then passed to the macro. This value will be later used to identify where the frame came from. BUG=883894 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1341c39029c54228964e433de5aafa1c89099e0b Reviewed-on: https://chromium-review.googlesource.com/c/1282039Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600023}
-
