GitLab

This change replaces the old time icon with the new material icon

Bug: 1021339
Change-Id: I1ae90a44e01c477097c19f0b94e4e3437a709233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014153Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#734220}

The Drallion (Wilco 1.5) keyboard has a slightly different layout than
Wilco 1.0:

1. The toggle mirror mode button has moved from F12 to its own key
without a corresponding F key.
2. F12 now shares a key with privacy screen toggle on devices with a
privacy screen.

BUG=b:147241224
TEST=build and deploy chrome to a Drallion DUT:
autoninja -C out_drallion/Release chrome chrome_sandbox nacl_helper;
deploy_chrome --build-dir=out_drallion/Release --to={DUT_IP};

Verify that top row keys map to expected key codes:
Privacy Screen -> VKEY_PRIVACY_SCREEN_TOGGLE
Privacy Screen + Fn -> VKEY_F12
Privacy Screen + Search -> VKEY_F12
Privacy Screen + Fn + Search -> VKEY_PRIVACY_SCREEN_TOGGLE

Mirror toggle key always maps to VKEY_MEDIA_LAUNCH_APP2 with Control
held down, regardless of Fn and Search key states.

Change-Id: I8df3d28d7ea9445d736ec831b4423f2c224dd592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008063
Commit-Queue: Mike Wiitala <mwiitala@google.com>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734219}

Secure DNS will be disabled in these windows, allowing users to
complete the captive portal resolution process.

Future cls will add additional conditions that will trigger captive
portal probes in secure mode.

Change-Id: I441d17465a9c9d11567775321ed3ddd8532598ab
Bug: 10161646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984663Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#734218}

https://chromium.googlesource.com/catapult.git/+log/b9cc8d75a2ad..bc9b29411747

git log b9cc8d75a2ad..bc9b29411747 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 bsheedy@chromium.org Workaround CrOS root partition read-only

Created with:
  gclient setdep -r src/third_party/catapult@bc9b29411747

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC nuskos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1043953
Tbr: nuskos@google.com
Change-Id: I660987f0c6598ee82936ed502ed292ba108a607f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734217}

This is the first file to be moved into the new flags module.

This is CL 3/3 to move ChromeFeatureList to chrome/browser/flags:java

Bug: 1041468
Change-Id: Ie52917a32896d7ee721c4b2278fa7bc6884b417d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007315
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734216}

In ImageResourceContent, |observers_| and |finished_observers_| can both
contain an |observer|. Therefore, in RemoveObserver(), if removing from
|observers_|, it's only fully removed if it does not exist in
|finished_observers_|.

Bug: 1041707
Change-Id: Ia21f21627d62e19788216cfc010715646ee4842d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011137Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734215}

This is limited to bound WebAPKs. This is the first step to make WebAPKs
discoverable via getInstalledRelatedApps.

Bug: 1043970
Change-Id: I1cbb86159d15554c129894b6c405c1efefa42587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012287
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734214}

We calculate clip rects for the underline intersections with glyphs to
clip out the underline. These intercepts are calculated by Skia and can
be infinite which results in an invalid clip-out paint op. This patch
skips these degenerate clips-outs. This is not done for all clips
because the common case is to clip from values from the layout system
which will be finite. This is not done in the intercept calculation
code because infinite values are correct for extreme glyph positions.

Bug: 1043753
Change-Id: I0b63eb892840994537b7fec4fd9b2313f74a7d14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014310
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734213}

This CL fixes a use case when a grouped tab is added before an already
grouped tab. Before, the tab would get appended to the end of the list
because it was not updating the |elementAtIndex| variable to be the
correct element.

Bug: 1027373
Change-Id: I1eaec3b950576ac06fd7b927cb4f23ce7810cc36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013584
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734212}

Pass currentFrameId to cookie operations where missing so that Cookie
operations run against the current execution context. This conforms with
WebDriver spec. This cl will affect only cases where the main context url and the frame URL are different.

Bug: chromedriver:3153
Change-Id: Idc4d14628ec5c00e153a3e75e38e3648cdc226a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987078Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734211}

Send the DidFinishDocumentLoad IPC directly from blink. The
WebLocalFrameClient callback is still necessary because
of RenderFrameObservers that need to listen for the load complete.

BUG=1042831

Change-Id: I39a487268c90195c8dd94c9862e7a6bd695ba213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005376
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734210}

This reverts commit d84a78f8.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 734144 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDg0YTc4Zjg2MjY2ZmI5MTllZjU0NzU4ZDZhNzdmMGZjODVmZmUyYgw

Sample Failed Build: https://ci.chromium.org/b/8890527503070869360

Sample Failed Step: content_browsertests

Sample Flaky Test: BackgroundTracingManagerBrowserTest.PerfettoSystemBackgroundScenarioRuleId

Original change's description:
> Enable system perfetto producer on all posix builds.
> 
> It remains disabled by default by the tracing flag
> --enable-features=kEnablePerfettoSystemTracing, but when enabled will
> attempt to connect to the result of GetProducerSocket().
> 
> This will be useful for people who want system wide tracing on linux
> from crashed browser processes since the tracing service will be alive
> even after Chrome dies.
> 
> Bug: 1007310
> Change-Id: I62e67bcdc9ff720da2a59497a6d3ebf855413b8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953718
> Auto-Submit: Stephen Nusko <nuskos@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734144}


Change-Id: I1edd45928f698173aa53dc1d00f4229ef7a877d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1007310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015774
Cr-Commit-Position: refs/heads/master@{#734209}

This is a necessary pre-cursor to cleaning up scheme initialization.
No GURLs should be created before schemes are modified/added and GURL
is ready to use. Enforcement of this will come in a followup CL.

See the bug for additional context.

Replacing static initalizers with functions ensures the GURLs are
only initialized when used, which happens after test setup.

Bug: 783819
Change-Id: I1d0f3e81ce47903156937e5e8e58db49d287eaba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008008
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734208}

Bug: 1044413
Test: Manual
Change-Id: I59eb13ef6e80c72c49eb9c8271ed9f70c063a9aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014120Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734207}

This patch caused a leak in IntersectionObserverController:

https://chromium-review.googlesource.com/c/chromium/src/+/1774244

In particular, if an explicit-root IntersectionObserver was destroyed
because it had no observations and no javascript references to it,
then IntersectionObserverController would continue to track the root
Element.

This patch overhauls the way the tracking bookkeeping is handled for
explicit-root observers, and guarantees two important cases:

- If the observer dies, the root will no longer be tracked.
- If the root element dies, any remaining observations will be
disconnected.

Change-Id: Ieb3822a4735850c7baae4ef32e7826f3eda10fb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008528
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734206}

https://chromium.googlesource.com/webm/libvpx.git/+log/50d1a4aa725f..7763c888e0c0

$ git log 50d1a4aa7..7763c888e --date=short --no-merges --format='%ad %ae %s'
2020-01-21 jianj vp9: fix control for delta qp for uv
2020-01-17 jzern add static_assert.h
2020-01-16 bpfoley Validate data used by vpx_codec_control...
2020-01-16 jianj vp9: add delta q for uv channel. add tests.
2020-01-13 chengchen Add comments to frame counts.
2020-01-10 jzern vp9_encoder.c,cosmetics: fix some typos
2020-01-10 jzern simple_encode*.cc: add missing copyright
2020-01-10 johannkoenig trivial: fix spelling errors
2020-01-09 jianj Fix test failure with --size-limit
2020-01-02 chengchen Copy frame counts to the encode result.
2020-01-07 courbet Avoid reloads in vp9_read_mode_info.
2019-12-18 wonkap Add text to clarify the unit of variables for target bitrate

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: Ia6da9c7fa7239908ea95025290b420af37e123c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014984Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#734205}

Shipping the passthrough command decoder on macOS is planned soon and
it's crucial to test this configuration on incoming ANGLE CLs.

Bug: angleproject:2273
Change-Id: I6fad76febc0e417fd6f741215a52443958345e6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013864Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734204}

In crbug.com/767924, we started syncing printers with invalid PPD
references. Since tracking, we found enough users with saved printers in
this invalid state to fix.

Bug: chromium:987869
Test: written tests confirm correct resolution
Change-Id: I406bdaf3e7658db42db9c408feadba6f579edb11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008135Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734203}

Adjust tests so that response returns text/css in order
to not fail these tests once stylesheet loading gets more strict.

Bug: 752830

Change-Id: I51ada4de148c384842911f001761b97f71a9082a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007112Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#734202}

In https://chromium-review.googlesource.com/c/chromium/src/+/1966385
we move IsFixedBlockSizeIndefinite out of MaySkipLayout and into the
caching layer.

This wasn't paired with moving this bit into AreSizeConstraintsEqual.

This caused us to skip a layout, when we couldn't. :(

Bug: 1043071
Change-Id: Idbb68e136efe21b77394466a16a7ec3b06abe06d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015101Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734201}

Register them in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: Ica20f108c27b33a04a547713d344e0d11f646278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011291Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734200}

TBR=govind@chromium.org

Change-Id: Ibd8f735fe8857ee365bf2f4419f53a9c3e3b6df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015224Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734199}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a5aa6680ce4..bdd89366d34e

git log 6a5aa6680ce4..bdd89366d34e --date=short --first-parent --format='%ad %ae %s'
2020-01-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@bdd89366d34e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Id785b3c5c49d0b89690271dbe7a548c0f32820a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015381Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734198}

This CL adds code to compare a version in Finch parameter and local
version cached in PrefService, and show a notification when the
version from Finch is newer.

The notification logic will be added in following CL.

Bug: 1042124
Change-Id: Ie2ab1250557517554abb142a0a0c5ee31eb95d75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006418Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734197}

menthod -> method

Change-Id: I93d84de0e7105a27ae765488cf0ec000c0c84909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015048Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734196}

This CL begins organizing code for Feed v2 by pulling some enums
into a new common directory.

Putting shared code in a different place makes it easier to understand
implications of modifying code, and will make it easier to understand
what pieces of code effect the 'v2' effort.

I'm starting with a few enums because they are very likely to remain
identical. More code will be moved here soon.

Bug: 1044139
Change-Id: I51f83f2fdc212aba9f72a1e9afd2ef8e79437e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012903
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734195}

Currently, SkiaOutputDeviceBufferQueue::Reshape() will cancel all
pending swap completion callbacks. It will generate wrong UMA data.
So instead of canceling pending callbacks during Reshape(), we just make
the image bind to the callback be weak ptr. So the callback can handle
it properly.

Bug: None
Change-Id: I05e943d193ff868063538899eb899fcd767ae7ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013807
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734194}

This test fails because the cleanup to "unsubscribe" cookies would
occur after the registration has already been unregistered for
non-workers.  This change removes the cleanup to "unsubscribe" and
just relies on "unregister" for cleanup.

The flaky failures can be reproduced locally using the following gn args
and commandline. (Googlers: http://screen/E7px76cVS2E)

gn args:
dcheck_always_on = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = false
mac_deterministic_build = true
proprietary_codecs = true
symbol_level = 1
use_goma = true

command: python third_party/blink/tools/run_web_tests.py -t LinuxTest third_party/blink/web_tests/external/wpt/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.js --gtest_repeat=20

Bug: 1029713
Change-Id: Ifa766b974bddfcc6ee43e60be0766c1cb80cb742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014100
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734193}

Split GpuMode::HARDWARE_ACCELERATED into HARDWARE_GL, HARDWARE_VULKAN,
and HARDWARE_METAL. Then, during GpuDataManagerImpl initialization, add
GL to the |fallback_modes_| stack, followed by Vulkan or Metal if they
are enabled.

GL can still be used in the Vulkan and Metal modes, but disable Vulkan
and Metal when the GPU is not running in that mode. This way, the first
GPU fallback will still leave hardware acceleration available.

Note that this doesn't check what Vulkan or Metal are being used for.
For instance, with the flag --use-vulkan=native, Vulkan will be
initialized, but Skia GL will still be used for compositing without the
flag --enable-features=Vulkan. In this case, the first fallback will
disable Vulkan anyway, and the second will disable GL.

Bug: 1005383
Change-Id: I2cc46b4861f325883f8324bde541410440764c3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976827
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734192}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6b291043..1bcbb571

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I682f7f579c9316eb42a851aa5debc5284da1cdc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014822Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734191}

Bug: 1042063
Change-Id: Ic419294853e42f951ca7586b81a19b5171ff7e95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013927Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734190}

Not sure why it was not done previously.

R=sandersd

Change-Id: Ifc72071add5ce1a753d4ffab977826a9ac56d964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013910
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734189}

If a physical keyboard is connected to a tablet, the virtual keyboard is
disabled and trying to show/hide it will trigger a DCHECK.

My newly introduced code in |AssistantDialogPlate| did not take that
into account (it now checks KeyboardUiController::IsEnabled()).

While writing the unittest to test this, I discovered the existing
|AshTestBase::SetTouchKeyboardEnabled| did not actually work:
   - Trying to enable the keyboard by using
     |SetTouchKeyboardEnabled(true)| does not actually enable the
     keyboard, as it was immediately disabled again as soon as the
     |DeviceDataManager| detected the presence of the actual physical
     keyboard connected to the test PC.
     To work around this, everybody who used this method also set the
     command line switch |kEnableVirtualKeyboard|, which simply
     overruled the value set by |SetTouchKeyboardEnabled|.
   - Trying to disable the keyboard later on by using
     |SetTouchKeyboardEnabled(false)| didn't disable the keyboard as
     the change was overruled by the command line switch
     |kEnableVirtualKeyboard|.
So to solve this, I removed the |SetTouchKeyboardEnabled| and replaced
it with a |AshTestBase::SetVirtualKeyboardEnabled| method which uses a
different set of flags (|kPolicyEnabled|/|kPolicyDisabled|) which are
always respected during the unittests.

Bug: b/147700828
TBR: shend@
Change-Id: I6137993a4ce5200cff400e882820580fa87d592c
Tests: New ash_unittest |AssistantPageViewTabletModeTest.ShouldNotShowKeyboardWhenItsDisabled|.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002742
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734188}

Fix a TODO in code to replace 29 with Build.VERSION_CODES.Q

Bug: 993538
Change-Id: I8b50ffa775912078a2b1b30579ffbeca0129e42c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007743Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Auto-Submit: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734187}

Bug: 1035491
Change-Id: I753b551900e7646558031f36b2ab011f671c3c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006308Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734186}

Change-Id: I17e63afd2b8dfc5e6758b7b02e74887c2c605cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012888
Commit-Queue: Bin Wu <wub@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734185}

Plumbs through various implementations including mojo.
Adds typemaps for the new mojo types.

Necessary for making predections in the renderer. A follow up CL will
call the API to make smoothness predictions for MediaCapabilities.

Change-Id: Ib6e46b2ac7f375bd343e1b9cda389ecf82eb880f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009843
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734184}

This fix changes focus ring colors for all ui elements
in the system menu to Google blue 300.

Bug: 960116
Change-Id: I2ad84b88168521240ac12434ab2a2d83fd704bf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006266Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734183}

The opacity filter canvas should calculate the alpha with opacity
according to the origin paint's alpha.

Bug: 1044493

Change-Id: I8f1ba00ffd75a7d455b925ed841a14ae92419a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012360Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734182}

TBR=masonfreed@chromium.org

Bug: 1044715
Bug: 1044712
Change-Id: I7bcdc1b00ab1b31dd210ae25265d553990d5f5ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015643Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734181}