- 17 Dec, 2020 40 commits
-
-
Chris Mumford authored
Switch IndexedDBContextImpl from using RefCountedDeleteOnSequence to use RefCountedThreadSafe. This change is to eliminate a user-after-free situation which is caused by the recreation of a scoped_refptr *after* the deletion of the IndexedDBContextImpl posted to the the correct sequence for deletion. This fix converts the "delete on sequence" into a "release on sequence", thus avoiding this crash. Bug: 1142712 Change-Id: I74359b515f5c05cdff9104de89691ef1f3d4557e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594289Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#838120}
-
Andrew Xu authored
Currently the bitmap item's border is drawn outside of the image. Instead, the border should be above the image. The description of the issue offers more details. Bug: 1159174 Change-Id: I4143785e957e8d7c2b18c2f1a92ad3bc5a00798f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596500Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838119}
-
Alexandre Courbot authored
Even if we have been requested to flush, we may very well receive a dynamic resolution change event before the last buffer of the flush is processed. Therefore, when a buffer with the LAST flag is dequeued, we must check whether a DRC event is pending even if a flush request has been requested before. BUG=b:174449972 TEST=android.media.cts.DecoderTest#testEOSBehaviorH264 passes on Trogdor. Change-Id: I04cf7d0d276cd036a6ea0a4434413ab193b91d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597241 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#838118}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/804d2150..fc4ac702 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e37534554c05335eb46593917c4b5a97813e23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597421Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838117}
-
Morten Stenshorne authored
Replace TODO with comment. If the inline-size of the contents of the multicol container is 0, an empty overflow rectangle will be produced, even if block-size is non-zero, and we'd fail balancing of blocks that are freely breakable inside, if initial column block-size is 0. The space shortage reporting machinery (which is what we use in subsequent column layout passes) really only works for content that we cannot (or at least don't want to) break inside. We'd also get log2(N)-ish relayouts (where N is the total block-size of the contents). So it looks like we need to keep CalculateColumnContentBlockSize(), after all. I tried to get rid of it here, before I realized that it would cause trouble: https://chromium-review.googlesource.com/c/chromium/src/+/2597308 Add a test that demonstrates this. Note that external/wpt/css/css-multicol/baseline-006.html also tests this, but that's not the main point with that test. Bug: 829028 Change-Id: I24516a5956f9e60f47c87cf51db2683feded1eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595540Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#838116}
-
Allen Webb authored
Bug: 874630 Test: chrome builds Change-Id: Id8b141daadfc4fdd3c32f8e6c801586156fa0f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593725Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#838115}
-
Ewann authored
This CL fixes Settings background when kSettingsRefresh flag is disabled. Bug: 922511, 1159765 Change-Id: I24c5a26d0a106408ac00df12f33ea0043e060b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596149 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#838114}
-
Harald Alvestrand authored
The parsing should be done only once per SLD/SRD call. Also: Add test for adding multiple tracks, one at a time - this is used to performance-test the changes. The upper limit of the track count should be adjusted to "reasonable". Bug: webrtc:12176 Change-Id: I95449eac710fcd2dd635e1e632bbb62641db848d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531993 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#838113}
-
Nina Satragno authored
When an authenticator has the forcePINChange flag on, attempting to set a PIN that is equal to the currently set PIN results in an error. Before attempting to send the new PIN to the authenticator, show the user an error explaining they need to set a new, different PIN. This patch also refactors PIN error handling so it's all handled on AuthTokenRequester now, removing some state from the UI & allowing unit tests to be written. UXW review: go/force-pin-change-ux A follow-up will implement similar logic on the settings page. Bug: 1152510 Change-Id: I00b0726b4ae34c4408df26aaa4ffbd250e03a003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593478Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#838112}
-
Eugene But authored
Bug: 688063 Change-Id: Idf3fdfc8718ebf51755dad67acbac2326eb29428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596523Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#838111}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0096403e47fb..25c49a45ff39 2020-12-17 aerotwist@chromium.org [unit test] Register missing events If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I909b648cf6951db39111df3f572cca36105bf32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838110}
-
Evan Stade authored
This is necessary because WebLayer doesn't store history, or even compile //components/history code. The change also removes the dependency on Profile, replacing it with BrowserContext. TBR=sky@chromium.org Bug: 1147274 Change-Id: Ib8e390500b1b237f6a04d062c835b0603e6eb2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592390Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#838109}
-
Joey Arhar authored
Before this patch, event handlers registered at the target of the event, which get fired during the AT_TARGET event phase, get fired in order of when they are registered without any regard for which handlers are capture and which ones are bubble. This patch fires all capture handlers before bubble handlers during the AT_TARGET event phase. WebKit implemented the same behavior here: https://trac.webkit.org/changeset/236002/webkit I2S: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/blink-dev/30jv38uD_84 Fixed: 1052152 Change-Id: I87752225dbcef7d07fccf9a6999711bdf5fbad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581814 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838108}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b64da3907f76..4052510f0b7a 2020-12-17 johnstiles@google.com Add an "allow-unreachable" flag to CFG basic blocks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I6eb592914492af9fc8adc4276794f7ca92c4708b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596862Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cfecd6b3e2e9..36522931735d 2020-12-17 saklein@chromium.org package_info: Add str and repr to PackageInfo 2020-12-16 benreich@chromium.org drivefs-uprev: Fix version comparison If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I5752d5ab7424002b54151f20881e12c1b52d722e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595193Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0da7da798b33..cc9b7694ce3d 2020-12-17 delphick@google.com Merge "metrics: Add tests for modified_rail_slices table" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I38670e3f9931ec193ac81f3d779e7a123484467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596788Reviewed-by:
-
Cammie Smith Barnes authored
The overall project aims to expose CNAME aliases to the SubresourceFilter to aid in ad tagging and blocking. A previous CL stored CNAME aliases in net::AddressList during DNS resolution. This change continues the plumbing by adding an accessor to net::ResolveHostRequest/net::HostResolverManager::RequestImpl. We also add a DnsAliasUtility with a static method for sanitizing the alias list, which is called in just after results are set. We moreover add support for host resolution with aliases to MockHostResolver, as this is needed in downstream tests for ConnectJobs, and since the MockDnsClient is currently not hooked up to MockHostResolver, the more realistic simulation path is not as simple to set up. Relevant tests: net:net_unittests out/Default/net_unittests --gtest_filter=*Dns*Alias* Bug: 1151047 Change-Id: I441fe15295f23090b697e1bc31279151f462008f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574974Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#838104}
-
Darin Fisher authored
Change-Id: I7b378b8a859cb918281134ded63c01ac24d4675f Fixed: 1159610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596216 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#838103}
-
Clark DuVall authored
This change attempts to force compile dex files on the first launch after an update or if it is detected a split is missing optimized dex. This should mitigate the startup regression seen from isolated splits on OMR1. Bug: 1159608 Change-Id: I05fb7b43a69646b9f541d57820f44c996f9908d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596030Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#838102}
-
Mikel Astiz authored
embedded_setup_chromeos.html is specifically used for ChromeOS tests so let's list some relevant folks as owners. Change-Id: Ifb6ac5537d48dbb099b0741cdff1f399fb033a7f Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595538 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838101}
-
Stepan Khapugin authored
Adds checks and blocks opening incognito tabs when the attempt is not authenticated and the authentication fails. Bug: none Change-Id: Ic7f37c1fc70306812e6b6a214e9129361927e45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593262 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#838100}
-
Allen Bauer authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Bug: 1159563 Change-Id: I43191984eb7555ab6011d23ac8c0ac33a195e26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595733Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#838099}
-
Alex Ilin authored
DetachedResourceRequestTest#testRepeatedIntents fails flakily on "android-pie-x86-rel" bot. Disabling the test on emulators. TBR: lizeb@chromium.org Bug: 1159805 Change-Id: I06e8efd025342d516e24f13231cf6bd1a8afe998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596303 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838098}
-
Titouan Rigoudy authored
This tests the inheritance of both the address space and secure context properties, for two new related cases: - the initial empty document (before about:blank commits) - javascript: URLs In both cases, because no navigation has yet committed into the frame host, the frame host has no `last_committed_client_security_state`. The tests confirm this incorrect behavior, and stand to be changed first once crrev.com/c/2587041 lands, then once again when inheritance is truly fixed. Bug: chromium:1154729, chromium:1126856 Change-Id: Ia2dec4e4b42e517f65891d55e7f391018edfb85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593636 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#838097}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012170600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/Lqnbzl4-hoc2WrAL80TsiADU6Of1I2wk_-c35v-9vSkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/175639859 Tbr: media-app@grotations.appspotmail.com Change-Id: I4db694d1f6159daac8fd736c26360effa7389163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838096}
-
Sebastien Marchand authored
Bug: 1144025 Change-Id: I4708ce31340be0e001ab2f0669305f61262d9512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593653 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#838095}
-
Liviu Tinta authored
Due to code changes related to ScrollUnification, we are bubbling events faster to ancestor frames. There is a race condition in this test, where we are not waiting for all the input events to be processed, after we test for the event we want bubbled and end the test. Because of that, GestureScrollEnd is fired at the end of the test, during test shutdown. To fix this issue, we need to wait for all events to be processed before we end the test. See stacktrace: [1102221:1102221:1216/103355.022210:FATAL:input_event_stream_validator.cc(32)] Check failed: ValidateImpl(event, &error_msg_). Ending scroll while pinching Invalid Event: GestureScrollEnd (Time: 1181016.526258, Modifiers: 0) { Pos: (0.000000, 0.000000) GlobalPos: (0.000000, 0.000000) SourceDevice: 2 RawData: (0.000000, 0.000000, 0.000000, 0.000000) } 0 0x7f500095312f base::debug::CollectStackTrace() 1 0x7f50006dc80a base::debug::StackTrace::StackTrace() 2 0x7f50006dc7c5 base::debug::StackTrace::StackTrace() 3 0x7f50007286b9 logging::LogMessage::~LogMessage() 4 0x7f5000728df9 logging::LogMessage::~LogMessage() 5 0x7f500069c05b logging::CheckError::~CheckError() 6 0x7f4fef3408c4 content::InputEventStreamValidator::Validate() 7 0x7f4ff0dc80c0 content::InputRouterImpl::SendGestureEvent() 8 0x7f4ff112d590 content::RenderWidgetHostImpl::ForwardGestureEventWithLatencyInfo() 9 0x7f4ff118242d content::RenderWidgetHostViewBase::ProcessGestureEvent() 10 0x7f4ff115f10e content::RenderWidgetHostInputEventRouter::SendGestureScrollEnd() 11 0x7f4ff115d351 content::RenderWidgetHostInputEventRouter::CancelScrollBubbling() 12 0x7f4ff115f1d0 content::RenderWidgetHostInputEventRouter::WillDetachChildView() 13 0x7f4ff0d85c4c content::CrossProcessFrameConnector::SetView() 14 0x7f4ff118967b content::RenderWidgetHostViewChildFrame::Destroy() 15 0x7f4ff118960f content::RenderWidgetHostViewChildFrame::RenderProcessGone() 16 0x7f4ff1130507 content::RenderWidgetHostImpl::RendererExited() 17 0x7f4ff0fc6797 content::RenderFrameHostImpl::RenderProcessGone() 18 0x7f4ff14ba436 content::SiteInstanceImpl::RenderProcessExited() 19 0x7f4ff109f5b8 content::RenderProcessHostImpl::ProcessDied() 20 0x7f4ff109f011 content::RenderProcessHostImpl::FastShutdownIfPossible() 21 0x55962752066c content::ContentBrowserTest::PostRunTestOnMainThread() 22 0x5596253c2aa9 content::SitePerProcessHitTestBrowserTest::PostRunTestOnMainThread() 23 0x5596275deeff content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() Bug: 1156243,1086625 Change-Id: I2077c85420680a53b1c14bcdef3ec4cad18cf1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595588Reviewed-by:Ken Buchanan <kenrb@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#838094}
-
Pâris MEULEMAN authored
Fix the CoopPageCrashIntoCoop test as the behavior is correct. The test was attempting to verify the following case: - A, with origin a.com and COOP: same-origin - A opens B, on the same origin, and with the same COOP - B embeds iframe C, cross-origin - Verify render frame proxies in A should be 1 for C - Crash A - Navigate A to origin a.com, COOP: same-origin - Verify render frame proxies in A, should be 1 but was 0. Visually: _________________ _________________ │ │ │ │ │A │ ----> │B │ │a.com │ opens │a.com │ │COOP: same-origin│ │COOP: same-origin│ │_________________│ | ___________ | | |C | | | |b.com | | | |___________| | │_________________│ The problem with this test, resulting in the removal of proxies, is that A and B are both in the same site instance, crashing A's process, also crashes B's, which leads to the deletion of C: ``` content::RenderFrameHostImpl::ResetChildren() content::RenderFrameHostImpl::RenderProcessExited() content::RenderProcessHostImpl::ProcessDied() content::RenderProcessHostImpl::OnChannelError() ``` This CL works around this by using COOP: Same-origin-allow-popups on A and a cross-origin, COOP: unsafe-none on B. - Opening the popup, creates the proxies. - Crashing A does not crash B. - A's proxies are still there after the navigation. _________________ _________________ │ │ │ │ │A │ ----> │B │ │a.com │ opens │b.com │ │COOP: SOAP │ │ │ │_________________│ │_________________│ The previous test, CoopPageCrashIntoNonCoop, is changed too. Indeed it had the proper results, but not as a consequence of COOP. Bug: 1060124 Change-Id: I9eb6b9261252bce6841f31beb39a90b57bdeaf71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592794 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#838093}
-
Liviu Tinta authored
AzimuthAltitude flag has been enabled in stable since M86. As far as I understand, we need to remove runtime feature flags after 2 releases. This CL removes AzimuthAltitude runtime feature flag from the code. Change-Id: Iae56d464cdf1bb7ddaf18a09de5b8e0a41e30ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595636Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#838092}
-
Emil Lundmark authored
This is intended to be enabled by default upstream in WebRTC, see https://crbug.com/webrtc/9985. Bug: 908377 Change-Id: I7210547b153a5ac394e8beb1f256be1e27278e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596147Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Emil Lundmark <lndmrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#838091}
-
Stephen McGruer authored
This was failing due to some leftover baseline files that were likely not updated because the test had been placed in TestExpectations already before the wpt import happened. Remove the baselines and the TestExpectations entry. Bug: 1159333 Change-Id: I277579598befb02af2eec60442ba9009ac4e9dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595641Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#838090}
-
Mohamed Amir Yosef authored
according to the latest mocks. Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/1c45071d1fddd97f280aecf63df2a04e24b1a9a6 Bug: 1139263 Change-Id: Ib9d3e3df0c93833935c0b8e4de8b131147732522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595304 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#838089}
-
Sebastien Marchand authored
Bug: 1144025 Change-Id: I7371085cfca50eb94c55e637597fd8acdf3dae25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593767 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Thiabaud Engelbrecht authored
We now release memory going into the freelists of `ClientDiscardableSharedMemoryManager`. This is done using `madvise(MADV_REMOVE)` or similar. We hide these changes being a feature which is disabled by default, so this CL doesn't have any effect on current functionality. Bug: 1142593 Change-Id: I302ddf8506480f656454a08fe6b016db66c68c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412833 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838087}
-
Nazerke authored
This CL styles the cells attributes like font of buttons, favicons and tab titles. Bug: 1128249 Change-Id: I890168e563f5d8b4ad65718a21a3f07a4630c25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582061 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Reviewed-by:
-
Ken Buchanan authored
Right now it is difficult for developers to diagnose any errors when they are testing WebID with provider implementations. This adds more descriptive console messages to help narrow down any problems. Bug: 1141125 Change-Id: I0c13ca6a5c50295292795d96cc7bedc2ee9cf99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596130Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#838085}
-
Justin Donnelly authored
Corresponding server change in http://cl/344096531. Change-Id: I710ae702807a9fe824a906c27c69466e87dc5ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558917Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#838084}
-
Rahul Goyal authored
Moved public methods to top in Base Onboarding Coordinator. Only the order of methods has been changed. PS: This change was missed from the last cl: https://crrev.com/c/2573138 Bug: b/174445633 Change-Id: I95f20004f74378cbd593b29976e48bfc5acb0be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597307Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#838083}
-
Sebastien Marchand authored
Visible tabs already can't be frozen (see https://source.chromium.org/chromium/chromium/src/+/master:content/browser/web_contents/web_contents_impl.cc;l=2656;drc=5d3dd257fdb048822291f570af44ab9116d73e14) and non-visible tabs are automatically unfrozen when they become visible. Bug: 1144025 Change-Id: Ia77bf792324fb4df049026d1073de858b5ed1f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595455 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Elizabeth Popova authored
Added keywords for address names found in manual testing of Turkish and Brazilian websites. Also excluded the regular expressions of the address name for name components classification. Bug: 1154727 Change-Id: I9232f367f9c5f9dc61656a64c7c89416b3a3d76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595410 Commit-Queue: Elizabeth Popova <lizapopova@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#838081}
-
