GitLab

Since we create the WebCredentialManagerClient in //chrome, we need a
tiny mock to ensure that the Blink-side has something it can wire
itself up to. This is that thing.

BUG=400674

Review URL: https://codereview.chromium.org/565943002

Cr-Commit-Position: refs/heads/master@{#295022}

"ctrl + double click" acts on the highlighted/selected bookmark list items
irrespective of on which list item the action is performed. To extend this to
clicked, unhighlighted list item, invoking mouseup event handling functionality
under doubleclick event handling before command execution. mouseup event takes
care of highlighting and unhighlighting list items.

BUG=243221

Review URL: https://codereview.chromium.org/515853002

Cr-Commit-Position: refs/heads/master@{#295021}

Revert of When we switch tabs in chrome, the tab being switched away from gets hidden/shown/hidden. (patchset #14 id:260001 of https://codereview.chromium.org/564553002/)

Reason for revert:
This seems to cause memory leaks in WebViewUnitTest.TestWebViewAttachDetachWebContents on Linux(ASan/LSan) and ChromiumOS(ASan/LSan)

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7468

Original issue's description:
> When we switch tabs in chrome, the tab being switched away from gets hidden/shown/hidden.
>
> This occurs in the NativeViewHostAura::NativeViewDetaching code path where we first remove the
> clipping window which is the intermediate parent of the web contents view. The clipping window
> is hidden which causes the RWHVA::Hide function to get called which initiates the hiding sequence.
> Then the web contents view is reparented to the main view which is still visible. Now the RWHVA::Show
> function is called which initiates the show sequence. Eventually the main view is hidden, which then
> initiates the hide sequence.
>
> Addressed this with the following changes.
> 1. WebView::AttachWebContents and WebView::DetachWebContents
>    now show and hide the webcontents native view. The
>    WebContents is shown and hidden as before in
>    WebContentsNativeViewAura::OnWindowVisibilityChanged.
>
> 2. Removed the WebContentsNativeViewAura::OnWindowParentChanged function.
>    This function was present to show and hide the webcontents if the window was visible.
>    This should not be needed with the change in #1 above.
>
> 3. Added a new file webview_unittest.cc. This contains the unittest WebViewUnitTest.TestWebViewAttachDetachWebContents
>    This is run as part of unit_tests.exe.
>
> BUG=412989
> R=sky
>
> Committed: https://crrev.com/99941773a742f62892fc9aad1a1ebfb7cc967164
> Cr-Commit-Position: refs/heads/master@{#294962}

TBR=sky@chromium.org,ananta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=412989

Review URL: https://codereview.chromium.org/577533003

Cr-Commit-Position: refs/heads/master@{#295020}

Revert of Files.app: Split background.js (patchset #4 id:60001 of https://codereview.chromium.org/562103002/)

Reason for revert:
This patch breaks the test.

Original issue's description:
> Files.app: Split background.js
>
> This patch splits the background.js into the 3 files (background_base.js, app_window_wrapper.js, background.js), extracting the common classes.
>
> This patch itself doesn't change any functionality, but the extracted files will be used in the separated audio player app in near future.
>
> BUG=375039
> TEST=browser_test passes
>
> Committed: https://crrev.com/479878c12c436c0bec667483df29fe1f23b710a2
> Cr-Commit-Position: refs/heads/master@{#294998}

TBR=hirono@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375039

Review URL: https://codereview.chromium.org/563743004

Cr-Commit-Position: refs/heads/master@{#295019}

https://skia.googlesource.com/skia/+log/df886ea06f0978e10695b482e658cf3daa9a1fc9..ae232a20d74de16baaec356787f968b4f04144c6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/572843002

Cr-Commit-Position: refs/heads/master@{#295018}

Regression are tiny:
- nacl_helper/nacl_helper (0.04%)
- nacl_helper-text/text (0.06%)

http://build.chromium.org/p/chromium/builders/Linux/builds/53437
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper&rev=294990&checked=all
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper-text&rev=294990&checked=all

TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/571313002

Cr-Commit-Position: refs/heads/master@{#295017}

Revert of Perf: Update size expectation for nacl_helper/nacl_helper on linux (patchset #1 id:1 of https://codereview.chromium.org/575603003/)

Reason for revert:
I should have updated the expectation for linux-release (not linux-release-64).

Original issue's description:
> Perf: Update size expectation for nacl_helper/nacl_helper on linux
>
> Regression is tiny (0.04%).
>
> http://build.chromium.org/p/chromium/builders/Linux/builds/53433
> https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux%2Cchromium-rel-xp&tests=sizes%2Fnacl_helper&rev=294900&checked=all
>
> TBR=nhiroki@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/bd700c84bf9132a96e17e0ea724d1855a8d01740
> Cr-Commit-Position: refs/heads/master@{#294991}

TBR=
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/574633002

Cr-Commit-Position: refs/heads/master@{#295016}

Previously SandboxBPF constructed the CodeGen Instruction sequence
primarily in one large, complex function.  Additionally, it made
extensive use of the CodeGen::JoinInstructions() function to
conditionally arrange various bits of instructions, which made it
harder to follow.

This CL splits the Instruction assembly code into 5 mostly distinct
functions and eliminates all use of JoinInstruction() in favor of
function composition.  E.g., instead of

    foo = gen->MakeInstruction(...);
    bar = gen->MakeInstruction(...);
    gen->JoinInstructions(foo, bar);

this CL favors writing

    MakeFoo(MakeBar())

with the convention that Instruction-constructing functions should
arrange for control to transfer to the Instruction sequence argument
when complete.  (I.e., "continuation-passing style":
http://en.wikipedia.org/wiki/Continuation-passing_style)

BUG=414363

Review URL: https://codereview.chromium.org/568053005

Cr-Commit-Position: refs/heads/master@{#295015}

Discard all useless QUIC retransmissions instead of only the most recent
useless retransmission.

May reduce the chances of truncated acks.

Merge internal change: 75561951
https://codereview.chromium.org/564663005/

Add a separate QUIC_CONNECTION_OVERALL_TIMED_OUT to identify overall
timeouts from idle timeouts and increase the initial overall timeout
from 5s to 10s.

Merge internal change: 75544619
https://codereview.chromium.org/572083003/

Fix QUIC crash on ConnectionClose, protected behind renamed flag
FLAGS_close_quic_connection_unfinished_streams_2 (defaulted to false).

With this change we avoid trying to close the connection while driving
the QUIC internal server response pipeline, as the call to
SendConnectionClose now happens during PostProcessAfterData, which is
only ever called after receiving new data. With a hacky
client/QUIC internal server combo (sending > 100 requests, but never
sending FIN/RST) I've verified that with this change we don't hit the
DFATAL from the attached bug.

Still not entirely sure why Chrome would trigger this, b/17402744 is
open to investigate why it ever opens more than kMaxStreams.

Merge internal change: 75541290
https://codereview.chromium.org/575593002/

Add a LOG(DFATAL) to a case where packets are acked before being sent.

Merge internal change: 75537267
https://codereview.chromium.org/575573003/

Allow number of open QUIC streams to grow 10% beyond configured limit at
the QUIC internal server before closing connection.

In the following situation Chrome may open more streams than the
configured limit:

* opens kMaxStreams streams
* sends a FIN for one of the streams, now has kMaxStreams-1 streams open
* opens a new stream
* FIN gets lost on way to QUIC internal server
* QUIC internal server terminates connection when new stream packet
  arrives

Rather than making Chrome keep track of when the server has acknowledged
a FIN, just give 10% breathing room which should avoid this case.

Merge internal change: 75393293
https://codereview.chromium.org/557363003/

client-only - Change QUIC clients to use the initial RTT estimate that
they provide to the server instead of the default.

Re-enabled LimitCongestionWindowAndRTT end_to_end unittest (since we
have fixed lot of flaky tests). Will test chromeos valgrind.

Merge internal change: 75389539
https://codereview.chromium.org/573763003/
BUG=321870

Increase flow control receive window of quic_client_bin.cc, by adding a
flag that defaults to 10 Mb.

Added --flow-control-window-bytes as argument.

Merge internal change: 75381087
https://codereview.chromium.org/569353003/

Call QuicSentPacketManager's OnPacketSerialized or OnRetransmittedPacket
right before OnPacketSent, in preparation for combining the three
methods into one.

Merge internal change: 75340764
https://codereview.chromium.org/566743003/

Instead of initializing QuicSession::next_stream_id_ to 3 in the
construct, and then setting it to 5 in InitializeSession simply
initialize it to 5 in the constructor.

Merge internal change: 75335114
https://codereview.chromium.org/562793003/

Do not allow a QUIC connection to timeout if no packets have been sent
or received. Protected by FLAGS_quic_timeouts_require_activity.

This seems to happen on windows from time to time and causes problems
there.

Merge internal change: 75304108
https://codereview.chromium.org/571993002/

Minor change to QUIC's retransmission to not link old retransmissions
with new ones when the version or encryption changes.

Allows the least_unacked to be raised more quickly, preventing spurious
acks.

Merge internal change: 75290729
https://codereview.chromium.org/572703003/

Removed unnecessary static_cast and replaced it with "lu".

Minor change to keep the code similar to internal code.

Merge internal change: 75263809
https://codereview.chromium.org/566373003/

QUIC cleanup to remove an unused bool argument in SendOrQueuePacket and
OnSerializedPacket.

Merge internal change: 75208575
https://codereview.chromium.org/553583007/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/559373003

Cr-Commit-Position: refs/heads/master@{#295014}

This cl adds the basic ChromeVox key bindings (Search+Shift+<arrows>). The command names currently serve as a placeholder pending a decision on what we should map them to.

TEST=Manually verify that the onCommand handler gets called for each command on each key combo only on the whitelisted page. Also, verify that ChromeVox uses the automation tree on the whitelisted pages while allowing content script control on all other pages. Desktop tree should always verbalize.

Review URL: https://codereview.chromium.org/536233002

Cr-Commit-Position: refs/heads/master@{#295013}

This CL adds path overrides for shortcut directories in testing environments.
This will ensure tests don't pollute the build bots with shortcuts

BUG=411970

Review URL: https://codereview.chromium.org/565523003

Cr-Commit-Position: refs/heads/master@{#295012}

Revert of Revert CL 117933003. Re-add resource speculative prefetching code. (patchset #10 id:180001 of https://codereview.chromium.org/462423004/)

Reason for revert:
This caused a bunch of memory leaks in following tests:

- ResourcePrefetcherTest.TestPrefetcherFinishes
- ResourcePrefetcherTest.TestPrefetcherStopped

Linux Chromium OS ASan LSan Tests (3)
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/3216

Linux ASan LSan Tests (2)
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7460

Original issue's description:
> Revert CL 117933003. Re-add speculative resource prefetching code.
> https://codereview.chromium.org/117933003/
>
> The speculative resource prefetching code was experimental code developed by
> shishir@. He found that it has little improvement on desktop Chrome (win). We
> though this should be beneficial to mobile browsers. After discussing with
> tburkard@ and kenjibaheux@, we decided to bring the code back and do more
> analysis on mobile devices. Reverting the patchset to re-add the code is the
> first step.
>
> The following design doc has discussed all related approaches and action items.
> https://docs.google.com/a/google.com/document/d/1ie3hu-zNNXvmTXm3aJAtKUGOh6nZfbNjA0aZE1bzzIg/edit?usp=sharing
>
> BUG=408399, 405690
>
> Committed: https://crrev.com/825722d5939dc0832d124b70958501611e6a4628
> Cr-Commit-Position: refs/heads/master@{#294899}

TBR=shishir@chromium.org,tburkard@chromium.org,kenjibaheux@chromium.org,jam@chromium.org,thestig@chromium.org,zhenw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408399, 405690

Review URL: https://codereview.chromium.org/577543002

Cr-Commit-Position: refs/heads/master@{#295011}

https://skia.googlesource.com/skia/+log/44162675ca4b790c2af0fbd9c41f262c8be26b05..df886ea06f0978e10695b482e658cf3daa9a1fc9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/570173004

Cr-Commit-Position: refs/heads/master@{#295010}

In RWHVA::SelectionBoundsChanged, there is a check
for anchor_rect x and y not being 0. Due to this, whenever
the cursor reaches 0 position (either left or top), it
triggers HideAndDisallowShowAutomatically.
This causes the insertion handle not to be shown on
scroll end. Restricting this condition to only check for
the origin minimizes the likelihood of the issue.

BUG=414020

Review URL: https://codereview.chromium.org/569003002

Cr-Commit-Position: refs/heads/master@{#295009}

In the in-process PDF plugin when checking the argument type of kJSSetZoomLevel
calls to the plugin we would check if the argument is a double. But it may be
an int and we really want to check if it's a number. This probably worked in
the past by chance and broke when we switched to using gin to implement JS
bindings for Pepper.

BUG=413525

Review URL: https://codereview.chromium.org/569403004

Cr-Commit-Position: refs/heads/master@{#295008}

BUG=410560
TEST=about:gpu page on Linux under X11
R=zmo@chromium.org

Review URL: https://codereview.chromium.org/570173003

Cr-Commit-Position: refs/heads/master@{#295007}

* When extension unloaded, ChromeLauncherController check the profile, and does action only for the correct profile.

R=jamescook@chromium.org, skuhne@chromium.org
BUG=354046, 411568
TEST=unit_tests

Review URL: https://codereview.chromium.org/565213002

Cr-Commit-Position: refs/heads/master@{#295006}

Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/chromeos"
module. WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/566863003

Cr-Commit-Position: refs/heads/master@{#295005}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/560913006

Cr-Commit-Position: refs/heads/master@{#295004}

https://chromium.googlesource.com/chromium/blink/+log/be75ff2f0cfa2d2ad48039af212f6b609c550784..aa5e6ea2e1ddb260730d333f555faff0a26df787
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/568343005

Cr-Commit-Position: refs/heads/master@{#295003}

Turns out dropping the time argument in 08602875 doesn't work well in a
video frame scheduling based world as a VideoRenderer is no longer
able to poll for the current time. Instead, go back to passing in the
start timestamp so that VideoRenderer implementations can do frame
accurate seeking.

BUG=110814,370634

Review URL: https://codereview.chromium.org/568113003

Cr-Commit-Position: refs/heads/master@{#295002}

BUG=279351

Review URL: https://codereview.chromium.org/570743002

Cr-Commit-Position: refs/heads/master@{#295001}

BUG=413748

Review URL: https://codereview.chromium.org/568393002

Cr-Commit-Position: refs/heads/master@{#295000}

Fix a ServiceWorker crasher. We have to test the provider_host_ weakptr in async callbacks because the document can be closed, and the host deleted, in the interim.

BUG=414118

Review URL: https://codereview.chromium.org/569423002

Cr-Commit-Position: refs/heads/master@{#294999}

This patch splits the background.js into the 3 files (background_base.js, app_window_wrapper.js, background.js), extracting the common classes.

This patch itself doesn't change any functionality, but the extracted files will be used in the separated audio player app in near future.

BUG=375039
TEST=browser_test passes

Review URL: https://codereview.chromium.org/562103002

Cr-Commit-Position: refs/heads/master@{#294998}

ChannelMojo::OnConnect() ignores errors in Send() but the error
results deleting |message_readrer_| which causes null access.
This CL add an error check for that.

This also adds some hooks to make this testable by
faking lower level API.

TEST=ipc_channel_mojo_unittest.cc
BUG=410813
R=yzshen@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/554363004

Cr-Commit-Position: refs/heads/master@{#294997}

https://skia.googlesource.com/skia/+log/f0ddf33f1954489d45e4f2d9c8712eac60539c65..44162675ca4b790c2af0fbd9c41f262c8be26b05

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/567423003

Cr-Commit-Position: refs/heads/master@{#294996}

Review URL: https://codereview.chromium.org/571843002

Cr-Commit-Position: refs/heads/master@{#294995}

BUG=359249

Review URL: https://codereview.chromium.org/568363002

Cr-Commit-Position: refs/heads/master@{#294994}

We're still seeing crashes that appear to come from multiple simultaneous
writes. Given that writing_ is false when we crash, but the operation
matches the current thread, file handle and IPC Channel, it could
be that for some reason a failed Write is still genarating a notification.

So this CL stores two error codes (one for the current operation and another
for a previous failure), and the write size.

BUG=387876
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/564863003

Cr-Commit-Position: refs/heads/master@{#294993}

Originally, we delayed the rendering and waited for the late coming frames. However, when play with audio, the late coming frame should be just dropped to keep the AV sync. So we change to drop a frame if it comes too late.

BUG=411123
TEST=Run vda_unittest on peach_pit.

Review URL: https://codereview.chromium.org/562173003

Cr-Commit-Position: refs/heads/master@{#294992}

Regression is tiny (0.04%).

http://build.chromium.org/p/chromium/builders/Linux/builds/53433
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux%2Cchromium-rel-xp&tests=sizes%2Fnacl_helper&rev=294900&checked=all

TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/575603003

Cr-Commit-Position: refs/heads/master@{#294991}

Regression is tiny (0.06%).

http://build.chromium.org/p/chromium/builders/Win/builds/24362
https://chromeperf.appspot.com/report?masters=Chromiqum&bots=chromium-rel-xp&tests=sizes%2Fchrome.dll&checked=all&start_rev=294698&end_rev=294959

TBR=nhiroki@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/575713002

Cr-Commit-Position: refs/heads/master@{#294990}

Discovered while running cast_simulator when seeing that no frames were
late at the receiver, even under impossible scenarios.

Review URL: https://codereview.chromium.org/575683002

Cr-Commit-Position: refs/heads/master@{#294989}

https://chromium.googlesource.com/chromium/blink/+log/fbd4f37d728e462a9cbc3482156ad7e8c2c1d0b5..be75ff2f0cfa2d2ad48039af212f6b609c550784
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/576563003

Cr-Commit-Position: refs/heads/master@{#294988}

BUG=https://code.google.com/p/chromium/issues/detail?id=388101
TEST=local + with trybots
R=mseaborn@chromium.org,jam@chromium.org,brettw@chromium.org

Review URL: https://codereview.chromium.org/452543002

Cr-Commit-Position: refs/heads/master@{#294987}

These are only used for futexes that are shared between processes, which should not be happening in Chromium.
BUG=413855

Review URL: https://codereview.chromium.org/569713004

Cr-Commit-Position: refs/heads/master@{#294986}

Always start a renderer if one does not already exist.
The check is cheap so no need for a parameter to control it.

BUG=

Review URL: https://codereview.chromium.org/570783002

Cr-Commit-Position: refs/heads/master@{#294985}

BUG=384041

Review URL: https://codereview.chromium.org/561453002

Cr-Commit-Position: refs/heads/master@{#294984}

BUG=407184,386735

Review URL: https://codereview.chromium.org/564373006

Cr-Commit-Position: refs/heads/master@{#294983}